From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EE838C433DB for ; Fri, 29 Jan 2021 14:29:07 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9EE5464DF1 for ; Fri, 29 Jan 2021 14:29:07 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9EE5464DF1 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=xilinx.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-ID:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=YZ5JmUgEBXj2foSneUq1JtJ06GUlz+3QJztaKhQu6So=; b=syMCDFJzgKDQnDJ/5Ilsn3Qrf ysIOcyG3VAdRm4YFxZOGTqfp+zZjbo4PPAXW3L82cgfvPoRLLmvDnLXr1stGW5kAIM4yWjykg2EBo tGFmBCWqkRnTnyEmEODhUlZLbr5WoYuB/F4MuVgbMSfXO2+Nv8ejXdMtbrYAGXCIoQggyLWDCidIW V96KExh5s9UYSoFEGB6CuOHTjr2G9fFW2N6mPNfRB8Q7X/yotCjSGMckCPX3A3R1hFsQCNB+Oylnr xSPsqSpKwC7nMs0XnV/kmLjXQcywR6egzYHXITMvBFzkA3zK/kxfhDyp8UA1omEFDqAgDWoltYtQ+ l7C6JHe1w==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1l5UkJ-0006sp-9a; Fri, 29 Jan 2021 14:27:35 +0000 Received: from mail-dm6nam10on2050.outbound.protection.outlook.com ([40.107.93.50] helo=NAM10-DM6-obe.outbound.protection.outlook.com) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1l5UkH-0006sN-II for linux-arm-kernel@lists.infradead.org; Fri, 29 Jan 2021 14:27:34 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=B0TH1QZ+iJ8xVgDT8GAHETYCtkRuXyjBGg/GLlq8K+P2eylZo21A1pM7hhFscaEYVyFll+ts8Uqp3m63fC9ovFjE4a/6TO71TeXx7AbR4qDv3SucmVtiGi9DB/AjdHKWP2C2SJwj7r/s7DZK3ZjpCJt3kCxlfnSMyNBWSdXELYweBwr1XyF6k3mgmetHnPEI2+UA7bzZkfYTpzy992JSoQnD/pTsre0JfKCxGsCCkokrDHF035769L9lBde+kSAI0aIECpzWp/VvOgJILyRTXEIswQ+3PnFrkuS6oIOArI0rIK60dhEM0auzYqFoYGjoe6gVwU0RcVusRAHt5n3vwg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=zEFxFxqKNtEcqis/o2KJrQBA4mRW582IJ7dh17vH/O8=; b=hgNVGtM1eGPYmDdgt+GM4T0MwE4hWGBdazY94Vw3MKqcKMi5eN6EmUgwHNgp7aCe8HtZK+hylLfI9AmCrgEvxhEZwUvi27H4WoPjtEBN0YWWtQqRDKh6g5qg1GeHySSdI6NPlfpHlk0J1dURJln+fqTa1Oatr8YfvLY7C+UCYxpfW6+elJNa09cv9cj/2O7Aurz2X6OEjGmQ5z4ugxow9hRMrmLZpx3j42Qy2OqgBqkKMyOwyTz5QaVJSMZ7quIvlNbEYfoDXGezTei7w7sZcsiUl5cFJ0WDovLlQjLtYjK33iK09cqrHveUShD57jqt57/sNkYP7QDZk5w9NNIM7w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 149.199.62.198) smtp.rcpttodomain=linaro.org smtp.mailfrom=xilinx.com; dmarc=bestguesspass action=none header.from=xilinx.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=xilinx.onmicrosoft.com; s=selector2-xilinx-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=zEFxFxqKNtEcqis/o2KJrQBA4mRW582IJ7dh17vH/O8=; b=hJmnRCuVZQx+Zi54S53CdualREnOsWEcg17enTnTsKRU4z3fSMhHDkfS9J7GIxrOPQ35FmXZB0bzxDIiAnTdG6A12JRgdcNl47jGBW8xM/gPWKZ7OaiVNs4wLYRwXM3Z70NVNCU5KaBSiWA8Ef9WiFJGTvpvXaR9da3TnskFutM= Received: from SN4PR0801CA0021.namprd08.prod.outlook.com (2603:10b6:803:29::31) by PH0PR02MB7288.namprd02.prod.outlook.com (2603:10b6:510:9::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3805.19; Fri, 29 Jan 2021 14:27:30 +0000 Received: from SN1NAM02FT016.eop-nam02.prod.protection.outlook.com (2603:10b6:803:29:cafe::52) by SN4PR0801CA0021.outlook.office365.com (2603:10b6:803:29::31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3805.17 via Frontend Transport; Fri, 29 Jan 2021 14:27:29 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 149.199.62.198) smtp.mailfrom=xilinx.com; linaro.org; dkim=none (message not signed) header.d=none;linaro.org; dmarc=bestguesspass action=none header.from=xilinx.com; Received-SPF: Pass (protection.outlook.com: domain of xilinx.com designates 149.199.62.198 as permitted sender) receiver=protection.outlook.com; client-ip=149.199.62.198; helo=xsj-pvapexch02.xlnx.xilinx.com; Received: from xsj-pvapexch02.xlnx.xilinx.com (149.199.62.198) by SN1NAM02FT016.mail.protection.outlook.com (10.152.72.113) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.3784.12 via Frontend Transport; Fri, 29 Jan 2021 14:27:29 +0000 Received: from xsj-pvapexch02.xlnx.xilinx.com (172.19.86.41) by xsj-pvapexch02.xlnx.xilinx.com (172.19.86.41) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1913.5; Fri, 29 Jan 2021 06:27:02 -0800 Received: from smtp.xilinx.com (172.19.127.95) by xsj-pvapexch02.xlnx.xilinx.com (172.19.86.41) with Microsoft SMTP Server id 15.1.1913.5 via Frontend Transport; Fri, 29 Jan 2021 06:27:02 -0800 Received: from [10.140.6.6] (port=56658 helo=xhdappanad40.xilinx.com) by smtp.xilinx.com with esmtp (Exim 4.90) (envelope-from ) id 1l5Ujk-00005L-Rg; Fri, 29 Jan 2021 06:27:01 -0800 From: Srinivas Neeli To: , , , , , , Subject: [PATCH V5 1/5] gpio: gpio-xilinx: Simplify with dev_err_probe() Date: Fri, 29 Jan 2021 19:56:46 +0530 Message-ID: <1611930410-25747-2-git-send-email-srinivas.neeli@xilinx.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1611930410-25747-1-git-send-email-srinivas.neeli@xilinx.com> References: <1611930410-25747-1-git-send-email-srinivas.neeli@xilinx.com> MIME-Version: 1.0 X-EOPAttributedMessage: 0 X-MS-Office365-Filtering-HT: Tenant X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 09310414-0346-4836-49cb-08d8c462023f X-MS-TrafficTypeDiagnostic: PH0PR02MB7288: X-Microsoft-Antispam-PRVS: X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply X-MS-Oob-TLC-OOBClassifiers: OLM:1284; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: dqJOX0eA+wXj7x750SQ2iuCbzSqQNryuk+PulEE+H3zB4+95JvFGD3FpbWyEcCd56tG4sfNArr9ebUBRnRtuPd46JJxazzG9dHMUVWCSJeGEZ/cvC3u+0VmV8kq2m008amDpJyTAQhYZ1pUJxy5Y4+6RgTjc0Uf9RK0Jj4qFrc4b26xD/PbdNIUxypf0dtZBBEijpIXdWXGJ/IaLAvEf+GdO1HeBTh2auuh0O+wuBISCpwf37GEEbtSpsbvxnJGbWJusCnItZru9tRypUhtYIsYTxZMVyvbVhnVF8+zvuBtzp8j2mIpTKaC8mFKjVOrRccZzN80oNeYjwi85uezdlIQ11N71fHJyxqEM6zFr57jG2DeaeMTrL30tTqyNrK4ToP4ub4dsETE3yqsLcXZkEd/52Qnby7yisiIj7kniYYV78zsaV5bXgjJZY2Cf5f+NG0bI26JeC9kGq02vqRUw1BGBu/IqT5wlM4z5JdZ0tCqPQ3KNQ0BnL+la0OF4LeclVgYwAUe6qkMl+xXZ67Om60Xm24/PIdhh3AFNNqHmq2BcQ3RKlhSAYjccs26iHoKKctTAz+MTEVMug/qbk2TOIYhUmO4nqQBnKkvS8LwzFdZY3dv1pxOij+h+oFADQAtc X-Forefront-Antispam-Report: CIP:149.199.62.198; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:xsj-pvapexch02.xlnx.xilinx.com; PTR:unknown-62-198.xilinx.com; CAT:NONE; SFS:(4636009)(376002)(346002)(39860400002)(396003)(136003)(46966006)(83380400001)(36906005)(316002)(9786002)(336012)(26005)(186003)(110136005)(4326008)(70586007)(7636003)(54906003)(70206006)(2906002)(426003)(2616005)(478600001)(7696005)(44832011)(82740400003)(82310400003)(5660300002)(6666004)(356005)(8936002)(107886003)(36756003)(47076005)(8676002)(102446001); DIR:OUT; SFP:1101; X-OriginatorOrg: xilinx.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Jan 2021 14:27:29.5656 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 09310414-0346-4836-49cb-08d8c462023f X-MS-Exchange-CrossTenant-Id: 657af505-d5df-48d0-8300-c31994686c5c X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=657af505-d5df-48d0-8300-c31994686c5c; Ip=[149.199.62.198]; Helo=[xsj-pvapexch02.xlnx.xilinx.com] X-MS-Exchange-CrossTenant-AuthSource: SN1NAM02FT016.eop-nam02.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR02MB7288 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210129_092733_630690_2553966E X-CRM114-Status: GOOD ( 11.90 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-gpio@vger.kernel.org, Srinivas Neeli , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, git@xilinx.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Common pattern of handling deferred probe can be simplified with dev_err_probe(). Less code and also it prints the error value. Signed-off-by: Srinivas Neeli Reviewed-by: Linus Walleij --- Changes in V5: -None Changes in V4: -New patch --- drivers/gpio/gpio-xilinx.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/drivers/gpio/gpio-xilinx.c b/drivers/gpio/gpio-xilinx.c index be539381fd82..d010a63d5d15 100644 --- a/drivers/gpio/gpio-xilinx.c +++ b/drivers/gpio/gpio-xilinx.c @@ -357,11 +357,8 @@ static int xgpio_probe(struct platform_device *pdev) } chip->clk = devm_clk_get_optional(&pdev->dev, NULL); - if (IS_ERR(chip->clk)) { - if (PTR_ERR(chip->clk) != -EPROBE_DEFER) - dev_dbg(&pdev->dev, "Input clock not found\n"); - return PTR_ERR(chip->clk); - } + if (IS_ERR(chip->clk)) + return dev_err_probe(&pdev->dev, PTR_ERR(chip->clk), "input clock not found.\n"); status = clk_prepare_enable(chip->clk); if (status < 0) { -- 2.7.4 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel