From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.5 required=3.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED,DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 39D4CC433DB for ; Mon, 1 Feb 2021 14:46:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 08BB96024A for ; Mon, 1 Feb 2021 14:46:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231492AbhBAOpz (ORCPT ); Mon, 1 Feb 2021 09:45:55 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59562 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231293AbhBAOmi (ORCPT ); Mon, 1 Feb 2021 09:42:38 -0500 Received: from mail-io1-xd2c.google.com (mail-io1-xd2c.google.com [IPv6:2607:f8b0:4864:20::d2c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D147CC061756; Mon, 1 Feb 2021 06:42:22 -0800 (PST) Received: by mail-io1-xd2c.google.com with SMTP id h11so17544481ioh.11; Mon, 01 Feb 2021 06:42:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=vYWcn7sL4czH23insMbT/xXB/qPApleY+YB9g2DqZvw=; b=srCiPPLg+FKyiypCOM4HhWnQR9qLFpjBesMwYf6bJhq048o7gMqqliN0JoZ8TIrxx7 lR2AhWdnqqRR1yM8pTNZYzgB5D8LFIvmsSp6UIlW0Gr2G8pHtDgwTswLA+T1xcC2Dz/s mTlTAYHbuU8GsoSGFIPPk3pUzkWkll0EbNP9gVdE2gFkJMUBTmiMZzLO9V+QwNpYCnXt MbaY22d3pkt7aVOjdbwzfFPez1PFGZ3tqSgM0E/8Yx80X2gkuLgvRACpuQICL1UX77g+ gJkyjLusERVpodvFNV/sUnBP+SOlagv7mVfC7PYEcgFauxvzGa/6GHQT9ARSfjY9Z3Jx ShAw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=vYWcn7sL4czH23insMbT/xXB/qPApleY+YB9g2DqZvw=; b=bleSF52TPo36+4KnFsEBZxG5A26pEMKhukt+6UqXKGlFj5XSeX3vZSj1SCYg/QpLsU 1acJ3MM7l6e7FCkln+l8pMQzUtgYpkiTOgY13c8uZBvbEQcpJqAJ9YAR2/tsVxain1H0 J3835kdd9/RIkYG3g1SDORveCNrvRiWopP1ZQzwMrjLzCeClL54MURcDZcuCPOhWllg0 mkYOmrz4EqR+kH9ty+W25Q8DHiPI8YOsm+0V127bnuTQtYNOKLbFY3lC6U6JA4RhkAo1 ScQ6ECyWkNzulEQ5Cv0snbut3pSWD86LffLiPbkmn+YMcBYfr00v0aDOW73A4QTZbP0f 4msA== X-Gm-Message-State: AOAM5302ScF/5F2bva73n43IRUTDQhADNTGATi5+QOpQVsDusj6UAFB8 U0sYsRnHXzxiTkwF8yGKGtk= X-Google-Smtp-Source: ABdhPJybG8fZlQcKGj1GssmKBu/UxhmQ73Q9+3UlPhYlNwH0kDkW72buRTLQh4I5AFqrw8SG5cAWhA== X-Received: by 2002:a6b:7501:: with SMTP id l1mr12314288ioh.92.1612190542355; Mon, 01 Feb 2021 06:42:22 -0800 (PST) Received: from spring-Precision-5820-Tower.cs.umn.edu ([2607:ea00:101:3c74:b4b0:f34c:770:f33f]) by smtp.gmail.com with ESMTPSA id w2sm8470106ioa.46.2021.02.01.06.42.21 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 01 Feb 2021 06:42:22 -0800 (PST) From: Wenjia Zhao Cc: driverfuzzing@gmail.com, Lee Jones , Daniel Thompson , Jingoo Han , Bartlomiej Zolnierkiewicz , dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] backlight: pcf50633: pdata may be a null pointer, null pointer dereference cause crash Date: Mon, 1 Feb 2021 08:41:38 -0600 Message-Id: <1612190499-73818-1-git-send-email-driverfuzzing@gmail.com> X-Mailer: git-send-email 2.7.4 To: unlisted-recipients:; (no To-header on input) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Signed-off-by: Wenjia Zhao --- drivers/video/backlight/pcf50633-backlight.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/video/backlight/pcf50633-backlight.c b/drivers/video/backlight/pcf50633-backlight.c index 540dd338..43267af 100644 --- a/drivers/video/backlight/pcf50633-backlight.c +++ b/drivers/video/backlight/pcf50633-backlight.c @@ -127,7 +127,8 @@ static int pcf50633_bl_probe(struct platform_device *pdev) platform_set_drvdata(pdev, pcf_bl); - pcf50633_reg_write(pcf_bl->pcf, PCF50633_REG_LEDDIM, pdata->ramp_time); + if (pdata) + pcf50633_reg_write(pcf_bl->pcf, PCF50633_REG_LEDDIM, pdata->ramp_time); /* * Should be different from bl_props.brightness, so we do not exit -- 2.7.4 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.5 required=3.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED,DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B7A0AC433E9 for ; Tue, 2 Feb 2021 08:27:30 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5C2A464EC3 for ; Tue, 2 Feb 2021 08:27:30 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5C2A464EC3 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 75B026E8DA; Tue, 2 Feb 2021 08:27:01 +0000 (UTC) Received: from mail-io1-xd31.google.com (mail-io1-xd31.google.com [IPv6:2607:f8b0:4864:20::d31]) by gabe.freedesktop.org (Postfix) with ESMTPS id DF3896E7D9 for ; Mon, 1 Feb 2021 14:42:22 +0000 (UTC) Received: by mail-io1-xd31.google.com with SMTP id e133so6725324iof.8 for ; Mon, 01 Feb 2021 06:42:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=vYWcn7sL4czH23insMbT/xXB/qPApleY+YB9g2DqZvw=; b=srCiPPLg+FKyiypCOM4HhWnQR9qLFpjBesMwYf6bJhq048o7gMqqliN0JoZ8TIrxx7 lR2AhWdnqqRR1yM8pTNZYzgB5D8LFIvmsSp6UIlW0Gr2G8pHtDgwTswLA+T1xcC2Dz/s mTlTAYHbuU8GsoSGFIPPk3pUzkWkll0EbNP9gVdE2gFkJMUBTmiMZzLO9V+QwNpYCnXt MbaY22d3pkt7aVOjdbwzfFPez1PFGZ3tqSgM0E/8Yx80X2gkuLgvRACpuQICL1UX77g+ gJkyjLusERVpodvFNV/sUnBP+SOlagv7mVfC7PYEcgFauxvzGa/6GHQT9ARSfjY9Z3Jx ShAw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=vYWcn7sL4czH23insMbT/xXB/qPApleY+YB9g2DqZvw=; b=eMGjawKgcm94PbH+YJmGEMwll0fcM10lTaA/0OcoaPSP/gOMTZht8gCm2e+VC74FMx 8UCWnMpvJP8Z55x9/21q8kkvCXrp9+HkYD5vBanWw8WqGhqEqp8yZWynH+nYdUikrxa1 X6YDU221POV1JVbxhfkBFaOWbrDMfgxvGR2yEyG+e9EWtvWpwF1hpeQDGUZgEP0c2Z1C l8Ms47f4d7NCP0nPEbfGnZVryz5803MK0vUdcVqRIQBT9t4m+KN4ysXV2mzi77hMbfXU zF5zU8hidKu2qSn+Nf5qRPq2XcaurNo+C4QXs8PsT/bsdmxj3u5uQm63jSv5YsK8E8de phqQ== X-Gm-Message-State: AOAM530MjHx3yW7yRLRFifiViwyF6l0l0zYGgIgXMoWYcqf5JdQ/S16Z jEwEbn7JJNIp5toCx5FId+0= X-Google-Smtp-Source: ABdhPJybG8fZlQcKGj1GssmKBu/UxhmQ73Q9+3UlPhYlNwH0kDkW72buRTLQh4I5AFqrw8SG5cAWhA== X-Received: by 2002:a6b:7501:: with SMTP id l1mr12314288ioh.92.1612190542355; Mon, 01 Feb 2021 06:42:22 -0800 (PST) Received: from spring-Precision-5820-Tower.cs.umn.edu ([2607:ea00:101:3c74:b4b0:f34c:770:f33f]) by smtp.gmail.com with ESMTPSA id w2sm8470106ioa.46.2021.02.01.06.42.21 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 01 Feb 2021 06:42:22 -0800 (PST) From: Wenjia Zhao To: Subject: [PATCH] backlight: pcf50633: pdata may be a null pointer, null pointer dereference cause crash Date: Mon, 1 Feb 2021 08:41:38 -0600 Message-Id: <1612190499-73818-1-git-send-email-driverfuzzing@gmail.com> X-Mailer: git-send-email 2.7.4 X-Mailman-Approved-At: Tue, 02 Feb 2021 08:27:00 +0000 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Daniel Thompson , driverfuzzing@gmail.com, Bartlomiej Zolnierkiewicz , Jingoo Han , linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Lee Jones MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Signed-off-by: Wenjia Zhao --- drivers/video/backlight/pcf50633-backlight.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/video/backlight/pcf50633-backlight.c b/drivers/video/backlight/pcf50633-backlight.c index 540dd338..43267af 100644 --- a/drivers/video/backlight/pcf50633-backlight.c +++ b/drivers/video/backlight/pcf50633-backlight.c @@ -127,7 +127,8 @@ static int pcf50633_bl_probe(struct platform_device *pdev) platform_set_drvdata(pdev, pcf_bl); - pcf50633_reg_write(pcf_bl->pcf, PCF50633_REG_LEDDIM, pdata->ramp_time); + if (pdata) + pcf50633_reg_write(pcf_bl->pcf, PCF50633_REG_LEDDIM, pdata->ramp_time); /* * Should be different from bl_props.brightness, so we do not exit -- 2.7.4 _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel