From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0E5F4C433DB for ; Thu, 4 Feb 2021 11:56:58 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5CCF064E0A for ; Thu, 4 Feb 2021 11:56:57 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5CCF064E0A Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=chris-wilson.co.uk Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id D3D9E89B7B; Thu, 4 Feb 2021 11:56:56 +0000 (UTC) Received: from fireflyinternet.com (unknown [77.68.26.236]) by gabe.freedesktop.org (Postfix) with ESMTPS id 2B71889ABA for ; Thu, 4 Feb 2021 11:56:55 +0000 (UTC) X-Default-Received-SPF: pass (skip=forwardok (res=PASS)) x-ip-name=78.156.69.177; Received: from localhost (unverified [78.156.69.177]) by fireflyinternet.com (Firefly Internet (M1)) with ESMTP (TLS) id 23785759-1500050 for multiple; Thu, 04 Feb 2021 11:56:52 +0000 MIME-Version: 1.0 In-Reply-To: <161243750979.1383.2504816924204435385@build.alporthouse.com> References: <20210201085715.27435-1-chris@chris-wilson.co.uk> <20210201085715.27435-20-chris@chris-wilson.co.uk> <45740fad-297d-03e7-7de4-3a171376c0c2@linux.intel.com> <161243750979.1383.2504816924204435385@build.alporthouse.com> From: Chris Wilson To: Tvrtko Ursulin , intel-gfx@lists.freedesktop.org Date: Thu, 04 Feb 2021 11:56:51 +0000 Message-ID: <161243981120.4856.4115126682547775710@build.alporthouse.com> User-Agent: alot/0.9 Subject: Re: [Intel-gfx] [PATCH 20/57] drm/i915: Wrap access to intel_engine.active X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" Quoting Chris Wilson (2021-02-04 11:18:29) > Quoting Tvrtko Ursulin (2021-02-04 11:07:07) > > > > > > On 01/02/2021 08:56, Chris Wilson wrote: > > > diff --git a/drivers/gpu/drm/i915/gt/intel_execlists_submission.c b/drivers/gpu/drm/i915/gt/intel_execlists_submission.c > > > index b56e321ef003..280d84c4e4b7 100644 > > > --- a/drivers/gpu/drm/i915/gt/intel_execlists_submission.c > > > +++ b/drivers/gpu/drm/i915/gt/intel_execlists_submission.c > > > @@ -293,6 +293,7 @@ static int virtual_prio(const struct intel_engine_execlists *el) > > > static bool need_preempt(const struct intel_engine_cs *engine, > > > const struct i915_request *rq) > > > { > > > + const struct i915_sched *se = &engine->active; > > > > There's only two instances in this patch which do not use > > intel_engine_get_scheduler. Intended? > > They were the ones I earmarked for being replaced by the scheduler > object being passed down. Having down that I can do the replacement here > and remove the conflicts with the final result later. The catch here was the const. We can't make the getter take a const* at this point, so I left it as &engine->active to not have to remove the constness. -Chris _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx