From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,USER_AGENT_SANE_2 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 65F8BC433E0 for ; Sun, 7 Feb 2021 02:11:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3925D64E8C for ; Sun, 7 Feb 2021 02:11:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229596AbhBGCL1 (ORCPT ); Sat, 6 Feb 2021 21:11:27 -0500 Received: from mailgw02.mediatek.com ([1.203.163.81]:56339 "EHLO mailgw02.mediatek.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S229522AbhBGCLZ (ORCPT ); Sat, 6 Feb 2021 21:11:25 -0500 X-UUID: ced1d66ed56b4ac091400e5512e046af-20210207 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=TX4lSlAbeAqKjYx/w0Lj9bavqM0Zf4skWi3dYgpYSTE=; b=kpPoCgCD2C0SU3+NlzPJem6BU0fRAM8Cqm0BusfJu+z2ZLmThP8ZutrCptxfrZAuHn6/rpb83/QKqHI9z96bNcwjEslsnpVNcmB2ILyipm39W3apDYkA0WrPb8MsrjptGZVzlfdPFdA9S1DP2TBMWCmmNm7SagZpBFwBoucYyPA=; X-UUID: ced1d66ed56b4ac091400e5512e046af-20210207 Received: from mtkcas36.mediatek.inc [(172.27.4.253)] by mailgw02.mediatek.com (envelope-from ) (mailgw01.mediatek.com ESMTP with TLSv1.2 ECDHE-RSA-AES256-SHA384 256/256) with ESMTP id 641904420; Sun, 07 Feb 2021 10:10:36 +0800 Received: from MTKCAS32.mediatek.inc (172.27.4.184) by MTKMBS33N2.mediatek.inc (172.27.4.76) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Sun, 7 Feb 2021 10:10:33 +0800 Received: from [10.17.3.153] (10.17.3.153) by MTKCAS32.mediatek.inc (172.27.4.170) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Sun, 7 Feb 2021 10:10:33 +0800 Message-ID: <1612663833.5147.19.camel@mhfsdcap03> Subject: Re: [RFC PATCH v2 1/3] dt-bindings: usb: mtk-xhci: add compatible for mt8195 From: Chunfeng Yun To: Greg Kroah-Hartman CC: Rob Herring , Matthias Brugger , Mathias Nyman , , , , , , Ikjoon Jang , "Nicolas Boichat" Date: Sun, 7 Feb 2021 10:10:33 +0800 In-Reply-To: References: <20210203102642.7353-1-chunfeng.yun@mediatek.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.10.4-0ubuntu2 MIME-Version: 1.0 X-TM-SNTS-SMTP: 5AAE49BA3F09489F842EFD23B49F651E0B37C4C1342176E6BF5BF481ACC3F1D62000:8 X-MTK: N Content-Transfer-Encoding: base64 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org T24gV2VkLCAyMDIxLTAyLTAzIGF0IDExOjMxICswMTAwLCBHcmVnIEtyb2FoLUhhcnRtYW4gd3Jv dGU6DQo+IE9uIFdlZCwgRmViIDAzLCAyMDIxIGF0IDA2OjI2OjQwUE0gKzA4MDAsIENodW5mZW5n IFl1biB3cm90ZToNCj4gPiBUaGVyZSBhcmUgNCBVU0IgY29udHJvbGxlcnMgb24gTVQ4MTk1LCB0 aGUgY29udHJvbGxlcnMgKElQMX5JUDMsDQo+ID4gZXhjbHVkZSBJUDApIGhhdmUgYSB3cm9uZyBk ZWZhdWx0IFNPRi9JVFAgaW50ZXJ2YWwgd2hpY2ggaXMNCj4gPiBjYWxjdWxhdGVkIGZyb20gdGhl IGZyYW1lIGNvdW50ZXIgY2xvY2sgMjRNaHogYnkgZGVmYXVsdCwgYnV0DQo+ID4gaW4gZmFjdCwg dGhlIGZyYW1lIGNvdW50ZXIgY2xvY2sgaXMgNDhNaHosIHNvIHdlIHNob3VsZCBzZXQNCj4gPiB0 aGUgYWNjdXJhdGUgaW50ZXJ2YWwgYWNjb3JkaW5nIHRvIDQ4TWh6LiBIZXJlIGFkZCBhIG5ldyBj b21wYXRpYmxlDQo+ID4gZm9yIE1UODE5NSwgaXQncyBhbHNvIHN1cHBvcnRlZCBpbiBkcml2ZXIu IEJ1dCB0aGUgZmlyc3QgY29udHJvbGxlcg0KPiA+IChJUDApIGhhcyBubyBzdWNoIGlzc3VlLCB3 ZSBwcmVmZXIgdG8gdXNlIGdlbmVyaWMgY29tcGF0aWJsZSwNCj4gPiBlLmcuIG10ODE5MidzIGNv bXBhdGlibGUuDQo+ID4gDQo+ID4gU2lnbmVkLW9mZi1ieTogQ2h1bmZlbmcgWXVuIDxjaHVuZmVu Zy55dW5AbWVkaWF0ZWsuY29tPg0KPiA+IC0tLQ0KPiA+IHYyOiBubyBjaGFuZ2VzDQo+IA0KPiBO b3RlLCBJIGRvIG5vdCBhcHBseSBwYXRjaGVzIHdpdGggIlJGQyIgYXMgb2J2aW91c2x5IHlvdSBk byBub3QgdGhpbmsNCj4gdGhleSBhcmUgd29ydGh5IG9mIGJlaW5nIGFwcGxpZWQuICBJIGRvbid0 IHNlZSB3aGF0IHlvdSBhcmUgYXNraW5nIHRvIGJlDQo+IGRvbmUgd2l0aCB0aGlzIHNldCBvZiBw YXRjaGVzLCBwbGVhc2UgZXhwbGFpbj8NClRoZSBEVFMgcGF0Y2ggWzIvM10gaW4gdGhlIHNlcmll cyB3aWxsIGNhdXNlIG1lcmdlIGNvbmZsaWN0LCBkdWUgdG8gdGhlDQpkZXBlbmRlbnQgcGF0Y2hl cyBhcmUgbm90IHVwc3RyZWFtZWQuDQoNCkFub3RoZXIgcHJvYmxlbSBpcyB0aGF0IEkgd2FuZGVy IHRvIGtub3cgd2hldGhlciB0aGUgY29tcGF0aWJsZSB1c2FnZSBhcw0KZm9sbG93aW5nIGlzIGFs bG93ZWQ6DQoNCmFyY2gvYXJtNjQvYm9vdC9kdHMvbWVkaWF0ZWsvbXQ4MTk1LmR0c2kNCg0KICAg dXNiQDExMjAwMDAwIHsgIC8vIGlwMA0KICAgICAgICBjb21wYXRpYmxlID0gIm1lZGlhdGVrLG10 ODE5Mi14aGNpIiwgIC8vIGhlcmUgdXNlIG10ODE5MidzDQpjb21wYXRpYmxlLCBhdm9pZCBjaGFu Z2luZyBTT0YvSVRQIGludGVydmFsIGZvciBpcDAsIGJlY2F1c2UgaXQncw0KZGVmYXVsdCB2YWx1 ZSBpcyBvay4ibWVkaWF0ZWssbXQ4MTkyLXhoY2kiIGlzIG5vdCBzdXBwb3J0ZWQgaW4gZHJpdmVy LA0Kc28gZmluYWxseSB3aWxsIHVzZSBnZW5lcmljIGNvcGF0aWJsZSAibWVkaWF0ZWssbXRrLXho Y2kiLg0KDQogICAgICAgICAgICAgICAgICAgICAibWVkaWF0ZWssbXRrLXhoY2kiOw0KICAgICAg ICAuLi4uDQogICAgfTsNCg0KICAgdXNiQDExMjkwMDAwIHsgIC8vIGlwMQ0KICAgICAgICBjb21w YXRpYmxlID0gIm1lZGlhdGVrLG10ODE5NS14aGNpIiwgIC8vIGhlcmUgdXNlIG10ODE5NSdzDQpj b21wYXRpYmxlLCB1c2VkIHRvIGNoYW5nZSBTT0YvSVRQIGludGVydmFsLCBkdWUgdGhlIHRoZSB3 cm9uZyBkZWZhdWx0DQp2YWx1ZS4NCiAgICAgICAgICAgICAgICAgICAgICJtZWRpYXRlayxtdGst eGhjaSI7DQogICB9Ow0KDQogICB1c2JAMTEyYTAwMDAgeyAgLy8gaXAyDQogICAgICAgIGNvbXBh dGlibGUgPSAibWVkaWF0ZWssbXQ4MTk1LXhoY2kiLCAgLy8gc2FtZSBhcyBpcDENCiAgICAgICAg ICAgICAgICAgICAgICJtZWRpYXRlayxtdGsteGhjaSI7DQogICAgfTsNCg0KVGhhbmsgeW91DQoN Cj4gDQo+IHRoYW5rcywNCj4gDQo+IGdyZWcgay1oDQoNCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 91B85C433E0 for ; Sun, 7 Feb 2021 02:10:59 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 084C064E87 for ; Sun, 7 Feb 2021 02:10:58 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 084C064E87 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Date:To:From: Subject:Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=1QSfgo8fXCHEkT0WnnsMiMCMv37pA5z2anqusPXyEug=; b=xpK3y2HXcqMocNejg7qmzcQMU gtWHa25WXAaxUXv0EUZKwH8SmGg+LHfc+aHLMFq/6sjVw26Gx9TS2chxzW/TuwN/0yrT2bopQgSL5 KuDkdxAm2tFnWXjZ6bQxvbIDjBSpF/nwlP0lE24u/sfpq5cQcjjha9njUEjApWFBSpNWyXNDyIJco wvp+A5P9F5UuBwKkm2wFbhhRQa0ThwpVEuwJbDNKVQEGBd/f+dAfohNpn+WlKJn3mjMIaEbSLQVKE k2pKt3qEfY+Wba53N/xAUrkokSQukaChOwioKwA6TZscUlrjN+5OojBA9hFyAOa8bPa5tfdtr6nNr 0sDBoUvXw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1l8ZXE-0005rb-A9; Sun, 07 Feb 2021 02:10:48 +0000 Received: from mailgw01.mediatek.com ([216.200.240.184]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1l8ZXB-0005r5-A6; Sun, 07 Feb 2021 02:10:46 +0000 X-UUID: f17af4e31bd04ac0a71f21f29dc5994b-20210206 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=TX4lSlAbeAqKjYx/w0Lj9bavqM0Zf4skWi3dYgpYSTE=; b=kpPoCgCD2C0SU3+NlzPJem6BU0fRAM8Cqm0BusfJu+z2ZLmThP8ZutrCptxfrZAuHn6/rpb83/QKqHI9z96bNcwjEslsnpVNcmB2ILyipm39W3apDYkA0WrPb8MsrjptGZVzlfdPFdA9S1DP2TBMWCmmNm7SagZpBFwBoucYyPA=; X-UUID: f17af4e31bd04ac0a71f21f29dc5994b-20210206 Received: from mtkcas66.mediatek.inc [(172.29.193.44)] by mailgw01.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLSv1.2 ECDHE-RSA-AES256-SHA384 256/256) with ESMTP id 1935425329; Sat, 06 Feb 2021 18:10:38 -0800 Received: from MTKMBS33N2.mediatek.inc (172.27.4.76) by MTKMBS62N2.mediatek.inc (172.29.193.42) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Sat, 6 Feb 2021 18:10:37 -0800 Received: from MTKCAS32.mediatek.inc (172.27.4.184) by MTKMBS33N2.mediatek.inc (172.27.4.76) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Sun, 7 Feb 2021 10:10:33 +0800 Received: from [10.17.3.153] (10.17.3.153) by MTKCAS32.mediatek.inc (172.27.4.170) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Sun, 7 Feb 2021 10:10:33 +0800 Message-ID: <1612663833.5147.19.camel@mhfsdcap03> Subject: Re: [RFC PATCH v2 1/3] dt-bindings: usb: mtk-xhci: add compatible for mt8195 From: Chunfeng Yun To: Greg Kroah-Hartman Date: Sun, 7 Feb 2021 10:10:33 +0800 In-Reply-To: References: <20210203102642.7353-1-chunfeng.yun@mediatek.com> X-Mailer: Evolution 3.10.4-0ubuntu2 MIME-Version: 1.0 X-TM-SNTS-SMTP: 5AAE49BA3F09489F842EFD23B49F651E0B37C4C1342176E6BF5BF481ACC3F1D62000:8 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210206_211045_589207_4206B457 X-CRM114-Status: GOOD ( 20.63 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, Nicolas Boichat , Mathias Nyman , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, Rob Herring , linux-mediatek@lists.infradead.org, Matthias Brugger , Ikjoon Jang , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org On Wed, 2021-02-03 at 11:31 +0100, Greg Kroah-Hartman wrote: > On Wed, Feb 03, 2021 at 06:26:40PM +0800, Chunfeng Yun wrote: > > There are 4 USB controllers on MT8195, the controllers (IP1~IP3, > > exclude IP0) have a wrong default SOF/ITP interval which is > > calculated from the frame counter clock 24Mhz by default, but > > in fact, the frame counter clock is 48Mhz, so we should set > > the accurate interval according to 48Mhz. Here add a new compatible > > for MT8195, it's also supported in driver. But the first controller > > (IP0) has no such issue, we prefer to use generic compatible, > > e.g. mt8192's compatible. > > > > Signed-off-by: Chunfeng Yun > > --- > > v2: no changes > > Note, I do not apply patches with "RFC" as obviously you do not think > they are worthy of being applied. I don't see what you are asking to be > done with this set of patches, please explain? The DTS patch [2/3] in the series will cause merge conflict, due to the dependent patches are not upstreamed. Another problem is that I wander to know whether the compatible usage as following is allowed: arch/arm64/boot/dts/mediatek/mt8195.dtsi usb@11200000 { // ip0 compatible = "mediatek,mt8192-xhci", // here use mt8192's compatible, avoid changing SOF/ITP interval for ip0, because it's default value is ok."mediatek,mt8192-xhci" is not supported in driver, so finally will use generic copatible "mediatek,mtk-xhci". "mediatek,mtk-xhci"; .... }; usb@11290000 { // ip1 compatible = "mediatek,mt8195-xhci", // here use mt8195's compatible, used to change SOF/ITP interval, due the the wrong default value. "mediatek,mtk-xhci"; }; usb@112a0000 { // ip2 compatible = "mediatek,mt8195-xhci", // same as ip1 "mediatek,mtk-xhci"; }; Thank you > > thanks, > > greg k-h _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,USER_AGENT_SANE_2 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B3CE1C433DB for ; Sun, 7 Feb 2021 02:12:28 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4912264E81 for ; Sun, 7 Feb 2021 02:12:28 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4912264E81 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Date:To:From: Subject:Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=dcKFoDX6LhxEpyf54awIXI6Xl3ElyBbq40o+OF+vjAw=; b=TaqI8xxhvhsl5ur6LW5wQzTld o+fcHPIr35+Cwi5m4Jm3xpA1BKIGVYshu2/FL+A/Jh9uFEpyP9/ODC9t3nRcaYqwTfnAP5GmG9/RU 1e4Yv/YqT6VM6xRNK/638EyOiqKao61yAcxOjoYkSr4FhEHqYn2RS/yjzUUsQOVGD3fDn33u3P07F bHJ1/+vE8QfKRs44Sg3lmhthgABMCQ/Dp5yqtoulxfQr8tA+vlALjt5k82gOoxFuPUwt7otNujEZa cD/NzLuNbf14nE2oAlbyfpa2sPp7G9PfacMbaEYi4Jd520A1q2zceyoei8QzCOECnnJ5FgugJ8lw5 UaKPqYFTA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1l8ZXF-0005ri-EY; Sun, 07 Feb 2021 02:10:49 +0000 Received: from mailgw01.mediatek.com ([216.200.240.184]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1l8ZXB-0005r5-A6; Sun, 07 Feb 2021 02:10:46 +0000 X-UUID: f17af4e31bd04ac0a71f21f29dc5994b-20210206 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=TX4lSlAbeAqKjYx/w0Lj9bavqM0Zf4skWi3dYgpYSTE=; b=kpPoCgCD2C0SU3+NlzPJem6BU0fRAM8Cqm0BusfJu+z2ZLmThP8ZutrCptxfrZAuHn6/rpb83/QKqHI9z96bNcwjEslsnpVNcmB2ILyipm39W3apDYkA0WrPb8MsrjptGZVzlfdPFdA9S1DP2TBMWCmmNm7SagZpBFwBoucYyPA=; X-UUID: f17af4e31bd04ac0a71f21f29dc5994b-20210206 Received: from mtkcas66.mediatek.inc [(172.29.193.44)] by mailgw01.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLSv1.2 ECDHE-RSA-AES256-SHA384 256/256) with ESMTP id 1935425329; Sat, 06 Feb 2021 18:10:38 -0800 Received: from MTKMBS33N2.mediatek.inc (172.27.4.76) by MTKMBS62N2.mediatek.inc (172.29.193.42) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Sat, 6 Feb 2021 18:10:37 -0800 Received: from MTKCAS32.mediatek.inc (172.27.4.184) by MTKMBS33N2.mediatek.inc (172.27.4.76) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Sun, 7 Feb 2021 10:10:33 +0800 Received: from [10.17.3.153] (10.17.3.153) by MTKCAS32.mediatek.inc (172.27.4.170) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Sun, 7 Feb 2021 10:10:33 +0800 Message-ID: <1612663833.5147.19.camel@mhfsdcap03> Subject: Re: [RFC PATCH v2 1/3] dt-bindings: usb: mtk-xhci: add compatible for mt8195 From: Chunfeng Yun To: Greg Kroah-Hartman Date: Sun, 7 Feb 2021 10:10:33 +0800 In-Reply-To: References: <20210203102642.7353-1-chunfeng.yun@mediatek.com> X-Mailer: Evolution 3.10.4-0ubuntu2 MIME-Version: 1.0 X-TM-SNTS-SMTP: 5AAE49BA3F09489F842EFD23B49F651E0B37C4C1342176E6BF5BF481ACC3F1D62000:8 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210206_211045_589207_4206B457 X-CRM114-Status: GOOD ( 20.63 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, Nicolas Boichat , Mathias Nyman , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, Rob Herring , linux-mediatek@lists.infradead.org, Matthias Brugger , Ikjoon Jang , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, 2021-02-03 at 11:31 +0100, Greg Kroah-Hartman wrote: > On Wed, Feb 03, 2021 at 06:26:40PM +0800, Chunfeng Yun wrote: > > There are 4 USB controllers on MT8195, the controllers (IP1~IP3, > > exclude IP0) have a wrong default SOF/ITP interval which is > > calculated from the frame counter clock 24Mhz by default, but > > in fact, the frame counter clock is 48Mhz, so we should set > > the accurate interval according to 48Mhz. Here add a new compatible > > for MT8195, it's also supported in driver. But the first controller > > (IP0) has no such issue, we prefer to use generic compatible, > > e.g. mt8192's compatible. > > > > Signed-off-by: Chunfeng Yun > > --- > > v2: no changes > > Note, I do not apply patches with "RFC" as obviously you do not think > they are worthy of being applied. I don't see what you are asking to be > done with this set of patches, please explain? The DTS patch [2/3] in the series will cause merge conflict, due to the dependent patches are not upstreamed. Another problem is that I wander to know whether the compatible usage as following is allowed: arch/arm64/boot/dts/mediatek/mt8195.dtsi usb@11200000 { // ip0 compatible = "mediatek,mt8192-xhci", // here use mt8192's compatible, avoid changing SOF/ITP interval for ip0, because it's default value is ok."mediatek,mt8192-xhci" is not supported in driver, so finally will use generic copatible "mediatek,mtk-xhci". "mediatek,mtk-xhci"; .... }; usb@11290000 { // ip1 compatible = "mediatek,mt8195-xhci", // here use mt8195's compatible, used to change SOF/ITP interval, due the the wrong default value. "mediatek,mtk-xhci"; }; usb@112a0000 { // ip2 compatible = "mediatek,mt8195-xhci", // same as ip1 "mediatek,mtk-xhci"; }; Thank you > > thanks, > > greg k-h _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel