From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DBC80C433E0 for ; Tue, 9 Feb 2021 02:33:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 996FA64EB4 for ; Tue, 9 Feb 2021 02:33:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229881AbhBICdU (ORCPT ); Mon, 8 Feb 2021 21:33:20 -0500 Received: from mail.kernel.org ([198.145.29.99]:33544 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229702AbhBICdN (ORCPT ); Mon, 8 Feb 2021 21:33:13 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id 1D2E064EBF; Tue, 9 Feb 2021 02:32:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1612837953; bh=E1JyaKaJyxf0Q/mgLSd9kZ+dqcdbkyNDn2+UStmuPK8=; h=In-Reply-To:References:Subject:From:Cc:To:Date:From; b=ScDvHxIbVZrqIWDoK5HGjVs1cBoouoaSKhtF7voWxHDz9e7q8cFMzVfvzc0KPbWu3 BllbecYnOOP9umI2xYn7dVbnT1qpopBalT6ip+JVWcro8G8XHYpZINcCYjjh9p6Oro pjuKhHzqArRnrQj40MqBUotoHYWHyFu8pnZzjF82X1IQtvDFPINKxpwGJx5GQZYGI7 6JTmvL3YyiACzDSns+F2L2DErimEoXAiAVP5vcaAUn7g1dprGAaPmbWF+P7/VTsZWt bbEpEsr6nI67C2tSdoorNb0EFA7al5qqpoj9PzLB4jtOchvlwS7aANq58PV4NK/kPV w+g11x1IU1iNA== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable In-Reply-To: <20210121071659.1226489-6-m.tretter@pengutronix.de> References: <20210121071659.1226489-1-m.tretter@pengutronix.de> <20210121071659.1226489-6-m.tretter@pengutronix.de> Subject: Re: [PATCH v3 05/15] soc: xilinx: vcu: add helpers for configuring PLL From: Stephen Boyd Cc: m.mtretter@pengutronix.de, michals@xilinx.com, kernel@pengutronix.de, mturquette@baylibre.com To: Michael Tretter , linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org Date: Mon, 08 Feb 2021 18:32:31 -0800 Message-ID: <161283795180.76967.9672753408331027692@swboyd.mtv.corp.google.com> User-Agent: alot/0.9.1 Precedence: bulk List-ID: X-Mailing-List: linux-clk@vger.kernel.org Quoting Michael Tretter (2021-01-20 23:16:49) > The xvcu_set_vcu_pll_info function sets the rate of the PLL and enables > it, which makes it difficult to cleanly convert the driver to the common > clock framework. >=20 > Split the function and add separate functions for setting the rate, > enabling the clock and disabling the clock. >=20 > Also move the enable of the reference clock from probe to the helper > that enables the PLL. >=20 > Signed-off-by: Michael Tretter > Acked-by: Michal Simek > --- Applied to clk-next From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 54203C433DB for ; Tue, 9 Feb 2021 02:34:05 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id EE87764E99 for ; Tue, 9 Feb 2021 02:34:04 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EE87764E99 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Message-ID:Date:To:From:Subject:References: In-Reply-To:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=7zEwm9cmBcMzkXwnEzSZwW+4cDrCqx9RXghkqN+Rm2w=; b=2ICcEQ/PtemSQsxBQq+SXmbF5 usy2w1N29GTXE/VhrWXpYGS23S1ReJttCXFoqeeO8QMGCftsj47vd7u/yf9qZpMM29QFSoTlMvchh pexQnXaW+K1c3x2+2e4/3edfp4C0FiVGNzG3H8NkZvL/QgU+1aMO37fnC+1IdKAS0DeRbkYyKSCPu z/H4XtGRUCXyAkJt6LFQzpQl4S/IzfR+hg5Cw+GdHbWowOl/WfEDUgT3xH7+y/mUnQAWVydyhmV1u 2YXtlCrHW3L5rr7hkQcP4JqgpulXPPiMBT9z7ZS7UVH83IYyP2bXgMg4bDPIj/ZNu1O0seRbB/Rnn M/zTitVSg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1l9IpQ-00029I-Ve; Tue, 09 Feb 2021 02:32:37 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1l9IpN-00028Z-U5 for linux-arm-kernel@lists.infradead.org; Tue, 09 Feb 2021 02:32:34 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id 1D2E064EBF; Tue, 9 Feb 2021 02:32:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1612837953; bh=E1JyaKaJyxf0Q/mgLSd9kZ+dqcdbkyNDn2+UStmuPK8=; h=In-Reply-To:References:Subject:From:Cc:To:Date:From; b=ScDvHxIbVZrqIWDoK5HGjVs1cBoouoaSKhtF7voWxHDz9e7q8cFMzVfvzc0KPbWu3 BllbecYnOOP9umI2xYn7dVbnT1qpopBalT6ip+JVWcro8G8XHYpZINcCYjjh9p6Oro pjuKhHzqArRnrQj40MqBUotoHYWHyFu8pnZzjF82X1IQtvDFPINKxpwGJx5GQZYGI7 6JTmvL3YyiACzDSns+F2L2DErimEoXAiAVP5vcaAUn7g1dprGAaPmbWF+P7/VTsZWt bbEpEsr6nI67C2tSdoorNb0EFA7al5qqpoj9PzLB4jtOchvlwS7aANq58PV4NK/kPV w+g11x1IU1iNA== MIME-Version: 1.0 In-Reply-To: <20210121071659.1226489-6-m.tretter@pengutronix.de> References: <20210121071659.1226489-1-m.tretter@pengutronix.de> <20210121071659.1226489-6-m.tretter@pengutronix.de> Subject: Re: [PATCH v3 05/15] soc: xilinx: vcu: add helpers for configuring PLL From: Stephen Boyd To: Michael Tretter , linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org Date: Mon, 08 Feb 2021 18:32:31 -0800 Message-ID: <161283795180.76967.9672753408331027692@swboyd.mtv.corp.google.com> User-Agent: alot/0.9.1 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210208_213234_058394_CBABB5B8 X-CRM114-Status: UNSURE ( 9.54 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: mturquette@baylibre.com, m.mtretter@pengutronix.de, michals@xilinx.com, kernel@pengutronix.de Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Quoting Michael Tretter (2021-01-20 23:16:49) > The xvcu_set_vcu_pll_info function sets the rate of the PLL and enables > it, which makes it difficult to cleanly convert the driver to the common > clock framework. > > Split the function and add separate functions for setting the rate, > enabling the clock and disabling the clock. > > Also move the enable of the reference clock from probe to the helper > that enables the PLL. > > Signed-off-by: Michael Tretter > Acked-by: Michal Simek > --- Applied to clk-next _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel