All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stephen Boyd <swboyd@chromium.org>
To: mkrishn@codeaurora.org
Cc: linux-arm-msm@vger.kernel.org, kalyan_t@codeaurora.org,
	tanmay@codeaurora.org, abhinavk@codeaurora.org,
	robdclark@gmail.com, bjorn.andersson@linaro.org,
	vinod.koul@linaro.org, rnayak@codeaurora.org,
	dianders@chromium.org, sibis@codeaurora.org
Subject: Re: [PATCH v10 2/4] dt-bindings: msm: dsi: add yaml schemas for DSI bindings
Date: Tue, 09 Feb 2021 22:02:27 -0800	[thread overview]
Message-ID: <161293694727.418021.3278297564567882319@swboyd.mtv.corp.google.com> (raw)
In-Reply-To: <2411ac0b2de4b4324b41f08761af1dff@codeaurora.org>

Quoting mkrishn@codeaurora.org (2021-02-09 02:53:41)
> On 2021-02-06 04:04, Stephen Boyd wrote:
> >> +  - interrupts
> >> +  - clocks
> >> +  - clock-names
> >> +  - phys
> >> +  - phy-names
> >> +  - ports
> >> +
> >> +unevaluatedProperties: false
> >> +
> >> +examples:
> >> +  - |
> >> +     #include <dt-bindings/interrupt-controller/arm-gic.h>
> >> +     #include <dt-bindings/clock/qcom,dispcc-sdm845.h>
> >> +     #include <dt-bindings/clock/qcom,gcc-sdm845.h>
> >> +
> >> +     soc {
> >> +       #address-cells = <2>;
> >> +       #size-cells = <2>;
> > 
> > The soc node can be left out.
> Should I follow the same approach that you suggested in DP yaml patch 
> here also ?
> ie. soc {
>          #address-cells = <2>;
>          #size-cells = <2>;
> 
>          dsi@ae9400000{
>            ...
>          }
>      }

Yes.

> Link : 
> https://patchwork.kernel.org/project/linux-arm-msm/patch/1612420939-15502-4-git-send-email-mkrishn@codeaurora.org/
> Comment:
>             Please look at section "2.2.2 Generic Names Recommendation" 
> of the DT
>             spec[1] to find a proper name. I don't see 'subsystem' there 
> but that
>             may be because it shouldn't really exist as a node. Instead 
> we should
>             have the child nodes sit directly under the SoC node.

  reply	other threads:[~2021-02-10  6:03 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-04  6:42 [PATCH v10 1/4] dt-bindings: msm: disp: add yaml schemas for DPU bindings Krishna Manikandan
2021-02-04  6:42 ` [PATCH v10 2/4] dt-bindings: msm: dsi: add yaml schemas for DSI bindings Krishna Manikandan
2021-02-05 22:34   ` Stephen Boyd
2021-02-09 10:53     ` mkrishn
2021-02-10  6:02       ` Stephen Boyd [this message]
2021-02-04  6:42 ` [PATCH v10 3/4] dt-bindings: msm: dsi: add yaml schemas for DSI PHY bindings Krishna Manikandan
2021-02-05 19:08   ` Stephen Boyd
2021-02-04  6:42 ` [PATCH v10 4/4] dt-bindings: msm/dp: Add bindings of MSM DisplayPort controller Krishna Manikandan
2021-02-05 19:02   ` Stephen Boyd
2021-02-05 20:55     ` khsieh
2021-02-05 22:38       ` Stephen Boyd

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=161293694727.418021.3278297564567882319@swboyd.mtv.corp.google.com \
    --to=swboyd@chromium.org \
    --cc=abhinavk@codeaurora.org \
    --cc=bjorn.andersson@linaro.org \
    --cc=dianders@chromium.org \
    --cc=kalyan_t@codeaurora.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=mkrishn@codeaurora.org \
    --cc=rnayak@codeaurora.org \
    --cc=robdclark@gmail.com \
    --cc=sibis@codeaurora.org \
    --cc=tanmay@codeaurora.org \
    --cc=vinod.koul@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.