From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B829EC433E6 for ; Thu, 11 Feb 2021 19:24:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4AF2B64DE1 for ; Thu, 11 Feb 2021 19:24:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230305AbhBKTYi (ORCPT ); Thu, 11 Feb 2021 14:24:38 -0500 Received: from mail.kernel.org ([198.145.29.99]:42198 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229978AbhBKTY3 (ORCPT ); Thu, 11 Feb 2021 14:24:29 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id 5B82764DF3; Thu, 11 Feb 2021 19:23:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1613071428; bh=q212lYt4ihrp76ADLXHJK6ZM1oxf7oDEPHFpC8j7mN8=; h=In-Reply-To:References:Subject:From:Cc:To:Date:From; b=O8Tfs1pEG2o3QsWaAKYQ20RF7SOR9YTFw+ljpvuTbsla77w7Er5ET1eCmg1otpjSH omX+vbHYtajcHNYvObKGVNvSetIZDQs00avD2WA5VE556cGER6WMfy0gx/ExoH4P/P 6JYGzuGcm/qrb8mEFLVcosH6dbwRkr02XQlxI+p2Xh6Xm7Ysxjch9zwmFwo8eV4V3q JcgXAkL1YkROEoOBbCkCnffHZKCPzFrmLnYnvLyHNDhJi+5kllYzreAQYy0s11KDdf 7zVEJf3TUDOs7Vwdut5UVrls8V2O+sVo+1c2PQF9W/CX+jRKocX9zZ3wwQJWRKeDtH EHVRoPqc8wkNQ== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable In-Reply-To: <20210126124540.3320214-9-lee.jones@linaro.org> References: <20210126124540.3320214-1-lee.jones@linaro.org> <20210126124540.3320214-9-lee.jones@linaro.org> Subject: Re: [PATCH 08/21] clk: clkdev: Ignore suggestion to use gnu_printf() as it's not appropriate here From: Stephen Boyd Cc: linux-kernel@vger.kernel.org, Russell King , linux-arm-kernel@lists.infradead.org, linux-kbuild@vger.kernel.org To: lee.jones@linaro.org Date: Thu, 11 Feb 2021 11:23:47 -0800 Message-ID: <161307142704.1254594.1986201109191269158@swboyd.mtv.corp.google.com> User-Agent: alot/0.9.1 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Quoting Lee Jones (2021-01-26 04:45:27) > Fixes the following W=3D1 kernel build warning(s): >=20 > drivers/clk/clkdev.c: In function =E2=80=98vclkdev_alloc=E2=80=99: > drivers/clk/clkdev.c:173:3: warning: function =E2=80=98vclkdev_alloc=E2= =80=99 might be a candidate for =E2=80=98gnu_printf=E2=80=99 format attribu= te [-Wsuggest-attribute=3Dformat] >=20 > Cc: Russell King > Cc: linux-arm-kernel@lists.infradead.org > Signed-off-by: Lee Jones > --- > drivers/clk/clkdev.c | 7 +++++++ > 1 file changed, 7 insertions(+) >=20 > diff --git a/drivers/clk/clkdev.c b/drivers/clk/clkdev.c > index 0f2e3fcf0f19f..5e5f25d568724 100644 > --- a/drivers/clk/clkdev.c > +++ b/drivers/clk/clkdev.c > @@ -153,6 +153,11 @@ struct clk_lookup_alloc { > char con_id[MAX_CON_ID]; > }; > =20 > +#pragma GCC diagnostic push > +#ifndef __clang__ > +#pragma GCC diagnostic ignored "-Wsuggest-attribute=3Dformat" > +#endif Can this be some macro banished to compiler.h? > + > static struct clk_lookup * __ref > vclkdev_alloc(struct clk_hw *hw, const char *con_id, const char *dev_fmt, > va_list ap) > @@ -177,6 +182,8 @@ vclkdev_alloc(struct clk_hw *hw, const char *con_id, = const char *dev_fmt, > return &cla->cl; > } > =20 > +#pragma GCC diagnostic pop > + > static struct clk_lookup * > vclkdev_create(struct clk_hw *hw, const char *con_id, const char *dev_fm= t, > va_list ap) > --=20 > 2.25.1 > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 938EDC433DB for ; Thu, 11 Feb 2021 19:25:08 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 80D7464DE1 for ; Thu, 11 Feb 2021 19:25:07 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 80D7464DE1 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Message-ID:Date:To:From:Subject:References: In-Reply-To:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=d2492ysY18wmN6rNFskonVMFOjkvsATNhOlb5zCSU8s=; b=FrKnF8blCb38+n4eYXPuXRJVW lSpft/b0FND0rMgZ8PwwOP7ClG4aBOg0KgT9eNU66MkPZnEIrxY7MX5jPLFnYFgFgt3EJuK4tcb9T ZDjQhRV1kSjg/vIAdPs1JQiav3yzQrfKgNe8r9CRN1lQv8Mf2HBJnHL230Kbv6nqPMwSXbTvPgsUa s6dBsU8lsJU1pl6eGEbJwxh23XpTxpbLFBoeCpFZ+pUDuyxl+iCTeNZZj+CHIqYvP7ozEqjl0ggVr y+syVb53gnUvcnbofzxkWf0kVb3U7K8y0QOGvv1WqC253HrV4+kHUPM6Pj8UTD+OQ+HWHV2eV5gXt dg/XxZSdQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1lAHZL-0000OO-1C; Thu, 11 Feb 2021 19:24:03 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1lAHZJ-0000Nc-H7 for linux-arm-kernel@lists.infradead.org; Thu, 11 Feb 2021 19:24:02 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id 5B82764DF3; Thu, 11 Feb 2021 19:23:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1613071428; bh=q212lYt4ihrp76ADLXHJK6ZM1oxf7oDEPHFpC8j7mN8=; h=In-Reply-To:References:Subject:From:Cc:To:Date:From; b=O8Tfs1pEG2o3QsWaAKYQ20RF7SOR9YTFw+ljpvuTbsla77w7Er5ET1eCmg1otpjSH omX+vbHYtajcHNYvObKGVNvSetIZDQs00avD2WA5VE556cGER6WMfy0gx/ExoH4P/P 6JYGzuGcm/qrb8mEFLVcosH6dbwRkr02XQlxI+p2Xh6Xm7Ysxjch9zwmFwo8eV4V3q JcgXAkL1YkROEoOBbCkCnffHZKCPzFrmLnYnvLyHNDhJi+5kllYzreAQYy0s11KDdf 7zVEJf3TUDOs7Vwdut5UVrls8V2O+sVo+1c2PQF9W/CX+jRKocX9zZ3wwQJWRKeDtH EHVRoPqc8wkNQ== MIME-Version: 1.0 In-Reply-To: <20210126124540.3320214-9-lee.jones@linaro.org> References: <20210126124540.3320214-1-lee.jones@linaro.org> <20210126124540.3320214-9-lee.jones@linaro.org> Subject: Re: [PATCH 08/21] clk: clkdev: Ignore suggestion to use gnu_printf() as it's not appropriate here From: Stephen Boyd To: lee.jones@linaro.org Date: Thu, 11 Feb 2021 11:23:47 -0800 Message-ID: <161307142704.1254594.1986201109191269158@swboyd.mtv.corp.google.com> User-Agent: alot/0.9.1 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210211_142401_634184_1B53DDC2 X-CRM114-Status: GOOD ( 13.11 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Russell King Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org UXVvdGluZyBMZWUgSm9uZXMgKDIwMjEtMDEtMjYgMDQ6NDU6MjcpCj4gRml4ZXMgdGhlIGZvbGxv d2luZyBXPTEga2VybmVsIGJ1aWxkIHdhcm5pbmcocyk6Cj4gCj4gIGRyaXZlcnMvY2xrL2Nsa2Rl di5jOiBJbiBmdW5jdGlvbiDigJh2Y2xrZGV2X2FsbG9j4oCZOgo+ICBkcml2ZXJzL2Nsay9jbGtk ZXYuYzoxNzM6Mzogd2FybmluZzogZnVuY3Rpb24g4oCYdmNsa2Rldl9hbGxvY+KAmSBtaWdodCBi ZSBhIGNhbmRpZGF0ZSBmb3Ig4oCYZ251X3ByaW50ZuKAmSBmb3JtYXQgYXR0cmlidXRlIFstV3N1 Z2dlc3QtYXR0cmlidXRlPWZvcm1hdF0KPiAKPiBDYzogUnVzc2VsbCBLaW5nIDxsaW51eEBhcm1s aW51eC5vcmcudWs+Cj4gQ2M6IGxpbnV4LWFybS1rZXJuZWxAbGlzdHMuaW5mcmFkZWFkLm9yZwo+ IFNpZ25lZC1vZmYtYnk6IExlZSBKb25lcyA8bGVlLmpvbmVzQGxpbmFyby5vcmc+Cj4gLS0tCj4g IGRyaXZlcnMvY2xrL2Nsa2Rldi5jIHwgNyArKysrKysrCj4gIDEgZmlsZSBjaGFuZ2VkLCA3IGlu c2VydGlvbnMoKykKPiAKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9jbGsvY2xrZGV2LmMgYi9kcml2 ZXJzL2Nsay9jbGtkZXYuYwo+IGluZGV4IDBmMmUzZmNmMGYxOWYuLjVlNWYyNWQ1Njg3MjQgMTAw NjQ0Cj4gLS0tIGEvZHJpdmVycy9jbGsvY2xrZGV2LmMKPiArKysgYi9kcml2ZXJzL2Nsay9jbGtk ZXYuYwo+IEBAIC0xNTMsNiArMTUzLDExIEBAIHN0cnVjdCBjbGtfbG9va3VwX2FsbG9jIHsKPiAg ICAgICAgIGNoYXIgICAgY29uX2lkW01BWF9DT05fSURdOwo+ICB9Owo+ICAKPiArI3ByYWdtYSBH Q0MgZGlhZ25vc3RpYyBwdXNoCj4gKyNpZm5kZWYgX19jbGFuZ19fCj4gKyNwcmFnbWEgR0NDIGRp YWdub3N0aWMgaWdub3JlZCAiLVdzdWdnZXN0LWF0dHJpYnV0ZT1mb3JtYXQiCj4gKyNlbmRpZgoK Q2FuIHRoaXMgYmUgc29tZSBtYWNybyBiYW5pc2hlZCB0byBjb21waWxlci5oPwoKPiArCj4gIHN0 YXRpYyBzdHJ1Y3QgY2xrX2xvb2t1cCAqIF9fcmVmCj4gIHZjbGtkZXZfYWxsb2Moc3RydWN0IGNs a19odyAqaHcsIGNvbnN0IGNoYXIgKmNvbl9pZCwgY29uc3QgY2hhciAqZGV2X2ZtdCwKPiAgICAg ICAgIHZhX2xpc3QgYXApCj4gQEAgLTE3Nyw2ICsxODIsOCBAQCB2Y2xrZGV2X2FsbG9jKHN0cnVj dCBjbGtfaHcgKmh3LCBjb25zdCBjaGFyICpjb25faWQsIGNvbnN0IGNoYXIgKmRldl9mbXQsCj4g ICAgICAgICByZXR1cm4gJmNsYS0+Y2w7Cj4gIH0KPiAgCj4gKyNwcmFnbWEgR0NDIGRpYWdub3N0 aWMgcG9wCj4gKwo+ICBzdGF0aWMgc3RydWN0IGNsa19sb29rdXAgKgo+ICB2Y2xrZGV2X2NyZWF0 ZShzdHJ1Y3QgY2xrX2h3ICpodywgY29uc3QgY2hhciAqY29uX2lkLCBjb25zdCBjaGFyICpkZXZf Zm10LAo+ICAgICAgICAgdmFfbGlzdCBhcCkKPiAtLSAKPiAyLjI1LjEKPgoKX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KbGludXgtYXJtLWtlcm5lbCBtYWls aW5nIGxpc3QKbGludXgtYXJtLWtlcm5lbEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0 cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtYXJtLWtlcm5lbAo=