All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH net 0/2] bnxt_en: 2 bug fixes.
@ 2021-02-11  7:24 Michael Chan
  2021-02-11  7:24 ` [PATCH net 1/2] bnxt_en: reverse order of TX disable and carrier off Michael Chan
                   ` (2 more replies)
  0 siblings, 3 replies; 18+ messages in thread
From: Michael Chan @ 2021-02-11  7:24 UTC (permalink / raw)
  To: davem; +Cc: netdev, kuba, gospo

Two unrelated fixes.  The first one fixes intermittent false TX timeouts
during ring reconfigurations.  The second one fixes a formatting
discrepancy between the stored and the running FW versions.

Please also queue these for -stable.  Thanks.

Edwin Peer (1):
  bnxt_en: reverse order of TX disable and carrier off

Vasundhara Volam (1):
  bnxt_en: Fix devlink info's stored fw.psid version format.

 drivers/net/ethernet/broadcom/bnxt/bnxt.c         | 3 ++-
 drivers/net/ethernet/broadcom/bnxt/bnxt_devlink.c | 4 ++--
 2 files changed, 4 insertions(+), 3 deletions(-)

-- 
2.18.1


^ permalink raw reply	[flat|nested] 18+ messages in thread

* [PATCH net 1/2] bnxt_en: reverse order of TX disable and carrier off
  2021-02-11  7:24 [PATCH net 0/2] bnxt_en: 2 bug fixes Michael Chan
@ 2021-02-11  7:24 ` Michael Chan
  2021-02-11  7:24 ` [PATCH net 2/2] bnxt_en: Fix devlink info's stored fw.psid version format Michael Chan
  2021-02-11 22:50 ` [PATCH net 0/2] bnxt_en: 2 bug fixes patchwork-bot+netdevbpf
  2 siblings, 0 replies; 18+ messages in thread
From: Michael Chan @ 2021-02-11  7:24 UTC (permalink / raw)
  To: davem; +Cc: netdev, kuba, gospo

From: Edwin Peer <edwin.peer@broadcom.com>

A TX queue can potentially immediately timeout after it is stopped
and the last TX timestamp on that queue was more than 5 seconds ago with
carrier still up.  Prevent these intermittent false TX timeouts
by bringing down carrier first before calling netif_tx_disable().

Fixes: c0c050c58d84 ("bnxt_en: New Broadcom ethernet driver.")
Signed-off-by: Edwin Peer <edwin.peer@broadcom.com>
Signed-off-by: Michael Chan <michael.chan@broadcom.com>
---
 drivers/net/ethernet/broadcom/bnxt/bnxt.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt.c b/drivers/net/ethernet/broadcom/bnxt/bnxt.c
index d10e4f85dd11..1c96b7ba24f2 100644
--- a/drivers/net/ethernet/broadcom/bnxt/bnxt.c
+++ b/drivers/net/ethernet/broadcom/bnxt/bnxt.c
@@ -8856,9 +8856,10 @@ void bnxt_tx_disable(struct bnxt *bp)
 			txr->dev_state = BNXT_DEV_STATE_CLOSING;
 		}
 	}
+	/* Drop carrier first to prevent TX timeout */
+	netif_carrier_off(bp->dev);
 	/* Stop all TX queues */
 	netif_tx_disable(bp->dev);
-	netif_carrier_off(bp->dev);
 }
 
 void bnxt_tx_enable(struct bnxt *bp)
-- 
2.18.1


^ permalink raw reply related	[flat|nested] 18+ messages in thread

* [PATCH net 2/2] bnxt_en: Fix devlink info's stored fw.psid version format.
  2021-02-11  7:24 [PATCH net 0/2] bnxt_en: 2 bug fixes Michael Chan
  2021-02-11  7:24 ` [PATCH net 1/2] bnxt_en: reverse order of TX disable and carrier off Michael Chan
@ 2021-02-11  7:24 ` Michael Chan
  2021-02-11 22:50 ` [PATCH net 0/2] bnxt_en: 2 bug fixes patchwork-bot+netdevbpf
  2 siblings, 0 replies; 18+ messages in thread
From: Michael Chan @ 2021-02-11  7:24 UTC (permalink / raw)
  To: davem; +Cc: netdev, kuba, gospo

From: Vasundhara Volam <vasundhara-v.volam@broadcom.com>

The running fw.psid version is in decimal format but the stored
fw.psid is in hex format.  This can mislead the user to reset the
NIC to activate the stored version to become the running version.

Fix it to display the stored fw.psid in decimal format.

Fixes: 1388875b3916 ("bnxt_en: Add stored FW version info to devlink info_get cb.")
Signed-off-by: Vasundhara Volam <vasundhara-v.volam@broadcom.com>
Signed-off-by: Michael Chan <michael.chan@broadcom.com>
---
 drivers/net/ethernet/broadcom/bnxt/bnxt_devlink.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt_devlink.c b/drivers/net/ethernet/broadcom/bnxt/bnxt_devlink.c
index 6b7b69ed62db..a9bcf887d2fb 100644
--- a/drivers/net/ethernet/broadcom/bnxt/bnxt_devlink.c
+++ b/drivers/net/ethernet/broadcom/bnxt/bnxt_devlink.c
@@ -472,8 +472,8 @@ static int bnxt_dl_info_get(struct devlink *dl, struct devlink_info_req *req,
 	if (BNXT_PF(bp) && !bnxt_hwrm_get_nvm_cfg_ver(bp, &nvm_cfg_ver)) {
 		u32 ver = nvm_cfg_ver.vu32;
 
-		sprintf(buf, "%X.%X.%X", (ver >> 16) & 0xF, (ver >> 8) & 0xF,
-			ver & 0xF);
+		sprintf(buf, "%d.%d.%d", (ver >> 16) & 0xf, (ver >> 8) & 0xf,
+			ver & 0xf);
 		rc = bnxt_dl_info_put(bp, req, BNXT_VERSION_STORED,
 				      DEVLINK_INFO_VERSION_GENERIC_FW_PSID,
 				      buf);
-- 
2.18.1


^ permalink raw reply related	[flat|nested] 18+ messages in thread

* Re: [PATCH net 0/2] bnxt_en: 2 bug fixes.
  2021-02-11  7:24 [PATCH net 0/2] bnxt_en: 2 bug fixes Michael Chan
  2021-02-11  7:24 ` [PATCH net 1/2] bnxt_en: reverse order of TX disable and carrier off Michael Chan
  2021-02-11  7:24 ` [PATCH net 2/2] bnxt_en: Fix devlink info's stored fw.psid version format Michael Chan
@ 2021-02-11 22:50 ` patchwork-bot+netdevbpf
  2 siblings, 0 replies; 18+ messages in thread
From: patchwork-bot+netdevbpf @ 2021-02-11 22:50 UTC (permalink / raw)
  To: Michael Chan; +Cc: davem, netdev, kuba, gospo

Hello:

This series was applied to netdev/net.git (refs/heads/master):

On Thu, 11 Feb 2021 02:24:22 -0500 you wrote:
> Two unrelated fixes.  The first one fixes intermittent false TX timeouts
> during ring reconfigurations.  The second one fixes a formatting
> discrepancy between the stored and the running FW versions.
> 
> Please also queue these for -stable.  Thanks.
> 
> Edwin Peer (1):
>   bnxt_en: reverse order of TX disable and carrier off
> 
> [...]

Here is the summary with links:
  - [net,1/2] bnxt_en: reverse order of TX disable and carrier off
    https://git.kernel.org/netdev/net/c/132e0b65dc2b
  - [net,2/2] bnxt_en: Fix devlink info's stored fw.psid version format.
    https://git.kernel.org/netdev/net/c/db28b6c77f40

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html



^ permalink raw reply	[flat|nested] 18+ messages in thread

* Re: [PATCH net 0/2] bnxt_en: 2 bug fixes
  2023-03-04  2:43 Michael Chan
@ 2023-03-06 21:30 ` patchwork-bot+netdevbpf
  0 siblings, 0 replies; 18+ messages in thread
From: patchwork-bot+netdevbpf @ 2023-03-06 21:30 UTC (permalink / raw)
  To: Michael Chan; +Cc: davem, netdev, kuba, edumazet, pabeni, gospo

Hello:

This series was applied to netdev/net.git (main)
by David S. Miller <davem@davemloft.net>:

On Fri,  3 Mar 2023 18:43:56 -0800 you wrote:
> This series fixes 2 issues:
> 
> 1. A potential order-5 memory allocation failure during open.
> 2. Double memory free bug during shutdown.
> 
> Michael Chan (1):
>   bnxt_en: Avoid order-5 memory allocation for TPA data
> 
> [...]

Here is the summary with links:
  - [net,1/2] bnxt_en: Avoid order-5 memory allocation for TPA data
    https://git.kernel.org/netdev/net/c/accd7e23693a
  - [net,2/2] bnxt_en: Fix the double free during device removal
    https://git.kernel.org/netdev/net/c/89b59a84cb16

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html



^ permalink raw reply	[flat|nested] 18+ messages in thread

* [PATCH net 0/2] bnxt_en: 2 bug fixes
@ 2023-03-04  2:43 Michael Chan
  2023-03-06 21:30 ` patchwork-bot+netdevbpf
  0 siblings, 1 reply; 18+ messages in thread
From: Michael Chan @ 2023-03-04  2:43 UTC (permalink / raw)
  To: davem; +Cc: netdev, kuba, edumazet, pabeni, gospo

[-- Attachment #1: Type: text/plain, Size: 475 bytes --]

This series fixes 2 issues:

1. A potential order-5 memory allocation failure during open.
2. Double memory free bug during shutdown.

Michael Chan (1):
  bnxt_en: Avoid order-5 memory allocation for TPA data

Selvin Xavier (1):
  bnxt_en: Fix the double free during device removal

 drivers/net/ethernet/broadcom/bnxt/bnxt.c     | 25 +++++++++----------
 drivers/net/ethernet/broadcom/bnxt/bnxt_ulp.c |  2 ++
 2 files changed, 14 insertions(+), 13 deletions(-)

-- 
2.32.0


[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4209 bytes --]

^ permalink raw reply	[flat|nested] 18+ messages in thread

* Re: [PATCH net 0/2] bnxt_en: 2 bug fixes
  2021-08-15 20:15 Michael Chan
@ 2021-08-16 10:40 ` patchwork-bot+netdevbpf
  0 siblings, 0 replies; 18+ messages in thread
From: patchwork-bot+netdevbpf @ 2021-08-16 10:40 UTC (permalink / raw)
  To: Michael Chan; +Cc: davem, netdev, kuba, gospo

Hello:

This series was applied to netdev/net.git (refs/heads/master):

On Sun, 15 Aug 2021 16:15:35 -0400 you wrote:
> The first one disables aRFS/NTUPLE on an older broken firmware version.
> The second one adds missing memory barriers related to completion ring
> handling.
> 
> Michael Chan (2):
>   bnxt_en: Disable aRFS if running on 212 firmware
>   bnxt_en: Add missing DMA memory barriers
> 
> [...]

Here is the summary with links:
  - [net,1/2] bnxt_en: Disable aRFS if running on 212 firmware
    https://git.kernel.org/netdev/net/c/976e52b718c3
  - [net,2/2] bnxt_en: Add missing DMA memory barriers
    https://git.kernel.org/netdev/net/c/828affc27ed4

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html



^ permalink raw reply	[flat|nested] 18+ messages in thread

* [PATCH net 0/2] bnxt_en: 2 bug fixes
@ 2021-08-15 20:15 Michael Chan
  2021-08-16 10:40 ` patchwork-bot+netdevbpf
  0 siblings, 1 reply; 18+ messages in thread
From: Michael Chan @ 2021-08-15 20:15 UTC (permalink / raw)
  To: davem; +Cc: netdev, kuba, gospo

[-- Attachment #1: Type: text/plain, Size: 378 bytes --]

The first one disables aRFS/NTUPLE on an older broken firmware version.
The second one adds missing memory barriers related to completion ring
handling.

Michael Chan (2):
  bnxt_en: Disable aRFS if running on 212 firmware
  bnxt_en: Add missing DMA memory barriers

 drivers/net/ethernet/broadcom/bnxt/bnxt.c | 15 +++++++++++++++
 1 file changed, 15 insertions(+)

-- 
2.18.1


[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4209 bytes --]

^ permalink raw reply	[flat|nested] 18+ messages in thread

* Re: [PATCH net 0/2] bnxt_en: 2 bug fixes.
  2021-05-15  7:25 Michael Chan
@ 2021-05-17 21:10 ` patchwork-bot+netdevbpf
  0 siblings, 0 replies; 18+ messages in thread
From: patchwork-bot+netdevbpf @ 2021-05-17 21:10 UTC (permalink / raw)
  To: Michael Chan; +Cc: davem, netdev, kuba, gospo

Hello:

This series was applied to netdev/net.git (refs/heads/master):

On Sat, 15 May 2021 03:25:17 -0400 you wrote:
> The first one fixes a bug to properly identify some recently added HyperV
> device IDs.  The second one fixes device context memory set up on systems
> with 64K page size.
> 
> Please queue these for -stable as well.  Thanks.
> 
> Andy Gospodarek (1):
>   bnxt_en: Include new P5 HV definition in VF check.
> 
> [...]

Here is the summary with links:
  - [net,1/2] bnxt_en: Include new P5 HV definition in VF check.
    https://git.kernel.org/netdev/net/c/ab21494be9dc
  - [net,2/2] bnxt_en: Fix context memory setup for 64K page size.
    https://git.kernel.org/netdev/net/c/702279d2ce46

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html



^ permalink raw reply	[flat|nested] 18+ messages in thread

* [PATCH net 0/2] bnxt_en: 2 bug fixes.
@ 2021-05-15  7:25 Michael Chan
  2021-05-17 21:10 ` patchwork-bot+netdevbpf
  0 siblings, 1 reply; 18+ messages in thread
From: Michael Chan @ 2021-05-15  7:25 UTC (permalink / raw)
  To: davem; +Cc: netdev, kuba, gospo

The first one fixes a bug to properly identify some recently added HyperV
device IDs.  The second one fixes device context memory set up on systems
with 64K page size.

Please queue these for -stable as well.  Thanks.

Andy Gospodarek (1):
  bnxt_en: Include new P5 HV definition in VF check.

Michael Chan (1):
  bnxt_en: Fix context memory setup for 64K page size.

 drivers/net/ethernet/broadcom/bnxt/bnxt.c | 12 +++---------
 drivers/net/ethernet/broadcom/bnxt/bnxt.h | 10 ++++++++++
 2 files changed, 13 insertions(+), 9 deletions(-)

-- 
2.18.1


^ permalink raw reply	[flat|nested] 18+ messages in thread

* Re: [PATCH net 0/2] bnxt_en: 2 bug fixes.
  2020-03-02  3:07 Michael Chan
@ 2020-03-02  3:17 ` David Miller
  0 siblings, 0 replies; 18+ messages in thread
From: David Miller @ 2020-03-02  3:17 UTC (permalink / raw)
  To: michael.chan; +Cc: netdev

From: Michael Chan <michael.chan@broadcom.com>
Date: Sun,  1 Mar 2020 22:07:16 -0500

> This first patch fixes a rare but possible crash in pci_disable_msix()
> when the MTU is changed.  The 2nd patch fixes a regression in error
> code handling when flashing a file to NVRAM.

Applied.

> Please also queue these for -stable.  Thanks.

Queued up, thanks Michael.

^ permalink raw reply	[flat|nested] 18+ messages in thread

* [PATCH net 0/2] bnxt_en: 2 bug fixes.
@ 2020-03-02  3:07 Michael Chan
  2020-03-02  3:17 ` David Miller
  0 siblings, 1 reply; 18+ messages in thread
From: Michael Chan @ 2020-03-02  3:07 UTC (permalink / raw)
  To: davem; +Cc: netdev

This first patch fixes a rare but possible crash in pci_disable_msix()
when the MTU is changed.  The 2nd patch fixes a regression in error
code handling when flashing a file to NVRAM.

Please also queue these for -stable.  Thanks.

Edwin Peer (1):
  bnxt_en: fix error handling when flashing from file

Vasundhara Volam (1):
  bnxt_en: reinitialize IRQs when MTU is modified

 drivers/net/ethernet/broadcom/bnxt/bnxt.c         |  4 ++--
 drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c | 24 +++++++++++------------
 2 files changed, 13 insertions(+), 15 deletions(-)

-- 
2.5.1


^ permalink raw reply	[flat|nested] 18+ messages in thread

* Re: [PATCH net 0/2] bnxt_en: 2 bug fixes.
  2019-04-08 21:39 Michael Chan
@ 2019-04-08 23:39 ` David Miller
  0 siblings, 0 replies; 18+ messages in thread
From: David Miller @ 2019-04-08 23:39 UTC (permalink / raw)
  To: michael.chan; +Cc: netdev

From: Michael Chan <michael.chan@broadcom.com>
Date: Mon,  8 Apr 2019 17:39:53 -0400

> The first patch prevents possible driver crash if we get a bad RX index
> from the hardware.  The second patch resets the device when the hardware
> reports buffer error to recover from the error.
> 
> Please queue these for -stable also.  Thanks.

Series applied and queued up for -stable, thanks.

^ permalink raw reply	[flat|nested] 18+ messages in thread

* [PATCH net 0/2] bnxt_en: 2 bug fixes.
@ 2019-04-08 21:39 Michael Chan
  2019-04-08 23:39 ` David Miller
  0 siblings, 1 reply; 18+ messages in thread
From: Michael Chan @ 2019-04-08 21:39 UTC (permalink / raw)
  To: davem; +Cc: netdev

The first patch prevents possible driver crash if we get a bad RX index
from the hardware.  The second patch resets the device when the hardware
reports buffer error to recover from the error.

Please queue these for -stable also.  Thanks.

Michael Chan (2):
  bnxt_en: Improve RX consumer index validity check.
  bnxt_en: Reset device on RX buffer errors.

 drivers/net/ethernet/broadcom/bnxt/bnxt.c | 16 +++++++++++++---
 1 file changed, 13 insertions(+), 3 deletions(-)

-- 
2.5.1


^ permalink raw reply	[flat|nested] 18+ messages in thread

* Re: [PATCH net 0/2] bnxt_en: 2 bug fixes.
  2016-11-11  5:11 Michael Chan
@ 2016-11-13 17:37 ` David Miller
  0 siblings, 0 replies; 18+ messages in thread
From: David Miller @ 2016-11-13 17:37 UTC (permalink / raw)
  To: michael.chan; +Cc: netdev

From: Michael Chan <michael.chan@broadcom.com>
Date: Fri, 11 Nov 2016 00:11:41 -0500

> Bug fixes in bnxt_setup_tc() and VF vitual link state.

Series applied, thanks Michael.

^ permalink raw reply	[flat|nested] 18+ messages in thread

* [PATCH net 0/2] bnxt_en: 2 bug fixes.
@ 2016-11-11  5:11 Michael Chan
  2016-11-13 17:37 ` David Miller
  0 siblings, 1 reply; 18+ messages in thread
From: Michael Chan @ 2016-11-11  5:11 UTC (permalink / raw)
  To: davem; +Cc: netdev

Bug fixes in bnxt_setup_tc() and VF vitual link state.

Michael Chan (2):
  bnxt_en: Fix ring arithmetic in bnxt_setup_tc().
  bnxt_en: Fix VF virtual link state.

 drivers/net/ethernet/broadcom/bnxt/bnxt.c       | 11 ++++++-----
 drivers/net/ethernet/broadcom/bnxt/bnxt_sriov.c |  4 ++--
 2 files changed, 8 insertions(+), 7 deletions(-)

-- 
1.8.3.1

^ permalink raw reply	[flat|nested] 18+ messages in thread

* Re: [PATCH net 0/2] bnxt_en: 2 bug fixes.
  2016-05-04 20:56 Michael Chan
@ 2016-05-04 21:12 ` David Miller
  0 siblings, 0 replies; 18+ messages in thread
From: David Miller @ 2016-05-04 21:12 UTC (permalink / raw)
  To: michael.chan; +Cc: netdev

From: Michael Chan <michael.chan@broadcom.com>
Date: Wed,  4 May 2016 16:56:42 -0400

> Fix crash on ppc64 due to missing memory barrier and restore multicast
> after reset.

Looks good, series applied, thanks.

^ permalink raw reply	[flat|nested] 18+ messages in thread

* [PATCH net 0/2] bnxt_en: 2 bug fixes.
@ 2016-05-04 20:56 Michael Chan
  2016-05-04 21:12 ` David Miller
  0 siblings, 1 reply; 18+ messages in thread
From: Michael Chan @ 2016-05-04 20:56 UTC (permalink / raw)
  To: davem; +Cc: netdev

Fix crash on ppc64 due to missing memory barrier and restore multicast
after reset.

Michael Chan (2):
  bnxt_en: Need memory barrier when processing the completion ring.
  bnxt_en: Setup multicast properly after resetting device.

 drivers/net/ethernet/broadcom/bnxt/bnxt.c | 23 +++++++++++++++++++----
 1 file changed, 19 insertions(+), 4 deletions(-)

-- 
1.8.3.1

^ permalink raw reply	[flat|nested] 18+ messages in thread

end of thread, other threads:[~2023-03-06 21:31 UTC | newest]

Thread overview: 18+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-02-11  7:24 [PATCH net 0/2] bnxt_en: 2 bug fixes Michael Chan
2021-02-11  7:24 ` [PATCH net 1/2] bnxt_en: reverse order of TX disable and carrier off Michael Chan
2021-02-11  7:24 ` [PATCH net 2/2] bnxt_en: Fix devlink info's stored fw.psid version format Michael Chan
2021-02-11 22:50 ` [PATCH net 0/2] bnxt_en: 2 bug fixes patchwork-bot+netdevbpf
  -- strict thread matches above, loose matches on Subject: below --
2023-03-04  2:43 Michael Chan
2023-03-06 21:30 ` patchwork-bot+netdevbpf
2021-08-15 20:15 Michael Chan
2021-08-16 10:40 ` patchwork-bot+netdevbpf
2021-05-15  7:25 Michael Chan
2021-05-17 21:10 ` patchwork-bot+netdevbpf
2020-03-02  3:07 Michael Chan
2020-03-02  3:17 ` David Miller
2019-04-08 21:39 Michael Chan
2019-04-08 23:39 ` David Miller
2016-11-11  5:11 Michael Chan
2016-11-13 17:37 ` David Miller
2016-05-04 20:56 Michael Chan
2016-05-04 21:12 ` David Miller

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.