From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 68C60C433E9 for ; Fri, 12 Feb 2021 22:06:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3D96D64DE0 for ; Fri, 12 Feb 2021 22:06:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230053AbhBLWG2 (ORCPT ); Fri, 12 Feb 2021 17:06:28 -0500 Received: from mail.kernel.org ([198.145.29.99]:41398 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229497AbhBLWG1 (ORCPT ); Fri, 12 Feb 2021 17:06:27 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id 0132264DE0; Fri, 12 Feb 2021 22:05:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1613167547; bh=x7+O4dfMkemD6U+vgZkpKlnW63NDjJ8hkv36eJK9x4o=; h=In-Reply-To:References:Subject:From:Cc:To:Date:From; b=utCEACe2van290abpiVInryUj9yVn2FwsXMbagw9hbUab72VorrpgY32/Amx4utiN j7Mc9urIjizH+MO0kEXOEdRlO76JE8KDEfkf4VWZwpa5zwrsAHPR56JbVeQtLZm12M bt5NlZBF9WzNhSn0NR7WBJh7jZ+hZ/mTGX3E9sSXjoSfOubGx2bNNkcKvhIvonnWu6 JniU8yhese97VZl+fQvPXwdJS917BMwsjIXpAOMxS4tvp7ZmpIAVtFA5fW1n1VvGsu HrqDR1yu8d1pn1hjR0JDtDenwDYyBO+cHSWBDZDx/N3OrSRsy+traSF5EdAtnY+kyN qSNMsCRFENbmg== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable In-Reply-To: <20210212212630.GD179940@dell> References: <20210126124540.3320214-1-lee.jones@linaro.org> <161307643148.1254594.6590013599999468609@swboyd.mtv.corp.google.com> <20210211211054.GD4572@dell> <161309925025.1254594.6210738031889810500@swboyd.mtv.corp.google.com> <20210212092016.GF4572@dell> <161316374113.1254594.14156657225822268891@swboyd.mtv.corp.google.com> <20210212212503.GC179940@dell> <20210212212630.GD179940@dell> Subject: Re: [PATCH 00/21] [Set 2] Rid W=1 warnings from Clock From: Stephen Boyd Cc: linux-kernel@vger.kernel.org, Ahmad Fatoum , Andy Gross , Avi Fishman , Benjamin Fair , Bjorn Andersson , Boris BREZILLON , Chen-Yu Tsai , Emilio =?utf-8?q?L=C3=B3pez?= , Fabio Estevam , Geert Uytterhoeven , Jan Kotas , Jernej Skrabec , Jonathan Hunter , linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, linux-omap@vger.kernel.org, linux-renesas-soc@vger.kernel.org, linux-tegra@vger.kernel.org, Loc Ho , Maxime Ripard , Michael Turquette , Michal Simek , Nancy Yuen , Nuvoton Technologies , NXP Linux Team , openbmc@lists.ozlabs.org, Patrick Venture , Pengutronix Kernel Team , Peter De Schrijver , Philipp Zabel , Prashant Gaikwad , Rajan Vaja , Rajeev Kumar , Richard Woodruff , Russell King , Sascha Hauer , Shawn Guo , Shiraz Hashim , =?utf-8?q?S=C3=B6ren?= Brinkmann , Tali Perry , Tero Kristo , Thierry Reding , Tomer Maimon , Viresh Kumar To: Lee Jones Date: Fri, 12 Feb 2021 14:05:45 -0800 Message-ID: <161316754567.1254594.9542583200097699504@swboyd.mtv.corp.google.com> User-Agent: alot/0.9.1 Precedence: bulk List-ID: X-Mailing-List: linux-tegra@vger.kernel.org Quoting Lee Jones (2021-02-12 13:26:30) > On Fri, 12 Feb 2021, Lee Jones wrote: >=20 > > The alternative is to not worry about it and review the slow drip of > > fixes that will occur as a result. The issues I just fixed were built > > up over years. They won't get to that level again. > >=20 > > In my mind contributors should be compiling their submissions with W=3D1 > > enabled by default. I'm fairly sure the auto-builders do this now. That's good. > >=20 > > Once W=3D1 warnings are down to an acceptable level in the kernel as a > > whole, we can provide some guidance in SubmittingPatches (or similar) > > on how to enable them (hint: you add "W=3D1" on the compile line). > >=20 > > Enabling W=3D1 in the default build will only serve to annoy Linus IMHO. > > If he wants them to be enabled by default, they wouldn't be W=3D1 in the > > first place, they'd be W=3D0 which *is* the default build. >=20 > Just to add real quick - my advice is to enable them for yourself and > send back any issues along with your normal review. A W=3D1 issue is no > different to a semantic or coding style one. >=20 I'd like to enable it for only files under drivers/clk/ but it doesn't seem to work. I'm not asking to enable it at the toplevel Makefile. I'm asking to enable it for drivers/clk/ so nobody has to think about it now that you've done the hard work of getting the numbers in this directory down to zero or close to zero. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C40DCC433DB for ; Sun, 14 Feb 2021 23:27:32 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 56CB264DDA for ; Sun, 14 Feb 2021 23:27:32 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 56CB264DDA Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=openbmc-bounces+openbmc=archiver.kernel.org@lists.ozlabs.org Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4Df3LC0Xzgz3ckx for ; Mon, 15 Feb 2021 10:27:31 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=utCEACe2; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=kernel.org (client-ip=198.145.29.99; helo=mail.kernel.org; envelope-from=sboyd@kernel.org; receiver=) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=utCEACe2; dkim-atps=neutral Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4Dcnct2zs9zDrQG for ; Sat, 13 Feb 2021 09:05:50 +1100 (AEDT) Received: by mail.kernel.org (Postfix) with ESMTPSA id 0132264DE0; Fri, 12 Feb 2021 22:05:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1613167547; bh=x7+O4dfMkemD6U+vgZkpKlnW63NDjJ8hkv36eJK9x4o=; h=In-Reply-To:References:Subject:From:Cc:To:Date:From; b=utCEACe2van290abpiVInryUj9yVn2FwsXMbagw9hbUab72VorrpgY32/Amx4utiN j7Mc9urIjizH+MO0kEXOEdRlO76JE8KDEfkf4VWZwpa5zwrsAHPR56JbVeQtLZm12M bt5NlZBF9WzNhSn0NR7WBJh7jZ+hZ/mTGX3E9sSXjoSfOubGx2bNNkcKvhIvonnWu6 JniU8yhese97VZl+fQvPXwdJS917BMwsjIXpAOMxS4tvp7ZmpIAVtFA5fW1n1VvGsu HrqDR1yu8d1pn1hjR0JDtDenwDYyBO+cHSWBDZDx/N3OrSRsy+traSF5EdAtnY+kyN qSNMsCRFENbmg== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable In-Reply-To: <20210212212630.GD179940@dell> References: <20210126124540.3320214-1-lee.jones@linaro.org> <161307643148.1254594.6590013599999468609@swboyd.mtv.corp.google.com> <20210211211054.GD4572@dell> <161309925025.1254594.6210738031889810500@swboyd.mtv.corp.google.com> <20210212092016.GF4572@dell> <161316374113.1254594.14156657225822268891@swboyd.mtv.corp.google.com> <20210212212503.GC179940@dell> <20210212212630.GD179940@dell> Subject: Re: [PATCH 00/21] [Set 2] Rid W=1 warnings from Clock From: Stephen Boyd To: Lee Jones Date: Fri, 12 Feb 2021 14:05:45 -0800 Message-ID: <161316754567.1254594.9542583200097699504@swboyd.mtv.corp.google.com> User-Agent: alot/0.9.1 X-Mailman-Approved-At: Mon, 15 Feb 2021 10:22:39 +1100 X-BeenThere: openbmc@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development list for OpenBMC List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Prashant Gaikwad , Tomer Maimon , Geert Uytterhoeven , Michael Turquette , Bjorn Andersson , Rajeev Kumar , Jan Kotas , Russell King , Fabio Estevam , linux-clk@vger.kernel.org, Boris BREZILLON , Ahmad Fatoum , Benjamin Fair , Emilio =?utf-8?q?L=C3=B3pez?= , Viresh Kumar , openbmc@lists.ozlabs.org, Michal Simek , Jonathan Hunter , Chen-Yu Tsai , Andy Gross , Loc Ho , NXP Linux Team , Richard Woodruff , Tali Perry , Philipp Zabel , linux-arm-msm@vger.kernel.org, Sascha Hauer , Maxime Ripard , linux-tegra@vger.kernel.org, linux-omap@vger.kernel.org, Shiraz Hashim , linux-arm-kernel@lists.infradead.org, =?utf-8?q?S=C3=B6ren?= Brinkmann , Jernej Skrabec , Tero Kristo , Rajan Vaja , Avi Fishman , Patrick Venture , Peter De Schrijver , linux-kernel@vger.kernel.org, linux-renesas-soc@vger.kernel.org, Nuvoton Technologies , Thierry Reding , Pengutronix Kernel Team , Shawn Guo Errors-To: openbmc-bounces+openbmc=archiver.kernel.org@lists.ozlabs.org Sender: "openbmc" Quoting Lee Jones (2021-02-12 13:26:30) > On Fri, 12 Feb 2021, Lee Jones wrote: >=20 > > The alternative is to not worry about it and review the slow drip of > > fixes that will occur as a result. The issues I just fixed were built > > up over years. They won't get to that level again. > >=20 > > In my mind contributors should be compiling their submissions with W=3D1 > > enabled by default. I'm fairly sure the auto-builders do this now. That's good. > >=20 > > Once W=3D1 warnings are down to an acceptable level in the kernel as a > > whole, we can provide some guidance in SubmittingPatches (or similar) > > on how to enable them (hint: you add "W=3D1" on the compile line). > >=20 > > Enabling W=3D1 in the default build will only serve to annoy Linus IMHO. > > If he wants them to be enabled by default, they wouldn't be W=3D1 in the > > first place, they'd be W=3D0 which *is* the default build. >=20 > Just to add real quick - my advice is to enable them for yourself and > send back any issues along with your normal review. A W=3D1 issue is no > different to a semantic or coding style one. >=20 I'd like to enable it for only files under drivers/clk/ but it doesn't seem to work. I'm not asking to enable it at the toplevel Makefile. I'm asking to enable it for drivers/clk/ so nobody has to think about it now that you've done the hard work of getting the numbers in this directory down to zero or close to zero. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 80844C433DB for ; Fri, 12 Feb 2021 22:07:11 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3EF6564E8D for ; Fri, 12 Feb 2021 22:07:11 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3EF6564E8D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Message-ID:Date:To:From:Subject:References: In-Reply-To:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=O3oMj43OdMvf2y5+Orna5JN/v2ybXHT/8fQt53FYptA=; b=SF0Ts0v1xDAT+WBS/1Wl9vidv cSwyzf9EmdZkT79SqLkSjEm+/DpzQ1nMemN1YUmd6DK7TvotAeqhTiwLc0iILn3djzqTzhivK6tFq RF4nuydLuClMIRBwV3nDmv6/yicKxkQN0ACzltge411dPL7WLmhN8FYQ1iU9FTYagIdOojuPk91qj ef3JLA7laZX2yMnIP8T3UwFuopgLw8s2ornHwVxLVwJfl0Mw6oWMWRJmtmZ6E1LgmM/VD4rp4H0q5 vhC6Uc1w+0GHWDGqwP2p/LtDr84ltn/IJVNMmuqpQJFLAqkTzpbc1VDkNqOHUjtlzAvQCKvH3Ma4v XmzgVTdHg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1lAgZS-0007Ez-Tg; Fri, 12 Feb 2021 22:05:50 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1lAgZQ-0007Ee-26 for linux-arm-kernel@lists.infradead.org; Fri, 12 Feb 2021 22:05:48 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id 0132264DE0; Fri, 12 Feb 2021 22:05:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1613167547; bh=x7+O4dfMkemD6U+vgZkpKlnW63NDjJ8hkv36eJK9x4o=; h=In-Reply-To:References:Subject:From:Cc:To:Date:From; b=utCEACe2van290abpiVInryUj9yVn2FwsXMbagw9hbUab72VorrpgY32/Amx4utiN j7Mc9urIjizH+MO0kEXOEdRlO76JE8KDEfkf4VWZwpa5zwrsAHPR56JbVeQtLZm12M bt5NlZBF9WzNhSn0NR7WBJh7jZ+hZ/mTGX3E9sSXjoSfOubGx2bNNkcKvhIvonnWu6 JniU8yhese97VZl+fQvPXwdJS917BMwsjIXpAOMxS4tvp7ZmpIAVtFA5fW1n1VvGsu HrqDR1yu8d1pn1hjR0JDtDenwDYyBO+cHSWBDZDx/N3OrSRsy+traSF5EdAtnY+kyN qSNMsCRFENbmg== MIME-Version: 1.0 In-Reply-To: <20210212212630.GD179940@dell> References: <20210126124540.3320214-1-lee.jones@linaro.org> <161307643148.1254594.6590013599999468609@swboyd.mtv.corp.google.com> <20210211211054.GD4572@dell> <161309925025.1254594.6210738031889810500@swboyd.mtv.corp.google.com> <20210212092016.GF4572@dell> <161316374113.1254594.14156657225822268891@swboyd.mtv.corp.google.com> <20210212212503.GC179940@dell> <20210212212630.GD179940@dell> Subject: Re: [PATCH 00/21] [Set 2] Rid W=1 warnings from Clock From: Stephen Boyd To: Lee Jones Date: Fri, 12 Feb 2021 14:05:45 -0800 Message-ID: <161316754567.1254594.9542583200097699504@swboyd.mtv.corp.google.com> User-Agent: alot/0.9.1 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210212_170548_257048_081AFA1F X-CRM114-Status: GOOD ( 17.10 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Prashant Gaikwad , Tomer Maimon , Geert Uytterhoeven , Michael Turquette , Bjorn Andersson , Rajeev Kumar , Jan Kotas , Russell King , Fabio Estevam , linux-clk@vger.kernel.org, Boris BREZILLON , Ahmad Fatoum , Benjamin Fair , Emilio =?utf-8?q?L=C3=B3pez?= , Viresh Kumar , openbmc@lists.ozlabs.org, Michal Simek , Jonathan Hunter , Nancy Yuen , Chen-Yu Tsai , Andy Gross , Loc Ho , NXP Linux Team , Richard Woodruff , Tali Perry , Philipp Zabel , linux-arm-msm@vger.kernel.org, Sascha Hauer , Maxime Ripard , linux-tegra@vger.kernel.org, linux-omap@vger.kernel.org, Shiraz Hashim , linux-arm-kernel@lists.infradead.org, =?utf-8?q?S=C3=B6ren?= Brinkmann , Jernej Skrabec , Tero Kristo , Rajan Vaja , Avi Fishman , Patrick Venture , Peter De Schrijver , linux-kernel@vger.kernel.org, linux-renesas-soc@vger.kernel.org, Nuvoton Technologies , Thierry Reding , Pengutronix Kernel Team , Shawn Guo Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Quoting Lee Jones (2021-02-12 13:26:30) > On Fri, 12 Feb 2021, Lee Jones wrote: > > > The alternative is to not worry about it and review the slow drip of > > fixes that will occur as a result. The issues I just fixed were built > > up over years. They won't get to that level again. > > > > In my mind contributors should be compiling their submissions with W=1 > > enabled by default. I'm fairly sure the auto-builders do this now. That's good. > > > > Once W=1 warnings are down to an acceptable level in the kernel as a > > whole, we can provide some guidance in SubmittingPatches (or similar) > > on how to enable them (hint: you add "W=1" on the compile line). > > > > Enabling W=1 in the default build will only serve to annoy Linus IMHO. > > If he wants them to be enabled by default, they wouldn't be W=1 in the > > first place, they'd be W=0 which *is* the default build. > > Just to add real quick - my advice is to enable them for yourself and > send back any issues along with your normal review. A W=1 issue is no > different to a semantic or coding style one. > I'd like to enable it for only files under drivers/clk/ but it doesn't seem to work. I'm not asking to enable it at the toplevel Makefile. I'm asking to enable it for drivers/clk/ so nobody has to think about it now that you've done the hard work of getting the numbers in this directory down to zero or close to zero. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel