From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C6B95C4332E for ; Thu, 18 Feb 2021 11:30:55 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8E37264E79 for ; Thu, 18 Feb 2021 11:30:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232046AbhBRL3f (ORCPT ); Thu, 18 Feb 2021 06:29:35 -0500 Received: from out30-133.freemail.mail.aliyun.com ([115.124.30.133]:37560 "EHLO out30-133.freemail.mail.aliyun.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232615AbhBRKLA (ORCPT ); Thu, 18 Feb 2021 05:11:00 -0500 X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R971e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=alimailimapcm10staff010182156082;MF=jiapeng.chong@linux.alibaba.com;NM=1;PH=DS;RN=11;SR=0;TI=SMTPD_---0UOtCp5d_1613643012; Received: from j63c13417.sqa.eu95.tbsite.net(mailfrom:jiapeng.chong@linux.alibaba.com fp:SMTPD_---0UOtCp5d_1613643012) by smtp.aliyun-inc.com(127.0.0.1); Thu, 18 Feb 2021 18:10:16 +0800 From: Jiapeng Chong To: mingo@redhat.com Cc: peterz@infradead.org, juri.lelli@redhat.com, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, rostedt@goodmis.org, bsegall@google.com, mgorman@suse.de, bristot@redhat.com, linux-kernel@vger.kernel.org, Jiapeng Chong Subject: [PATCH] sched/fair: Use true and false for bool variable Date: Thu, 18 Feb 2021 18:10:11 +0800 Message-Id: <1613643011-114108-1-git-send-email-jiapeng.chong@linux.alibaba.com> X-Mailer: git-send-email 1.8.3.1 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Fix the following coccicheck warnings: ./kernel/sched/fair.c:9504:9-10: WARNING: return of 0/1 in function 'voluntary_active_balance' with return type bool. Reported-by: Abaci Robot Signed-off-by: Jiapeng Chong --- kernel/sched/fair.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c index 04a3ce2..cf78337 100644 --- a/kernel/sched/fair.c +++ b/kernel/sched/fair.c @@ -9501,7 +9501,7 @@ static struct rq *find_busiest_queue(struct lb_env *env, struct sched_domain *sd = env->sd; if (asym_active_balance(env)) - return 1; + return true; /* * The dst_cpu is idle and the src_cpu CPU has only 1 CFS task. @@ -9513,13 +9513,13 @@ static struct rq *find_busiest_queue(struct lb_env *env, (env->src_rq->cfs.h_nr_running == 1)) { if ((check_cpu_capacity(env->src_rq, sd)) && (capacity_of(env->src_cpu)*sd->imbalance_pct < capacity_of(env->dst_cpu)*100)) - return 1; + return true; } if (env->migration_type == migrate_misfit) - return 1; + return true; - return 0; + return false; } static int need_active_balance(struct lb_env *env) -- 1.8.3.1