From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [PATCH v2 08/10] config: add dpaaX build support in
	common linuxapp
Date: Fri, 09 Mar 2018 18:11:33 +0100
Message-ID: <1614156.TSxC4NnS1j@xps>
References: <1519752352-15442-1-git-send-email-hemant.agrawal@nxp.com>
 <1519889597-5805-1-git-send-email-hemant.agrawal@nxp.com>
 <1519889597-5805-9-git-send-email-hemant.agrawal@nxp.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org, bruce.richardson@intel.com
To: Hemant Agrawal <hemant.agrawal@nxp.com>
Return-path: <dev-bounces@dpdk.org>
Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com
 [66.111.4.26]) by dpdk.org (Postfix) with ESMTP id E67FE5F44
 for <dev@dpdk.org>; Fri,  9 Mar 2018 18:11:48 +0100 (CET)
In-Reply-To: <1519889597-5805-9-git-send-email-hemant.agrawal@nxp.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

Hi,

As you know the config options should be declared in common_base
and overwritten in common_linuxapp.

That's why there is no need to add comments in common_linuxapp.
And some of the options should be only in common_base, like
	CONFIG_RTE_LIBRTE_DPAA_HWDEBUG=n

Please try to move all the options in common_base with their comments,
and only overwrite what is needed for Linux compilation.

Thanks


01/03/2018 08:33, Hemant Agrawal:
> --- a/config/common_linuxapp
> +++ b/config/common_linuxapp
> @@ -23,3 +23,40 @@ CONFIG_RTE_LIBRTE_NFP_PMD=y
>  CONFIG_RTE_LIBRTE_POWER=y
>  CONFIG_RTE_VIRTIO_USER=y
>  CONFIG_RTE_PROC_INFO=y
> +#
> +# ARMv8 Specific driver compilation flags
> +#
> +
> +# Compile NXP DPAA Bus
> +CONFIG_RTE_LIBRTE_DPAA_BUS=y
> +CONFIG_RTE_LIBRTE_DPAA_HWDEBUG=n
> +
> +# Compile NXP DPAA Mempool
> +CONFIG_RTE_LIBRTE_DPAA_MEMPOOL=y
> +
> +# Compile bust-oriented NXP DPAA PMD
> +CONFIG_RTE_LIBRTE_DPAA_PMD=y
> +
> +# Compile schedule-oriented NXP DPAA Event Dev PMD
> +CONFIG_RTE_LIBRTE_PMD_DPAA_EVENTDEV=y
> +
> +# Compile NXP DPAA caam - crypto driver
> +CONFIG_RTE_LIBRTE_PMD_DPAA_SEC=y
> +CONFIG_RTE_LIBRTE_DPAA_MAX_CRYPTODEV=4
> +CONFIG_RTE_DPAA_SEC_PMD_MAX_NB_SESSIONS=2048
> +
> +# Compile NXP DPAA2 FSL-MC Bus
> +CONFIG_RTE_LIBRTE_FSLMC_BUS=y
> +
> +# Compile NXP DPAA2 Mempool
> +CONFIG_RTE_LIBRTE_DPAA2_MEMPOOL=y
> +
> +# Compile burst-oriented NXP DPAA2 PMD driver
> +CONFIG_RTE_LIBRTE_DPAA2_PMD=y
> +
> +# Compile schedule-oriented NXP DPAA2 EVENTDEV driver
> +CONFIG_RTE_LIBRTE_PMD_DPAA2_EVENTDEV=y
> +
> +# Compile NXP DPAA2 crypto sec driver for CAAM HW
> +CONFIG_RTE_LIBRTE_PMD_DPAA2_SEC=y
> +CONFIG_RTE_DPAA2_SEC_PMD_MAX_NB_SESSIONS=2048