* [PATCH][next] media: venus: Fix uninitialized variable count being checked for zero
@ 2021-01-15 10:11 Colin King
2021-03-01 19:59 ` patchwork-bot+linux-arm-msm
0 siblings, 1 reply; 2+ messages in thread
From: Colin King @ 2021-01-15 10:11 UTC (permalink / raw)
To: Stanimir Varbanov, Andy Gross, Bjorn Andersson,
Mauro Carvalho Chehab, linux-media, linux-arm-msm
Cc: kernel-janitors, linux-kernel
From: Colin Ian King <colin.king@canonical.com>
In the case where plat->codecs is NULL the variable count is uninitialized
but is being checked to see if it is 0. Fix this by initializing
count to 0.
Addresses-Coverity: ("Uninitialized scalar variable")
Fixes: e29929266be1 ("media: venus: Get codecs and capabilities from hfi platform")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/media/platform/qcom/venus/hfi_parser.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/platform/qcom/venus/hfi_parser.c b/drivers/media/platform/qcom/venus/hfi_parser.c
index 2c63988cb321..7263c0c32695 100644
--- a/drivers/media/platform/qcom/venus/hfi_parser.c
+++ b/drivers/media/platform/qcom/venus/hfi_parser.c
@@ -232,7 +232,7 @@ static int hfi_platform_parser(struct venus_core *core, struct venus_inst *inst)
{
const struct hfi_platform *plat;
const struct hfi_plat_caps *caps = NULL;
- u32 enc_codecs, dec_codecs, count;
+ u32 enc_codecs, dec_codecs, count = 0;
unsigned int entries;
if (inst)
--
2.29.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH][next] media: venus: Fix uninitialized variable count being checked for zero
2021-01-15 10:11 [PATCH][next] media: venus: Fix uninitialized variable count being checked for zero Colin King
@ 2021-03-01 19:59 ` patchwork-bot+linux-arm-msm
0 siblings, 0 replies; 2+ messages in thread
From: patchwork-bot+linux-arm-msm @ 2021-03-01 19:59 UTC (permalink / raw)
To: Colin King; +Cc: linux-arm-msm
Hello:
This patch was applied to qcom/linux.git (refs/heads/for-next):
On Fri, 15 Jan 2021 10:11:26 +0000 you wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> In the case where plat->codecs is NULL the variable count is uninitialized
> but is being checked to see if it is 0. Fix this by initializing
> count to 0.
>
> Addresses-Coverity: ("Uninitialized scalar variable")
> Fixes: e29929266be1 ("media: venus: Get codecs and capabilities from hfi platform")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
>
> [...]
Here is the summary with links:
- [next] media: venus: Fix uninitialized variable count being checked for zero
https://git.kernel.org/qcom/c/c5b14df7a80a
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-03-01 20:46 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-01-15 10:11 [PATCH][next] media: venus: Fix uninitialized variable count being checked for zero Colin King
2021-03-01 19:59 ` patchwork-bot+linux-arm-msm
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.