All of lore.kernel.org
 help / color / mirror / Atom feed
From: "tip-bot2 for Vincent Guittot" <tip-bot2@linutronix.de>
To: linux-tip-commits@vger.kernel.org
Cc: Vincent Guittot <vincent.guittot@linaro.org>,
	"Peter Zijlstra (Intel)" <peterz@infradead.org>,
	Valentin Schneider <valentin.schneider@arm.com>,
	x86@kernel.org, linux-kernel@vger.kernel.org
Subject: [tip: sched/core] sched/fair: Remove unused parameter of update_nohz_stats
Date: Tue, 02 Mar 2021 09:01:55 -0000	[thread overview]
Message-ID: <161467571544.20312.5783812537772586397.tip-bot2@tip-bot2> (raw)
In-Reply-To: <20210224133007.28644-4-vincent.guittot@linaro.org>

The following commit has been merged into the sched/core branch of tip:

Commit-ID:     8af3f0fbfbaa3b78bb1fc577ee42c3228f3cc822
Gitweb:        https://git.kernel.org/tip/8af3f0fbfbaa3b78bb1fc577ee42c3228f3cc822
Author:        Vincent Guittot <vincent.guittot@linaro.org>
AuthorDate:    Wed, 24 Feb 2021 14:30:03 +01:00
Committer:     Peter Zijlstra <peterz@infradead.org>
CommitterDate: Mon, 01 Mar 2021 18:17:23 +01:00

sched/fair: Remove unused parameter of update_nohz_stats

idle load balance is the only user of update_nohz_stats and doesn't use
force parameter. Remove it

Signed-off-by: Vincent Guittot <vincent.guittot@linaro.org>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Reviewed-by: Valentin Schneider <valentin.schneider@arm.com>
Link: https://lkml.kernel.org/r/20210224133007.28644-4-vincent.guittot@linaro.org
---
 kernel/sched/fair.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c
index 6a458e9..1b91030 100644
--- a/kernel/sched/fair.c
+++ b/kernel/sched/fair.c
@@ -8352,7 +8352,7 @@ group_type group_classify(unsigned int imbalance_pct,
 	return group_has_spare;
 }
 
-static bool update_nohz_stats(struct rq *rq, bool force)
+static bool update_nohz_stats(struct rq *rq)
 {
 #ifdef CONFIG_NO_HZ_COMMON
 	unsigned int cpu = rq->cpu;
@@ -8363,7 +8363,7 @@ static bool update_nohz_stats(struct rq *rq, bool force)
 	if (!cpumask_test_cpu(cpu, nohz.idle_cpus_mask))
 		return false;
 
-	if (!force && !time_after(jiffies, rq->last_blocked_load_update_tick))
+	if (!time_after(jiffies, rq->last_blocked_load_update_tick))
 		return true;
 
 	update_blocked_averages(cpu);
@@ -10401,7 +10401,7 @@ static void _nohz_idle_balance(struct rq *this_rq, unsigned int flags,
 
 		rq = cpu_rq(balance_cpu);
 
-		has_blocked_load |= update_nohz_stats(rq, true);
+		has_blocked_load |= update_nohz_stats(rq);
 
 		/*
 		 * If time for next balance is due,

  reply	other threads:[~2021-03-02  9:36 UTC|newest]

Thread overview: 39+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-24 13:30 [PATCH 0/7 v4] move update blocked load outside newidle_balance Vincent Guittot
2021-02-24 13:30 ` [PATCH 1/7 v4] sched/fair: remove update of blocked load from newidle_balance Vincent Guittot
2021-03-02  9:01   ` [tip: sched/core] sched/fair: Remove " tip-bot2 for Vincent Guittot
2021-03-03  9:49   ` tip-bot2 for Vincent Guittot
2021-03-06 11:42   ` tip-bot2 for Vincent Guittot
2021-02-24 13:30 ` [PATCH 2/7 v4] sched/fair: remove unused return of _nohz_idle_balance Vincent Guittot
2021-03-02  9:01   ` [tip: sched/core] sched/fair: Remove " tip-bot2 for Vincent Guittot
2021-03-03  9:49   ` tip-bot2 for Vincent Guittot
2021-03-06 11:42   ` tip-bot2 for Vincent Guittot
2021-02-24 13:30 ` [PATCH 3/7 v4] sched/fair: remove unused parameter of update_nohz_stats Vincent Guittot
2021-03-02  9:01   ` tip-bot2 for Vincent Guittot [this message]
2021-03-03  9:49   ` [tip: sched/core] sched/fair: Remove " tip-bot2 for Vincent Guittot
2021-03-05 13:55   ` [PATCH 3/7 v4] sched/fair: remove " Qais Yousef
2021-03-06 11:42   ` [tip: sched/core] sched/fair: Remove " tip-bot2 for Vincent Guittot
2021-02-24 13:30 ` [PATCH 4/7 v4] sched/fair: merge for each idle cpu loop of ILB Vincent Guittot
2021-03-02  9:01   ` [tip: sched/core] sched/fair: Merge " tip-bot2 for Vincent Guittot
2021-03-03  9:49   ` tip-bot2 for Vincent Guittot
2021-03-06 11:42   ` tip-bot2 for Vincent Guittot
2021-02-24 13:30 ` [PATCH 5/7 v4] sched/fair: reorder newidle_balance pulled_task tests Vincent Guittot
2021-03-02  9:01   ` [tip: sched/core] sched/fair: Reorder " tip-bot2 for Vincent Guittot
2021-03-03  9:49   ` tip-bot2 for Vincent Guittot
2021-03-06 11:42   ` tip-bot2 for Vincent Guittot
2021-02-24 13:30 ` [PATCH 6/7 v4] sched/fair: trigger the update of blocked load on newly idle cpu Vincent Guittot
2021-03-02  9:01   ` [tip: sched/core] sched/fair: Trigger " tip-bot2 for Vincent Guittot
2021-03-03  9:49   ` tip-bot2 for Vincent Guittot
2021-03-05 13:52   ` [PATCH 6/7 v4] sched/fair: trigger " Qais Yousef
2021-03-06 11:42   ` [tip: sched/core] sched/fair: Trigger " tip-bot2 for Vincent Guittot
2021-02-24 13:30 ` [PATCH 7/7 v4] sched/fair: reduce the window for duplicated update Vincent Guittot
2021-03-02  9:01   ` [tip: sched/core] sched/fair: Reduce " tip-bot2 for Vincent Guittot
2021-03-03  9:49   ` tip-bot2 for Vincent Guittot
2021-03-06 11:42   ` tip-bot2 for Vincent Guittot
2021-02-24 15:53 ` [PATCH 0/7 v4] move update blocked load outside newidle_balance Peter Zijlstra
2021-02-24 15:57   ` Vincent Guittot
2021-02-24 17:41     ` Peter Zijlstra
2021-02-24 17:51       ` Vincent Guittot
2021-02-24 18:17         ` Peter Zijlstra
2021-02-24 18:46 ` Valentin Schneider
2021-02-25  8:05   ` Vincent Guittot
2021-02-25 12:14     ` Valentin Schneider

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=161467571544.20312.5783812537772586397.tip-bot2@tip-bot2 \
    --to=tip-bot2@linutronix.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tip-commits@vger.kernel.org \
    --cc=peterz@infradead.org \
    --cc=valentin.schneider@arm.com \
    --cc=vincent.guittot@linaro.org \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.