From: Stephen Boyd <swboyd@chromium.org>
To: Rajendra Nayak <rnayak@codeaurora.org>,
Taniya Das <tdas@codeaurora.org>,
agross@kernel.org, bjorn.andersson@linaro.org,
robh+dt@kernel.org
Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 06/13] arm64: dts: qcom: SC7280: Add rpmhcc clock controller node
Date: Wed, 03 Mar 2021 00:21:25 -0800 [thread overview]
Message-ID: <161475968509.1478170.5248506718236838205@swboyd.mtv.corp.google.com> (raw)
In-Reply-To: <f58070ee-ff00-f8c5-6459-782562e903e5@codeaurora.org>
Quoting Taniya Das (2021-03-01 09:27:06)
> On 2/23/2021 1:13 PM, Stephen Boyd wrote:
> > Quoting Rajendra Nayak (2021-02-11 23:28:43)
> >> diff --git a/arch/arm64/boot/dts/qcom/sc7280.dtsi b/arch/arm64/boot/dts/qcom/sc7280.dtsi
> >> + usb3_phy_wrapper_gcc_usb30_pipe_clk: usb3-phy-wrapper-gcc-usb30-pipe-clk {
> >> + compatible = "fixed-clock";
> >> + clock-frequency = <1000>;
> >> + #clock-cells = <0>;
> >> + };
> >
> > Shouldn't these come from the phys? Why are they being added here?
> >
>
> Once the phys are added, these could be replaced, that was the reason to
> add them.
>
> >> };
> >>
> >> reserved_memory: reserved-memory {
> >> @@ -174,6 +211,17 @@
> >> gcc: clock-controller@100000 {
> >> compatible = "qcom,gcc-sc7280";
> >> reg = <0 0x00100000 0 0x1f0000>;
> >> + clocks = <&rpmhcc RPMH_CXO_CLK>,
> >> + <&rpmhcc RPMH_CXO_CLK_A>, <&sleep_clk>,
> >> + <&pcie_0_pipe_clk>, <&pcie_1_pipe_clk>,
> >> + <&ufs_phy_rx_symbol_0_clk>, <&ufs_phy_rx_symbol_1_clk>,
> >> + <&ufs_phy_tx_symbol_0_clk>,
> >> + <&usb3_phy_wrapper_gcc_usb30_pipe_clk>;
> >
> > If the phys aren't ready then <0> should work. Unless something goes
> > wrong?
> >
>
> Nothing would go wrong if we add <0>, but wanted them to be replaced
> once the support is added.
Please use <0> to indicate that it's missing. Otherwise we may never
realize that we should connect it up later.
next prev parent reply other threads:[~2021-03-03 21:42 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-12 7:28 [PATCH 00/13] Add binding updates and DT files for SC7280 SoC Rajendra Nayak
2021-02-12 7:28 ` [PATCH 01/13] dt-bindings: arm: qcom: Document SC7280 SoC and board Rajendra Nayak
2021-02-23 7:49 ` Stephen Boyd
2021-03-05 20:08 ` Rob Herring
2021-02-12 7:28 ` [PATCH 02/13] dt-bindings: firmware: scm: Add SC7280 support Rajendra Nayak
2021-02-23 7:50 ` Stephen Boyd
2021-03-05 20:08 ` Rob Herring
2021-02-12 7:28 ` [PATCH 03/13] arm64: dts: sc7280: Add basic dts/dtsi files for SC7280 soc Rajendra Nayak
2021-02-12 20:00 ` kernel test robot
2021-02-12 20:00 ` kernel test robot
2021-02-23 7:37 ` Stephen Boyd
2021-02-23 11:42 ` Rajendra Nayak
2021-02-12 7:28 ` [PATCH 04/13] dt-bindings: qcom,pdc: Add compatible for sc7280 Rajendra Nayak
2021-02-23 7:38 ` Stephen Boyd
2021-02-23 7:39 ` Stephen Boyd
2021-03-05 5:46 ` Rajendra Nayak
2021-02-12 7:28 ` [PATCH 05/13] arm64: dts: qcom: sc7280: Add RSC and PDC devices Rajendra Nayak
2021-02-23 7:41 ` Stephen Boyd
2021-02-12 7:28 ` [PATCH 06/13] arm64: dts: qcom: SC7280: Add rpmhcc clock controller node Rajendra Nayak
2021-02-23 7:43 ` Stephen Boyd
2021-03-01 17:27 ` Taniya Das
2021-03-03 8:21 ` Stephen Boyd [this message]
2021-02-12 7:28 ` [PATCH 07/13] dt-bindings: arm-smmu: Add compatible for SC7280 SoC Rajendra Nayak
2021-02-23 7:43 ` Stephen Boyd
2021-02-12 7:28 ` [PATCH 08/13] arm64: dts: qcom: sc7280: Add device node for APPS SMMU Rajendra Nayak
2021-02-12 7:28 ` [PATCH 09/13] arm64: dts: qcom: Add reserved memory for fw Rajendra Nayak
2021-02-23 7:45 ` Stephen Boyd
2021-02-23 11:45 ` Rajendra Nayak
2021-02-12 7:28 ` [PATCH 10/13] dt-bindings: watchdog: Add compatible for SC7280 SoC Rajendra Nayak
2021-02-23 7:45 ` Stephen Boyd
2021-02-12 7:28 ` [PATCH 11/13] arm64: dts: qcom: sc7280: Add APSS watchdog node Rajendra Nayak
2021-02-23 7:46 ` Stephen Boyd
2021-02-12 7:28 ` [PATCH 12/13] arm64: dts: qcom: sc7280: Add SPMI PMIC arbiter device for SC7280 Rajendra Nayak
2021-02-12 7:28 ` [PATCH 13/13] arm64: dts: qcom: sc7280: Add cpuidle states Rajendra Nayak
2021-02-23 7:49 ` Stephen Boyd
2021-02-23 11:50 ` Maulik Shah
2021-03-11 0:13 ` [PATCH 00/13] Add binding updates and DT files for SC7280 SoC Bjorn Andersson
2021-03-11 9:15 ` Rajendra Nayak
2021-03-11 11:35 ` Rajendra Nayak
2021-03-11 16:44 ` Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=161475968509.1478170.5248506718236838205@swboyd.mtv.corp.google.com \
--to=swboyd@chromium.org \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rnayak@codeaurora.org \
--cc=robh+dt@kernel.org \
--cc=tdas@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.