From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A80EDC433E9 for ; Thu, 4 Mar 2021 01:01:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7BFD664F53 for ; Thu, 4 Mar 2021 01:01:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240980AbhCDBBK (ORCPT ); Wed, 3 Mar 2021 20:01:10 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45772 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1382744AbhCDALy (ORCPT ); Wed, 3 Mar 2021 19:11:54 -0500 Received: from mail-pf1-x42d.google.com (mail-pf1-x42d.google.com [IPv6:2607:f8b0:4864:20::42d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B59CBC0610E0 for ; Wed, 3 Mar 2021 16:04:14 -0800 (PST) Received: by mail-pf1-x42d.google.com with SMTP id q20so17493386pfu.8 for ; Wed, 03 Mar 2021 16:04:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:content-transfer-encoding:in-reply-to:references :subject:from:cc:to:date:message-id:user-agent; bh=Xsa9Mpvkt/notnN/e4GDL+3FBsMQ7YT2Kdplb0idhbI=; b=km3yzkAfcfhxQkOel4IYCsI/+mE/weaL6XTa1RLUnVXK+5JhaNhUtbYsJqJthvlFMP Q5WPkeQ3m2vcw8iCk0+CMDHbJ35tAHf96Nc1A3prYwIfZetGdJGcBBaENSPcUB7A5/BO V5+gtpXSkH/4lQc4p9PNGNCxvTRI/xeAlF5tA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:content-transfer-encoding :in-reply-to:references:subject:from:cc:to:date:message-id :user-agent; bh=Xsa9Mpvkt/notnN/e4GDL+3FBsMQ7YT2Kdplb0idhbI=; b=JvNl9AXzoz/CXvOXXR0HvQUvfPa6lS8wJSxg/oy6qc5/VCPXZa8YoFL4OotElcU/Y+ MoynJRrxuJSEhxqd0s7BH4wh+Hjbf3w1kVitzVMWCVlPWt1iKyeVcVkE7rwf7M0MyRi3 J9WzGavd/IhZQzZ7b30lgdemAFiDyrsN2yOs+FNqYpmC8OkEaYgrTjGYcsaEeh8T7tTU sWTYnKgoo9Lgdh3vvtR5MMxG3PEIhZWWrLl2I57SuQx/UuT8+B2/JkCSKkOcusun4F4z ceoEj1JQNQiSFyecdBSUlAjhhw1D50GeY/GdT44PBkjfeiwboOw9h0/dVkgh45HdSg48 B5Jg== X-Gm-Message-State: AOAM533xFDjcVfPmVJyNEUP8wS+M4ai/zLRrOT2cPQMetv02Cn5dWP2e PjlqasfTyXgubBcoc0FCDStVY6Gw2wNAVw== X-Google-Smtp-Source: ABdhPJxAp2vIvJNooX/Qe3go8/D7UNaN3yUYZy8fmYrsT40tvKPhp5FHDC2KXOft3YudxQYPVe1yvw== X-Received: by 2002:a63:1d1c:: with SMTP id d28mr1218685pgd.216.1614816253332; Wed, 03 Mar 2021 16:04:13 -0800 (PST) Received: from chromium.org ([2620:15c:202:201:2510:ab07:78a:7d78]) by smtp.gmail.com with ESMTPSA id r2sm24492211pgv.50.2021.03.03.16.04.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 03 Mar 2021 16:04:12 -0800 (PST) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable In-Reply-To: <1614773878-8058-6-git-send-email-rnayak@codeaurora.org> References: <1614773878-8058-1-git-send-email-rnayak@codeaurora.org> <1614773878-8058-6-git-send-email-rnayak@codeaurora.org> Subject: Re: [PATCH v2 05/14] arm64: dts: qcom: sc7280: Add RSC and PDC devices From: Stephen Boyd Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Maulik Shah , Rajendra Nayak To: Rajendra Nayak , agross@kernel.org, bjorn.andersson@linaro.org, robh+dt@kernel.org Date: Wed, 03 Mar 2021 16:04:10 -0800 Message-ID: <161481625091.1478170.8810587061043612400@swboyd.mtv.corp.google.com> User-Agent: alot/0.9.1 Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org Quoting Rajendra Nayak (2021-03-03 04:17:49) > diff --git a/arch/arm64/boot/dts/qcom/sc7280.dtsi b/arch/arm64/boot/dts/q= com/sc7280.dtsi > index 4a56d9c..21c2399 100644 > --- a/arch/arm64/boot/dts/qcom/sc7280.dtsi > +++ b/arch/arm64/boot/dts/qcom/sc7280.dtsi > @@ -30,6 +31,18 @@ > }; > }; > =20 > + reserved_memory: reserved-memory { Do we plan to use this label at any point? I'd prefer we remove this until it becomes useful. > + #address-cells =3D <2>; > + #size-cells =3D <2>; > + ranges; > + > + aop_cmd_db_mem: memory@80860000 { > + reg =3D <0x0 0x80860000 0x0 0x20000>; > + compatible =3D "qcom,cmd-db"; > + no-map; > + }; > + }; > + > cpus { > #address-cells =3D <2>; > #size-cells =3D <0>; > @@ -203,6 +229,7 @@ > interrupt-controller; > #interrupt-cells =3D <2>; > gpio-ranges =3D <&tlmm 0 0 175>; > + wakeup-parent =3D <&pdc>; > =20 > qup_uart5_default: qup-uart5-default { > pins =3D "gpio46", "gpio47"; > @@ -287,6 +314,23 @@ > status =3D "disabled"; > }; > }; > + > + apps_rsc: rsc@18200000 { Any better name than 'rsc'? Maybe 'power-controller'? > + compatible =3D "qcom,rpmh-rsc"; > + reg =3D <0 0x18200000 0 0x10000>, > + <0 0x18210000 0 0x10000>, > + <0 0x18220000 0 0x10000>; > + reg-names =3D "drv-0", "drv-1", "drv-2"; > + interrupts =3D , > + , > + ; > + qcom,tcs-offset =3D <0xd00>; > + qcom,drv-id =3D <2>; > + qcom,tcs-config =3D , > + , > + , > + ; > + }; > };