All of lore.kernel.org
 help / color / mirror / Atom feed
From: no-reply@patchew.org
To: jiaxun.yang@flygoat.com
Cc: syq@debian.org, laurent@vivier.eu, qemu-devel@nongnu.org
Subject: Re: [PATCH] linux-user: add missing MULTICAST_IF get/setsockopt option
Date: Thu, 4 Mar 2021 19:42:48 -0800 (PST)	[thread overview]
Message-ID: <161491576761.25942.13581879647546304735@c667a6b167f6> (raw)
In-Reply-To: <20210305033510.8600-1-jiaxun.yang@flygoat.com>

Patchew URL: https://patchew.org/QEMU/20210305033510.8600-1-jiaxun.yang@flygoat.com/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: 20210305033510.8600-1-jiaxun.yang@flygoat.com
Subject: [PATCH] linux-user: add missing MULTICAST_IF get/setsockopt option

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 - [tag update]      patchew/20210218175648.1636219-1-f4bug@amsat.org -> patchew/20210218175648.1636219-1-f4bug@amsat.org
 - [tag update]      patchew/20210218212453.831406-1-dje@google.com -> patchew/20210218212453.831406-1-dje@google.com
 - [tag update]      patchew/20210219144617.4782-1-peter.maydell@linaro.org -> patchew/20210219144617.4782-1-peter.maydell@linaro.org
 - [tag update]      patchew/20210304021621.579-1-yuzenghui@huawei.com -> patchew/20210304021621.579-1-yuzenghui@huawei.com
 - [tag update]      patchew/20210304101738.20248-1-vsementsov@virtuozzo.com -> patchew/20210304101738.20248-1-vsementsov@virtuozzo.com
 - [tag update]      patchew/20210304140229.575481-1-armbru@redhat.com -> patchew/20210304140229.575481-1-armbru@redhat.com
 - [tag update]      patchew/20210304203540.41614-1-nieklinnenbank@gmail.com -> patchew/20210304203540.41614-1-nieklinnenbank@gmail.com
 - [tag update]      patchew/20210304220104.2574112-1-laurent@vivier.eu -> patchew/20210304220104.2574112-1-laurent@vivier.eu
 - [tag update]      patchew/20210304221103.6369-1-mark.cave-ayland@ilande.co.uk -> patchew/20210304221103.6369-1-mark.cave-ayland@ilande.co.uk
 * [new tag]         patchew/20210305033510.8600-1-jiaxun.yang@flygoat.com -> patchew/20210305033510.8600-1-jiaxun.yang@flygoat.com
Switched to a new branch 'test'
fe4b962 linux-user: add missing MULTICAST_IF get/setsockopt option

=== OUTPUT BEGIN ===
Use of uninitialized value $acpi_testexpected in string eq at ./scripts/checkpatch.pl line 1529.
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#54: 
new file mode 100644

ERROR: trailing whitespace
#1158: FILE: linux-user/syscall.c.orig:1100:
+    $

ERROR: trailing whitespace
#1166: FILE: linux-user/syscall.c.orig:1108:
+    $

ERROR: trailing whitespace
#1176: FILE: linux-user/syscall.c.orig:1118:
+    $

ERROR: trailing whitespace
#1182: FILE: linux-user/syscall.c.orig:1124:
+    $

ERROR: trailing whitespace
#1934: FILE: linux-user/syscall.c.orig:1876:
+    $

ERROR: trailing whitespace
#1936: FILE: linux-user/syscall.c.orig:1878:
+    if (msg_controllen < sizeof (struct target_cmsghdr)) $

ERROR: trailing whitespace
#2022: FILE: linux-user/syscall.c.orig:1964:
+    if (msg_controllen < sizeof (struct target_cmsghdr)) $

ERROR: trailing whitespace
#6313: FILE: linux-user/syscall.c.orig:6255:
+    if (ldt_info.entry_number < TARGET_GDT_ENTRY_TLS_MIN || $

ERROR: trailing whitespace
#6391: FILE: linux-user/syscall.c.orig:6333:
+    $

ERROR: trailing whitespace
#6407: FILE: linux-user/syscall.c.orig:6349:
+    base_addr = (entry_1 >> 16) | $

ERROR: trailing whitespace
#6408: FILE: linux-user/syscall.c.orig:6350:
+        (entry_2 & 0xff000000) | $

ERROR: trailing whitespace
#11511: FILE: linux-user/syscall.c.orig:11453:
+        if (!(p = lock_user_string(arg2))) $

total: 12 errors, 1 warnings, 13333 lines checked

Commit fe4b9625baf8 (linux-user: add missing MULTICAST_IF get/setsockopt option) has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/20210305033510.8600-1-jiaxun.yang@flygoat.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com

  reply	other threads:[~2021-03-05  3:44 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-05  3:35 [PATCH] linux-user: add missing MULTICAST_IF get/setsockopt option Jiaxun Yang
2021-03-05  3:42 ` no-reply [this message]
2021-03-05  3:46 ` Jiaxun Yang
2021-03-05  9:34   ` Philippe Mathieu-Daudé

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=161491576761.25942.13581879647546304735@c667a6b167f6 \
    --to=no-reply@patchew.org \
    --cc=jiaxun.yang@flygoat.com \
    --cc=laurent@vivier.eu \
    --cc=qemu-devel@nongnu.org \
    --cc=syq@debian.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.