All of lore.kernel.org
 help / color / mirror / Atom feed
From: patchwork-bot+linux-arm-msm@kernel.org
To: Doug Anderson <dianders@chromium.org>
Cc: linux-arm-msm@vger.kernel.org
Subject: Re: [PATCH] arm64: dts: qcom: sc7180: Avoid glitching SPI CS at bootup on trogdor
Date: Mon, 08 Mar 2021 23:20:07 +0000	[thread overview]
Message-ID: <161524560776.12181.4446448510565909019.git-patchwork-notify@kernel.org> (raw)
In-Reply-To: <20210218145456.1.I1da01a075dd86e005152f993b2d5d82dd9686238@changeid>

Hello:

This patch was applied to qcom/linux.git (refs/heads/for-next):

On Thu, 18 Feb 2021 14:55:09 -0800 you wrote:
> At boot time the following happens:
> 1. Device core gets ready to probe our SPI driver.
> 2. Device core applies SPI controller's "default" pinctrl.
> 3. Device core calls the SPI driver's probe() function which will
>    eventually setup the chip select GPIO as "unasserted".
> 
> Thinking about the above, we can find:
> a) For SPI devices that the BIOS inits (Cr50 and EC), the BIOS would
>    have had them configured as "GENI" pins and not as "GPIO" pins.
> b) It turns out that our BIOS also happens to init these pins as
>    "output" (even though it doesn't need to since they're not muxed as
>    GPIO) but leaves them at the default state of "low".
> c) As soon as we apply the "default" chip select it'll switch the
>    function to GPIO and stop driving the chip select high (which is
>    how "GENI" was driving it) and start driving it low.
> d) As of commit 9378f46040be ("UPSTREAM: spi: spi-geni-qcom: Use the
>    new method of gpio CS control"), when the SPI core inits things it
>    inits the GPIO to be "deasserted".  Prior to that commit the GPIO
>    was left untouched until first use.
> e) When the first transaction happens we'll assert the chip select and
>    then deassert it after done.
> 
> [...]

Here is the summary with links:
  - arm64: dts: qcom: sc7180: Avoid glitching SPI CS at bootup on trogdor
    https://git.kernel.org/qcom/c/deb625f19bc8

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html



      parent reply	other threads:[~2021-03-08 23:21 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-18 22:55 [PATCH] arm64: dts: qcom: sc7180: Avoid glitching SPI CS at bootup on trogdor Douglas Anderson
2021-02-19  0:55 ` Doug Anderson
2021-02-22 20:12 ` Stephen Boyd
2021-03-08 23:20 ` patchwork-bot+linux-arm-msm [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=161524560776.12181.4446448510565909019.git-patchwork-notify@kernel.org \
    --to=patchwork-bot+linux-arm-msm@kernel.org \
    --cc=dianders@chromium.org \
    --cc=linux-arm-msm@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.