From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 99F17C433E0 for ; Sat, 13 Mar 2021 20:24:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6365A64DF3 for ; Sat, 13 Mar 2021 20:24:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234299AbhCMUXp (ORCPT ); Sat, 13 Mar 2021 15:23:45 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48398 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234288AbhCMUX0 (ORCPT ); Sat, 13 Mar 2021 15:23:26 -0500 Received: from mail-pl1-x630.google.com (mail-pl1-x630.google.com [IPv6:2607:f8b0:4864:20::630]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4DB95C061574 for ; Sat, 13 Mar 2021 12:23:26 -0800 (PST) Received: by mail-pl1-x630.google.com with SMTP id w7so9990758pll.8 for ; Sat, 13 Mar 2021 12:23:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:content-transfer-encoding:in-reply-to:references :subject:from:cc:to:date:message-id:user-agent; bh=ZComPBNmBnlqs+w0q0axDrp2f7RBu3PW/uQNk9c0Mhg=; b=nZrKaPnBoh/iTbk/rPQgvk9qqHWK/RiepcUBKG52cr72cN8noIjG4ylYQAnV6vV03+ L7uTZCeeYJZPFnHf5oaOUgCir5abAz2eN+6OTWrpWm5qHWz0/BxJyifYCG1rKZNZQpOX ws2D8Ddv06kWnUXJOEOC10pHfySsaIMqJibbc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:content-transfer-encoding :in-reply-to:references:subject:from:cc:to:date:message-id :user-agent; bh=ZComPBNmBnlqs+w0q0axDrp2f7RBu3PW/uQNk9c0Mhg=; b=Geyxa9qxzoaIndtiyYXp5s3uPm52ZUpJlbkP39l8Cpa7EHR89o12So8jPk3cjt0r1w bCWFeiS5ukUPphW1zirv+U9tJINtk+7THHkrcn5Zw5MRr5VjnudNmZs0LgkzsSlNkBOd HatSb8asMout4aBBHiTVGTMMP0q2MnSkFekUyPgB3D1kcNieS9HTfHNvUG3xuJz2lHNt 8ymz2f7TDxyb3PHoIogzR0ae+0QGK6KAjlk/lOs5tscrUhIOryUAyNbypsgrI8PYvTYn FnhxkNs3VSJwSFUu5CylYdGhBWkTjMr7mzo8LuRXVhphrOZX9b0pcZHQlYc62648v8Kb CZig== X-Gm-Message-State: AOAM533W+39xz9Mop7f1qRURNDf/afutaUtUxRasMavWqy+1SWEN7YtN aVBq7yzG+PkwbUmSBdewAcqY+SiggQgSSw== X-Google-Smtp-Source: ABdhPJznrkgb4Vd9RGXUd7Ed7KRkZc2x1ozNjnwo1RoQtD567KQBnrtv+hRFwfyfkIYeRiOhS0oyPw== X-Received: by 2002:a17:902:8a91:b029:e6:3e11:b252 with SMTP id p17-20020a1709028a91b02900e63e11b252mr4516299plo.7.1615667005608; Sat, 13 Mar 2021 12:23:25 -0800 (PST) Received: from chromium.org ([2620:15c:202:201:e859:c7d5:7d7b:5ed8]) by smtp.gmail.com with ESMTPSA id 22sm2521970pjl.31.2021.03.13.12.23.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 13 Mar 2021 12:23:24 -0800 (PST) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable In-Reply-To: <20210304155144.1.Ic9c04f960190faad5290738b2a35d73661862735@changeid> References: <20210304155144.1.Ic9c04f960190faad5290738b2a35d73661862735@changeid> Subject: Re: [PATCH 1/3] drm/bridge: ti-sn65dsi86: Simplify refclk handling From: Stephen Boyd Cc: linux-arm-msm@vger.kernel.org, robdclark@chromium.org, Douglas Anderson , Daniel Vetter , David Airlie , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org To: Andrzej Hajda , Douglas Anderson , Jernej Skrabec , Jonas Karlman , Laurent Pinchart , Neil Armstrong , Sam Ravnborg Date: Sat, 13 Mar 2021 12:23:23 -0800 Message-ID: <161566700332.1478170.13745405253404480721@swboyd.mtv.corp.google.com> User-Agent: alot/0.9.1 Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org Quoting Douglas Anderson (2021-03-04 15:51:59) > The clock framework makes it simple to deal with an optional clock. > You can call clk_get_optional() and if the clock isn't specified it'll > just return NULL without complaint. It's valid to pass NULL to > enable/disable/prepare/unprepare. Let's make use of this to simplify > things a tiny bit. >=20 > NOTE: this makes things look a tad bit asymmetric now since we check > for NULL before clk_prepare_enable() but not for > clk_disable_unprepare(). This seemed OK to me. We already have to > check for NULL in the enable case anyway so why not avoid the extra > call? >=20 > Signed-off-by: Douglas Anderson > --- Reviewed-by: Stephen Boyd From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 711A6C433DB for ; Sat, 13 Mar 2021 20:23:28 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 263D164EC4 for ; Sat, 13 Mar 2021 20:23:28 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 263D164EC4 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 8FDE66E118; Sat, 13 Mar 2021 20:23:27 +0000 (UTC) Received: from mail-pj1-x1032.google.com (mail-pj1-x1032.google.com [IPv6:2607:f8b0:4864:20::1032]) by gabe.freedesktop.org (Postfix) with ESMTPS id F02006E118 for ; Sat, 13 Mar 2021 20:23:25 +0000 (UTC) Received: by mail-pj1-x1032.google.com with SMTP id ga23-20020a17090b0397b02900c0b81bbcd4so12395550pjb.0 for ; Sat, 13 Mar 2021 12:23:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:content-transfer-encoding:in-reply-to:references :subject:from:cc:to:date:message-id:user-agent; bh=ZComPBNmBnlqs+w0q0axDrp2f7RBu3PW/uQNk9c0Mhg=; b=nZrKaPnBoh/iTbk/rPQgvk9qqHWK/RiepcUBKG52cr72cN8noIjG4ylYQAnV6vV03+ L7uTZCeeYJZPFnHf5oaOUgCir5abAz2eN+6OTWrpWm5qHWz0/BxJyifYCG1rKZNZQpOX ws2D8Ddv06kWnUXJOEOC10pHfySsaIMqJibbc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:content-transfer-encoding :in-reply-to:references:subject:from:cc:to:date:message-id :user-agent; bh=ZComPBNmBnlqs+w0q0axDrp2f7RBu3PW/uQNk9c0Mhg=; b=idMe7EG+VaOWxz1LLkkvKtb8zjEOpOjvXh3xbBiHuKxQJnYH6YTT5Y75H8YJoGDFy7 a+5idlrcWkVmqScT75KvmArr6P8GbTcb8X0ltnSy4B8a4D0/B5NFprYOgJUHVcbmZ4cn /ClE0BbTIApS5vub8MmKFoXeb/2WSsTvZ+cjgbAjS6ZGBbJTfe2KiCoA24CLPbO6U5QL DZUSmMog57hf4zhL82Azp1F4QsdClORp2IMPmA4oE1UgQgL7NJ6862yeSDkUJSWerieI EXUv0sNOxXMJjYMJAhFEbSf40b7qI2asxiPHD/MiJ1+SpkIrpFQlP6BucOJNZDrx5NN1 XKkQ== X-Gm-Message-State: AOAM532im5cQ3ELeE7c11kaoVXA16egXPJvt5yEwighSzIs7SK0U0yVU QR3M/3cVasjEUAGNe4EA8RES7A== X-Google-Smtp-Source: ABdhPJznrkgb4Vd9RGXUd7Ed7KRkZc2x1ozNjnwo1RoQtD567KQBnrtv+hRFwfyfkIYeRiOhS0oyPw== X-Received: by 2002:a17:902:8a91:b029:e6:3e11:b252 with SMTP id p17-20020a1709028a91b02900e63e11b252mr4516299plo.7.1615667005608; Sat, 13 Mar 2021 12:23:25 -0800 (PST) Received: from chromium.org ([2620:15c:202:201:e859:c7d5:7d7b:5ed8]) by smtp.gmail.com with ESMTPSA id 22sm2521970pjl.31.2021.03.13.12.23.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 13 Mar 2021 12:23:24 -0800 (PST) MIME-Version: 1.0 In-Reply-To: <20210304155144.1.Ic9c04f960190faad5290738b2a35d73661862735@changeid> References: <20210304155144.1.Ic9c04f960190faad5290738b2a35d73661862735@changeid> Subject: Re: [PATCH 1/3] drm/bridge: ti-sn65dsi86: Simplify refclk handling From: Stephen Boyd To: Andrzej Hajda , Douglas Anderson , Jernej Skrabec , Jonas Karlman , Laurent Pinchart , Neil Armstrong , Sam Ravnborg Date: Sat, 13 Mar 2021 12:23:23 -0800 Message-ID: <161566700332.1478170.13745405253404480721@swboyd.mtv.corp.google.com> User-Agent: alot/0.9.1 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: robdclark@chromium.org, David Airlie , linux-arm-msm@vger.kernel.org, Douglas Anderson , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Quoting Douglas Anderson (2021-03-04 15:51:59) > The clock framework makes it simple to deal with an optional clock. > You can call clk_get_optional() and if the clock isn't specified it'll > just return NULL without complaint. It's valid to pass NULL to > enable/disable/prepare/unprepare. Let's make use of this to simplify > things a tiny bit. > > NOTE: this makes things look a tad bit asymmetric now since we check > for NULL before clk_prepare_enable() but not for > clk_disable_unprepare(). This seemed OK to me. We already have to > check for NULL in the enable case anyway so why not avoid the extra > call? > > Signed-off-by: Douglas Anderson > --- Reviewed-by: Stephen Boyd _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel