From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <SRS0=UYv2=IN=dpdk.org=dev-bounces@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
X-Spam-Level: 
X-Spam-Status: No, score=-16.8 required=3.0 tests=BAYES_00,
	HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH,
	MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham
	autolearn_force=no version=3.4.0
Received: from mail.kernel.org (mail.kernel.org [198.145.29.99])
	by smtp.lore.kernel.org (Postfix) with ESMTP id 246AAC433DB
	for <dpdk-dev@archiver.kernel.org>; Mon, 15 Mar 2021 16:20:09 +0000 (UTC)
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by mail.kernel.org (Postfix) with ESMTP id 353BF64E09
	for <dpdk-dev@archiver.kernel.org>; Mon, 15 Mar 2021 16:20:08 +0000 (UTC)
DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 353BF64E09
Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=fit.vutbr.cz
Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=dev-bounces@dpdk.org
Received: from [217.70.189.124] (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 01CC9242704;
	Mon, 15 Mar 2021 17:19:19 +0100 (CET)
Received: from office2.cesnet.cz (office2.cesnet.cz [195.113.144.244])
 by mails.dpdk.org (Postfix) with ESMTP id 1C59A4068C
 for <dev@dpdk.org>; Mon, 15 Mar 2021 16:34:02 +0100 (CET)
Received: from dpdk-test.liberouter.org (mt-kou.liberouter.org
 [195.113.172.85])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by office2.cesnet.cz (Postfix) with ESMTPSA id D764D40006B;
 Mon, 15 Mar 2021 16:34:01 +0100 (CET)
From: Jan Viktorin <iviktorin@fit.vutbr.cz>
To: dev@dpdk.org
Cc: Jan Viktorin <viktorin@cesnet.cz>, Asaf Penso <asafp@nvidia.com>,
 Shahaf Shuler <shahafs@nvidia.com>,
 Viacheslav Ovsiienko <viacheslavo@nvidia.com>,
 Matan Azrad <matan@nvidia.com>
Date: Mon, 15 Mar 2021 15:33:58 +0000
Message-Id: <1615822438-10082-2-git-send-email-iviktorin@fit.vutbr.cz>
X-Mailer: git-send-email 1.8.3.1
In-Reply-To: <1615822438-10082-1-git-send-email-iviktorin@fit.vutbr.cz>
References: <1615822438-10082-1-git-send-email-iviktorin@fit.vutbr.cz>
X-Mailman-Approved-At: Mon, 15 Mar 2021 17:19:06 +0100
Subject: [dpdk-dev] [PATCH 2/2] net/mlx5: avoid unbind step to enable
 switchdev mode
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

From: Jan Viktorin <viktorin@cesnet.cz>

The step 4 is a contradiction. It advices to unbind the device from the
mlx5_core which removes the associated system network interface (e.g.
eth0). In the step 5, the same system network interface (e.g. eth0) is
required to exist.

Signed-off-by: Jan Viktorin <viktorin@cesnet.cz>
---
 doc/guides/nics/mlx5.rst | 6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)

diff --git a/doc/guides/nics/mlx5.rst b/doc/guides/nics/mlx5.rst
index 0a2dc3dee..122d8e0fc 100644
--- a/doc/guides/nics/mlx5.rst
+++ b/doc/guides/nics/mlx5.rst
@@ -1370,11 +1370,7 @@ the DPDK application.
 
         echo <num of vfs > /sys/class/net/<net device>/device/sriov_numvfs
 
-4. Unbind the device (can be rebind after the switchdev mode)::
-
-        echo -n "<device pci address>" > /sys/bus/pci/drivers/mlx5_core/unbind
-
-5. Enable switchdev mode::
+4. Enable switchdev mode::
 
         echo switchdev > /sys/class/net/<net device>/compat/devlink/mode
 
-- 
2.30.1