* [PATCH] scsi: ibmvfc: Switch to using the new API kobj_to_dev()
@ 2021-02-22 6:47 ` Yang Li
0 siblings, 0 replies; 10+ messages in thread
From: Yang Li @ 2021-02-22 6:47 UTC (permalink / raw)
To: martin.petersen
Cc: mpe, benh, paulus, jejb, tyreld, linux-scsi, linuxppc-dev,
linux-kernel, Yang Li
fixed the following coccicheck:
./drivers/scsi/ibmvscsi/ibmvfc.c:3161:60-61: WARNING opportunity for
kobj_to_dev()
Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
---
drivers/scsi/ibmvscsi/ibmvfc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/scsi/ibmvscsi/ibmvfc.c b/drivers/scsi/ibmvscsi/ibmvfc.c
index 65f168c..e947149 100644
--- a/drivers/scsi/ibmvscsi/ibmvfc.c
+++ b/drivers/scsi/ibmvscsi/ibmvfc.c
@@ -3158,7 +3158,7 @@ static ssize_t ibmvfc_read_trace(struct file *filp, struct kobject *kobj,
struct bin_attribute *bin_attr,
char *buf, loff_t off, size_t count)
{
- struct device *dev = container_of(kobj, struct device, kobj);
+ struct device *dev = kobj_to_dev(kobj);
struct Scsi_Host *shost = class_to_shost(dev);
struct ibmvfc_host *vhost = shost_priv(shost);
unsigned long flags = 0;
--
1.8.3.1
^ permalink raw reply related [flat|nested] 10+ messages in thread
* [PATCH] scsi: ibmvfc: Switch to using the new API kobj_to_dev()
@ 2021-02-22 6:47 ` Yang Li
0 siblings, 0 replies; 10+ messages in thread
From: Yang Li @ 2021-02-22 6:47 UTC (permalink / raw)
To: martin.petersen
Cc: tyreld, linux-scsi, jejb, linux-kernel, paulus, Yang Li, linuxppc-dev
fixed the following coccicheck:
./drivers/scsi/ibmvscsi/ibmvfc.c:3161:60-61: WARNING opportunity for
kobj_to_dev()
Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
---
drivers/scsi/ibmvscsi/ibmvfc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/scsi/ibmvscsi/ibmvfc.c b/drivers/scsi/ibmvscsi/ibmvfc.c
index 65f168c..e947149 100644
--- a/drivers/scsi/ibmvscsi/ibmvfc.c
+++ b/drivers/scsi/ibmvscsi/ibmvfc.c
@@ -3158,7 +3158,7 @@ static ssize_t ibmvfc_read_trace(struct file *filp, struct kobject *kobj,
struct bin_attribute *bin_attr,
char *buf, loff_t off, size_t count)
{
- struct device *dev = container_of(kobj, struct device, kobj);
+ struct device *dev = kobj_to_dev(kobj);
struct Scsi_Host *shost = class_to_shost(dev);
struct ibmvfc_host *vhost = shost_priv(shost);
unsigned long flags = 0;
--
1.8.3.1
^ permalink raw reply related [flat|nested] 10+ messages in thread
* Re: [PATCH] scsi: ibmvfc: Switch to using the new API kobj_to_dev()
2021-02-22 6:47 ` Yang Li
@ 2021-03-16 3:15 ` Martin K. Petersen
-1 siblings, 0 replies; 10+ messages in thread
From: Martin K. Petersen @ 2021-03-16 3:15 UTC (permalink / raw)
To: Yang Li
Cc: Martin K . Petersen, jejb, linux-scsi, linuxppc-dev, mpe,
linux-kernel, benh, paulus, tyreld
On Mon, 22 Feb 2021 14:47:09 +0800, Yang Li wrote:
> fixed the following coccicheck:
> ./drivers/scsi/ibmvscsi/ibmvfc.c:3161:60-61: WARNING opportunity for
> kobj_to_dev()
Applied to 5.13/scsi-queue, thanks!
[1/1] scsi: ibmvfc: Switch to using the new API kobj_to_dev()
https://git.kernel.org/mkp/scsi/c/18c2a59a4190
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] scsi: ibmvfc: Switch to using the new API kobj_to_dev()
@ 2021-03-16 3:15 ` Martin K. Petersen
0 siblings, 0 replies; 10+ messages in thread
From: Martin K. Petersen @ 2021-03-16 3:15 UTC (permalink / raw)
To: Yang Li
Cc: tyreld, Martin K . Petersen, linux-scsi, jejb, linux-kernel,
paulus, linuxppc-dev
On Mon, 22 Feb 2021 14:47:09 +0800, Yang Li wrote:
> fixed the following coccicheck:
> ./drivers/scsi/ibmvscsi/ibmvfc.c:3161:60-61: WARNING opportunity for
> kobj_to_dev()
Applied to 5.13/scsi-queue, thanks!
[1/1] scsi: ibmvfc: Switch to using the new API kobj_to_dev()
https://git.kernel.org/mkp/scsi/c/18c2a59a4190
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] scsi: ibmvfc: Switch to using the new API kobj_to_dev()
2021-03-04 9:28 ` Jiapeng Chong
@ 2021-03-16 3:14 ` Martin K. Petersen
-1 siblings, 0 replies; 10+ messages in thread
From: Martin K. Petersen @ 2021-03-16 3:14 UTC (permalink / raw)
To: Jiapeng Chong, tyreld
Cc: Martin K . Petersen, jejb, linux-scsi, linuxppc-dev, mpe,
linux-kernel, benh, paulus
On Thu, 4 Mar 2021 17:28:44 +0800, Jiapeng Chong wrote:
> Fix the following coccicheck warnings:
>
> ./drivers/scsi/ibmvscsi/ibmvfc.c:3483:60-61: WARNING opportunity for
> kobj_to_dev().
Applied to 5.13/scsi-queue, thanks!
[1/1] scsi: ibmvfc: Switch to using the new API kobj_to_dev()
https://git.kernel.org/mkp/scsi/c/18c2a59a4190
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] scsi: ibmvfc: Switch to using the new API kobj_to_dev()
@ 2021-03-16 3:14 ` Martin K. Petersen
0 siblings, 0 replies; 10+ messages in thread
From: Martin K. Petersen @ 2021-03-16 3:14 UTC (permalink / raw)
To: Jiapeng Chong, tyreld
Cc: Martin K . Petersen, linux-scsi, jejb, linux-kernel, paulus,
linuxppc-dev
On Thu, 4 Mar 2021 17:28:44 +0800, Jiapeng Chong wrote:
> Fix the following coccicheck warnings:
>
> ./drivers/scsi/ibmvscsi/ibmvfc.c:3483:60-61: WARNING opportunity for
> kobj_to_dev().
Applied to 5.13/scsi-queue, thanks!
[1/1] scsi: ibmvfc: Switch to using the new API kobj_to_dev()
https://git.kernel.org/mkp/scsi/c/18c2a59a4190
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] scsi: ibmvfc: Switch to using the new API kobj_to_dev()
2021-03-04 9:28 ` Jiapeng Chong
@ 2021-03-04 18:48 ` Tyrel Datwyler
-1 siblings, 0 replies; 10+ messages in thread
From: Tyrel Datwyler @ 2021-03-04 18:48 UTC (permalink / raw)
To: Jiapeng Chong
Cc: mpe, benh, paulus, jejb, martin.petersen, linux-scsi,
linuxppc-dev, linux-kernel
On 3/4/21 1:28 AM, Jiapeng Chong wrote:
> Fix the following coccicheck warnings:
>
> ./drivers/scsi/ibmvscsi/ibmvfc.c:3483:60-61: WARNING opportunity for
> kobj_to_dev().
>
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
Acked-by: Tyrel Datwyler <tyreld@linux.ibm.com>
> ---
> drivers/scsi/ibmvscsi/ibmvfc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/scsi/ibmvscsi/ibmvfc.c b/drivers/scsi/ibmvscsi/ibmvfc.c
> index 755313b..e5f1ca7 100644
> --- a/drivers/scsi/ibmvscsi/ibmvfc.c
> +++ b/drivers/scsi/ibmvscsi/ibmvfc.c
> @@ -3480,7 +3480,7 @@ static ssize_t ibmvfc_read_trace(struct file *filp, struct kobject *kobj,
> struct bin_attribute *bin_attr,
> char *buf, loff_t off, size_t count)
> {
> - struct device *dev = container_of(kobj, struct device, kobj);
> + struct device *dev = kobj_to_dev(kobj);
> struct Scsi_Host *shost = class_to_shost(dev);
> struct ibmvfc_host *vhost = shost_priv(shost);
> unsigned long flags = 0;
>
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] scsi: ibmvfc: Switch to using the new API kobj_to_dev()
@ 2021-03-04 18:48 ` Tyrel Datwyler
0 siblings, 0 replies; 10+ messages in thread
From: Tyrel Datwyler @ 2021-03-04 18:48 UTC (permalink / raw)
To: Jiapeng Chong
Cc: martin.petersen, linux-scsi, jejb, linux-kernel, paulus, linuxppc-dev
On 3/4/21 1:28 AM, Jiapeng Chong wrote:
> Fix the following coccicheck warnings:
>
> ./drivers/scsi/ibmvscsi/ibmvfc.c:3483:60-61: WARNING opportunity for
> kobj_to_dev().
>
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
Acked-by: Tyrel Datwyler <tyreld@linux.ibm.com>
> ---
> drivers/scsi/ibmvscsi/ibmvfc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/scsi/ibmvscsi/ibmvfc.c b/drivers/scsi/ibmvscsi/ibmvfc.c
> index 755313b..e5f1ca7 100644
> --- a/drivers/scsi/ibmvscsi/ibmvfc.c
> +++ b/drivers/scsi/ibmvscsi/ibmvfc.c
> @@ -3480,7 +3480,7 @@ static ssize_t ibmvfc_read_trace(struct file *filp, struct kobject *kobj,
> struct bin_attribute *bin_attr,
> char *buf, loff_t off, size_t count)
> {
> - struct device *dev = container_of(kobj, struct device, kobj);
> + struct device *dev = kobj_to_dev(kobj);
> struct Scsi_Host *shost = class_to_shost(dev);
> struct ibmvfc_host *vhost = shost_priv(shost);
> unsigned long flags = 0;
>
^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH] scsi: ibmvfc: Switch to using the new API kobj_to_dev()
@ 2021-03-04 9:28 ` Jiapeng Chong
0 siblings, 0 replies; 10+ messages in thread
From: Jiapeng Chong @ 2021-03-04 9:28 UTC (permalink / raw)
To: tyreld
Cc: mpe, benh, paulus, jejb, martin.petersen, linux-scsi,
linuxppc-dev, linux-kernel, Jiapeng Chong
Fix the following coccicheck warnings:
./drivers/scsi/ibmvscsi/ibmvfc.c:3483:60-61: WARNING opportunity for
kobj_to_dev().
Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
---
drivers/scsi/ibmvscsi/ibmvfc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/scsi/ibmvscsi/ibmvfc.c b/drivers/scsi/ibmvscsi/ibmvfc.c
index 755313b..e5f1ca7 100644
--- a/drivers/scsi/ibmvscsi/ibmvfc.c
+++ b/drivers/scsi/ibmvscsi/ibmvfc.c
@@ -3480,7 +3480,7 @@ static ssize_t ibmvfc_read_trace(struct file *filp, struct kobject *kobj,
struct bin_attribute *bin_attr,
char *buf, loff_t off, size_t count)
{
- struct device *dev = container_of(kobj, struct device, kobj);
+ struct device *dev = kobj_to_dev(kobj);
struct Scsi_Host *shost = class_to_shost(dev);
struct ibmvfc_host *vhost = shost_priv(shost);
unsigned long flags = 0;
--
1.8.3.1
^ permalink raw reply related [flat|nested] 10+ messages in thread
* [PATCH] scsi: ibmvfc: Switch to using the new API kobj_to_dev()
@ 2021-03-04 9:28 ` Jiapeng Chong
0 siblings, 0 replies; 10+ messages in thread
From: Jiapeng Chong @ 2021-03-04 9:28 UTC (permalink / raw)
To: tyreld
Cc: Jiapeng Chong, martin.petersen, linux-scsi, jejb, linux-kernel,
paulus, linuxppc-dev
Fix the following coccicheck warnings:
./drivers/scsi/ibmvscsi/ibmvfc.c:3483:60-61: WARNING opportunity for
kobj_to_dev().
Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
---
drivers/scsi/ibmvscsi/ibmvfc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/scsi/ibmvscsi/ibmvfc.c b/drivers/scsi/ibmvscsi/ibmvfc.c
index 755313b..e5f1ca7 100644
--- a/drivers/scsi/ibmvscsi/ibmvfc.c
+++ b/drivers/scsi/ibmvscsi/ibmvfc.c
@@ -3480,7 +3480,7 @@ static ssize_t ibmvfc_read_trace(struct file *filp, struct kobject *kobj,
struct bin_attribute *bin_attr,
char *buf, loff_t off, size_t count)
{
- struct device *dev = container_of(kobj, struct device, kobj);
+ struct device *dev = kobj_to_dev(kobj);
struct Scsi_Host *shost = class_to_shost(dev);
struct ibmvfc_host *vhost = shost_priv(shost);
unsigned long flags = 0;
--
1.8.3.1
^ permalink raw reply related [flat|nested] 10+ messages in thread
end of thread, other threads:[~2021-03-16 7:23 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-02-22 6:47 [PATCH] scsi: ibmvfc: Switch to using the new API kobj_to_dev() Yang Li
2021-02-22 6:47 ` Yang Li
2021-03-16 3:15 ` Martin K. Petersen
2021-03-16 3:15 ` Martin K. Petersen
2021-03-04 9:28 Jiapeng Chong
2021-03-04 9:28 ` Jiapeng Chong
2021-03-04 18:48 ` Tyrel Datwyler
2021-03-04 18:48 ` Tyrel Datwyler
2021-03-16 3:14 ` Martin K. Petersen
2021-03-16 3:14 ` Martin K. Petersen
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.