From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EC748C433E6 for ; Tue, 16 Mar 2021 18:02:50 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5B2F96512E for ; Tue, 16 Mar 2021 18:02:50 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5B2F96512E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id EF7931931; Tue, 16 Mar 2021 19:01:58 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz EF7931931 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1615917769; bh=38WyV8v4iq0F8oP0e3/RtPJ7rN9AuwnlWyMS9fqp3qc=; h=From:To:Subject:Date:In-Reply-To:References:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=gjKNAXMP6z8uspvpU0+AS1NNjRC0krVe6vQq85RGkAcb2jjxlv5ERLCjt/jcmmCks ZQUQU7ZTdinuF9wYwaVZbiXgSXxoVmPGADx7QS4h6Xx1VzVqrvr3nwfjpRa/1wyIaK 2+m/HNIT+q6g5kO65e91wMAWrl74deopNsZGQbWs= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id C490FF8049C; Tue, 16 Mar 2021 19:00:22 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id B1FC5F80171; Tue, 16 Mar 2021 19:00:16 +0100 (CET) Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 9802EF80156 for ; Tue, 16 Mar 2021 19:00:12 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 9802EF80156 Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="X2IDI0I9" Received: by mail.kernel.org (Postfix) with ESMTPSA id 05DCE6512E; Tue, 16 Mar 2021 18:00:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1615917610; bh=38WyV8v4iq0F8oP0e3/RtPJ7rN9AuwnlWyMS9fqp3qc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=X2IDI0I9IufjRTUobZUc873zt6QC3v2ggmqGdlVPUoz2bBpTmfViwlu+JpKpke/FM phf1QTaAdYt0GOsRr51iWzA36ob4M9qKOMbUfZNICP0xwy4XFOAhAVBqbdTmJoB7AX iKBws2psWUqWTozmwZW6/vmRvNqNd9ie/ET+TpO+oWsM+DseE6rO4wW2E2N/HPAH6Z 6bGneEmoyXsAIHD4ItJegofEQvOCOAn8RvSGKmXeoPuBKRVpxE2TBTPP5gy0nyKo5i F+xW4NvznjCOU8LN7ggOCd4iYhA1mtGN+kcEBKtjyWIN5Y4G96mmHwmrELcD8D0A9N G/ywUHWkhcr/g== From: Mark Brown To: kuninori.morimoto.gx@renesas.com, mikhail_durnev@mentor.com, mdurnev@gmail.com, lgirdwood@gmail.com, alsa-devel@alsa-project.org Subject: Re: [PATCH v0] ASoC: rsnd: core: Check convert rate in rsnd_hw_params Date: Tue, 16 Mar 2021 17:59:45 +0000 Message-Id: <161591744696.13544.2360957689864131715.b4-ty@kernel.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <1615870055-13954-1-git-send-email-mikhail_durnev@mentor.com> References: <1615870055-13954-1-git-send-email-mikhail_durnev@mentor.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Cc: Mark Brown X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Tue, 16 Mar 2021 14:47:35 +1000, mdurnev@gmail.com wrote: > snd_pcm_hw_params_set_rate_near can return incorrect sample rate in > some cases, e.g. when the backend output rate is set to some value higher > than 48000 Hz and the input rate is 8000 Hz. So passing the value returned > by snd_pcm_hw_params_set_rate_near to snd_pcm_hw_params will result in > "FSO/FSI ratio error" and playing no audio at all while the userland > is not properly notified about the issue. > > [...] Applied to https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next Thanks! [1/1] ASoC: rsnd: core: Check convert rate in rsnd_hw_params commit: 19c6a63ced5e07e40f3a5255cb1f0fe0d3be7b14 All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark