Re: [RFC v5 0/6] hmp, qmp: Add some commands to introspect virtio deices

[no-reply@patchew.org]

Patchew URL: https://patchew.org/QEMU/1616084984-11263-1-git-send-email-jonah.palmer@oracle.com/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: 1616084984-11263-1-git-send-email-jonah.palmer@oracle.com
Subject: [RFC v5 0/6] hmp,qmp: Add some commands to introspect virtio deices

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 * [new tag]         patchew/1616084984-11263-1-git-send-email-jonah.palmer@oracle.com -> patchew/1616084984-11263-1-git-send-email-jonah.palmer@oracle.com
Switched to a new branch 'test'
be70546 hmp: add virtio commands
e4f8190 qmp: add QMP command x-debug-virtio-queue-element
3313968 qmp: add QMP command x-debug-virtio-queue-status
8e1517f qmp: decode feature bits in virtio-status
e8c80fb qmp: add QMP command x-debug-virtio-status
8b46cdd qmp: add QMP command x-debug-query-virtio

=== OUTPUT BEGIN ===
1/6 Checking commit 8b46cdd9037d (qmp: add QMP command x-debug-query-virtio)
Use of uninitialized value $acpi_testexpected in string eq at ./scripts/checkpatch.pl line 1529.
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#41: 
new file mode 100644

total: 0 errors, 1 warnings, 183 lines checked

Patch 1/6 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
2/6 Checking commit e8c80fb0056a (qmp: add QMP command x-debug-virtio-status)
3/6 Checking commit 8e1517f2abd7 (qmp: decode feature bits in virtio-status)
4/6 Checking commit 3313968494d6 (qmp: add QMP command x-debug-virtio-queue-status)
5/6 Checking commit e4f8190e9a24 (qmp: add QMP command x-debug-virtio-queue-element)
6/6 Checking commit be705468685f (hmp: add virtio commands)
Use of uninitialized value $acpi_testexpected in string eq at ./scripts/checkpatch.pl line 1529.
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#39: 
new file mode 100644

WARNING: line over 80 characters
#306: FILE: hw/virtio/virtio.c:4016:
+    monitor_printf(mon, "  signalled_used_valid: %d\n", s->signalled_used_valid);

ERROR: "foo * bar" should be "foo *bar"
#330: FILE: hw/virtio/virtio.c:4164:
+        type##FeatureList * list = features->u.field.features;              \

total: 1 errors, 2 warnings, 473 lines checked

Patch 6/6 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/1616084984-11263-1-git-send-email-jonah.palmer@oracle.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com