All of lore.kernel.org
 help / color / mirror / Atom feed
From: Patchwork <patchwork@emeril.freedesktop.org>
To: "Matt Roper" <matthew.d.roper@intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Disassociate display version from INTEL_GEN()
Date: Sat, 20 Mar 2021 05:09:18 -0000	[thread overview]
Message-ID: <161621695852.5020.565555582819733500@emeril.freedesktop.org> (raw)
In-Reply-To: <20210320044245.3920043-1-matthew.d.roper@intel.com>

== Series Details ==

Series: Disassociate display version from INTEL_GEN()
URL   : https://patchwork.freedesktop.org/series/88198/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
56a5c428be9d drm/i915/display: Convert gen5/gen6 tests to IS_IRONLAKE/IS_SANDYBRIDGE
-:130: CHECK:CAMELCASE: Avoid CamelCase: <ILK_eDP_A_DISABLE>
#130: FILE: drivers/gpu/drm/i915/display/intel_display.c:11604:
+	if (IS_IRONLAKE(dev_priv) && (intel_de_read(dev_priv, FUSE_STRAP) & ILK_eDP_A_DISABLE))

total: 0 errors, 0 warnings, 1 checks, 216 lines checked
f8b20ca1925b drm/i915: Add DISPLAY_VER() and related macros
-:73: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'i915' - possible side-effects?
#73: FILE: drivers/gpu/drm/i915/i915_drv.h:1245:
+#define IS_DISPLAY_RANGE(i915, from, until) \
+	(DISPLAY_VER(i915) >= (from) && DISPLAY_VER(i915) <= (until))

-:89: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'x' - possible side-effects?
#89: FILE: drivers/gpu/drm/i915/i915_pci.c:39:
+#define GEN(x) .gen = (x), .gen_mask = BIT((x) - 1), .display.version = (x)

total: 0 errors, 0 warnings, 2 checks, 27 lines checked
4135e2766a89 drm/i915/display: Eliminate most usage of INTEL_GEN()
-:2043: CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'port == PORT_E'
#2043: FILE: drivers/gpu/drm/i915/display/intel_display.c:6717:
+	if (DISPLAY_VER(dev_priv) < 9 &&
 	    (port == PORT_E) && intel_de_read(dev_priv, LPT_TRANSCONF) & TRANS_ENABLE) {

-:2631: WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (8, 63)
#2631: FILE: drivers/gpu/drm/i915/display/intel_display_debugfs.c:153:
+	if (DISPLAY_VER(dev_priv) >= 9)
 		/* no global SR status; inspect per-plane WM */;

-:4188: CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'intel_dp->psr_dpcd[0] == DP_PSR2_WITH_Y_COORD_IS_SUPPORTED'
#4188: FILE: drivers/gpu/drm/i915/display/intel_psr.c:324:
+	if (DISPLAY_VER(dev_priv) >= 9 &&
 	    (intel_dp->psr_dpcd[0] == DP_PSR2_WITH_Y_COORD_IS_SUPPORTED)) {

total: 0 errors, 1 warnings, 2 checks, 4216 lines checked
e0603202a0f8 drm/i915: Convert INTEL_GEN() to DISPLAY_VER() as appropriate in intel_pm.c
91f629e52c4d drm/i915: Convert INTEL_GEN() to DISPLAY_VER() as appropriate in i915_irq.c
a2afb96857c4 drm/i915/display: Simplify GLK display version tests


_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  parent reply	other threads:[~2021-03-20  5:09 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-20  4:42 [Intel-gfx] [PATCH 0/6] Disassociate display version from INTEL_GEN() Matt Roper
2021-03-20  4:42 ` [Intel-gfx] [PATCH 1/6] drm/i915/display: Convert gen5/gen6 tests to IS_IRONLAKE/IS_SANDYBRIDGE Matt Roper
2021-03-20  4:42 ` [Intel-gfx] [PATCH 2/6] drm/i915: Add DISPLAY_VER() and related macros Matt Roper
2021-03-23  5:37   ` Lucas De Marchi
2021-03-20  4:42 ` [Intel-gfx] [PATCH 3/6] drm/i915/display: Eliminate most usage of INTEL_GEN() Matt Roper
2021-03-23  5:45   ` Lucas De Marchi
2021-03-20  4:42 ` [Intel-gfx] [PATCH 4/6] drm/i915: Convert INTEL_GEN() to DISPLAY_VER() as appropriate in intel_pm.c Matt Roper
2021-03-20  4:42 ` [Intel-gfx] [PATCH 5/6] drm/i915: Convert INTEL_GEN() to DISPLAY_VER() as appropriate in i915_irq.c Matt Roper
2021-03-20  4:42 ` [Intel-gfx] [PATCH 6/6] drm/i915/display: Simplify GLK display version tests Matt Roper
2021-03-22 15:19   ` Ville Syrjälä
2021-03-22 19:48     ` [Intel-gfx] [PATCH v2 " Matt Roper
2021-03-22 19:50       ` [Intel-gfx] [PATCH v2.1 " Matt Roper
2021-03-22 21:16         ` Ville Syrjälä
2021-03-22 21:25           ` Matt Roper
2021-03-22 21:34             ` Ville Syrjälä
2021-03-22 23:38           ` [Intel-gfx] [PATCH v3 " Matt Roper
2021-03-23 17:25             ` Ville Syrjälä
2021-03-23 17:27               ` Matt Roper
2021-03-23 17:40                 ` Ville Syrjälä
2021-03-23 18:00                   ` Matt Roper
2021-03-20  5:09 ` Patchwork [this message]
2021-03-20  5:10 ` [Intel-gfx] ✗ Fi.CI.SPARSE: warning for Disassociate display version from INTEL_GEN() Patchwork
2021-03-20  5:43 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2021-03-20  6:56 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
2021-03-22 22:13 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Disassociate display version from INTEL_GEN() (rev3) Patchwork
2021-03-22 22:15 ` [Intel-gfx] ✗ Fi.CI.SPARSE: " Patchwork
2021-03-22 22:43 ` [Intel-gfx] ✗ Fi.CI.BAT: failure " Patchwork
2021-03-23  0:25 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Disassociate display version from INTEL_GEN() (rev4) Patchwork
2021-03-23  0:27 ` [Intel-gfx] ✗ Fi.CI.SPARSE: " Patchwork
2021-03-23  0:54 ` [Intel-gfx] ✗ Fi.CI.BAT: failure " Patchwork
2021-03-23  1:27 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Disassociate display version from INTEL_GEN() (rev5) Patchwork
2021-03-23  1:28 ` [Intel-gfx] ✗ Fi.CI.SPARSE: " Patchwork
2021-03-23  1:55 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2021-03-23 22:59 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
2021-03-23 23:55   ` Matt Roper

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=161621695852.5020.565555582819733500@emeril.freedesktop.org \
    --to=patchwork@emeril.freedesktop.org \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=matthew.d.roper@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.