Re: [PATCH for 6.0 v1 00/14] fixes for rc1 (kernel-doc, semihosting, testing)

[no-reply@patchew.org]

Patchew URL: https://patchew.org/QEMU/20210320133706.21475-1-alex.bennee@linaro.org/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: 20210320133706.21475-1-alex.bennee@linaro.org
Subject: [PATCH for 6.0 v1 00/14] fixes for rc1 (kernel-doc, semihosting, testing)

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 * [new tag]         patchew/20210320133706.21475-1-alex.bennee@linaro.org -> patchew/20210320133706.21475-1-alex.bennee@linaro.org
Switched to a new branch 'test'
2fe05ca utils: Work around mingw strto*l bug with 0x
c791580 utils: Tighter tests for qemu_strtosz
2b30091 cirrus.yml: Update the FreeBSD task to version 12.2
9a32f92 configure: Don't use the __atomic_*_16 functions for testing 128-bit support
411f58c gitlab-ci.yml: Merge the trace-backend testing into other jobs
f9008ed tests/tcg: add HeapInfo checking to semihosting test
c7fc498 linux-user/riscv: initialise the TaskState heap/stack info
64f8850 semihosting/arm-compat-semi: don't use SET_ARG to report SYS_HEAPINFO
4346991 semihosting/arm-compat-semi: unify GET/SET_ARG helpers
736c595 semihosting: move semihosting tests to multiarch
521038a tools/virtiofsd: include --socket-group in help
7a9f5fc docs/devel: expand style section of memory management
2d7c361 docs/devel: include the plugin API information from the headers
f4fed9c scripts/kernel-doc: strip QEMU_ from function definitions

=== OUTPUT BEGIN ===
1/14 Checking commit f4fed9c2b4ea (scripts/kernel-doc: strip QEMU_ from function definitions)
2/14 Checking commit 2d7c36108cba (docs/devel: include the plugin API information from the headers)
3/14 Checking commit 7a9f5fcce8d9 (docs/devel: expand style section of memory management)
4/14 Checking commit 521038a4b304 (tools/virtiofsd: include --socket-group in help)
5/14 Checking commit 736c59564aea (semihosting: move semihosting tests to multiarch)
6/14 Checking commit 4346991f6330 (semihosting/arm-compat-semi: unify GET/SET_ARG helpers)
7/14 Checking commit 64f885005bcc (semihosting/arm-compat-semi: don't use SET_ARG to report SYS_HEAPINFO)
8/14 Checking commit c7fc498483de (linux-user/riscv: initialise the TaskState heap/stack info)
9/14 Checking commit f9008edfe887 (tests/tcg: add HeapInfo checking to semihosting test)
10/14 Checking commit 411f58c7842f (gitlab-ci.yml: Merge the trace-backend testing into other jobs)
11/14 Checking commit 9a32f927b913 (configure: Don't use the __atomic_*_16 functions for testing 128-bit support)
12/14 Checking commit 2b30091c3c73 (cirrus.yml: Update the FreeBSD task to version 12.2)
13/14 Checking commit c7915804f46b (utils: Tighter tests for qemu_strtosz)
14/14 Checking commit 2fe05ca4258e (utils: Work around mingw strto*l bug with 0x)
ERROR: consider using qemu_strtol in preference to strtol
#144: FILE: util/cutils.c:409:
+        if (strtol(nptr, &tmp, 10) == 0 && errno == 0 &&

total: 1 errors, 0 warnings, 169 lines checked

Patch 14/14 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/20210320133706.21475-1-alex.bennee@linaro.org/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com