All of lore.kernel.org
 help / color / mirror / Atom feed
From: Robert Hoo <robert.hu@linux.intel.com>
To: pbonzini@redhat.com, richard.henderson@linaro.org, ehabkost@redhat.com
Cc: qemu-devel@nongnu.org, Robert Hoo <robert.hu@linux.intel.com>
Subject: [PATCH] i386/cpu_dump: support AVX512 ZMM regs dump
Date: Mon, 22 Mar 2021 18:59:56 +0800	[thread overview]
Message-ID: <1616410796-43167-1-git-send-email-robert.hu@linux.intel.com> (raw)

Since commit fa4518741e (target-i386: Rename struct XMMReg to ZMMReg),
CPUX86State.xmm_regs[] has already been extended to 512bit to support
AVX512.
Also, other qemu level supports for AVX512 registers are there for
years.
But in x86_cpu_dump_state(), still only dump XMM registers.
This patch is just to complement this part, let it dump ZMM of 512bits.

Signed-off-by: Robert Hoo <robert.hu@linux.intel.com>
---
 target/i386/cpu-dump.c | 23 +++++++++++++----------
 1 file changed, 13 insertions(+), 10 deletions(-)

diff --git a/target/i386/cpu-dump.c b/target/i386/cpu-dump.c
index aac21f1..789e774 100644
--- a/target/i386/cpu-dump.c
+++ b/target/i386/cpu-dump.c
@@ -499,17 +499,20 @@ void x86_cpu_dump_state(CPUState *cs, FILE *f, int flags)
             else
                 qemu_fprintf(f, " ");
         }
-        if (env->hflags & HF_CS64_MASK)
-            nb = 16;
-        else
-            nb = 8;
-        for(i=0;i<nb;i++) {
-            qemu_fprintf(f, "XMM%02d=%08x%08x%08x%08x",
+
+        nb = sizeof(env->xmm_regs) / sizeof(env->xmm_regs[0]);
+        for (i = 0; i < nb; i++) {
+            qemu_fprintf(f, "ZMM%02d=0x%016lx %016lx %016lx %016lx %016lx "
+                            "%016lx %016lx %016lx",
                          i,
-                         env->xmm_regs[i].ZMM_L(3),
-                         env->xmm_regs[i].ZMM_L(2),
-                         env->xmm_regs[i].ZMM_L(1),
-                         env->xmm_regs[i].ZMM_L(0));
+                         env->xmm_regs[i].ZMM_Q(7),
+                         env->xmm_regs[i].ZMM_Q(6),
+                         env->xmm_regs[i].ZMM_Q(5),
+                         env->xmm_regs[i].ZMM_Q(4),
+                         env->xmm_regs[i].ZMM_Q(3),
+                         env->xmm_regs[i].ZMM_Q(2),
+                         env->xmm_regs[i].ZMM_Q(1),
+                         env->xmm_regs[i].ZMM_Q(0));
             if ((i & 1) == 1)
                 qemu_fprintf(f, "\n");
             else
-- 
1.8.3.1



             reply	other threads:[~2021-03-22 11:02 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-22 10:59 Robert Hoo [this message]
2021-03-22 21:06 ` [PATCH] i386/cpu_dump: support AVX512 ZMM regs dump Richard Henderson
2021-03-23  7:00   ` Robert Hoo
2021-03-23 12:14     ` Richard Henderson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1616410796-43167-1-git-send-email-robert.hu@linux.intel.com \
    --to=robert.hu@linux.intel.com \
    --cc=ehabkost@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=richard.henderson@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.