From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 72321C433DB for ; Tue, 23 Mar 2021 07:15:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3F58661994 for ; Tue, 23 Mar 2021 07:15:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229804AbhCWHOd (ORCPT ); Tue, 23 Mar 2021 03:14:33 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39380 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230012AbhCWHOH (ORCPT ); Tue, 23 Mar 2021 03:14:07 -0400 Received: from mail-pg1-x52b.google.com (mail-pg1-x52b.google.com [IPv6:2607:f8b0:4864:20::52b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5EB68C061574 for ; Tue, 23 Mar 2021 00:14:07 -0700 (PDT) Received: by mail-pg1-x52b.google.com with SMTP id v3so10776775pgq.2 for ; Tue, 23 Mar 2021 00:14:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:content-transfer-encoding:in-reply-to:references :subject:from:cc:to:date:message-id:user-agent; bh=fYWO1UsVoh/R8XZE64RM/Jl8z5zWy63u5I7GZoSU3SQ=; b=Xo69Mt6/kL/aCKLvYa4Fwr/j/tKHmX3zlRj4mQ3UYyxt4TqESg+DiZQnhQRNho9iLu fndUjnKmf/vMdACOm13Pfy6MjDrsvVWzg8vDSZRIP26TGx6oNw3kzcRJL8lJXA2rZPFz VTrXDP9Vdje6a6md8xr1UxBXIy7JKO+7oGkgc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:content-transfer-encoding :in-reply-to:references:subject:from:cc:to:date:message-id :user-agent; bh=fYWO1UsVoh/R8XZE64RM/Jl8z5zWy63u5I7GZoSU3SQ=; b=n96++nNjOa7sARz53jQ73wxNfnlT+bUtHtsGq3sTxkHM/ylQpfhqrhigTCwOVCcqJe VMVJ1y2b3HvOqWJ2nRORKpFA2JeHnS8USD0E+zfFnw2cyvf2myV2QE3xqm9+btGoarnO Gp5CjrfF7k5YLy2gMMXwGyaNzWV8QveP2rEE10gfIIMVzU7k1vC92BlfgE2IOjXNs7Uq 5kq/Q7auovC4SMq8VdEZUs3/ItS5A6RdxGIlfLj2Lm3KgRAKevq75r3NQYLFMSEIUBIs prtgPCUWt1YHsK+4/QkYuWU4XpKOsfzdq9JVK9XI8DkVCJtW5eL3meKUWKmnCKcNJBmV V2WA== X-Gm-Message-State: AOAM533TbkN0ClGLwEKsGi4HdaGvPuu1HEq5JCWEcRWKCtIIO8TZu6gU Q+Oy4nsen8oQPhLHcsPeWvyqrOYMqbNzEA== X-Google-Smtp-Source: ABdhPJw9WwH3T40f83xyLQqcJ7XwWyC7xDQSJ3yvrXZrrL8RcVUYTZujJS7eHt23lV3STFi5M+ZCBQ== X-Received: by 2002:a17:902:7fc8:b029:e4:32af:32da with SMTP id t8-20020a1709027fc8b02900e432af32damr4224131plb.24.1616483646679; Tue, 23 Mar 2021 00:14:06 -0700 (PDT) Received: from chromium.org ([2620:15c:202:201:e90d:d453:87ae:2e10]) by smtp.gmail.com with ESMTPSA id o19sm3550978pgh.62.2021.03.23.00.14.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 23 Mar 2021 00:14:06 -0700 (PDT) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable In-Reply-To: <20210322030128.2283-6-laurent.pinchart+renesas@ideasonboard.com> References: <20210322030128.2283-1-laurent.pinchart+renesas@ideasonboard.com> <20210322030128.2283-6-laurent.pinchart+renesas@ideasonboard.com> Subject: Re: [RFC PATCH 05/11] drm/bridge: ti-sn65dsi86: Wrap panel with panel-bridge From: Stephen Boyd Cc: linux-renesas-soc@vger.kernel.org, Andrzej Hajda , Neil Armstrong , Jonas Karlman , Jernej Skrabec , Douglas Anderson To: Laurent Pinchart , dri-devel@lists.freedesktop.org Date: Tue, 23 Mar 2021 00:14:04 -0700 Message-ID: <161648364484.3012082.8827104507556270267@swboyd.mtv.corp.google.com> User-Agent: alot/0.9.1 Precedence: bulk List-ID: X-Mailing-List: linux-renesas-soc@vger.kernel.org Quoting Laurent Pinchart (2021-03-21 20:01:22) > diff --git a/drivers/gpu/drm/bridge/ti-sn65dsi86.c b/drivers/gpu/drm/brid= ge/ti-sn65dsi86.c > index 1d1be791d5ba..c21a7f7d452b 100644 > --- a/drivers/gpu/drm/bridge/ti-sn65dsi86.c > +++ b/drivers/gpu/drm/bridge/ti-sn65dsi86.c > @@ -418,8 +420,18 @@ static int ti_sn_bridge_attach(struct drm_bridge *br= idge, > } > pdata->dsi =3D dsi; > =20 > + /* Attach the next bridge */ > + ret =3D drm_bridge_attach(bridge->encoder, pdata->next_bridge, > + &pdata->bridge, flags); > + if (ret < 0) { > + DRM_ERROR("failed to attach next bridge\n"); Can this be pushed into drm_bridge_attach() instead of in each caller? > + goto err_dsi_detach; > + } > + > return 0; > =20 > +err_dsi_detach: > + mipi_dsi_detach(dsi); > err_dsi_attach: > mipi_dsi_device_unregister(dsi); > err_dsi_host: > static void ti_sn_bridge_post_disable(struct drm_bridge *bridge) > @@ -1245,6 +1249,14 @@ static int ti_sn_bridge_probe(struct i2c_client *c= lient, > return ret; > } > =20 > + pdata->next_bridge =3D devm_drm_panel_bridge_add(pdata->dev, > + pdata->panel); > + if (IS_ERR(pdata->next_bridge)) { > + DRM_ERROR("failed to create panel bridge\n"); > + ret =3D PTR_ERR(pdata->next_bridge); > + return ret; Just return PTR_ERR(pdata->next_bridge)? > + } > + > dev_set_drvdata(&client->dev, pdata); From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B6A3BC433C1 for ; Tue, 23 Mar 2021 07:14:08 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7584E619AB for ; Tue, 23 Mar 2021 07:14:08 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7584E619AB Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id DC38A6E833; Tue, 23 Mar 2021 07:14:07 +0000 (UTC) Received: from mail-pf1-x42e.google.com (mail-pf1-x42e.google.com [IPv6:2607:f8b0:4864:20::42e]) by gabe.freedesktop.org (Postfix) with ESMTPS id F325E6E833 for ; Tue, 23 Mar 2021 07:14:06 +0000 (UTC) Received: by mail-pf1-x42e.google.com with SMTP id h3so13346412pfr.12 for ; Tue, 23 Mar 2021 00:14:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:content-transfer-encoding:in-reply-to:references :subject:from:cc:to:date:message-id:user-agent; bh=fYWO1UsVoh/R8XZE64RM/Jl8z5zWy63u5I7GZoSU3SQ=; b=Xo69Mt6/kL/aCKLvYa4Fwr/j/tKHmX3zlRj4mQ3UYyxt4TqESg+DiZQnhQRNho9iLu fndUjnKmf/vMdACOm13Pfy6MjDrsvVWzg8vDSZRIP26TGx6oNw3kzcRJL8lJXA2rZPFz VTrXDP9Vdje6a6md8xr1UxBXIy7JKO+7oGkgc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:content-transfer-encoding :in-reply-to:references:subject:from:cc:to:date:message-id :user-agent; bh=fYWO1UsVoh/R8XZE64RM/Jl8z5zWy63u5I7GZoSU3SQ=; b=LyC3IhNvuFICwRk1VgE1wIqPiyfp6D6vyv2koLllDsz0ahSe8XHqC0filnIZ5HxvwO lH+jBlzvVugQ+D3rTA9In6w2VWDHTJgNLuc4nN2Al6oyFQPLMxfC5W07+BjF32rEzOu6 IQNsa5snd+xF/kRLYJI4pckr9HCI1Xg7W7d2e8Oer+w/zD+3Haa35JTIT5faBjQfZSc+ Z6QRRD1Vg0KC3Pn6BUWpSMYY8ggAOHfQQ8o0YJijL8u35WLpY8Ruj5nJbCLr44PjyHbc gG4yilucGJOb1W9ozumPDs0ZeQExb9Z13qIJm3nABxcXSFneQrSoDnXo3h+iLI7Wjm8u fYZA== X-Gm-Message-State: AOAM530yB1GUjU8EODOfrMF3DsCS+sxTtWem/C+fKsYZwZXbA1Ec71BJ i0ykS0d2gycDcK2yMEty4zvzSQ== X-Google-Smtp-Source: ABdhPJw9WwH3T40f83xyLQqcJ7XwWyC7xDQSJ3yvrXZrrL8RcVUYTZujJS7eHt23lV3STFi5M+ZCBQ== X-Received: by 2002:a17:902:7fc8:b029:e4:32af:32da with SMTP id t8-20020a1709027fc8b02900e432af32damr4224131plb.24.1616483646679; Tue, 23 Mar 2021 00:14:06 -0700 (PDT) Received: from chromium.org ([2620:15c:202:201:e90d:d453:87ae:2e10]) by smtp.gmail.com with ESMTPSA id o19sm3550978pgh.62.2021.03.23.00.14.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 23 Mar 2021 00:14:06 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <20210322030128.2283-6-laurent.pinchart+renesas@ideasonboard.com> References: <20210322030128.2283-1-laurent.pinchart+renesas@ideasonboard.com> <20210322030128.2283-6-laurent.pinchart+renesas@ideasonboard.com> Subject: Re: [RFC PATCH 05/11] drm/bridge: ti-sn65dsi86: Wrap panel with panel-bridge From: Stephen Boyd To: Laurent Pinchart , dri-devel@lists.freedesktop.org Date: Tue, 23 Mar 2021 00:14:04 -0700 Message-ID: <161648364484.3012082.8827104507556270267@swboyd.mtv.corp.google.com> User-Agent: alot/0.9.1 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Jernej Skrabec , Jonas Karlman , Neil Armstrong , Douglas Anderson , linux-renesas-soc@vger.kernel.org, Andrzej Hajda Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Quoting Laurent Pinchart (2021-03-21 20:01:22) > diff --git a/drivers/gpu/drm/bridge/ti-sn65dsi86.c b/drivers/gpu/drm/bridge/ti-sn65dsi86.c > index 1d1be791d5ba..c21a7f7d452b 100644 > --- a/drivers/gpu/drm/bridge/ti-sn65dsi86.c > +++ b/drivers/gpu/drm/bridge/ti-sn65dsi86.c > @@ -418,8 +420,18 @@ static int ti_sn_bridge_attach(struct drm_bridge *bridge, > } > pdata->dsi = dsi; > > + /* Attach the next bridge */ > + ret = drm_bridge_attach(bridge->encoder, pdata->next_bridge, > + &pdata->bridge, flags); > + if (ret < 0) { > + DRM_ERROR("failed to attach next bridge\n"); Can this be pushed into drm_bridge_attach() instead of in each caller? > + goto err_dsi_detach; > + } > + > return 0; > > +err_dsi_detach: > + mipi_dsi_detach(dsi); > err_dsi_attach: > mipi_dsi_device_unregister(dsi); > err_dsi_host: > static void ti_sn_bridge_post_disable(struct drm_bridge *bridge) > @@ -1245,6 +1249,14 @@ static int ti_sn_bridge_probe(struct i2c_client *client, > return ret; > } > > + pdata->next_bridge = devm_drm_panel_bridge_add(pdata->dev, > + pdata->panel); > + if (IS_ERR(pdata->next_bridge)) { > + DRM_ERROR("failed to create panel bridge\n"); > + ret = PTR_ERR(pdata->next_bridge); > + return ret; Just return PTR_ERR(pdata->next_bridge)? > + } > + > dev_set_drvdata(&client->dev, pdata); _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel