From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 759A4C433DB for ; Mon, 29 Mar 2021 19:35:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 463FE61981 for ; Mon, 29 Mar 2021 19:35:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231793AbhC2Tey (ORCPT ); Mon, 29 Mar 2021 15:34:54 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55090 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231794AbhC2Tel (ORCPT ); Mon, 29 Mar 2021 15:34:41 -0400 Received: from mail-pl1-x630.google.com (mail-pl1-x630.google.com [IPv6:2607:f8b0:4864:20::630]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A6E95C061574 for ; Mon, 29 Mar 2021 12:34:40 -0700 (PDT) Received: by mail-pl1-x630.google.com with SMTP id o2so4901966plg.1 for ; Mon, 29 Mar 2021 12:34:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:content-transfer-encoding:in-reply-to:references :subject:from:cc:to:date:message-id:user-agent; bh=4/AjcviJM+MN/+F8Vy+FJ7ln76QoDZiyxq5y8TMSkpE=; b=L2srLFum8RmHEw+td2eI6LO1Ehlsob/6OnhmJPb9xldC56tHgR9+SpUmCCf4q83+i/ abpeKNTf2iWhHwOZeBskvs1/5uO2FaxsbGpMUyX7XzNaLvu3vJXjkylw0SYu48LWzpcn zChuKzk+1zZOYVBoZ/6n6BgjKUhdio/7Mzv7E= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:content-transfer-encoding :in-reply-to:references:subject:from:cc:to:date:message-id :user-agent; bh=4/AjcviJM+MN/+F8Vy+FJ7ln76QoDZiyxq5y8TMSkpE=; b=Xmt43fFHyF2DpiqVeLGnW+6nGTcEEI9/kxt3G25DUi77qwo/EF8KNpV3ipmoMRGs4i xUdbrgdvD9G1WfN2LgBwJdL6hdtvLOsTn6QB4Z+OuVXI1r+Apm0HKJNBVV+p5qMwR4MJ bFh4vX4hbGo9fsiXJlyiVbli4+7MvMU2kVnGIKS/XIgEBjjQMappQDAjEjdZY36o0FU0 opCCA/vAi2UK3lM8401ZbJWnZ74EZmIONCzlWNXKvQjwh3+U79II0Ckm0OXWEiZarT73 VzhV/XLV0eyy8VqT8VthIDc5cxzH9H7H8sd+dRFkEZe3xuvJWxXfXlZTaeGcuTVSS8am imBA== X-Gm-Message-State: AOAM531FVsmWiLVakO4oetvNRkqT5BzD7A7qOQIGAc2HBYd01cNDrkj4 H00I+lVLOddaxY6aoTbLPWH9qA== X-Google-Smtp-Source: ABdhPJz3TidD50Ag7Kik9OP4JEultVxXJ9TyLE4CvKWcc8IlgTj554nkINbgbuyrv1G2biVaUOu2sA== X-Received: by 2002:a17:90a:66c2:: with SMTP id z2mr673191pjl.139.1617046480184; Mon, 29 Mar 2021 12:34:40 -0700 (PDT) Received: from chromium.org ([2620:15c:202:201:4091:2b37:966b:1fca]) by smtp.gmail.com with ESMTPSA id cp22sm323225pjb.15.2021.03.29.12.34.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 29 Mar 2021 12:34:39 -0700 (PDT) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable In-Reply-To: <5cd274f98b38d4b85c1ce212720b6b680f4a00f0.1616651305.git.schowdhu@codeaurora.org> References: <5cd274f98b38d4b85c1ce212720b6b680f4a00f0.1616651305.git.schowdhu@codeaurora.org> Subject: Re: [PATCH V2 1/5] dt-bindings: Added the yaml bindings for DCC From: Stephen Boyd Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, Sai Prakash Ranjan , Sibi Sankar , Rajendra Nayak , vkoul@kernel.org, Souradeep Chowdhury To: Andy Gross , Bjorn Andersson , Rob Herring , Souradeep Chowdhury Date: Mon, 29 Mar 2021 12:34:38 -0700 Message-ID: <161704647819.3012082.13027529193947275446@swboyd.mtv.corp.google.com> User-Agent: alot/0.9.1 Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org Quoting Souradeep Chowdhury (2021-03-25 01:02:32) > diff --git a/Documentation/devicetree/bindings/arm/msm/qcom,dcc.yaml b/Do= cumentation/devicetree/bindings/arm/msm/qcom,dcc.yaml > new file mode 100644 > index 0000000..c6e0a9c > --- /dev/null > +++ b/Documentation/devicetree/bindings/arm/msm/qcom,dcc.yaml > @@ -0,0 +1,49 @@ > +# SPDX-License-Identifier: (GPL-2.0-or-later OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/arm/msm/qcom,dcc.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Data Capture and Compare > + > +maintainers: > + - Souradeep Chowdhury > + > +description: | > + DCC (Data Capture and Compare) is a DMA engine which is used to save > + configuration data or system memory contents during catastrophic fai= lure > + or SW trigger.DCC is used to capture and store data for debugging pu= rpose Add space between trigger. and DCC? > + > + Drop double newline? > +properties: > + compatible: > + items: > + - enum: > + - qcom,sm8150-dcc > + - const: qcom,dcc > + > + reg: > + items: > + - description: DCC base register region > + - description: DCC RAM base register region > + > + reg-names: > + items: > + - const: dcc > + - const: dcc-ram > + > +required: > + - compatible > + - reg > + - reg-names Do we really need reg names? Seems like we can assume the ordering. > + > +additionalProperties: false > + > +examples: > + - | > + dcc@10a2000{ dma@10a2000? Or debug@10a2000? > + compatible =3D "qcom,sm8150-dcc","qcom,dcc"; > + reg =3D <0x010a2000 0x1000>, > + <0x010ad000 0x2000>; > + reg-names =3D "dcc", "dcc-ram"; > + }; From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CF5AFC433DB for ; Tue, 30 Mar 2021 00:37:28 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 509AA61935 for ; Tue, 30 Mar 2021 00:37:28 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 509AA61935 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Message-ID:Date:To:Cc:From:Subject:References: In-Reply-To:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Hp35f1HLLiyd2n9wnoVPxrK4FGDTTvTEt6EXLvMuLdo=; b=BEqiMx4FwKDHyfss9eTFaSLT7 V8P9DGApjbPyfQ7qonhyiQ+UQwygd1E+76POSJnrHLtxqvfsUHq4LRbOwYyoO++X9vj6x02o/jB5l vrb2kX6HvxgE9bzv1itQJABntw0hgpPUdAjPwuu0KnZwRX+6IWnRsaaNuLDuW+pQCsb/zQF098m0T Gw1IBa976u0lFyavA1KYV5LYkGoIy6E4p8opkJVuAE5XHs174lK00MeBSEHAd0i6h+GqzHwUbL8ba gGNZ9iBXtddTaSM/+HaQwYnTiBoAHoXGGS49LaBEbY4CnuOjVENy+kSCJnHs5ynZB5u8/K1u/HsRd yZyPVXkgA==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lR2ME-002Br3-W3; Tue, 30 Mar 2021 00:35:47 +0000 Received: from mail-pl1-x633.google.com ([2607:f8b0:4864:20::633]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lQxew-001Gdf-SL for linux-arm-kernel@lists.infradead.org; Mon, 29 Mar 2021 19:35:18 +0000 Received: by mail-pl1-x633.google.com with SMTP id h8so4900721plt.7 for ; Mon, 29 Mar 2021 12:34:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:content-transfer-encoding:in-reply-to:references :subject:from:cc:to:date:message-id:user-agent; bh=4/AjcviJM+MN/+F8Vy+FJ7ln76QoDZiyxq5y8TMSkpE=; b=L2srLFum8RmHEw+td2eI6LO1Ehlsob/6OnhmJPb9xldC56tHgR9+SpUmCCf4q83+i/ abpeKNTf2iWhHwOZeBskvs1/5uO2FaxsbGpMUyX7XzNaLvu3vJXjkylw0SYu48LWzpcn zChuKzk+1zZOYVBoZ/6n6BgjKUhdio/7Mzv7E= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:content-transfer-encoding :in-reply-to:references:subject:from:cc:to:date:message-id :user-agent; bh=4/AjcviJM+MN/+F8Vy+FJ7ln76QoDZiyxq5y8TMSkpE=; b=JU7+QchlLe1AKK/nsGr/0YaOG4hHBLUVFHUCzxtL7hXtgxoAK2SIM79/OpOHBVMgpb RhV9dYjBQTOdjo60rLItC1+l+vEYDXpId5Wog6U0n+FsfquIEq0hAfHP2SbOHLicbV9K qprKyIWmGC2WXHsRhXdglPiGg4vqMim/VxpTHUQB47Hi9M+kHjpUF2+7CqQEQ/uZeSnE w0IKN7I8FAIFD+m438OpNgwWnDpFvTwVpGSaLK+WA7fOWX/kDPo8mi61Crg0mT96Tjod utA/0ooFmu1Qd5gxKAj2sHcShbC1WGy+SyLdw3IvrQ6GlmfBpW3PM7KY/1Iw8CiH4N7J A+lw== X-Gm-Message-State: AOAM532RiIJFBJ3wbh4ssjbfW7KyiGCoBUNv/+vLGOnh5zsTQwE8AHSH BOfNUJQKt0Q8fhSQgVnRnqn3UpvlDNNBCw== X-Google-Smtp-Source: ABdhPJz3TidD50Ag7Kik9OP4JEultVxXJ9TyLE4CvKWcc8IlgTj554nkINbgbuyrv1G2biVaUOu2sA== X-Received: by 2002:a17:90a:66c2:: with SMTP id z2mr673191pjl.139.1617046480184; Mon, 29 Mar 2021 12:34:40 -0700 (PDT) Received: from chromium.org ([2620:15c:202:201:4091:2b37:966b:1fca]) by smtp.gmail.com with ESMTPSA id cp22sm323225pjb.15.2021.03.29.12.34.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 29 Mar 2021 12:34:39 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <5cd274f98b38d4b85c1ce212720b6b680f4a00f0.1616651305.git.schowdhu@codeaurora.org> References: <5cd274f98b38d4b85c1ce212720b6b680f4a00f0.1616651305.git.schowdhu@codeaurora.org> Subject: Re: [PATCH V2 1/5] dt-bindings: Added the yaml bindings for DCC From: Stephen Boyd Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, Sai Prakash Ranjan , Sibi Sankar , Rajendra Nayak , vkoul@kernel.org, Souradeep Chowdhury To: Andy Gross , Bjorn Andersson , Rob Herring , Souradeep Chowdhury Date: Mon, 29 Mar 2021 12:34:38 -0700 Message-ID: <161704647819.3012082.13027529193947275446@swboyd.mtv.corp.google.com> User-Agent: alot/0.9.1 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210329_203515_137149_9E659D3A X-CRM114-Status: GOOD ( 14.70 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Quoting Souradeep Chowdhury (2021-03-25 01:02:32) > diff --git a/Documentation/devicetree/bindings/arm/msm/qcom,dcc.yaml b/Documentation/devicetree/bindings/arm/msm/qcom,dcc.yaml > new file mode 100644 > index 0000000..c6e0a9c > --- /dev/null > +++ b/Documentation/devicetree/bindings/arm/msm/qcom,dcc.yaml > @@ -0,0 +1,49 @@ > +# SPDX-License-Identifier: (GPL-2.0-or-later OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/arm/msm/qcom,dcc.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Data Capture and Compare > + > +maintainers: > + - Souradeep Chowdhury > + > +description: | > + DCC (Data Capture and Compare) is a DMA engine which is used to save > + configuration data or system memory contents during catastrophic failure > + or SW trigger.DCC is used to capture and store data for debugging purpose Add space between trigger. and DCC? > + > + Drop double newline? > +properties: > + compatible: > + items: > + - enum: > + - qcom,sm8150-dcc > + - const: qcom,dcc > + > + reg: > + items: > + - description: DCC base register region > + - description: DCC RAM base register region > + > + reg-names: > + items: > + - const: dcc > + - const: dcc-ram > + > +required: > + - compatible > + - reg > + - reg-names Do we really need reg names? Seems like we can assume the ordering. > + > +additionalProperties: false > + > +examples: > + - | > + dcc@10a2000{ dma@10a2000? Or debug@10a2000? > + compatible = "qcom,sm8150-dcc","qcom,dcc"; > + reg = <0x010a2000 0x1000>, > + <0x010ad000 0x2000>; > + reg-names = "dcc", "dcc-ram"; > + }; _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel