From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 068BEC433C1 for ; Tue, 30 Mar 2021 02:01:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id CB02161990 for ; Tue, 30 Mar 2021 02:01:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230381AbhC3CBO (ORCPT ); Mon, 29 Mar 2021 22:01:14 -0400 Received: from mail.kernel.org ([198.145.29.99]:43930 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230467AbhC3CBB (ORCPT ); Mon, 29 Mar 2021 22:01:01 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 578726193A; Tue, 30 Mar 2021 02:01:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1617069661; bh=tPB7I98WMiY4qUDzrZwfnJOg5RGmk1XF+lQBzxV+12M=; h=In-Reply-To:References:Subject:From:Cc:To:Date:From; b=HLJ/CrQx+D1nZMt8Mo7t4MP4iaRDIKYME6Emjyu7efBoa9rA7riDU8sDf9p5HztY6 CGST2pfmufMD6sAF/jcTnSibKKmAmi9RIVStio33IqczDSj5HCGab62M/oAy//BHpj /j+fYx5aDMpQbjYu5s83L/0I5ujXX0OUCE0qtLf+Z+9k9vPp0DnRX6jUHVhNWsTdzD A21CWGkFVL7wdZs7CKFDpiHePeE974XvF6QjfAGMppP1BuVq2xUKRZxutcrFBRSpLg lX4yBAzfcVSlwU1CT3eNWG6y0jvDbjZuxr7mD6+TKuDyp74fo5wgzrNgBy0uqpcjhC i5UJRed8vtauA== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable In-Reply-To: <20210325075018.6598-1-avolmat@me.com> References: <20210325075018.6598-1-avolmat@me.com> Subject: Re: [PATCH v2 00/16] clk: st: embed clock outputs within drivers From: Stephen Boyd Cc: Lee Jones , linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Alain Volmat To: Alain Volmat , Michael Turquette , Patrice Chotard , Rob Herring Date: Mon, 29 Mar 2021 19:01:00 -0700 Message-ID: <161706966003.3012082.13602640109563561014@swboyd.mtv.corp.google.com> User-Agent: alot/0.9.1 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Quoting Alain Volmat (2021-03-25 00:50:02) > Most of ST clock drivers used by STi platform are updated in > order to introduce clock outputs informations within each drivers > and thus allow to avoid having to rely on clock-output-names properties > within DT clock nodes. > For that purpose, drivers are updated to allow handling both modes > (with or without clock-output-names). > Once all DT will have been updated, the legacy mode could be removed > from the drivers. > This will also allow, once all STi DT will be corrected, to remove the > of_clk_detect_critical API from clk core code since STi clock drivers > are the only drivers using this API. >=20 > This serie also contains modifications within STi DTS in order to use > the newly introduced compatible and remove clock-output-names > properties. Can you split the dts changes from the driver changes and only send the clk driver changes to clk maintainers? I don't intend to apply dts file changes to the clk tree. Those can go via arm-soc based on some immutable branch that lives in clk tree until next merge window closes. >=20 > Alain Volmat (16): > clk: st: clkgen-pll: remove used variable of struct clkgen_pll > clk: st: flexgen: embed soc clock outputs within compatible data > dt-bindings: clock: st: flexgen: add new introduced compatible > clk: st: clkgen-pll: embed soc clock outputs within compatible data > dt-bindings: clock: st: clkgen-pll: add new introduced compatible > clk: st: clkgen-fsyn: embed soc clock outputs within compatible data > dt-bindings: clock: st: clkgen-fsyn: add new introduced compatible > ARM: dts: sti: update flexgen compatible within stih418-clock > ARM: dts: sti: update flexgen compatible within stih407-clock > ARM: dts: sti: update flexgen compatible within stih410-clock > ARM: dts: sti: update clkgen-pll entries in stih407-clock > ARM: dts: sti: update clkgen-pll entries in stih410-clock > ARM: dts: sti: update clkgen-pll entries in stih418-clock > ARM: dts: sti: update clkgen-fsyn entries in stih407-clock > ARM: dts: sti: update clkgen-fsyn entries in stih410-clock > ARM: dts: sti: update clkgen-fsyn entries in stih418-clock >=20 > .../bindings/clock/st/st,clkgen-pll.txt | 3 + > .../bindings/clock/st/st,flexgen.txt | 10 + > .../bindings/clock/st/st,quadfs.txt | 3 + > arch/arm/boot/dts/stih407-clock.dtsi | 128 +------ > arch/arm/boot/dts/stih410-clock.dtsi | 138 +------ > arch/arm/boot/dts/stih418-clock.dtsi | 136 +------ > drivers/clk/st/clk-flexgen.c | 344 +++++++++++++++++- > drivers/clk/st/clkgen-fsyn.c | 113 +++++- > drivers/clk/st/clkgen-pll.c | 121 +++++- > 9 files changed, 588 insertions(+), 408 deletions(-) >=20 > --- > v2: fix drivers to update some clocks as CLK_IS_CRITICAL >=20 Please document in the code why CLK_IS_CRITICAL is used. For example, "This clk needs to be on so the CPU can keep fetching instructions from memory" or something like that. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2668BC433DB for ; Tue, 30 Mar 2021 02:10:36 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A8530617C9 for ; Tue, 30 Mar 2021 02:10:35 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A8530617C9 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Message-ID:Date:To:Cc:From:Subject:References: In-Reply-To:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=+szMvQXyVKpl4782aRYDgKP7EkEgN5Yz779li0fftOQ=; b=l9iH+d+/b1dYhtucSSjzEnpMm e7jw6mvvXQ5MJOD8aa9jwmtFVctZapzN8Bjf71gN2mtUpL6kqMT+rQ3jcB2gJoezTJMnJsrldU/mL IynV3aidT2FO+YR4aQwzlakjlKdwRj9E2IumufUmOomUgFQQSWG/PSr/DE5FsHWTfKOnfMkcgQPDy Y3PmE6m5a1YbID9NzfXrRmjwbdWAdVHI1GdJmftmsdNyOmNFTavxHGbFo3Tu8quuuJiKuTZ56sf4A rr1K97vmEme25GXgYYkQIxyMOc28DJWDxG943zDYsxv1LAOSByH9LfA1zsx5P7uv+ig/0w5CTfCal t0pGQGY1w==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lR3o0-002Pv4-Sx; Tue, 30 Mar 2021 02:08:33 +0000 Received: from mail.kernel.org ([198.145.29.99]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lR3gl-002P89-55 for linux-arm-kernel@lists.infradead.org; Tue, 30 Mar 2021 02:01:07 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id 578726193A; Tue, 30 Mar 2021 02:01:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1617069661; bh=tPB7I98WMiY4qUDzrZwfnJOg5RGmk1XF+lQBzxV+12M=; h=In-Reply-To:References:Subject:From:Cc:To:Date:From; b=HLJ/CrQx+D1nZMt8Mo7t4MP4iaRDIKYME6Emjyu7efBoa9rA7riDU8sDf9p5HztY6 CGST2pfmufMD6sAF/jcTnSibKKmAmi9RIVStio33IqczDSj5HCGab62M/oAy//BHpj /j+fYx5aDMpQbjYu5s83L/0I5ujXX0OUCE0qtLf+Z+9k9vPp0DnRX6jUHVhNWsTdzD A21CWGkFVL7wdZs7CKFDpiHePeE974XvF6QjfAGMppP1BuVq2xUKRZxutcrFBRSpLg lX4yBAzfcVSlwU1CT3eNWG6y0jvDbjZuxr7mD6+TKuDyp74fo5wgzrNgBy0uqpcjhC i5UJRed8vtauA== MIME-Version: 1.0 In-Reply-To: <20210325075018.6598-1-avolmat@me.com> References: <20210325075018.6598-1-avolmat@me.com> Subject: Re: [PATCH v2 00/16] clk: st: embed clock outputs within drivers From: Stephen Boyd Cc: Lee Jones , linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Alain Volmat To: Alain Volmat , Michael Turquette , Patrice Chotard , Rob Herring Date: Mon, 29 Mar 2021 19:01:00 -0700 Message-ID: <161706966003.3012082.13602640109563561014@swboyd.mtv.corp.google.com> User-Agent: alot/0.9.1 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210330_030105_200568_977FBFE0 X-CRM114-Status: GOOD ( 18.16 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Quoting Alain Volmat (2021-03-25 00:50:02) > Most of ST clock drivers used by STi platform are updated in > order to introduce clock outputs informations within each drivers > and thus allow to avoid having to rely on clock-output-names properties > within DT clock nodes. > For that purpose, drivers are updated to allow handling both modes > (with or without clock-output-names). > Once all DT will have been updated, the legacy mode could be removed > from the drivers. > This will also allow, once all STi DT will be corrected, to remove the > of_clk_detect_critical API from clk core code since STi clock drivers > are the only drivers using this API. > > This serie also contains modifications within STi DTS in order to use > the newly introduced compatible and remove clock-output-names > properties. Can you split the dts changes from the driver changes and only send the clk driver changes to clk maintainers? I don't intend to apply dts file changes to the clk tree. Those can go via arm-soc based on some immutable branch that lives in clk tree until next merge window closes. > > Alain Volmat (16): > clk: st: clkgen-pll: remove used variable of struct clkgen_pll > clk: st: flexgen: embed soc clock outputs within compatible data > dt-bindings: clock: st: flexgen: add new introduced compatible > clk: st: clkgen-pll: embed soc clock outputs within compatible data > dt-bindings: clock: st: clkgen-pll: add new introduced compatible > clk: st: clkgen-fsyn: embed soc clock outputs within compatible data > dt-bindings: clock: st: clkgen-fsyn: add new introduced compatible > ARM: dts: sti: update flexgen compatible within stih418-clock > ARM: dts: sti: update flexgen compatible within stih407-clock > ARM: dts: sti: update flexgen compatible within stih410-clock > ARM: dts: sti: update clkgen-pll entries in stih407-clock > ARM: dts: sti: update clkgen-pll entries in stih410-clock > ARM: dts: sti: update clkgen-pll entries in stih418-clock > ARM: dts: sti: update clkgen-fsyn entries in stih407-clock > ARM: dts: sti: update clkgen-fsyn entries in stih410-clock > ARM: dts: sti: update clkgen-fsyn entries in stih418-clock > > .../bindings/clock/st/st,clkgen-pll.txt | 3 + > .../bindings/clock/st/st,flexgen.txt | 10 + > .../bindings/clock/st/st,quadfs.txt | 3 + > arch/arm/boot/dts/stih407-clock.dtsi | 128 +------ > arch/arm/boot/dts/stih410-clock.dtsi | 138 +------ > arch/arm/boot/dts/stih418-clock.dtsi | 136 +------ > drivers/clk/st/clk-flexgen.c | 344 +++++++++++++++++- > drivers/clk/st/clkgen-fsyn.c | 113 +++++- > drivers/clk/st/clkgen-pll.c | 121 +++++- > 9 files changed, 588 insertions(+), 408 deletions(-) > > --- > v2: fix drivers to update some clocks as CLK_IS_CRITICAL > Please document in the code why CLK_IS_CRITICAL is used. For example, "This clk needs to be on so the CPU can keep fetching instructions from memory" or something like that. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel