* [PATCH] platform/chrome: wilco_ec: convert stream-like files from nonseekable_open -> stream_open
@ 2021-02-07 9:08 Yang Li
2021-03-31 7:37 ` Enric Balletbo i Serra
0 siblings, 1 reply; 2+ messages in thread
From: Yang Li @ 2021-02-07 9:08 UTC (permalink / raw)
To: bleung; +Cc: enric.balletbo, linux-kernel, Yang Li
Eliminate the following coccicheck warning:
./drivers/platform/chrome/wilco_ec/telemetry.c:259:1-17: WARNING:
telem_fops: .read() and .write() have stream semantic; safe to change
nonseekable_open -> stream_open.
Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
---
drivers/platform/chrome/wilco_ec/telemetry.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/platform/chrome/wilco_ec/telemetry.c b/drivers/platform/chrome/wilco_ec/telemetry.c
index e06d96f..60da7a2 100644
--- a/drivers/platform/chrome/wilco_ec/telemetry.c
+++ b/drivers/platform/chrome/wilco_ec/telemetry.c
@@ -256,7 +256,7 @@ static int telem_open(struct inode *inode, struct file *filp)
sess_data->dev_data = dev_data;
sess_data->has_msg = false;
- nonseekable_open(inode, filp);
+ stream_open(inode, filp);
filp->private_data = sess_data;
return 0;
--
1.8.3.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] platform/chrome: wilco_ec: convert stream-like files from nonseekable_open -> stream_open
2021-02-07 9:08 [PATCH] platform/chrome: wilco_ec: convert stream-like files from nonseekable_open -> stream_open Yang Li
@ 2021-03-31 7:37 ` Enric Balletbo i Serra
0 siblings, 0 replies; 2+ messages in thread
From: Enric Balletbo i Serra @ 2021-03-31 7:37 UTC (permalink / raw)
To: Yang Li, bleung; +Cc: linux-kernel
On Sun, 7 Feb 2021 17:08:38 +0800, Yang Li wrote:
> Eliminate the following coccicheck warning:
> ./drivers/platform/chrome/wilco_ec/telemetry.c:259:1-17: WARNING:
> telem_fops: .read() and .write() have stream semantic; safe to change
> nonseekable_open -> stream_open.
Applied, thanks!
[1/1] platform/chrome: wilco_ec: convert stream-like files from nonseekable_open -> stream_open
commit: dbc334fb411f2e87ca0e812dc7ba13464aa89504
Best regards,
--
Enric Balletbo i Serra <enric.balletbo@collabora.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-03-31 7:38 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-02-07 9:08 [PATCH] platform/chrome: wilco_ec: convert stream-like files from nonseekable_open -> stream_open Yang Li
2021-03-31 7:37 ` Enric Balletbo i Serra
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.