From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY, USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id ADBB2C433DB for ; Wed, 31 Mar 2021 08:31:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8448F619DA for ; Wed, 31 Mar 2021 08:31:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233140AbhCaIbM (ORCPT ); Wed, 31 Mar 2021 04:31:12 -0400 Received: from mailgw02.mediatek.com ([1.203.163.81]:6035 "EHLO mailgw02.mediatek.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S231172AbhCaIbC (ORCPT ); Wed, 31 Mar 2021 04:31:02 -0400 X-UUID: 3850fc3b5091490a92c4b838fc5deb04-20210331 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=W3q5DAk4wjiboZB+4xm4r+D77u+vIj/xKBGT22s32q4=; b=P3tlUBa1Wl0b+SOqp9657Xsv25LXjXJL8x5LVHWExBGTQi1DM5TDydDf2yaZTopcyjecIfaGlivcxMxlbX311BW40n8+SMFhTMETys7fCHHwKrkhakzwd/7rC5EYEyzzCAYVRyUw3/ig/un6k8VEnAUETDqz2DgNqXtyXSCauu4=; X-UUID: 3850fc3b5091490a92c4b838fc5deb04-20210331 Received: from mtkcas32.mediatek.inc [(172.27.4.253)] by mailgw02.mediatek.com (envelope-from ) (mailgw01.mediatek.com ESMTP with TLSv1.2 ECDHE-RSA-AES256-SHA384 256/256) with ESMTP id 711188797; Wed, 31 Mar 2021 16:30:59 +0800 Received: from MTKCAS32.mediatek.inc (172.27.4.184) by MTKMBS31N2.mediatek.inc (172.27.4.87) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Wed, 31 Mar 2021 16:30:55 +0800 Received: from [10.17.3.153] (10.17.3.153) by MTKCAS32.mediatek.inc (172.27.4.170) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Wed, 31 Mar 2021 16:30:55 +0800 Message-ID: <1617179455.2752.1.camel@mhfsdcap03> Subject: Re: [PATCH 1/2] usb: xhci-mtk: remove unnecessary assignments in periodic TT scheduler From: Chunfeng Yun To: Ikjoon Jang , Yaqii Wu CC: , Greg Kroah-Hartman , Mathias Nyman , Matthias Brugger , , , Date: Wed, 31 Mar 2021 16:30:55 +0800 In-Reply-To: <20210330160508.1.I797d214790033d0402d19ff6b47a34aff60d3062@changeid> References: <20210330080617.3746932-1-ikjn@chromium.org> <20210330160508.1.I797d214790033d0402d19ff6b47a34aff60d3062@changeid> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.10.4-0ubuntu2 MIME-Version: 1.0 X-TM-SNTS-SMTP: BC6F4D0A80AC4B87C9CE430B543EEBEF87DF16C0DE213A0549C1FAF1B0B002352000:8 X-MTK: N Content-Transfer-Encoding: base64 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Y2MgWWFxaWkgV3UgPFlhcWlpLld1QG1lZGlhdGVrLmNvbT4NCg0KSSdsbCB0ZXN0IGl0ICwgdGhh bmtzDQoNCk9uIFR1ZSwgMjAyMS0wMy0zMCBhdCAxNjowNiArMDgwMCwgSWtqb29uIEphbmcgd3Jv dGU6DQo+IFJlbW92ZSB1bm5lY2Vzc2FyeSB2YXJpYWJsZXMgaW4gY2hlY2tfc2NoX2J3KCkuDQo+ IE5vIGZ1bmN0aW9uYWwgY2hhbmdlcywganVzdCBmb3IgYmV0dGVyIHJlYWRhYmlsaXR5Lg0KPiAN Cj4gU2lnbmVkLW9mZi1ieTogSWtqb29uIEphbmcgPGlram5AY2hyb21pdW0ub3JnPg0KPiAtLS0N Cj4gDQo+ICBkcml2ZXJzL3VzYi9ob3N0L3hoY2ktbXRrLXNjaC5jIHwgNTIgKysrKysrKysrKysr Ky0tLS0tLS0tLS0tLS0tLS0tLS0tDQo+ICAxIGZpbGUgY2hhbmdlZCwgMjEgaW5zZXJ0aW9ucygr KSwgMzEgZGVsZXRpb25zKC0pDQo+IA0KPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy91c2IvaG9zdC94 aGNpLW10ay1zY2guYyBiL2RyaXZlcnMvdXNiL2hvc3QveGhjaS1tdGstc2NoLmMNCj4gaW5kZXgg YTU5ZDFmNmQ0NzQ0Li4wY2I0MTAwN2VjNjUgMTAwNjQ0DQo+IC0tLSBhL2RyaXZlcnMvdXNiL2hv c3QveGhjaS1tdGstc2NoLmMNCj4gKysrIGIvZHJpdmVycy91c2IvaG9zdC94aGNpLW10ay1zY2gu Yw0KPiBAQCAtNDc5LDYgKzQ3OSw5IEBAIHN0YXRpYyBpbnQgY2hlY2tfc2NoX3R0KHN0cnVjdCBt dTNoX3NjaF9lcF9pbmZvICpzY2hfZXAsIHUzMiBvZmZzZXQpDQo+ICAJdTMyIHN0YXJ0X2NzLCBs YXN0X2NzOw0KPiAgCWludCBpOw0KPiAgDQo+ICsJaWYgKCFzY2hfZXAtPnNjaF90dCkNCj4gKwkJ cmV0dXJuIDA7DQo+ICsNCj4gIAlzdGFydF9zcyA9IG9mZnNldCAlIDg7DQo+ICANCj4gIAlpZiAo c2NoX2VwLT5lcF90eXBlID09IElTT0NfT1VUX0VQKSB7DQo+IEBAIC02MDYsNTQgKzYwOSw0MSBA QCBzdGF0aWMgdTMyIGdldF9lc2l0X2JvdW5kYXJ5KHN0cnVjdCBtdTNoX3NjaF9lcF9pbmZvICpz Y2hfZXApDQo+ICBzdGF0aWMgaW50IGNoZWNrX3NjaF9idyhzdHJ1Y3QgbXUzaF9zY2hfYndfaW5m byAqc2NoX2J3LA0KPiAgCQkJc3RydWN0IG11M2hfc2NoX2VwX2luZm8gKnNjaF9lcCkNCj4gIHsN Cj4gLQl1MzIgb2Zmc2V0Ow0KPiAtCXUzMiBtaW5fYnc7DQo+IC0JdTMyIG1pbl9pbmRleDsNCj4g LQl1MzIgd29yc3RfYnc7DQo+IC0JdTMyIGJ3X2JvdW5kYXJ5Ow0KPiAtCXUzMiBlc2l0X2JvdW5k YXJ5Ow0KPiAtCXUzMiBtaW5fbnVtX2J1ZGdldDsNCj4gLQl1MzIgbWluX2NzX2NvdW50Ow0KPiAt CWludCByZXQgPSAwOw0KPiArCWludCBpLCBmb3VuZCA9IC0xOw0KPiArCWNvbnN0IHUzMiBlc2l0 X2JvdW5kYXJ5ID0gZ2V0X2VzaXRfYm91bmRhcnkoc2NoX2VwKTsNCj4gKwljb25zdCB1MzIgYndf Ym91bmRhcnkgPSBnZXRfYndfYm91bmRhcnkoc2NoX2VwLT5zcGVlZCk7DQo+ICsJdTMyIG1pbl9i dyA9IH4wOw0KPiAgDQo+ICAJLyoNCj4gIAkgKiBTZWFyY2ggdGhyb3VnaCBhbGwgcG9zc2libGUg c2NoZWR1bGUgbWljcm9mcmFtZXMuDQo+ICAJICogYW5kIGZpbmQgYSBtaWNyb2ZyYW1lIHdoZXJl IGl0cyB3b3JzdCBiYW5kd2lkdGggaXMgbWluaW11bS4NCj4gIAkgKi8NCj4gLQltaW5fYncgPSB+ MDsNCj4gLQltaW5faW5kZXggPSAwOw0KPiAtCW1pbl9jc19jb3VudCA9IHNjaF9lcC0+Y3NfY291 bnQ7DQo+IC0JbWluX251bV9idWRnZXQgPSBzY2hfZXAtPm51bV9idWRnZXRfbWljcm9mcmFtZXM7 DQo+IC0JZXNpdF9ib3VuZGFyeSA9IGdldF9lc2l0X2JvdW5kYXJ5KHNjaF9lcCk7DQo+IC0JZm9y IChvZmZzZXQgPSAwOyBvZmZzZXQgPCBzY2hfZXAtPmVzaXQ7IG9mZnNldCsrKSB7DQo+IC0JCWlm IChzY2hfZXAtPnNjaF90dCkgew0KPiAtCQkJcmV0ID0gY2hlY2tfc2NoX3R0KHNjaF9lcCwgb2Zm c2V0KTsNCj4gLQkJCWlmIChyZXQpDQo+IC0JCQkJY29udGludWU7DQo+IC0JCX0NCj4gKwlmb3Ig KGkgPSAwOyBpIDwgc2NoX2VwLT5lc2l0OyBpKyspIHsNCj4gKwkJdTMyIHdvcnN0X2J3Ow0KPiAg DQo+IC0JCWlmICgob2Zmc2V0ICsgc2NoX2VwLT5udW1fYnVkZ2V0X21pY3JvZnJhbWVzKSA+IGVz aXRfYm91bmRhcnkpDQo+ICsJCWlmICgoaSArIHNjaF9lcC0+bnVtX2J1ZGdldF9taWNyb2ZyYW1l cykgPiBlc2l0X2JvdW5kYXJ5KQ0KPiAgCQkJYnJlYWs7DQo+ICANCj4gLQkJd29yc3RfYncgPSBn ZXRfbWF4X2J3KHNjaF9idywgc2NoX2VwLCBvZmZzZXQpOw0KPiArCQlpZiAoY2hlY2tfc2NoX3R0 KHNjaF9lcCwgaSkpDQo+ICsJCQljb250aW51ZTsNCj4gKw0KPiArCQl3b3JzdF9idyA9IGdldF9t YXhfYncoc2NoX2J3LCBzY2hfZXAsIGkpOw0KPiArCQlpZiAod29yc3RfYncgPiBid19ib3VuZGFy eSkNCj4gKwkJCWNvbnRpbnVlOw0KPiArDQo+ICAJCWlmIChtaW5fYncgPiB3b3JzdF9idykgew0K PiAgCQkJbWluX2J3ID0gd29yc3RfYnc7DQo+IC0JCQltaW5faW5kZXggPSBvZmZzZXQ7DQo+IC0J CQltaW5fY3NfY291bnQgPSBzY2hfZXAtPmNzX2NvdW50Ow0KPiAtCQkJbWluX251bV9idWRnZXQg PSBzY2hfZXAtPm51bV9idWRnZXRfbWljcm9mcmFtZXM7DQo+ICsJCQlmb3VuZCA9IGk7DQo+ICAJ CX0NCj4gIAkJaWYgKG1pbl9idyA9PSAwKQ0KPiAgCQkJYnJlYWs7DQo+ICAJfQ0KPiAgDQo+IC0J YndfYm91bmRhcnkgPSBnZXRfYndfYm91bmRhcnkoc2NoX2VwLT5zcGVlZCk7DQo+ICAJLyogY2hl Y2sgYmFuZHdpZHRoICovDQo+IC0JaWYgKG1pbl9idyA+IGJ3X2JvdW5kYXJ5KQ0KPiAtCQlyZXR1 cm4gcmV0ID8gcmV0IDogLUVTQ0hfQldfT1ZFUkZMT1c7DQo+ICsJaWYgKGZvdW5kIDwgMCkNCj4g KwkJcmV0dXJuIC1FU0NIX0JXX09WRVJGTE9XOw0KPiAgDQo+IC0Jc2NoX2VwLT5vZmZzZXQgPSBt aW5faW5kZXg7DQo+IC0Jc2NoX2VwLT5jc19jb3VudCA9IG1pbl9jc19jb3VudDsNCj4gLQlzY2hf ZXAtPm51bV9idWRnZXRfbWljcm9mcmFtZXMgPSBtaW5fbnVtX2J1ZGdldDsNCj4gKwlzY2hfZXAt Pm9mZnNldCA9IGZvdW5kOw0KPiAgDQo+ICAJcmV0dXJuIGxvYWRfZXBfYncoc2NoX2J3LCBzY2hf ZXAsIHRydWUpOw0KPiAgfQ0KDQo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY, USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 41709C433C1 for ; Wed, 31 Mar 2021 08:31:53 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BE75A6196C for ; Wed, 31 Mar 2021 08:31:52 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BE75A6196C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Date:CC:To:From: Subject:Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=mF0VgH3LOh8EOaG5RepJeAf+2G2wSxUtQ6TNUkCWJpM=; b=aL6PB3FKd7Q6WYLzk5OAs9AbA 1fL2BiZzYprjIG1gNW6iauybY0MzsTtrHZX7yzIcMwsnP7i38AmcRcXx/FQi6nKnegaaYSfEWRa4q 9Q8NgSOUAp/ZFUmgPZklZY9TTquJLgLqUKDRj1wfsms7jbtZtpat8RnmlN4QUp28ZnjO9D44dgmfH ZeDr2bcQ7LxfsLVNmwQM6Yy5jefne7pc9zvnQdsc2Wa3XMZVEMG+EvbN7oUX+2RKsRqYSMp03dQIO CIa+tlCAWvj3LxLcSo0xR3kgHffcC0hfDuLg8prVne0Aa3cvdWwTepfubiq1HbHOvAURji11CNqb0 B8l+xaIQA==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lRWGK-005xoo-0C; Wed, 31 Mar 2021 08:31:40 +0000 Received: from mailgw02.mediatek.com ([216.200.240.185]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lRWFl-005xZg-S6; Wed, 31 Mar 2021 08:31:09 +0000 X-UUID: c9b2d47a6ebe4c0da510040e5703312e-20210331 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=W3q5DAk4wjiboZB+4xm4r+D77u+vIj/xKBGT22s32q4=; b=P3tlUBa1Wl0b+SOqp9657Xsv25LXjXJL8x5LVHWExBGTQi1DM5TDydDf2yaZTopcyjecIfaGlivcxMxlbX311BW40n8+SMFhTMETys7fCHHwKrkhakzwd/7rC5EYEyzzCAYVRyUw3/ig/un6k8VEnAUETDqz2DgNqXtyXSCauu4=; X-UUID: c9b2d47a6ebe4c0da510040e5703312e-20210331 Received: from mtkcas67.mediatek.inc [(172.29.193.45)] by mailgw02.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLSv1.2 ECDHE-RSA-AES256-SHA384 256/256) with ESMTP id 386193767; Wed, 31 Mar 2021 01:31:01 -0700 Received: from MTKMBS31N2.mediatek.inc (172.27.4.87) by MTKMBS62N1.mediatek.inc (172.29.193.41) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Wed, 31 Mar 2021 01:31:00 -0700 Received: from MTKCAS32.mediatek.inc (172.27.4.184) by MTKMBS31N2.mediatek.inc (172.27.4.87) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Wed, 31 Mar 2021 16:30:55 +0800 Received: from [10.17.3.153] (10.17.3.153) by MTKCAS32.mediatek.inc (172.27.4.170) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Wed, 31 Mar 2021 16:30:55 +0800 Message-ID: <1617179455.2752.1.camel@mhfsdcap03> Subject: Re: [PATCH 1/2] usb: xhci-mtk: remove unnecessary assignments in periodic TT scheduler From: Chunfeng Yun To: Ikjoon Jang , Yaqii Wu CC: , Greg Kroah-Hartman , Mathias Nyman , Matthias Brugger , , , Date: Wed, 31 Mar 2021 16:30:55 +0800 In-Reply-To: <20210330160508.1.I797d214790033d0402d19ff6b47a34aff60d3062@changeid> References: <20210330080617.3746932-1-ikjn@chromium.org> <20210330160508.1.I797d214790033d0402d19ff6b47a34aff60d3062@changeid> X-Mailer: Evolution 3.10.4-0ubuntu2 MIME-Version: 1.0 X-TM-SNTS-SMTP: BC6F4D0A80AC4B87C9CE430B543EEBEF87DF16C0DE213A0549C1FAF1B0B002352000:8 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210331_093106_622682_31C0CC2B X-CRM114-Status: GOOD ( 20.02 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org cc Yaqii Wu I'll test it , thanks On Tue, 2021-03-30 at 16:06 +0800, Ikjoon Jang wrote: > Remove unnecessary variables in check_sch_bw(). > No functional changes, just for better readability. > > Signed-off-by: Ikjoon Jang > --- > > drivers/usb/host/xhci-mtk-sch.c | 52 +++++++++++++-------------------- > 1 file changed, 21 insertions(+), 31 deletions(-) > > diff --git a/drivers/usb/host/xhci-mtk-sch.c b/drivers/usb/host/xhci-mtk-sch.c > index a59d1f6d4744..0cb41007ec65 100644 > --- a/drivers/usb/host/xhci-mtk-sch.c > +++ b/drivers/usb/host/xhci-mtk-sch.c > @@ -479,6 +479,9 @@ static int check_sch_tt(struct mu3h_sch_ep_info *sch_ep, u32 offset) > u32 start_cs, last_cs; > int i; > > + if (!sch_ep->sch_tt) > + return 0; > + > start_ss = offset % 8; > > if (sch_ep->ep_type == ISOC_OUT_EP) { > @@ -606,54 +609,41 @@ static u32 get_esit_boundary(struct mu3h_sch_ep_info *sch_ep) > static int check_sch_bw(struct mu3h_sch_bw_info *sch_bw, > struct mu3h_sch_ep_info *sch_ep) > { > - u32 offset; > - u32 min_bw; > - u32 min_index; > - u32 worst_bw; > - u32 bw_boundary; > - u32 esit_boundary; > - u32 min_num_budget; > - u32 min_cs_count; > - int ret = 0; > + int i, found = -1; > + const u32 esit_boundary = get_esit_boundary(sch_ep); > + const u32 bw_boundary = get_bw_boundary(sch_ep->speed); > + u32 min_bw = ~0; > > /* > * Search through all possible schedule microframes. > * and find a microframe where its worst bandwidth is minimum. > */ > - min_bw = ~0; > - min_index = 0; > - min_cs_count = sch_ep->cs_count; > - min_num_budget = sch_ep->num_budget_microframes; > - esit_boundary = get_esit_boundary(sch_ep); > - for (offset = 0; offset < sch_ep->esit; offset++) { > - if (sch_ep->sch_tt) { > - ret = check_sch_tt(sch_ep, offset); > - if (ret) > - continue; > - } > + for (i = 0; i < sch_ep->esit; i++) { > + u32 worst_bw; > > - if ((offset + sch_ep->num_budget_microframes) > esit_boundary) > + if ((i + sch_ep->num_budget_microframes) > esit_boundary) > break; > > - worst_bw = get_max_bw(sch_bw, sch_ep, offset); > + if (check_sch_tt(sch_ep, i)) > + continue; > + > + worst_bw = get_max_bw(sch_bw, sch_ep, i); > + if (worst_bw > bw_boundary) > + continue; > + > if (min_bw > worst_bw) { > min_bw = worst_bw; > - min_index = offset; > - min_cs_count = sch_ep->cs_count; > - min_num_budget = sch_ep->num_budget_microframes; > + found = i; > } > if (min_bw == 0) > break; > } > > - bw_boundary = get_bw_boundary(sch_ep->speed); > /* check bandwidth */ > - if (min_bw > bw_boundary) > - return ret ? ret : -ESCH_BW_OVERFLOW; > + if (found < 0) > + return -ESCH_BW_OVERFLOW; > > - sch_ep->offset = min_index; > - sch_ep->cs_count = min_cs_count; > - sch_ep->num_budget_microframes = min_num_budget; > + sch_ep->offset = found; > > return load_ep_bw(sch_bw, sch_ep, true); > } _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY, USER_AGENT_SANE_2 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2397FC433E0 for ; Wed, 31 Mar 2021 08:32:49 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5AF8B61962 for ; Wed, 31 Mar 2021 08:32:48 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5AF8B61962 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Date:CC:To:From: Subject:Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Ui5LuEig9svdeNQ3tFb2CbIZRifvdAnh3flqQ+uZvkk=; b=Vs6MxF5IG1ahrgWiIsB8c9BS2 01CMha7a7gNIhvL+od0xHgsuIqwd519JhoZOr8bMc4gT1Mn5dfKknGOdDtMgZU2PUSMe14Xs/GuSb KW0mM0RWXuogMIU7XoTSzHM4FUrJktGsfGtdubzikXalnxe0lsaNe6HwdNDOwkXgsWmDcvMQcLiHm bZJYjNVbUrMQqjrgqMpZjJum2cCsU5iBR4/ndIA8jY2DYVPAcwgJzeiFw2xBvKtN8VDhUXXTKN/By 8FTIwkvZbrNDiRwZLkFEk1dKpjb9qKzaJEDsGQhixExtO9SXB442XBG48/C83cusV6OER6H+tYJ34 xdTOEkd2g==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lRWFt-005xdz-57; Wed, 31 Mar 2021 08:31:13 +0000 Received: from mailgw02.mediatek.com ([216.200.240.185]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lRWFl-005xZg-S6; Wed, 31 Mar 2021 08:31:09 +0000 X-UUID: c9b2d47a6ebe4c0da510040e5703312e-20210331 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=W3q5DAk4wjiboZB+4xm4r+D77u+vIj/xKBGT22s32q4=; b=P3tlUBa1Wl0b+SOqp9657Xsv25LXjXJL8x5LVHWExBGTQi1DM5TDydDf2yaZTopcyjecIfaGlivcxMxlbX311BW40n8+SMFhTMETys7fCHHwKrkhakzwd/7rC5EYEyzzCAYVRyUw3/ig/un6k8VEnAUETDqz2DgNqXtyXSCauu4=; X-UUID: c9b2d47a6ebe4c0da510040e5703312e-20210331 Received: from mtkcas67.mediatek.inc [(172.29.193.45)] by mailgw02.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLSv1.2 ECDHE-RSA-AES256-SHA384 256/256) with ESMTP id 386193767; Wed, 31 Mar 2021 01:31:01 -0700 Received: from MTKMBS31N2.mediatek.inc (172.27.4.87) by MTKMBS62N1.mediatek.inc (172.29.193.41) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Wed, 31 Mar 2021 01:31:00 -0700 Received: from MTKCAS32.mediatek.inc (172.27.4.184) by MTKMBS31N2.mediatek.inc (172.27.4.87) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Wed, 31 Mar 2021 16:30:55 +0800 Received: from [10.17.3.153] (10.17.3.153) by MTKCAS32.mediatek.inc (172.27.4.170) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Wed, 31 Mar 2021 16:30:55 +0800 Message-ID: <1617179455.2752.1.camel@mhfsdcap03> Subject: Re: [PATCH 1/2] usb: xhci-mtk: remove unnecessary assignments in periodic TT scheduler From: Chunfeng Yun To: Ikjoon Jang , Yaqii Wu CC: , Greg Kroah-Hartman , Mathias Nyman , Matthias Brugger , , , Date: Wed, 31 Mar 2021 16:30:55 +0800 In-Reply-To: <20210330160508.1.I797d214790033d0402d19ff6b47a34aff60d3062@changeid> References: <20210330080617.3746932-1-ikjn@chromium.org> <20210330160508.1.I797d214790033d0402d19ff6b47a34aff60d3062@changeid> X-Mailer: Evolution 3.10.4-0ubuntu2 MIME-Version: 1.0 X-TM-SNTS-SMTP: BC6F4D0A80AC4B87C9CE430B543EEBEF87DF16C0DE213A0549C1FAF1B0B002352000:8 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210331_093106_622682_31C0CC2B X-CRM114-Status: GOOD ( 20.02 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org cc Yaqii Wu I'll test it , thanks On Tue, 2021-03-30 at 16:06 +0800, Ikjoon Jang wrote: > Remove unnecessary variables in check_sch_bw(). > No functional changes, just for better readability. > > Signed-off-by: Ikjoon Jang > --- > > drivers/usb/host/xhci-mtk-sch.c | 52 +++++++++++++-------------------- > 1 file changed, 21 insertions(+), 31 deletions(-) > > diff --git a/drivers/usb/host/xhci-mtk-sch.c b/drivers/usb/host/xhci-mtk-sch.c > index a59d1f6d4744..0cb41007ec65 100644 > --- a/drivers/usb/host/xhci-mtk-sch.c > +++ b/drivers/usb/host/xhci-mtk-sch.c > @@ -479,6 +479,9 @@ static int check_sch_tt(struct mu3h_sch_ep_info *sch_ep, u32 offset) > u32 start_cs, last_cs; > int i; > > + if (!sch_ep->sch_tt) > + return 0; > + > start_ss = offset % 8; > > if (sch_ep->ep_type == ISOC_OUT_EP) { > @@ -606,54 +609,41 @@ static u32 get_esit_boundary(struct mu3h_sch_ep_info *sch_ep) > static int check_sch_bw(struct mu3h_sch_bw_info *sch_bw, > struct mu3h_sch_ep_info *sch_ep) > { > - u32 offset; > - u32 min_bw; > - u32 min_index; > - u32 worst_bw; > - u32 bw_boundary; > - u32 esit_boundary; > - u32 min_num_budget; > - u32 min_cs_count; > - int ret = 0; > + int i, found = -1; > + const u32 esit_boundary = get_esit_boundary(sch_ep); > + const u32 bw_boundary = get_bw_boundary(sch_ep->speed); > + u32 min_bw = ~0; > > /* > * Search through all possible schedule microframes. > * and find a microframe where its worst bandwidth is minimum. > */ > - min_bw = ~0; > - min_index = 0; > - min_cs_count = sch_ep->cs_count; > - min_num_budget = sch_ep->num_budget_microframes; > - esit_boundary = get_esit_boundary(sch_ep); > - for (offset = 0; offset < sch_ep->esit; offset++) { > - if (sch_ep->sch_tt) { > - ret = check_sch_tt(sch_ep, offset); > - if (ret) > - continue; > - } > + for (i = 0; i < sch_ep->esit; i++) { > + u32 worst_bw; > > - if ((offset + sch_ep->num_budget_microframes) > esit_boundary) > + if ((i + sch_ep->num_budget_microframes) > esit_boundary) > break; > > - worst_bw = get_max_bw(sch_bw, sch_ep, offset); > + if (check_sch_tt(sch_ep, i)) > + continue; > + > + worst_bw = get_max_bw(sch_bw, sch_ep, i); > + if (worst_bw > bw_boundary) > + continue; > + > if (min_bw > worst_bw) { > min_bw = worst_bw; > - min_index = offset; > - min_cs_count = sch_ep->cs_count; > - min_num_budget = sch_ep->num_budget_microframes; > + found = i; > } > if (min_bw == 0) > break; > } > > - bw_boundary = get_bw_boundary(sch_ep->speed); > /* check bandwidth */ > - if (min_bw > bw_boundary) > - return ret ? ret : -ESCH_BW_OVERFLOW; > + if (found < 0) > + return -ESCH_BW_OVERFLOW; > > - sch_ep->offset = min_index; > - sch_ep->cs_count = min_cs_count; > - sch_ep->num_budget_microframes = min_num_budget; > + sch_ep->offset = found; > > return load_ep_bw(sch_bw, sch_ep, true); > } _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel