* [PATCH][next] scsi: a100u2w: remove unused variable biosaddr
@ 2021-03-25 17:07 Colin King
2021-04-02 3:54 ` Martin K. Petersen
0 siblings, 1 reply; 2+ messages in thread
From: Colin King @ 2021-03-25 17:07 UTC (permalink / raw)
To: James E . J . Bottomley, Martin K . Petersen, linux-scsi
Cc: kernel-janitors, linux-kernel
From: Colin Ian King <colin.king@canonical.com>
The variable biosaddr is being assigned a value that is never read,
the variable is redundant and can be safely removed.
Addresses-Coverity: ("Unused value")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/scsi/a100u2w.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/scsi/a100u2w.c b/drivers/scsi/a100u2w.c
index c9ed210d77b3..028af6b1057c 100644
--- a/drivers/scsi/a100u2w.c
+++ b/drivers/scsi/a100u2w.c
@@ -1088,7 +1088,6 @@ static int inia100_probe_one(struct pci_dev *pdev,
unsigned long port, bios;
int error = -ENODEV;
u32 sz;
- unsigned long biosaddr;
if (pci_enable_device(pdev))
goto out;
@@ -1138,8 +1137,6 @@ static int inia100_probe_one(struct pci_dev *pdev,
goto out_free_scb_array;
}
- biosaddr = host->BIOScfg;
- biosaddr = (biosaddr << 4);
if (init_orchid(host)) { /* Initialize orchid chip */
printk("inia100: initial orchid fail!!\n");
goto out_free_escb_array;
--
2.30.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH][next] scsi: a100u2w: remove unused variable biosaddr
2021-03-25 17:07 [PATCH][next] scsi: a100u2w: remove unused variable biosaddr Colin King
@ 2021-04-02 3:54 ` Martin K. Petersen
0 siblings, 0 replies; 2+ messages in thread
From: Martin K. Petersen @ 2021-04-02 3:54 UTC (permalink / raw)
To: Colin King, James E . J . Bottomley, linux-scsi
Cc: Martin K . Petersen, kernel-janitors, linux-kernel
On Thu, 25 Mar 2021 17:07:31 +0000, Colin King wrote:
> The variable biosaddr is being assigned a value that is never read,
> the variable is redundant and can be safely removed.
Applied to 5.13/scsi-queue, thanks!
[1/1] scsi: a100u2w: remove unused variable biosaddr
https://git.kernel.org/mkp/scsi/c/92b4c52c43e1
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-04-02 3:54 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-25 17:07 [PATCH][next] scsi: a100u2w: remove unused variable biosaddr Colin King
2021-04-02 3:54 ` Martin K. Petersen
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.