All of lore.kernel.org
 help / color / mirror / Atom feed
From: Patchwork <patchwork@emeril.freedesktop.org>
To: "Lucas De Marchi" <lucas.demarchi@intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Extend GEN renames to the rest of the driver (rev2)
Date: Thu, 08 Apr 2021 05:19:11 -0000	[thread overview]
Message-ID: <161785915155.10404.6198326634188488530@emeril.freedesktop.org> (raw)
In-Reply-To: <20210408045227.985408-1-lucas.demarchi@intel.com>

== Series Details ==

Series: drm/i915: Extend GEN renames to the rest of the driver (rev2)
URL   : https://patchwork.freedesktop.org/series/88825/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
80f2d9b2707c drm/i915: rename display.version to display.ver
-:46: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'x' - possible side-effects?
#46: FILE: drivers/gpu/drm/i915/i915_pci.c:39:
+#define GEN(x) .gen = (x), .gen_mask = BIT((x) - 1), .display.ver = (x)

total: 0 errors, 0 warnings, 1 checks, 32 lines checked
ee9f103524db drm/i915: add macros for graphics and media versions
-:40: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'i915' - possible side-effects?
#40: FILE: drivers/gpu/drm/i915/i915_drv.h:1246:
+#define IS_GRAPHICS_RANGE(i915, from, until) \
+	(GRAPHICS_VER(i915) >= (from) && GRAPHICS_VER(i915) <= (until))

-:45: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'i915' - possible side-effects?
#45: FILE: drivers/gpu/drm/i915/i915_drv.h:1251:
+#define IS_MEDIA_RANGE(i915, from, until) \
+	(MEDIA_VER(i915) >= (from) && MEDIA_VER(i915) <= (until))

-:61: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'x' - possible side-effects?
#61: FILE: drivers/gpu/drm/i915/i915_pci.c:39:
+#define GEN(x) \
+	.gen_mask = BIT((x) - 1), \
+	.gen = (x), \
+	.graphics_ver = (x), \
+	.media_ver = (x), \
+	.display.ver = (x)

total: 0 errors, 0 warnings, 3 checks, 47 lines checked
6f23787ecba4 drm/i915/gt: replace gen use in intel_engine_cs
fe5e3e94c2b1 drm/i915/selftests: replace unused mask with simple version
e5492f832b05 drm/i915/selftests: eliminate use of gen_mask
cfbe5560528d drm/i915: finish removal of gen_mask
87f338a98fc3 drm/i915: eliminate remaining uses of intel_device_info->gen
bb6756e3a46d drm/i915: finish removal of gen from intel_device_info
b857f06983f3 drm/i915: add media and display versions to device_info print
3a85bfab0b35 drm/i915/display: use DISPLAY_VER() on remaining users
38c8ca70a088 drm/i915: replace IS_GEN and friends with IS_GRAPHICS_VER
-:2809: WARNING:LONG_LINE: line length of 112 exceeds 100 columns
#2809: FILE: drivers/gpu/drm/i915/gt/selftest_llc.c:47:
+			       intel_gpu_freq(rps, gpu_freq * (GRAPHICS_VER(i915) >= 9 ? GEN9_FREQ_SCALER : 1)),

-:2818: WARNING:LONG_LINE: line length of 112 exceeds 100 columns
#2818: FILE: drivers/gpu/drm/i915/gt/selftest_llc.c:57:
+			       intel_gpu_freq(rps, gpu_freq * (GRAPHICS_VER(i915) >= 9 ? GEN9_FREQ_SCALER : 1)),

-:3537: WARNING:LONG_LINE: line length of 101 exceeds 100 columns
#3537: FILE: drivers/gpu/drm/i915/i915_debugfs.c:489:
+			   (gt_perf_status & (GRAPHICS_VER(dev_priv) >= 9 ? 0x1ff00 : 0xff00)) >> 8);

total: 0 errors, 3 warnings, 0 checks, 4187 lines checked
e1b404b9b972 drm/i915: split dgfx features from gen 12


_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  parent reply	other threads:[~2021-04-08  5:19 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-08  4:52 [Intel-gfx] [PATCH 00/12] drm/i915: Extend GEN renames to the rest of the driver Lucas De Marchi
2021-04-08  4:52 ` [Intel-gfx] [PATCH 01/12] drm/i915: rename display.version to display.ver Lucas De Marchi
2021-04-10  0:07   ` Souza, Jose
2021-04-11 15:33   ` Matt Roper
2021-04-12 11:04     ` Jani Nikula
2021-04-08  4:52 ` [Intel-gfx] [PATCH 02/12] drm/i915: add macros for graphics and media versions Lucas De Marchi
2021-04-10  1:09   ` Souza, Jose
2021-04-12 11:12   ` Jani Nikula
2021-04-12 11:40     ` Jani Nikula
2021-04-12 20:33       ` Lucas De Marchi
2021-04-08  4:52 ` [Intel-gfx] [PATCH 03/12] drm/i915/gt: replace gen use in intel_engine_cs Lucas De Marchi
2021-04-08  4:52 ` [Intel-gfx] [PATCH 04/12] drm/i915/selftests: replace unused mask with simple version Lucas De Marchi
2021-04-08  4:52 ` [Intel-gfx] [PATCH 05/12] drm/i915/selftests: eliminate use of gen_mask Lucas De Marchi
2021-04-08  4:52 ` [Intel-gfx] [PATCH 06/12] drm/i915: finish removal " Lucas De Marchi
2021-04-08  4:52 ` [Intel-gfx] [PATCH 07/12] drm/i915: eliminate remaining uses of intel_device_info->gen Lucas De Marchi
2021-04-08  4:52 ` [Intel-gfx] [PATCH 08/12] drm/i915: finish removal of gen from intel_device_info Lucas De Marchi
2021-04-08  4:52 ` [Intel-gfx] [PATCH 09/12] drm/i915: add media and display versions to device_info print Lucas De Marchi
2021-04-08  4:52 ` [Intel-gfx] [PATCH 10/12] drm/i915/display: use DISPLAY_VER() on remaining users Lucas De Marchi
2021-04-08  4:52 ` [Intel-gfx] [PATCH 11/12] drm/i915: replace IS_GEN and friends with IS_GRAPHICS_VER Lucas De Marchi
2021-04-08  4:52 ` [Intel-gfx] [PATCH 12/12] drm/i915: split dgfx features from gen 12 Lucas De Marchi
2021-04-08  5:19 ` Patchwork [this message]
2021-04-08  5:20 ` [Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915: Extend GEN renames to the rest of the driver (rev2) Patchwork
2021-04-08  5:24 ` [Intel-gfx] ✗ Fi.CI.DOCS: " Patchwork
2021-04-08  5:44 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2021-04-08  7:03 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=161785915155.10404.6198326634188488530@emeril.freedesktop.org \
    --to=patchwork@emeril.freedesktop.org \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=lucas.demarchi@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.