From: Stephen Boyd <swboyd@chromium.org>
To: Petr Mladek <pmladek@suse.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org, Jiri Olsa <jolsa@kernel.org>,
Alexei Starovoitov <ast@kernel.org>, Jessica Yu <jeyu@kernel.org>,
Evan Green <evgreen@chromium.org>,
Hsin-Yi Wang <hsinyi@chromium.org>,
Steven Rostedt <rostedt@goodmis.org>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Matthew Wilcox <willy@infradead.org>
Subject: Re: [PATCH v3 03/12] dump_stack: Add vmlinux build ID to stack traces
Date: Wed, 07 Apr 2021 23:20:32 -0700 [thread overview]
Message-ID: <161786283299.3790633.9395579294249054249@swboyd.mtv.corp.google.com> (raw)
In-Reply-To: <YG27p1AhiOKJOm+y@alley>
Quoting Petr Mladek (2021-04-07 07:03:19)
> # readelf -Wn vmlinux-5.12.0-rc6-default+
>
> Displaying notes found in: .notes
> Owner Data size Description
> Xen 0x00000006 Unknown note type: (0x00000006) description data: 6c 69 6e 75 78 00
> Xen 0x00000004 Unknown note type: (0x00000007) description data: 32 2e 36 00
> Xen 0x00000008 Unknown note type: (0x00000005) description data: 78 65 6e 2d 33 2e 30 00
> Xen 0x00000008 Unknown note type: (0x00000003) description data: 00 00 00 ffffff80 ffffffff ffffffff ffffffff ffffffff
>
Thanks for the readelf output. That was most helpful to see what's going
on. The buildid code isn't prepared for this it seems. We'll need to
check the note data to see if it starts with "GNU\0" and if it does then
we use it as the buildid. I'm not sure what this Xen note is that has a
type of 3 but I think that's OK, it won't have "GNU" in there so we
should ignore it. Does this patch work?
----8<----
diff --git a/lib/buildid.c b/lib/buildid.c
index 483abf71eeec..f281dbe6fb83 100644
--- a/lib/buildid.c
+++ b/lib/buildid.c
@@ -25,6 +25,7 @@ static int parse_build_id_buf(unsigned char *build_id,
if (nhdr->n_type == BUILD_ID &&
nhdr->n_namesz == sizeof("GNU") &&
+ !strcmp((char *)(nhdr + 1), "GNU") &&
nhdr->n_descsz > 0 &&
nhdr->n_descsz <= BUILD_ID_SIZE_MAX) {
memcpy(build_id,
next prev parent reply other threads:[~2021-04-08 6:20 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-31 3:05 [PATCH v3 00/12] Add build ID to stacktraces Stephen Boyd
2021-03-31 3:05 ` Stephen Boyd
2021-03-31 3:05 ` Stephen Boyd
2021-03-31 3:05 ` [PATCH v3 01/12] buildid: Add API to parse build ID out of buffer Stephen Boyd
2021-03-31 3:05 ` [PATCH v3 02/12] buildid: Stash away kernels build ID on init Stephen Boyd
2021-03-31 3:05 ` Stephen Boyd
2021-04-08 12:05 ` Jessica Yu
2021-04-08 12:05 ` Jessica Yu
2021-04-08 18:52 ` Stephen Boyd
2021-04-08 18:52 ` Stephen Boyd
2021-03-31 3:05 ` [PATCH v3 03/12] dump_stack: Add vmlinux build ID to stack traces Stephen Boyd
2021-04-07 13:42 ` Petr Mladek
2021-04-08 5:44 ` Stephen Boyd
2021-04-07 14:03 ` Petr Mladek
2021-04-08 1:14 ` Stephen Boyd
2021-04-08 6:20 ` Stephen Boyd [this message]
2021-04-08 10:13 ` Petr Mladek
2021-04-08 19:52 ` Stephen Boyd
2021-04-08 21:08 ` Stephen Boyd
2021-04-09 9:19 ` Petr Mladek
2021-03-31 3:05 ` [PATCH v3 04/12] module: Add printk format to add module build ID to stacktraces Stephen Boyd
2021-04-07 14:54 ` Petr Mladek
2021-04-07 15:07 ` Andy Shevchenko
2021-04-07 15:03 ` Petr Mladek
2021-04-07 15:37 ` Andy Shevchenko
2021-04-08 6:58 ` Stephen Boyd
2021-04-08 13:44 ` Jessica Yu
2021-04-08 14:05 ` Andy Shevchenko
2021-04-08 19:57 ` Stephen Boyd
2021-03-31 3:05 ` [PATCH v3 05/12] arm64: stacktrace: Use %pSb for backtrace printing Stephen Boyd
2021-03-31 3:05 ` Stephen Boyd
2021-03-31 3:05 ` [PATCH v3 06/12] x86/dumpstack: " Stephen Boyd
2021-03-31 3:05 ` [PATCH v3 07/12] scripts/decode_stacktrace.sh: Support debuginfod Stephen Boyd
2021-03-31 3:05 ` [PATCH v3 08/12] scripts/decode_stacktrace.sh: Silence stderr messages from addr2line/nm Stephen Boyd
2021-03-31 3:05 ` [PATCH v3 09/12] scripts/decode_stacktrace.sh: Indicate 'auto' can be used for base path Stephen Boyd
2021-03-31 3:05 ` [PATCH v3 10/12] buildid: Mark some arguments const Stephen Boyd
2021-03-31 3:05 ` [PATCH v3 11/12] buildid: Fix kernel-doc notation Stephen Boyd
2021-03-31 3:05 ` [PATCH v3 12/12] kdump: Use vmlinux_build_id to simplify Stephen Boyd
2021-03-31 3:05 ` Stephen Boyd
2021-04-07 17:03 ` Petr Mladek
2021-04-07 17:03 ` Petr Mladek
2021-04-08 5:36 ` Stephen Boyd
2021-04-08 5:36 ` Stephen Boyd
2021-04-08 10:17 ` Baoquan He
2021-04-08 10:17 ` Baoquan He
2021-04-08 19:58 ` Stephen Boyd
2021-04-08 19:58 ` Stephen Boyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=161786283299.3790633.9395579294249054249@swboyd.mtv.corp.google.com \
--to=swboyd@chromium.org \
--cc=akpm@linux-foundation.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=ast@kernel.org \
--cc=evgreen@chromium.org \
--cc=hsinyi@chromium.org \
--cc=jeyu@kernel.org \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pmladek@suse.com \
--cc=rostedt@goodmis.org \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.