From mboxrd@z Thu Jan 1 00:00:00 1970 From: Laurent Pinchart Date: Thu, 25 Jun 2015 21:56:00 +0000 Subject: Re: [PATCH 08/08] ARM: shmobile: Remove CMT renesas,channels-mask from DTS Message-Id: <1618432.qSqOq2tHsD@avalon> List-Id: References: <20150621080903.10187.20998.sendpatchset@little-apple> <8019375.XSP9R0ZLbm@avalon> In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Magnus Damm Cc: linux-kernel , "devicetree@vger.kernel.org" , Laurent Pinchart , Geert Uytterhoeven , SH-Linux , Daniel Lezcano , Simon Horman , Thomas Gleixner Hi Magnus, On Tuesday 23 June 2015 11:46:45 Magnus Damm wrote: > On Tue, Jun 23, 2015 at 7:40 AM, Laurent Pinchart wrote: > > On Sunday 21 June 2015 17:10:33 Magnus Damm wrote: > >> From: Magnus Damm > >> > >> Update the DTS to remove the now deprecated "renesas,channels-mask" > >> property. > >> > >> The channel information is now kept in the device driver and can easily > >> be determined based on the compat string. > > > > Unless I've missed something (which is entirely possibly given the late > > hour), the channel mask is only stored in the driver for the Gen2 CMT > > instances. > > The case for sh73a0 and r8a7740 is also covered by some of the earlier > patches in this series. My bad, I've missed that. We should be good then. > So unless I'm mistaken the series should cover all current in-tree CMT DT > users that we have. I'm not aware of any out-of-tree users. > > You are right that there are more unused compat strings documented, so > those will break. I would be tempted in phasing those out somehow. > Also, I did not spend much time cleaning up the non R-Car Gen2 cases, > so in general that needs some love. -- Regards, Laurent Pinchart From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751802AbbFYV4L (ORCPT ); Thu, 25 Jun 2015 17:56:11 -0400 Received: from galahad.ideasonboard.com ([185.26.127.97]:46880 "EHLO galahad.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751495AbbFYV4G (ORCPT ); Thu, 25 Jun 2015 17:56:06 -0400 From: Laurent Pinchart To: Magnus Damm Cc: linux-kernel , "devicetree@vger.kernel.org" , Laurent Pinchart , Geert Uytterhoeven , SH-Linux , Daniel Lezcano , Simon Horman , Thomas Gleixner Subject: Re: [PATCH 08/08] ARM: shmobile: Remove CMT renesas,channels-mask from DTS Date: Fri, 26 Jun 2015 00:56 +0300 Message-ID: <1618432.qSqOq2tHsD@avalon> User-Agent: KMail/4.14.8 (Linux/4.0.5-gentoo; KDE/4.14.8; x86_64; ; ) In-Reply-To: References: <20150621080903.10187.20998.sendpatchset@little-apple> <8019375.XSP9R0ZLbm@avalon> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Magnus, On Tuesday 23 June 2015 11:46:45 Magnus Damm wrote: > On Tue, Jun 23, 2015 at 7:40 AM, Laurent Pinchart wrote: > > On Sunday 21 June 2015 17:10:33 Magnus Damm wrote: > >> From: Magnus Damm > >> > >> Update the DTS to remove the now deprecated "renesas,channels-mask" > >> property. > >> > >> The channel information is now kept in the device driver and can easily > >> be determined based on the compat string. > > > > Unless I've missed something (which is entirely possibly given the late > > hour), the channel mask is only stored in the driver for the Gen2 CMT > > instances. > > The case for sh73a0 and r8a7740 is also covered by some of the earlier > patches in this series. My bad, I've missed that. We should be good then. > So unless I'm mistaken the series should cover all current in-tree CMT DT > users that we have. I'm not aware of any out-of-tree users. > > You are right that there are more unused compat strings documented, so > those will break. I would be tempted in phasing those out somehow. > Also, I did not spend much time cleaning up the non R-Car Gen2 cases, > so in general that needs some love. -- Regards, Laurent Pinchart