From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D819FC43461 for ; Sat, 17 Apr 2021 02:39:55 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B594161107 for ; Sat, 17 Apr 2021 02:39:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235391AbhDQCkT (ORCPT ); Fri, 16 Apr 2021 22:40:19 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35096 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231997AbhDQCkT (ORCPT ); Fri, 16 Apr 2021 22:40:19 -0400 Received: from mail-pf1-x42c.google.com (mail-pf1-x42c.google.com [IPv6:2607:f8b0:4864:20::42c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4E846C061574; Fri, 16 Apr 2021 19:39:52 -0700 (PDT) Received: by mail-pf1-x42c.google.com with SMTP id h11so1881996pfn.0; Fri, 16 Apr 2021 19:39:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:subject:to:cc:references:in-reply-to:mime-version :message-id:content-transfer-encoding; bh=rjTC8IKkPWGWDKmkZjVmpYAuXFrvSVsRIGffPplx4nk=; b=d+i0hnWpFX+Mj0V53vmK2vj8eRQNdZ7OmdBSqZs2JJu/wGdZaWjUSK5j03u+Qpqm/L JZoSxrNu88qDz90SkZdyhY8BYMglj4UmZjcr6iTK6UWLU0FqAmcd8fGLlLW1/vwJH7wv uZwheH6dxMQ1lPMdfOj75qaFpNBsekFCKLNIKBUCKAHiCRAF0DdRBY6UyDKiQziz4PNl OXUB/cWg0CbBphwRIMSOla1jFmUsP8imKGMwzwRREmU2d5lIuEVgaf0gxRGcDX3ZhLHv QWLgav7Bm3QDC+X/8lCvPBVXjQw1dbC6orZs1vwa6Fgu1hfu0U5vP03SdT7jUqw9PySn oCWQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:subject:to:cc:references:in-reply-to :mime-version:message-id:content-transfer-encoding; bh=rjTC8IKkPWGWDKmkZjVmpYAuXFrvSVsRIGffPplx4nk=; b=f5VCalrIFWg7N0M6TxgZKY+gC5zQwC6SDKDXrICXoL2gZFVrRxUgvZGnyjnADE2eqO QRns5uEF69DBJyWNT67DTADio0sxcBnCU/OIQ4vItXoAEM0fZxYeWeQXSZJhyQSVyEMQ U0ingeZ5PEIYTGwcchYDHYWIHCqlg6Joq8tgcI/BchaaHu5cUx2SgfiZUaqEPqEqpTTB oKMWtr/L2p0xtydRuZdqoButnYlcQqOPDaCYN3ZsaWtv17yvI0NuuIdtO3rXVHr5kIhz ZQrQoHVI/nW5rmOhHXsoAcN/le7FEUs/GIrwJAhD3ppbkVa6MHW49Xafd9gbi4d8f4V1 2FHg== X-Gm-Message-State: AOAM5309pNTPGSh7r22FtYxKaXKB1jXlmwFchKCUwoqVaLDJga4MzwfO xvLWKBRrnw6eQ/dpB+0zGUo= X-Google-Smtp-Source: ABdhPJzKHRpN7gEF064yyI6uHK9DoHuLx2LLT4PLDM9LCYl5VihNm2cIzm1UeMD0xnn7UN5ajHvQVg== X-Received: by 2002:a63:28c2:: with SMTP id o185mr1752428pgo.40.1618627191851; Fri, 16 Apr 2021 19:39:51 -0700 (PDT) Received: from localhost (193-116-90-211.tpgi.com.au. [193.116.90.211]) by smtp.gmail.com with ESMTPSA id k19sm6304711pgl.1.2021.04.16.19.39.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 16 Apr 2021 19:39:51 -0700 (PDT) Date: Sat, 17 Apr 2021 12:39:45 +1000 From: Nicholas Piggin Subject: Re: [PATCH v13 14/14] powerpc/64s/radix: Enable huge vmalloc mappings To: Andrew Morton , Christophe Leroy Cc: Ding Tianhong , Christoph Hellwig , Jonathan Cameron , linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linuxppc-dev@lists.ozlabs.org, Michael Ellerman , =?iso-8859-1?q?Rick=0A?= Edgecombe , Stephen Rothwell References: <20210317062402.533919-1-npiggin@gmail.com> <20210317062402.533919-15-npiggin@gmail.com> <20210415115529.9703ba8e9f7a38dea39efa56@linux-foundation.org> In-Reply-To: <20210415115529.9703ba8e9f7a38dea39efa56@linux-foundation.org> MIME-Version: 1.0 Message-Id: <1618627160.9nazv519mt.astroid@bobo.none> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Excerpts from Andrew Morton's message of April 16, 2021 4:55 am: > On Thu, 15 Apr 2021 12:23:55 +0200 Christophe Leroy wrote: >> > + * is done. STRICT_MODULE_RWX may require extra work to support this >> > + * too. >> > + */ >> > =20 >> > - return __vmalloc_node_range(size, 1, MODULES_VADDR, MODULES_END, GFP= _KERNEL, >> > - PAGE_KERNEL_EXEC, VM_FLUSH_RESET_PERMS, NUMA_NO_NODE, >>=20 >>=20 >> I think you should add the following in >>=20 >> #ifndef MODULES_VADDR >> #define MODULES_VADDR VMALLOC_START >> #define MODULES_END VMALLOC_END >> #endif >>=20 >> And leave module_alloc() as is (just removing the enclosing #ifdef MODUL= ES_VADDR and adding the=20 >> VM_NO_HUGE_VMAP flag) >>=20 >> This would minimise the conflits with the changes I did in powerpc/next = reported by Stephen R. >>=20 >=20 > I'll drop powerpc-64s-radix-enable-huge-vmalloc-mappings.patch for now, > make life simpler. Yeah that's fine. > Nick, a redo on top of Christophe's changes in linux-next would be best > please. Will do. Thanks, Nick From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.5 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EA225C433ED for ; Sat, 17 Apr 2021 02:40:25 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 61E7461107 for ; Sat, 17 Apr 2021 02:40:25 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 61E7461107 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4FMckb5jfZz3c6C for ; Sat, 17 Apr 2021 12:40:23 +1000 (AEST) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20161025 header.b=d+i0hnWp; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gmail.com (client-ip=2607:f8b0:4864:20::532; helo=mail-pg1-x532.google.com; envelope-from=npiggin@gmail.com; receiver=) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20161025 header.b=d+i0hnWp; dkim-atps=neutral Received: from mail-pg1-x532.google.com (mail-pg1-x532.google.com [IPv6:2607:f8b0:4864:20::532]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4FMck41Jw0z2yjL for ; Sat, 17 Apr 2021 12:39:55 +1000 (AEST) Received: by mail-pg1-x532.google.com with SMTP id t22so20430553pgu.0 for ; Fri, 16 Apr 2021 19:39:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:subject:to:cc:references:in-reply-to:mime-version :message-id:content-transfer-encoding; bh=rjTC8IKkPWGWDKmkZjVmpYAuXFrvSVsRIGffPplx4nk=; b=d+i0hnWpFX+Mj0V53vmK2vj8eRQNdZ7OmdBSqZs2JJu/wGdZaWjUSK5j03u+Qpqm/L JZoSxrNu88qDz90SkZdyhY8BYMglj4UmZjcr6iTK6UWLU0FqAmcd8fGLlLW1/vwJH7wv uZwheH6dxMQ1lPMdfOj75qaFpNBsekFCKLNIKBUCKAHiCRAF0DdRBY6UyDKiQziz4PNl OXUB/cWg0CbBphwRIMSOla1jFmUsP8imKGMwzwRREmU2d5lIuEVgaf0gxRGcDX3ZhLHv QWLgav7Bm3QDC+X/8lCvPBVXjQw1dbC6orZs1vwa6Fgu1hfu0U5vP03SdT7jUqw9PySn oCWQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:subject:to:cc:references:in-reply-to :mime-version:message-id:content-transfer-encoding; bh=rjTC8IKkPWGWDKmkZjVmpYAuXFrvSVsRIGffPplx4nk=; b=eZ0PBsiYwD3kn7eXcvp05GryToO+l8okBzd6FakWJFJJGU7p3Divmtu/AoaNd+XJVM b6rdsZXptXZeroXoof/JQxKSj9CySqWJOSR06/2hukDE+i/RLNlD+rr/3gmBDqlBG1Us QtNx+jZDvAR9OuAtJMDD3HWYqep86B7mUMfPQcxw+qaCSvDKd2tBgHZzA68ZOx0plXbK rMWsMOc/pEp66ktICdP7fDEIDd9V4vWlkswnM2D2xwJlZ1wtVx1AlgtCAom7u2yRqivk MQWrZnFeSqw8AUgBo45IfLh+O0cDEyyw8INUzVQUpCAu7YCgH68qHYHxC3BY1JZnp6rV uItA== X-Gm-Message-State: AOAM533LA07c1Sqkv6OzfRZ40WIT974RPclBsQL2Sq9MmoJ4cayuUbCG fMywLNyqOuBDhWfVL2nOv6w= X-Google-Smtp-Source: ABdhPJzKHRpN7gEF064yyI6uHK9DoHuLx2LLT4PLDM9LCYl5VihNm2cIzm1UeMD0xnn7UN5ajHvQVg== X-Received: by 2002:a63:28c2:: with SMTP id o185mr1752428pgo.40.1618627191851; Fri, 16 Apr 2021 19:39:51 -0700 (PDT) Received: from localhost (193-116-90-211.tpgi.com.au. [193.116.90.211]) by smtp.gmail.com with ESMTPSA id k19sm6304711pgl.1.2021.04.16.19.39.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 16 Apr 2021 19:39:51 -0700 (PDT) Date: Sat, 17 Apr 2021 12:39:45 +1000 From: Nicholas Piggin Subject: Re: [PATCH v13 14/14] powerpc/64s/radix: Enable huge vmalloc mappings To: Andrew Morton , Christophe Leroy References: <20210317062402.533919-1-npiggin@gmail.com> <20210317062402.533919-15-npiggin@gmail.com> <20210415115529.9703ba8e9f7a38dea39efa56@linux-foundation.org> In-Reply-To: <20210415115529.9703ba8e9f7a38dea39efa56@linux-foundation.org> MIME-Version: 1.0 Message-Id: <1618627160.9nazv519mt.astroid@bobo.none> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-arch@vger.kernel.org, Stephen Rothwell , Ding Tianhong , linux-kernel@vger.kernel.org, Christoph Hellwig , linux-mm@kvack.org, Jonathan Cameron , =?iso-8859-1?q?Rick=0A?= Edgecombe , linuxppc-dev@lists.ozlabs.org Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" Excerpts from Andrew Morton's message of April 16, 2021 4:55 am: > On Thu, 15 Apr 2021 12:23:55 +0200 Christophe Leroy wrote: >> > + * is done. STRICT_MODULE_RWX may require extra work to support this >> > + * too. >> > + */ >> > =20 >> > - return __vmalloc_node_range(size, 1, MODULES_VADDR, MODULES_END, GFP= _KERNEL, >> > - PAGE_KERNEL_EXEC, VM_FLUSH_RESET_PERMS, NUMA_NO_NODE, >>=20 >>=20 >> I think you should add the following in >>=20 >> #ifndef MODULES_VADDR >> #define MODULES_VADDR VMALLOC_START >> #define MODULES_END VMALLOC_END >> #endif >>=20 >> And leave module_alloc() as is (just removing the enclosing #ifdef MODUL= ES_VADDR and adding the=20 >> VM_NO_HUGE_VMAP flag) >>=20 >> This would minimise the conflits with the changes I did in powerpc/next = reported by Stephen R. >>=20 >=20 > I'll drop powerpc-64s-radix-enable-huge-vmalloc-mappings.patch for now, > make life simpler. Yeah that's fine. > Nick, a redo on top of Christophe's changes in linux-next would be best > please. Will do. Thanks, Nick