Re: [PATCH v3 00/30] target/mips: Re-org to allow KVM-only builds

[no-reply@patchew.org]

Patchew URL: https://patchew.org/QEMU/20210419191823.1555482-1-f4bug@amsat.org/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: 20210419191823.1555482-1-f4bug@amsat.org
Subject: [PATCH v3 00/30] target/mips: Re-org to allow KVM-only builds

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 - [tag update]      patchew/20210415215141.1865467-1-crosa@redhat.com -> patchew/20210415215141.1865467-1-crosa@redhat.com
 * [new tag]         patchew/20210419191823.1555482-1-f4bug@amsat.org -> patchew/20210419191823.1555482-1-f4bug@amsat.org
Switched to a new branch 'test'
81092a5 gitlab-ci: Add KVM mips64el cross-build jobs
599f90a hw/mips: Restrict non-virtualized machines to TCG
96d3db9 target/mips: Move TCG source files under tcg/ sub directory
ac05c2e target/mips: Move CP0 helpers to sysemu/cp0.c
8a08759 target/mips: Move exception management code to exception.c
835cb9b target/mips: Move TLB management helpers to tcg/sysemu/tlb_helper.c
5ea9141 target/mips: Move helper_cache() to tcg/sysemu/special_helper.c
b5730e6 target/mips: Move Special opcodes to tcg/sysemu/special_helper.c
ad82783 target/mips: Restrict CPUMIPSTLBContext::map_address() handlers scope
d406574 target/mips: Move tlb_helper.c to tcg/sysemu/
a108f18 target/mips: Restrict mmu_init() to TCG
371bbba target/mips: Move sysemu TCG-specific code to tcg/sysemu/ subfolder
d71e8e3 target/mips: Restrict cpu_mips_get_random() / update_pagemask() to TCG
5814d8e target/mips: Move physical addressing code to sysemu/physaddr.c
f186610 target/mips: Move sysemu specific files under sysemu/ subfolder
2f45566 target/mips: Move cpu_signal_handler definition around
fe33054 target/mips: Add simple user-mode mips_cpu_tlb_fill()
2a692bf target/mips: Add simple user-mode mips_cpu_do_interrupt()
381d0ec target/mips: Introduce tcg-internal.h for TCG specific declarations
5b69add meson: Introduce meson_user_arch source set for arch-specific user-mode
c5e43b4 target/mips: Extract load/store helpers to ldst_helper.c
2c88480 target/mips: Merge do_translate_address into cpu_mips_translate_address
87fde0b target/mips: Declare mips_cpu_set_error_pc() inlined in "internal.h"
32b579e target/mips: Turn printfpr() macro into a proper function
46c2010 target/mips: Restrict mips_cpu_dump_state() to cpu.c
fbb7662 target/mips: Optimize CPU/FPU regnames[] arrays
b09a6e5f target/mips: Make CPU/FPU regnames[] arrays global
79aa8aa target/mips: Move msa_reset() to new source file
999b551 target/mips: Move IEEE rounding mode array to new source file
425f9ab target/mips: Simplify meson TCG rules

=== OUTPUT BEGIN ===
1/30 Checking commit 425f9abc6fff (target/mips: Simplify meson TCG rules)
2/30 Checking commit 999b5510ae6c (target/mips: Move IEEE rounding mode array to new source file)
Use of uninitialized value $acpi_testexpected in string eq at ./scripts/checkpatch.pl line 1529.
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#31: 
new file mode 100644

total: 0 errors, 1 warnings, 39 lines checked

Patch 2/30 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
3/30 Checking commit 79aa8aa9862d (target/mips: Move msa_reset() to new source file)
Use of uninitialized value $acpi_testexpected in string eq at ./scripts/checkpatch.pl line 1529.
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#37: 
new file mode 100644

total: 0 errors, 1 warnings, 70 lines checked

Patch 3/30 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
4/30 Checking commit b09a6e5f3ab3 (target/mips: Make CPU/FPU regnames[] arrays global)
5/30 Checking commit fbb76626dda5 (target/mips: Optimize CPU/FPU regnames[] arrays)
6/30 Checking commit 46c20103b401 (target/mips: Restrict mips_cpu_dump_state() to cpu.c)
7/30 Checking commit 32b579ebe323 (target/mips: Turn printfpr() macro into a proper function)
8/30 Checking commit 87fde0b3548f (target/mips: Declare mips_cpu_set_error_pc() inlined in "internal.h")
9/30 Checking commit 2c88480fd743 (target/mips: Merge do_translate_address into cpu_mips_translate_address)
10/30 Checking commit c5e43b4cb247 (target/mips: Extract load/store helpers to ldst_helper.c)
Use of uninitialized value $acpi_testexpected in string eq at ./scripts/checkpatch.pl line 1529.
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#18: 
new file mode 100644

total: 0 errors, 1 warnings, 560 lines checked

Patch 10/30 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
11/30 Checking commit 5b69add8ad8e (meson: Introduce meson_user_arch source set for arch-specific user-mode)
12/30 Checking commit 381d0ec08b42 (target/mips: Introduce tcg-internal.h for TCG specific declarations)
Use of uninitialized value $acpi_testexpected in string eq at ./scripts/checkpatch.pl line 1529.
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#54: 
new file mode 100644

total: 0 errors, 1 warnings, 45 lines checked

Patch 12/30 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
13/30 Checking commit 2a692bf0fbaa (target/mips: Add simple user-mode mips_cpu_do_interrupt())
Use of uninitialized value $acpi_testexpected in string eq at ./scripts/checkpatch.pl line 1529.
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#54: 
new file mode 100644

total: 0 errors, 1 warnings, 76 lines checked

Patch 13/30 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
14/30 Checking commit fe330545abeb (target/mips: Add simple user-mode mips_cpu_tlb_fill())
15/30 Checking commit 2f455665e65c (target/mips: Move cpu_signal_handler definition around)
16/30 Checking commit f1866109f978 (target/mips: Move sysemu specific files under sysemu/ subfolder)
17/30 Checking commit 5814d8e0b469 (target/mips: Move physical addressing code to sysemu/physaddr.c)
Use of uninitialized value $acpi_testexpected in string eq at ./scripts/checkpatch.pl line 1529.
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#76: 
new file mode 100644

total: 0 errors, 1 warnings, 573 lines checked

Patch 17/30 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
18/30 Checking commit d71e8e3b7c2f (target/mips: Restrict cpu_mips_get_random() / update_pagemask() to TCG)
19/30 Checking commit 371bbba742e5 (target/mips: Move sysemu TCG-specific code to tcg/sysemu/ subfolder)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#19: 
 target/mips/{ => tcg/sysemu}/cp0_helper.c |   0

total: 0 errors, 1 warnings, 371 lines checked

Patch 19/30 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
20/30 Checking commit a108f187d9a9 (target/mips: Restrict mmu_init() to TCG)
21/30 Checking commit d406574cad95 (target/mips: Move tlb_helper.c to tcg/sysemu/)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#24: 
 target/mips/{ => tcg/sysemu}/tlb_helper.c | 3 ---

total: 0 errors, 1 warnings, 59 lines checked

Patch 21/30 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
22/30 Checking commit ad82783920ce (target/mips: Restrict CPUMIPSTLBContext::map_address() handlers scope)
23/30 Checking commit b5730e6d60e0 (target/mips: Move Special opcodes to tcg/sysemu/special_helper.c)
Use of uninitialized value $acpi_testexpected in string eq at ./scripts/checkpatch.pl line 1529.
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#194: 
new file mode 100644

total: 0 errors, 1 warnings, 311 lines checked

Patch 23/30 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
24/30 Checking commit 5ea9141c0463 (target/mips: Move helper_cache() to tcg/sysemu/special_helper.c)
25/30 Checking commit 835cb9b97d71 (target/mips: Move TLB management helpers to tcg/sysemu/tlb_helper.c)
ERROR: space prohibited after that '&' (ctx:WxW)
#456: FILE: target/mips/tcg/sysemu/tlb_helper.c:71:
+    tlb->XI0 = (env->CP0_EntryLo0 >> CP0EnLo_XI) & 1;
                                                  ^

ERROR: space prohibited after that '&' (ctx:WxW)
#457: FILE: target/mips/tcg/sysemu/tlb_helper.c:72:
+    tlb->RI0 = (env->CP0_EntryLo0 >> CP0EnLo_RI) & 1;
                                                  ^

ERROR: space prohibited after that '&' (ctx:WxW)
#462: FILE: target/mips/tcg/sysemu/tlb_helper.c:77:
+    tlb->XI1 = (env->CP0_EntryLo1 >> CP0EnLo_XI) & 1;
                                                  ^

ERROR: space prohibited after that '&' (ctx:WxW)
#463: FILE: target/mips/tcg/sysemu/tlb_helper.c:78:
+    tlb->RI1 = (env->CP0_EntryLo1 >> CP0EnLo_RI) & 1;
                                                  ^

total: 4 errors, 0 warnings, 720 lines checked

Patch 25/30 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

26/30 Checking commit 8a0875918466 (target/mips: Move exception management code to exception.c)
Use of uninitialized value $acpi_testexpected in string eq at ./scripts/checkpatch.pl line 1529.
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#158: 
new file mode 100644

total: 0 errors, 1 warnings, 402 lines checked

Patch 26/30 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
27/30 Checking commit ac05c2ef9c03 (target/mips: Move CP0 helpers to sysemu/cp0.c)
Use of uninitialized value $acpi_testexpected in string eq at ./scripts/checkpatch.pl line 1529.
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#161: 
new file mode 100644

ERROR: space prohibited after that '&' (ctx:WxW)
#205: FILE: target/mips/sysemu/cp0.c:40:
+    cu = (v >> CP0St_CU0) & 0xf;
                           ^

ERROR: space prohibited after that '&' (ctx:WxW)
#206: FILE: target/mips/sysemu/cp0.c:41:
+    mx = (v >> CP0St_MX) & 0x1;
                          ^

ERROR: space prohibited after that '&' (ctx:WxW)
#207: FILE: target/mips/sysemu/cp0.c:42:
+    ksu = (v >> CP0St_KSU) & 0x3;
                            ^

ERROR: space prohibited after that '&' (ctx:WxW)
#234: FILE: target/mips/sysemu/cp0.c:69:
+        uint32_t ksux = (1 << CP0St_KX) & val;
                                         ^

ERROR: space prohibited after that '&' (ctx:WxW)
#242: FILE: target/mips/sysemu/cp0.c:77:
+        mask &= ~(((1 << CP0St_SR) | (1 << CP0St_NMI)) & val);
                                                        ^

ERROR: space prohibited after that '&' (ctx:WxW)
#269: FILE: target/mips/sysemu/cp0.c:104:
+        mask &= ~((1 << CP0Ca_WP) & val);
                                   ^

ERROR: space prohibited after that '&' (ctx:WxW)
#274: FILE: target/mips/sysemu/cp0.c:109:
+    if ((old ^ env->CP0_Cause) & (1 << CP0Ca_DC)) {
                                ^

ERROR: space prohibited after that '&' (ctx:WxW)
#284: FILE: target/mips/sysemu/cp0.c:119:
+        if ((old ^ env->CP0_Cause) & (1 << (CP0Ca_IP + i))) {
                                    ^

total: 8 errors, 1 warnings, 257 lines checked

Patch 27/30 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

28/30 Checking commit 96d3db971b40 (target/mips: Move TCG source files under tcg/ sub directory)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#24: 
 target/mips/{ => tcg}/dsp_helper.c           |  0

total: 0 errors, 1 warnings, 144 lines checked

Patch 28/30 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
29/30 Checking commit 599f90aabbf8 (hw/mips: Restrict non-virtualized machines to TCG)
30/30 Checking commit 81092a51bc04 (gitlab-ci: Add KVM mips64el cross-build jobs)
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/20210419191823.1555482-1-f4bug@amsat.org/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com