From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: POSWALD@suse.com, mahesh.rajashekhara@microchip.com,
Don Brace <don.brace@microchip.com>,
mike.mcgowen@microchip.com, Kevin.Barnett@microchip.com,
scott.teel@microchip.com, joseph.szczypek@hpe.com,
scott.benesh@microchip.com, gerry.morong@microchip.com,
jejb@linux.vnet.ibm.com, hch@infradead.org,
murthy.bhat@microchip.com, Justin.Lindley@microchip.com
Cc: "Martin K . Petersen" <martin.petersen@oracle.com>,
linux-scsi@vger.kernel.org
Subject: Re: [PATCH 0/2] smartpqi fix static checker issues
Date: Mon, 19 Apr 2021 22:29:11 -0400 [thread overview]
Message-ID: <161888563602.11594.16470501854942163846.b4-ty@oracle.com> (raw)
In-Reply-To: <161850488487.7302.7018870513204678832.stgit@brunhilda>
On Thu, 15 Apr 2021 11:41:58 -0500, Don Brace wrote:
> These patches are based on Martin Peterson's 5.13/scsi-queue tree
>
> This set corrects two static checker warnings found by
> Dan Carpenter <dan.carpenter@oracle.com>
>
> smartpqi-fix-blocks_per_row-static-checker-issue
> Link: https://lore.kernel.org/linux-scsi/YG%2F5kWHHAr7w5dU5@mwanda/
> Fixes: 6702d2c40f31 ("scsi: smartpqi: Add support for RAID5 and RAID6 writes")
> Using rmd->blocks_per_row as a divisor without checking
> it for 0 first.
> The variable blocks_per_row is used as a divisor in many
> raid_map calculations. This can lead to a divide by 0.
> This patch prevents a possible divide by 0. If the member
> is 0, return PQI_RAID_BYPASS_INELIGIBLE before any division is
> performed. The current check for a non-0 value was after multiple
> divisions were performed.
>
> [...]
Applied to 5.13/scsi-queue, thanks!
[1/2] smartpqi: fix blocks_per_row static checker issue
https://git.kernel.org/mkp/scsi/c/667298ceaf04
[2/2] smartpqi: fix device pointer variable reference static checker issue
https://git.kernel.org/mkp/scsi/c/5cad5a507241
--
Martin K. Petersen Oracle Linux Engineering
prev parent reply other threads:[~2021-04-20 2:29 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-15 16:41 [PATCH 0/2] smartpqi fix static checker issues Don Brace
2021-04-15 16:42 ` [PATCH 1/2] smartpqi: fix blocks_per_row static checker issue Don Brace
2021-04-15 16:42 ` [PATCH 2/2] smartpqi: fix device pointer variable reference " Don Brace
2021-04-16 2:03 ` [PATCH 0/2] smartpqi fix static checker issues Martin K. Petersen
2021-04-20 2:29 ` Martin K. Petersen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=161888563602.11594.16470501854942163846.b4-ty@oracle.com \
--to=martin.petersen@oracle.com \
--cc=Justin.Lindley@microchip.com \
--cc=Kevin.Barnett@microchip.com \
--cc=POSWALD@suse.com \
--cc=don.brace@microchip.com \
--cc=gerry.morong@microchip.com \
--cc=hch@infradead.org \
--cc=jejb@linux.vnet.ibm.com \
--cc=joseph.szczypek@hpe.com \
--cc=linux-scsi@vger.kernel.org \
--cc=mahesh.rajashekhara@microchip.com \
--cc=mike.mcgowen@microchip.com \
--cc=murthy.bhat@microchip.com \
--cc=scott.benesh@microchip.com \
--cc=scott.teel@microchip.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.