From: Stephen Boyd <swboyd@chromium.org> To: Kuogee Hsieh <khsieh@codeaurora.org>, robdclark@gmail.com, sean@poorly.run Cc: abhinavk@codeaurora.org, aravindh@codeaurora.org, khsieh@codeaurora.org, airlied@linux.ie, daniel@ffwll.ch, linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2] drm/msm/dp: service only one irq_hpd if there are multiple irq_hpd pending Date: Tue, 20 Apr 2021 15:01:02 -0700 [thread overview] Message-ID: <161895606268.46595.2841353121480638642@swboyd.mtv.corp.google.com> (raw) In-Reply-To: <1618604877-28297-1-git-send-email-khsieh@codeaurora.org> Quoting Kuogee Hsieh (2021-04-16 13:27:57) > Some dongle may generate more than one irq_hpd events in a short period of > time. This patch will treat those irq_hpd events as single one and service > only one irq_hpd event. Why is it bad to get multiple irq_hpd events in a short period of time? Please tell us here in the commit text. > > Signed-off-by: Kuogee Hsieh <khsieh@codeaurora.org> > --- > drivers/gpu/drm/msm/dp/dp_display.c | 9 +++++++++ > 1 file changed, 9 insertions(+) > > diff --git a/drivers/gpu/drm/msm/dp/dp_display.c b/drivers/gpu/drm/msm/dp/dp_display.c > index 5a39da6..0a7d383 100644 > --- a/drivers/gpu/drm/msm/dp/dp_display.c > +++ b/drivers/gpu/drm/msm/dp/dp_display.c > @@ -707,6 +707,9 @@ static int dp_irq_hpd_handle(struct dp_display_private *dp, u32 data) > return 0; > } > > + /* only handle first irq_hpd in case of multiple irs_hpd pending */ > + dp_del_event(dp, EV_IRQ_HPD_INT); > + > ret = dp_display_usbpd_attention_cb(&dp->pdev->dev); > if (ret == -ECONNRESET) { /* cable unplugged */ > dp->core_initialized = false; > @@ -1300,6 +1303,9 @@ static int dp_pm_suspend(struct device *dev) > /* host_init will be called at pm_resume */ > dp->core_initialized = false; > > + /* system suspended, delete pending irq_hdps */ > + dp_del_event(dp, EV_IRQ_HPD_INT); What happens if I suspend my device and when this function is running I toggle my monitor to use the HDMI input that is connected instead of some other input, maybe the second HDMI input? Wouldn't that generate an HPD interrupt to grab the attention of this device? > + > mutex_unlock(&dp->event_mutex); > > return 0; > @@ -1496,6 +1502,9 @@ int msm_dp_display_disable(struct msm_dp *dp, struct drm_encoder *encoder) > /* stop sentinel checking */ > dp_del_event(dp_display, EV_DISCONNECT_PENDING_TIMEOUT); > > + /* link is down, delete pending irq_hdps */ > + dp_del_event(dp_display, EV_IRQ_HPD_INT); > + I'm becoming convinced that the whole kthread design and event queue is broken. These sorts of patches are working around the larger problem that the kthread is running independently of the driver and irqs can come in at any time but the event queue is not checked from the irq handler to debounce the irq event. Is the event queue necessary at all? I wonder if it would be simpler to just use an irq thread and process the hpd signal from there. Then we're guaranteed to not get an irq again until the irq thread is done processing the event. This would naturally debounce the irq hpd event that way. > dp_display_disable(dp_display, 0); > > rc = dp_display_unprepare(dp);
WARNING: multiple messages have this Message-ID (diff)
From: Stephen Boyd <swboyd@chromium.org> To: Kuogee Hsieh <khsieh@codeaurora.org>, robdclark@gmail.com, sean@poorly.run Cc: airlied@linux.ie, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, abhinavk@codeaurora.org, khsieh@codeaurora.org, dri-devel@lists.freedesktop.org, aravindh@codeaurora.org, freedreno@lists.freedesktop.org Subject: Re: [PATCH 1/2] drm/msm/dp: service only one irq_hpd if there are multiple irq_hpd pending Date: Tue, 20 Apr 2021 15:01:02 -0700 [thread overview] Message-ID: <161895606268.46595.2841353121480638642@swboyd.mtv.corp.google.com> (raw) In-Reply-To: <1618604877-28297-1-git-send-email-khsieh@codeaurora.org> Quoting Kuogee Hsieh (2021-04-16 13:27:57) > Some dongle may generate more than one irq_hpd events in a short period of > time. This patch will treat those irq_hpd events as single one and service > only one irq_hpd event. Why is it bad to get multiple irq_hpd events in a short period of time? Please tell us here in the commit text. > > Signed-off-by: Kuogee Hsieh <khsieh@codeaurora.org> > --- > drivers/gpu/drm/msm/dp/dp_display.c | 9 +++++++++ > 1 file changed, 9 insertions(+) > > diff --git a/drivers/gpu/drm/msm/dp/dp_display.c b/drivers/gpu/drm/msm/dp/dp_display.c > index 5a39da6..0a7d383 100644 > --- a/drivers/gpu/drm/msm/dp/dp_display.c > +++ b/drivers/gpu/drm/msm/dp/dp_display.c > @@ -707,6 +707,9 @@ static int dp_irq_hpd_handle(struct dp_display_private *dp, u32 data) > return 0; > } > > + /* only handle first irq_hpd in case of multiple irs_hpd pending */ > + dp_del_event(dp, EV_IRQ_HPD_INT); > + > ret = dp_display_usbpd_attention_cb(&dp->pdev->dev); > if (ret == -ECONNRESET) { /* cable unplugged */ > dp->core_initialized = false; > @@ -1300,6 +1303,9 @@ static int dp_pm_suspend(struct device *dev) > /* host_init will be called at pm_resume */ > dp->core_initialized = false; > > + /* system suspended, delete pending irq_hdps */ > + dp_del_event(dp, EV_IRQ_HPD_INT); What happens if I suspend my device and when this function is running I toggle my monitor to use the HDMI input that is connected instead of some other input, maybe the second HDMI input? Wouldn't that generate an HPD interrupt to grab the attention of this device? > + > mutex_unlock(&dp->event_mutex); > > return 0; > @@ -1496,6 +1502,9 @@ int msm_dp_display_disable(struct msm_dp *dp, struct drm_encoder *encoder) > /* stop sentinel checking */ > dp_del_event(dp_display, EV_DISCONNECT_PENDING_TIMEOUT); > > + /* link is down, delete pending irq_hdps */ > + dp_del_event(dp_display, EV_IRQ_HPD_INT); > + I'm becoming convinced that the whole kthread design and event queue is broken. These sorts of patches are working around the larger problem that the kthread is running independently of the driver and irqs can come in at any time but the event queue is not checked from the irq handler to debounce the irq event. Is the event queue necessary at all? I wonder if it would be simpler to just use an irq thread and process the hpd signal from there. Then we're guaranteed to not get an irq again until the irq thread is done processing the event. This would naturally debounce the irq hpd event that way. > dp_display_disable(dp_display, 0); > > rc = dp_display_unprepare(dp); _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2021-04-20 22:01 UTC|newest] Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-04-16 20:27 [PATCH 1/2] drm/msm/dp: service only one irq_hpd if there are multiple irq_hpd pending Kuogee Hsieh 2021-04-16 20:27 ` Kuogee Hsieh 2021-04-20 22:01 ` Stephen Boyd [this message] 2021-04-20 22:01 ` Stephen Boyd 2021-04-21 17:26 ` khsieh 2021-04-21 17:26 ` khsieh 2021-04-21 18:55 ` aravindh 2021-04-21 18:55 ` aravindh 2021-04-28 0:00 ` Stephen Boyd 2021-04-28 0:00 ` Stephen Boyd 2021-04-28 17:38 ` khsieh 2021-04-28 17:38 ` khsieh 2021-04-29 9:26 ` Stephen Boyd 2021-04-29 9:26 ` Stephen Boyd 2021-04-29 17:23 ` khsieh 2021-04-29 17:23 ` khsieh 2021-04-30 3:11 ` Stephen Boyd 2021-04-30 3:11 ` Stephen Boyd 2021-05-03 19:23 ` khsieh 2021-05-03 19:23 ` khsieh 2021-05-04 4:28 ` Stephen Boyd 2021-05-04 4:28 ` Stephen Boyd
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=161895606268.46595.2841353121480638642@swboyd.mtv.corp.google.com \ --to=swboyd@chromium.org \ --cc=abhinavk@codeaurora.org \ --cc=airlied@linux.ie \ --cc=aravindh@codeaurora.org \ --cc=daniel@ffwll.ch \ --cc=dri-devel@lists.freedesktop.org \ --cc=freedreno@lists.freedesktop.org \ --cc=khsieh@codeaurora.org \ --cc=linux-arm-msm@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=robdclark@gmail.com \ --cc=sean@poorly.run \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.