* [GIT PULL] KEYS: trusted fixes for 5.12-rc7
@ 2021-04-22 20:26 James Bottomley
2021-04-22 21:03 ` Linus Torvalds
2021-04-22 21:04 ` pr-tracker-bot
0 siblings, 2 replies; 3+ messages in thread
From: James Bottomley @ 2021-04-22 20:26 UTC (permalink / raw)
To: Andrew Morton, Linus Torvalds
Cc: linux-kernel, Mimi Zohar, jarkko, linux-integrity, keyrings,
David Howells
This is an urgent regression fix for a tpm patch set that went in this
merge window. It looks like a rebase before the original pull request
lost a tpm_try_get_ops() so we have a lock imbalance in our code which
is causing oopses. The original patch was correct on the mailing list.
I'm sending this in agreement with Mimi (as joint maintainers of
trusted keys) because Jarkko is off communing with the Reindeer or
whatever it is Finns do when on holiday.
git://git.kernel.org/pub/scm/linux/kernel/git/jejb/tpmdd.git fixes
The short changelog is:
James Bottomley (1):
KEYS: trusted: Fix TPM reservation for seal/unseal
And the diffstat:
security/keys/trusted-keys/trusted_tpm2.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
With full diff below.
James
---
diff --git a/security/keys/trusted-keys/trusted_tpm2.c b/security/keys/trusted-keys/trusted_tpm2.c
index e2a0ed5d02f0..c87c4df8703d 100644
--- a/security/keys/trusted-keys/trusted_tpm2.c
+++ b/security/keys/trusted-keys/trusted_tpm2.c
@@ -79,7 +79,7 @@ int tpm2_seal_trusted(struct tpm_chip *chip,
if (i == ARRAY_SIZE(tpm2_hash_map))
return -EINVAL;
- rc = tpm_buf_init(&buf, TPM2_ST_SESSIONS, TPM2_CC_CREATE);
+ rc = tpm_try_get_ops(chip);
if (rc)
return rc;
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [GIT PULL] KEYS: trusted fixes for 5.12-rc7
2021-04-22 20:26 [GIT PULL] KEYS: trusted fixes for 5.12-rc7 James Bottomley
@ 2021-04-22 21:03 ` Linus Torvalds
2021-04-22 21:04 ` pr-tracker-bot
1 sibling, 0 replies; 3+ messages in thread
From: Linus Torvalds @ 2021-04-22 21:03 UTC (permalink / raw)
To: James Bottomley
Cc: Andrew Morton, linux-kernel, Mimi Zohar, Jarkko Sakkinen,
linux-integrity, keyrings, David Howells
On Thu, Apr 22, 2021 at 1:26 PM James Bottomley
<James.Bottomley@hansenpartnership.com> wrote:
>
> I'm sending this in agreement with Mimi (as joint maintainers of
> trusted keys) because Jarkko is off communing with the Reindeer or
> whatever it is Finns do when on holiday.
"Communing with Reindeer" is unlikely except possibly as a euphemism
for "drinking".
The traditional Finnish thing would be to go to a small cottage by a
lake ("mökki") and relax while fishing, going to the sauna, and just
getting away from it all.
But whether that's what Jarkko does, who knows? It's not quite the
season for lake cottages yet - April in Finland is not generally the
most pleasant weather...
Pulled.
Linus
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [GIT PULL] KEYS: trusted fixes for 5.12-rc7
2021-04-22 20:26 [GIT PULL] KEYS: trusted fixes for 5.12-rc7 James Bottomley
2021-04-22 21:03 ` Linus Torvalds
@ 2021-04-22 21:04 ` pr-tracker-bot
1 sibling, 0 replies; 3+ messages in thread
From: pr-tracker-bot @ 2021-04-22 21:04 UTC (permalink / raw)
To: James Bottomley
Cc: Andrew Morton, Linus Torvalds, linux-kernel, Mimi Zohar, jarkko,
linux-integrity, keyrings, David Howells
The pull request you sent on Thu, 22 Apr 2021 13:26:48 -0700:
> git://git.kernel.org/pub/scm/linux/kernel/git/jejb/tpmdd.git fixes
has been merged into torvalds/linux.git:
https://git.kernel.org/torvalds/c/90c911ad7445ccec9936763f05fa5db6a3da53be
Thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/prtracker.html
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-04-22 21:04 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-22 20:26 [GIT PULL] KEYS: trusted fixes for 5.12-rc7 James Bottomley
2021-04-22 21:03 ` Linus Torvalds
2021-04-22 21:04 ` pr-tracker-bot
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.