* [Intel-gfx] [PATCH] drm/i915/gt: Disable HiZ Raw Stall Optimization on broken gen7
@ 2021-04-26 14:11 Simon Rettberg
2021-04-26 16:05 ` Ville Syrjälä
` (5 more replies)
0 siblings, 6 replies; 11+ messages in thread
From: Simon Rettberg @ 2021-04-26 14:11 UTC (permalink / raw)
To: intel-gfx; +Cc: development
When resetting CACHE_MODE registers, don't enable HiZ Raw Stall
Optimization on Ivybridge GT1 and Baytrail, as it causes severe glitches
when rendering any kind of 3D accelerated content.
This optimization is disabled on these platforms by default according to
official documentation from 01.org.
Fixes: ef99a60ffd9b ("drm/i915/gt: Clear CACHE_MODE prior to clearing residuals")
Fixes: 520d05a77b28 ("drm/i915/gt: Clear CACHE_MODE prior to clearing residuals")
BugLink: https://gitlab.freedesktop.org/drm/intel/-/issues/3081
BugLink: https://gitlab.freedesktop.org/drm/intel/-/issues/3404
BugLink: https://gitlab.freedesktop.org/drm/intel/-/issues/3071
Reviewed-By: Manuel Bentele <development@manuel-bentele.de>
Signed-off-by: Simon Rettberg <simon.rettberg@rz.uni-freiburg.de>
---
drivers/gpu/drm/i915/gt/gen7_renderclear.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/gt/gen7_renderclear.c b/drivers/gpu/drm/i915/gt/gen7_renderclear.c
index de575fdb0..21f08e538 100644
--- a/drivers/gpu/drm/i915/gt/gen7_renderclear.c
+++ b/drivers/gpu/drm/i915/gt/gen7_renderclear.c
@@ -397,7 +397,10 @@ static void emit_batch(struct i915_vma * const vma,
gen7_emit_pipeline_invalidate(&cmds);
batch_add(&cmds, MI_LOAD_REGISTER_IMM(2));
batch_add(&cmds, i915_mmio_reg_offset(CACHE_MODE_0_GEN7));
- batch_add(&cmds, 0xffff0000);
+ batch_add(&cmds, 0xffff0000 |
+ ((IS_IVB_GT1(i915) || IS_VALLEYVIEW(i915)) ?
+ HIZ_RAW_STALL_OPT_DISABLE :
+ 0));
batch_add(&cmds, i915_mmio_reg_offset(CACHE_MODE_1));
batch_add(&cmds, 0xffff0000 | PIXEL_SUBSPAN_COLLECT_OPT_DISABLE);
gen7_emit_pipeline_invalidate(&cmds);
--
2.25.1
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 11+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915/gt: Disable HiZ Raw Stall Optimization on broken gen7
2021-04-26 14:11 [Intel-gfx] [PATCH] drm/i915/gt: Disable HiZ Raw Stall Optimization on broken gen7 Simon Rettberg
@ 2021-04-26 16:05 ` Ville Syrjälä
2021-04-27 8:33 ` Simon Rettberg
2021-04-26 18:48 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for " Patchwork
` (4 subsequent siblings)
5 siblings, 1 reply; 11+ messages in thread
From: Ville Syrjälä @ 2021-04-26 16:05 UTC (permalink / raw)
To: Simon Rettberg; +Cc: intel-gfx, development
On Mon, Apr 26, 2021 at 04:11:24PM +0200, Simon Rettberg wrote:
> When resetting CACHE_MODE registers, don't enable HiZ Raw Stall
> Optimization on Ivybridge GT1 and Baytrail, as it causes severe glitches
> when rendering any kind of 3D accelerated content.
> This optimization is disabled on these platforms by default according to
> official documentation from 01.org.
>
> Fixes: ef99a60ffd9b ("drm/i915/gt: Clear CACHE_MODE prior to clearing residuals")
> Fixes: 520d05a77b28 ("drm/i915/gt: Clear CACHE_MODE prior to clearing residuals")
> BugLink: https://gitlab.freedesktop.org/drm/intel/-/issues/3081
> BugLink: https://gitlab.freedesktop.org/drm/intel/-/issues/3404
> BugLink: https://gitlab.freedesktop.org/drm/intel/-/issues/3071
> Reviewed-By: Manuel Bentele <development@manuel-bentele.de>
> Signed-off-by: Simon Rettberg <simon.rettberg@rz.uni-freiburg.de>
> ---
> drivers/gpu/drm/i915/gt/gen7_renderclear.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/gt/gen7_renderclear.c b/drivers/gpu/drm/i915/gt/gen7_renderclear.c
> index de575fdb0..21f08e538 100644
> --- a/drivers/gpu/drm/i915/gt/gen7_renderclear.c
> +++ b/drivers/gpu/drm/i915/gt/gen7_renderclear.c
> @@ -397,7 +397,10 @@ static void emit_batch(struct i915_vma * const vma,
> gen7_emit_pipeline_invalidate(&cmds);
> batch_add(&cmds, MI_LOAD_REGISTER_IMM(2));
> batch_add(&cmds, i915_mmio_reg_offset(CACHE_MODE_0_GEN7));
> - batch_add(&cmds, 0xffff0000);
> + batch_add(&cmds, 0xffff0000 |
> + ((IS_IVB_GT1(i915) || IS_VALLEYVIEW(i915)) ?
> + HIZ_RAW_STALL_OPT_DISABLE :
> + 0));
> batch_add(&cmds, i915_mmio_reg_offset(CACHE_MODE_1));
> batch_add(&cmds, 0xffff0000 | PIXEL_SUBSPAN_COLLECT_OPT_DISABLE);
> gen7_emit_pipeline_invalidate(&cmds);
CACHE_MODE* should be context saved. So there seems to be some kind
of more fundemental bug in this code if it manages to clobber
application contexts. Looking at the code it at least tries to
switch to the kernel context before emitting the w/a batch.
--
Ville Syrjälä
Intel
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 11+ messages in thread
* [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/gt: Disable HiZ Raw Stall Optimization on broken gen7
2021-04-26 14:11 [Intel-gfx] [PATCH] drm/i915/gt: Disable HiZ Raw Stall Optimization on broken gen7 Simon Rettberg
2021-04-26 16:05 ` Ville Syrjälä
@ 2021-04-26 18:48 ` Patchwork
2021-04-26 19:18 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
` (3 subsequent siblings)
5 siblings, 0 replies; 11+ messages in thread
From: Patchwork @ 2021-04-26 18:48 UTC (permalink / raw)
To: Simon Rettberg; +Cc: intel-gfx
== Series Details ==
Series: drm/i915/gt: Disable HiZ Raw Stall Optimization on broken gen7
URL : https://patchwork.freedesktop.org/series/89502/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip
9afaf45bfe53 drm/i915/gt: Disable HiZ Raw Stall Optimization on broken gen7
-:14: WARNING:UNKNOWN_COMMIT_ID: Unknown commit id '520d05a77b28', maybe rebased or not pulled?
#14:
Fixes: 520d05a77b28 ("drm/i915/gt: Clear CACHE_MODE prior to clearing residuals")
-:18: WARNING:BAD_SIGN_OFF: 'Reviewed-by:' is the preferred signature form
#18:
Reviewed-By: Manuel Bentele <development@manuel-bentele.de>
total: 0 errors, 2 warnings, 0 checks, 11 lines checked
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 11+ messages in thread
* [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/gt: Disable HiZ Raw Stall Optimization on broken gen7
2021-04-26 14:11 [Intel-gfx] [PATCH] drm/i915/gt: Disable HiZ Raw Stall Optimization on broken gen7 Simon Rettberg
2021-04-26 16:05 ` Ville Syrjälä
2021-04-26 18:48 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for " Patchwork
@ 2021-04-26 19:18 ` Patchwork
2021-04-27 3:10 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
` (2 subsequent siblings)
5 siblings, 0 replies; 11+ messages in thread
From: Patchwork @ 2021-04-26 19:18 UTC (permalink / raw)
To: Simon Rettberg; +Cc: intel-gfx
[-- Attachment #1.1: Type: text/plain, Size: 2348 bytes --]
== Series Details ==
Series: drm/i915/gt: Disable HiZ Raw Stall Optimization on broken gen7
URL : https://patchwork.freedesktop.org/series/89502/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_10011 -> Patchwork_19993
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19993/index.html
Known issues
------------
Here are the changes found in Patchwork_19993 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@amdgpu/amd_basic@query-info:
- fi-bsw-kefka: NOTRUN -> [SKIP][1] ([fdo#109271]) +17 similar issues
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19993/fi-bsw-kefka/igt@amdgpu/amd_basic@query-info.html
#### Possible fixes ####
* igt@i915_selftest@live@execlists:
- fi-bsw-kefka: [INCOMPLETE][2] ([i915#2782] / [i915#2940]) -> [PASS][3]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10011/fi-bsw-kefka/igt@i915_selftest@live@execlists.html
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19993/fi-bsw-kefka/igt@i915_selftest@live@execlists.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[i915#1222]: https://gitlab.freedesktop.org/drm/intel/issues/1222
[i915#2782]: https://gitlab.freedesktop.org/drm/intel/issues/2782
[i915#2940]: https://gitlab.freedesktop.org/drm/intel/issues/2940
Participating hosts (40 -> 38)
------------------------------
Missing (2): fi-bsw-cyan fi-bdw-samus
Build changes
-------------
* Linux: CI_DRM_10011 -> Patchwork_19993
CI-20190529: 20190529
CI_DRM_10011: 7e185a8c4fb2230187a8637e3885be57123cb7eb @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_6075: ccf602c569257291045415ff504a6d2460986c28 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_19993: 9afaf45bfe53ea60a3915232c0d0712263e34ba5 @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
9afaf45bfe53 drm/i915/gt: Disable HiZ Raw Stall Optimization on broken gen7
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19993/index.html
[-- Attachment #1.2: Type: text/html, Size: 2903 bytes --]
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 11+ messages in thread
* [Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/gt: Disable HiZ Raw Stall Optimization on broken gen7
2021-04-26 14:11 [Intel-gfx] [PATCH] drm/i915/gt: Disable HiZ Raw Stall Optimization on broken gen7 Simon Rettberg
` (2 preceding siblings ...)
2021-04-26 19:18 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
@ 2021-04-27 3:10 ` Patchwork
2021-05-13 0:18 ` [Intel-gfx] [PATCH] " Dave Airlie
2021-05-13 12:31 ` [Intel-gfx] ✗ Fi.CI.BUILD: failure for drm/i915/gt: Disable HiZ Raw Stall Optimization on broken gen7 (rev2) Patchwork
5 siblings, 0 replies; 11+ messages in thread
From: Patchwork @ 2021-04-27 3:10 UTC (permalink / raw)
To: Simon Rettberg; +Cc: intel-gfx
[-- Attachment #1.1: Type: text/plain, Size: 30285 bytes --]
== Series Details ==
Series: drm/i915/gt: Disable HiZ Raw Stall Optimization on broken gen7
URL : https://patchwork.freedesktop.org/series/89502/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_10011_full -> Patchwork_19993_full
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with Patchwork_19993_full absolutely need to be
verified manually.
If you think the reported changes have nothing to do with the changes
introduced in Patchwork_19993_full, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_19993_full:
### IGT changes ###
#### Possible regressions ####
* igt@kms_psr@psr2_primary_mmap_gtt:
- shard-tglb: [PASS][1] -> [DMESG-WARN][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10011/shard-tglb8/igt@kms_psr@psr2_primary_mmap_gtt.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19993/shard-tglb5/igt@kms_psr@psr2_primary_mmap_gtt.html
Known issues
------------
Here are the changes found in Patchwork_19993_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_ctx_persistence@legacy-engines-queued:
- shard-snb: NOTRUN -> [SKIP][3] ([fdo#109271] / [i915#1099]) +4 similar issues
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19993/shard-snb2/igt@gem_ctx_persistence@legacy-engines-queued.html
* igt@gem_ctx_ringsize@idle@bcs0:
- shard-skl: NOTRUN -> [INCOMPLETE][4] ([i915#3316])
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19993/shard-skl10/igt@gem_ctx_ringsize@idle@bcs0.html
* igt@gem_eio@unwedge-stress:
- shard-tglb: [PASS][5] -> [TIMEOUT][6] ([i915#2369] / [i915#3063])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10011/shard-tglb5/igt@gem_eio@unwedge-stress.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19993/shard-tglb7/igt@gem_eio@unwedge-stress.html
* igt@gem_exec_fair@basic-flow@rcs0:
- shard-skl: NOTRUN -> [SKIP][7] ([fdo#109271]) +87 similar issues
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19993/shard-skl10/igt@gem_exec_fair@basic-flow@rcs0.html
* igt@gem_exec_fair@basic-none-rrul@rcs0:
- shard-kbl: [PASS][8] -> [FAIL][9] ([i915#2842])
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10011/shard-kbl3/igt@gem_exec_fair@basic-none-rrul@rcs0.html
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19993/shard-kbl3/igt@gem_exec_fair@basic-none-rrul@rcs0.html
* igt@gem_exec_fair@basic-none-share@rcs0:
- shard-tglb: [PASS][10] -> [FAIL][11] ([i915#2842])
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10011/shard-tglb8/igt@gem_exec_fair@basic-none-share@rcs0.html
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19993/shard-tglb7/igt@gem_exec_fair@basic-none-share@rcs0.html
* igt@gem_exec_fair@basic-none@vcs0:
- shard-apl: [PASS][12] -> [FAIL][13] ([i915#2842])
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10011/shard-apl8/igt@gem_exec_fair@basic-none@vcs0.html
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19993/shard-apl8/igt@gem_exec_fair@basic-none@vcs0.html
* igt@gem_exec_fair@basic-none@vcs1:
- shard-iclb: NOTRUN -> [FAIL][14] ([i915#2842])
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19993/shard-iclb1/igt@gem_exec_fair@basic-none@vcs1.html
* igt@gem_exec_fair@basic-throttle@rcs0:
- shard-iclb: [PASS][15] -> [FAIL][16] ([i915#2849])
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10011/shard-iclb2/igt@gem_exec_fair@basic-throttle@rcs0.html
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19993/shard-iclb8/igt@gem_exec_fair@basic-throttle@rcs0.html
* igt@gem_exec_fence@parallel@rcs0:
- shard-glk: [PASS][17] -> [DMESG-WARN][18] ([i915#118] / [i915#95]) +2 similar issues
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10011/shard-glk2/igt@gem_exec_fence@parallel@rcs0.html
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19993/shard-glk8/igt@gem_exec_fence@parallel@rcs0.html
* igt@gem_pwrite@basic-exhaustion:
- shard-kbl: NOTRUN -> [WARN][19] ([i915#2658])
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19993/shard-kbl2/igt@gem_pwrite@basic-exhaustion.html
* igt@gem_userptr_blits@set-cache-level:
- shard-snb: NOTRUN -> [FAIL][20] ([i915#3324])
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19993/shard-snb2/igt@gem_userptr_blits@set-cache-level.html
* igt@gem_userptr_blits@vma-merge:
- shard-apl: NOTRUN -> [FAIL][21] ([i915#3318])
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19993/shard-apl8/igt@gem_userptr_blits@vma-merge.html
* igt@gen9_exec_parse@batch-invalid-length:
- shard-snb: NOTRUN -> [SKIP][22] ([fdo#109271]) +328 similar issues
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19993/shard-snb2/igt@gen9_exec_parse@batch-invalid-length.html
* igt@i915_pm_dc@dc6-psr:
- shard-skl: NOTRUN -> [FAIL][23] ([i915#454])
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19993/shard-skl10/igt@i915_pm_dc@dc6-psr.html
* igt@i915_suspend@forcewake:
- shard-kbl: [PASS][24] -> [INCOMPLETE][25] ([i915#155] / [i915#636])
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10011/shard-kbl6/igt@i915_suspend@forcewake.html
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19993/shard-kbl3/igt@i915_suspend@forcewake.html
* igt@kms_chamelium@dp-hpd-for-each-pipe:
- shard-kbl: NOTRUN -> [SKIP][26] ([fdo#109271] / [fdo#111827]) +5 similar issues
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19993/shard-kbl2/igt@kms_chamelium@dp-hpd-for-each-pipe.html
* igt@kms_chamelium@hdmi-hpd-storm-disable:
- shard-skl: NOTRUN -> [SKIP][27] ([fdo#109271] / [fdo#111827]) +6 similar issues
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19993/shard-skl2/igt@kms_chamelium@hdmi-hpd-storm-disable.html
* igt@kms_chamelium@hdmi-mode-timings:
- shard-snb: NOTRUN -> [SKIP][28] ([fdo#109271] / [fdo#111827]) +18 similar issues
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19993/shard-snb2/igt@kms_chamelium@hdmi-mode-timings.html
* igt@kms_color@pipe-b-ctm-0-75:
- shard-skl: [PASS][29] -> [DMESG-WARN][30] ([i915#1982])
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10011/shard-skl8/igt@kms_color@pipe-b-ctm-0-75.html
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19993/shard-skl8/igt@kms_color@pipe-b-ctm-0-75.html
* igt@kms_color_chamelium@pipe-a-ctm-limited-range:
- shard-apl: NOTRUN -> [SKIP][31] ([fdo#109271] / [fdo#111827]) +31 similar issues
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19993/shard-apl7/igt@kms_color_chamelium@pipe-a-ctm-limited-range.html
* igt@kms_content_protection@lic:
- shard-apl: NOTRUN -> [TIMEOUT][32] ([i915#1319]) +2 similar issues
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19993/shard-apl8/igt@kms_content_protection@lic.html
* igt@kms_content_protection@uevent:
- shard-apl: NOTRUN -> [FAIL][33] ([i915#2105])
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19993/shard-apl7/igt@kms_content_protection@uevent.html
* igt@kms_cursor_crc@pipe-d-cursor-max-size-sliding:
- shard-kbl: NOTRUN -> [SKIP][34] ([fdo#109271]) +30 similar issues
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19993/shard-kbl2/igt@kms_cursor_crc@pipe-d-cursor-max-size-sliding.html
* igt@kms_fbcon_fbt@fbc-suspend:
- shard-apl: [PASS][35] -> [INCOMPLETE][36] ([i915#180] / [i915#1982])
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10011/shard-apl3/igt@kms_fbcon_fbt@fbc-suspend.html
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19993/shard-apl6/igt@kms_fbcon_fbt@fbc-suspend.html
* igt@kms_fbcon_fbt@psr-suspend:
- shard-skl: [PASS][37] -> [INCOMPLETE][38] ([i915#198])
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10011/shard-skl8/igt@kms_fbcon_fbt@psr-suspend.html
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19993/shard-skl8/igt@kms_fbcon_fbt@psr-suspend.html
* igt@kms_flip@busy-flip@c-edp1:
- shard-skl: [PASS][39] -> [FAIL][40] ([i915#275])
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10011/shard-skl9/igt@kms_flip@busy-flip@c-edp1.html
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19993/shard-skl9/igt@kms_flip@busy-flip@c-edp1.html
* igt@kms_flip@flip-vs-expired-vblank-interruptible@a-dp1:
- shard-apl: NOTRUN -> [FAIL][41] ([i915#79])
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19993/shard-apl7/igt@kms_flip@flip-vs-expired-vblank-interruptible@a-dp1.html
* igt@kms_flip@flip-vs-suspend-interruptible@a-dp1:
- shard-kbl: [PASS][42] -> [DMESG-WARN][43] ([i915#180]) +6 similar issues
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10011/shard-kbl2/igt@kms_flip@flip-vs-suspend-interruptible@a-dp1.html
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19993/shard-kbl3/igt@kms_flip@flip-vs-suspend-interruptible@a-dp1.html
* igt@kms_flip@plain-flip-fb-recreate-interruptible@a-hdmi-a1:
- shard-glk: [PASS][44] -> [FAIL][45] ([i915#2122])
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10011/shard-glk8/igt@kms_flip@plain-flip-fb-recreate-interruptible@a-hdmi-a1.html
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19993/shard-glk2/igt@kms_flip@plain-flip-fb-recreate-interruptible@a-hdmi-a1.html
* igt@kms_pipe_crc_basic@nonblocking-crc-pipe-d-frame-sequence:
- shard-apl: NOTRUN -> [SKIP][46] ([fdo#109271] / [i915#533])
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19993/shard-apl8/igt@kms_pipe_crc_basic@nonblocking-crc-pipe-d-frame-sequence.html
* igt@kms_plane_alpha_blend@pipe-a-alpha-opaque-fb:
- shard-skl: NOTRUN -> [FAIL][47] ([fdo#108145] / [i915#265]) +1 similar issue
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19993/shard-skl2/igt@kms_plane_alpha_blend@pipe-a-alpha-opaque-fb.html
* igt@kms_plane_alpha_blend@pipe-a-alpha-transparent-fb:
- shard-skl: NOTRUN -> [FAIL][48] ([i915#265])
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19993/shard-skl10/igt@kms_plane_alpha_blend@pipe-a-alpha-transparent-fb.html
* igt@kms_plane_alpha_blend@pipe-c-alpha-basic:
- shard-apl: NOTRUN -> [FAIL][49] ([fdo#108145] / [i915#265]) +1 similar issue
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19993/shard-apl7/igt@kms_plane_alpha_blend@pipe-c-alpha-basic.html
* igt@kms_plane_alpha_blend@pipe-c-alpha-transparent-fb:
- shard-apl: NOTRUN -> [FAIL][50] ([i915#265])
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19993/shard-apl8/igt@kms_plane_alpha_blend@pipe-c-alpha-transparent-fb.html
* igt@kms_plane_scaling@scaler-with-clipping-clamping@pipe-c-scaler-with-clipping-clamping:
- shard-skl: NOTRUN -> [SKIP][51] ([fdo#109271] / [i915#2733])
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19993/shard-skl10/igt@kms_plane_scaling@scaler-with-clipping-clamping@pipe-c-scaler-with-clipping-clamping.html
* igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area-2:
- shard-apl: NOTRUN -> [SKIP][52] ([fdo#109271] / [i915#658]) +7 similar issues
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19993/shard-apl3/igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area-2.html
* igt@kms_psr2_sf@overlay-primary-update-sf-dmg-area-3:
- shard-kbl: NOTRUN -> [SKIP][53] ([fdo#109271] / [i915#658])
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19993/shard-kbl2/igt@kms_psr2_sf@overlay-primary-update-sf-dmg-area-3.html
* igt@kms_psr2_sf@plane-move-sf-dmg-area-3:
- shard-skl: NOTRUN -> [SKIP][54] ([fdo#109271] / [i915#658])
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19993/shard-skl1/igt@kms_psr2_sf@plane-move-sf-dmg-area-3.html
* igt@kms_psr@psr2_suspend:
- shard-iclb: [PASS][55] -> [SKIP][56] ([fdo#109441]) +2 similar issues
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10011/shard-iclb2/igt@kms_psr@psr2_suspend.html
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19993/shard-iclb8/igt@kms_psr@psr2_suspend.html
* igt@kms_sysfs_edid_timing:
- shard-apl: NOTRUN -> [FAIL][57] ([IGT#2])
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19993/shard-apl7/igt@kms_sysfs_edid_timing.html
* igt@kms_vblank@pipe-a-ts-continuation-suspend:
- shard-kbl: [PASS][58] -> [DMESG-WARN][59] ([i915#180] / [i915#295])
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10011/shard-kbl1/igt@kms_vblank@pipe-a-ts-continuation-suspend.html
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19993/shard-kbl7/igt@kms_vblank@pipe-a-ts-continuation-suspend.html
* igt@kms_vblank@pipe-c-ts-continuation-dpms-suspend:
- shard-kbl: [PASS][60] -> [INCOMPLETE][61] ([i915#155] / [i915#2405])
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10011/shard-kbl2/igt@kms_vblank@pipe-c-ts-continuation-dpms-suspend.html
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19993/shard-kbl3/igt@kms_vblank@pipe-c-ts-continuation-dpms-suspend.html
* igt@kms_vblank@pipe-d-wait-idle:
- shard-skl: NOTRUN -> [SKIP][62] ([fdo#109271] / [i915#533])
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19993/shard-skl1/igt@kms_vblank@pipe-d-wait-idle.html
* igt@kms_writeback@writeback-check-output:
- shard-apl: NOTRUN -> [SKIP][63] ([fdo#109271] / [i915#2437])
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19993/shard-apl6/igt@kms_writeback@writeback-check-output.html
* igt@kms_writeback@writeback-fb-id:
- shard-skl: NOTRUN -> [SKIP][64] ([fdo#109271] / [i915#2437])
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19993/shard-skl10/igt@kms_writeback@writeback-fb-id.html
* igt@perf@polling-small-buf:
- shard-skl: [PASS][65] -> [FAIL][66] ([i915#1722])
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10011/shard-skl1/igt@perf@polling-small-buf.html
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19993/shard-skl1/igt@perf@polling-small-buf.html
* igt@prime_nv_api@i915_nv_reimport_twice_check_flink_name:
- shard-apl: NOTRUN -> [SKIP][67] ([fdo#109271]) +291 similar issues
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19993/shard-apl7/igt@prime_nv_api@i915_nv_reimport_twice_check_flink_name.html
* igt@sysfs_clients@fair-0:
- shard-apl: NOTRUN -> [SKIP][68] ([fdo#109271] / [i915#2994]) +3 similar issues
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19993/shard-apl7/igt@sysfs_clients@fair-0.html
* igt@sysfs_clients@pidname:
- shard-skl: NOTRUN -> [SKIP][69] ([fdo#109271] / [i915#2994]) +1 similar issue
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19993/shard-skl10/igt@sysfs_clients@pidname.html
* igt@sysfs_preempt_timeout@timeout@rcs0:
- shard-skl: [PASS][70] -> [FAIL][71] ([i915#2821])
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10011/shard-skl2/igt@sysfs_preempt_timeout@timeout@rcs0.html
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19993/shard-skl2/igt@sysfs_preempt_timeout@timeout@rcs0.html
#### Possible fixes ####
* igt@gem_create@create-clear:
- shard-glk: [FAIL][72] ([i915#1888] / [i915#3160]) -> [PASS][73]
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10011/shard-glk3/igt@gem_create@create-clear.html
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19993/shard-glk6/igt@gem_create@create-clear.html
* igt@gem_ctx_persistence@many-contexts:
- shard-tglb: [FAIL][74] ([i915#2410]) -> [PASS][75]
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10011/shard-tglb1/igt@gem_ctx_persistence@many-contexts.html
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19993/shard-tglb3/igt@gem_ctx_persistence@many-contexts.html
* igt@gem_exec_fair@basic-deadline:
- shard-kbl: [FAIL][76] ([i915#2846]) -> [PASS][77]
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10011/shard-kbl4/igt@gem_exec_fair@basic-deadline.html
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19993/shard-kbl6/igt@gem_exec_fair@basic-deadline.html
* igt@gem_exec_fair@basic-none@rcs0:
- shard-glk: [FAIL][78] ([i915#2842]) -> [PASS][79]
[78]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10011/shard-glk2/igt@gem_exec_fair@basic-none@rcs0.html
[79]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19993/shard-glk8/igt@gem_exec_fair@basic-none@rcs0.html
* igt@gem_exec_fair@basic-none@vcs0:
- shard-kbl: [FAIL][80] ([i915#2842]) -> [PASS][81] +1 similar issue
[80]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10011/shard-kbl4/igt@gem_exec_fair@basic-none@vcs0.html
[81]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19993/shard-kbl6/igt@gem_exec_fair@basic-none@vcs0.html
* igt@gem_exec_fair@basic-pace@bcs0:
- shard-tglb: [FAIL][82] ([i915#2842]) -> [PASS][83] +2 similar issues
[82]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10011/shard-tglb1/igt@gem_exec_fair@basic-pace@bcs0.html
[83]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19993/shard-tglb2/igt@gem_exec_fair@basic-pace@bcs0.html
* igt@gem_exec_fair@basic-pace@vecs0:
- shard-kbl: [SKIP][84] ([fdo#109271]) -> [PASS][85] +2 similar issues
[84]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10011/shard-kbl1/igt@gem_exec_fair@basic-pace@vecs0.html
[85]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19993/shard-kbl6/igt@gem_exec_fair@basic-pace@vecs0.html
* igt@gem_mmap_gtt@cpuset-basic-small-copy-odd:
- shard-iclb: [FAIL][86] ([i915#307]) -> [PASS][87] +1 similar issue
[86]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10011/shard-iclb3/igt@gem_mmap_gtt@cpuset-basic-small-copy-odd.html
[87]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19993/shard-iclb2/igt@gem_mmap_gtt@cpuset-basic-small-copy-odd.html
* igt@i915_selftest@mock@requests:
- shard-skl: [INCOMPLETE][88] ([i915#198]) -> [PASS][89]
[88]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10011/shard-skl6/igt@i915_selftest@mock@requests.html
[89]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19993/shard-skl7/igt@i915_selftest@mock@requests.html
* igt@i915_suspend@fence-restore-tiled2untiled:
- shard-glk: [FAIL][90] -> [PASS][91]
[90]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10011/shard-glk3/igt@i915_suspend@fence-restore-tiled2untiled.html
[91]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19993/shard-glk4/igt@i915_suspend@fence-restore-tiled2untiled.html
* igt@kms_cursor_crc@pipe-a-cursor-suspend:
- shard-apl: [DMESG-WARN][92] ([i915#180]) -> [PASS][93]
[92]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10011/shard-apl6/igt@kms_cursor_crc@pipe-a-cursor-suspend.html
[93]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19993/shard-apl3/igt@kms_cursor_crc@pipe-a-cursor-suspend.html
* igt@kms_cursor_crc@pipe-b-cursor-256x85-sliding:
- shard-skl: [FAIL][94] ([i915#54]) -> [PASS][95]
[94]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10011/shard-skl1/igt@kms_cursor_crc@pipe-b-cursor-256x85-sliding.html
[95]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19993/shard-skl6/igt@kms_cursor_crc@pipe-b-cursor-256x85-sliding.html
* igt@kms_cursor_crc@pipe-c-cursor-suspend:
- shard-kbl: [DMESG-WARN][96] ([i915#180]) -> [PASS][97] +4 similar issues
[96]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10011/shard-kbl4/igt@kms_cursor_crc@pipe-c-cursor-suspend.html
[97]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19993/shard-kbl6/igt@kms_cursor_crc@pipe-c-cursor-suspend.html
* igt@kms_cursor_legacy@flip-vs-cursor-atomic:
- shard-skl: [FAIL][98] ([i915#2346]) -> [PASS][99] +2 similar issues
[98]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10011/shard-skl6/igt@kms_cursor_legacy@flip-vs-cursor-atomic.html
[99]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19993/shard-skl4/igt@kms_cursor_legacy@flip-vs-cursor-atomic.html
* igt@kms_flip@flip-vs-expired-vblank-interruptible@b-edp1:
- shard-skl: [FAIL][100] ([i915#2122]) -> [PASS][101]
[100]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10011/shard-skl7/igt@kms_flip@flip-vs-expired-vblank-interruptible@b-edp1.html
[101]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19993/shard-skl8/igt@kms_flip@flip-vs-expired-vblank-interruptible@b-edp1.html
* igt@kms_flip@flip-vs-suspend-interruptible@a-edp1:
- shard-skl: [DMESG-WARN][102] ([i915#1982]) -> [PASS][103]
[102]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10011/shard-skl4/igt@kms_flip@flip-vs-suspend-interruptible@a-edp1.html
[103]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19993/shard-skl9/igt@kms_flip@flip-vs-suspend-interruptible@a-edp1.html
* igt@kms_hdr@bpc-switch-dpms:
- shard-skl: [FAIL][104] ([i915#1188]) -> [PASS][105]
[104]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10011/shard-skl1/igt@kms_hdr@bpc-switch-dpms.html
[105]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19993/shard-skl4/igt@kms_hdr@bpc-switch-dpms.html
* igt@kms_plane_alpha_blend@pipe-b-coverage-7efc:
- shard-skl: [FAIL][106] ([fdo#108145] / [i915#265]) -> [PASS][107]
[106]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10011/shard-skl1/igt@kms_plane_alpha_blend@pipe-b-coverage-7efc.html
[107]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19993/shard-skl6/igt@kms_plane_alpha_blend@pipe-b-coverage-7efc.html
* igt@kms_psr@psr2_sprite_plane_move:
- shard-iclb: [SKIP][108] ([fdo#109441]) -> [PASS][109] +2 similar issues
[108]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10011/shard-iclb3/igt@kms_psr@psr2_sprite_plane_move.html
[109]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19993/shard-iclb2/igt@kms_psr@psr2_sprite_plane_move.html
* igt@perf@polling-parameterized:
- shard-iclb: [FAIL][110] ([i915#1542]) -> [PASS][111]
[110]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10011/shard-iclb5/igt@perf@polling-parameterized.html
[111]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19993/shard-iclb6/igt@perf@polling-parameterized.html
#### Warnings ####
* igt@gem_mmap_gtt@cpuset-big-copy-odd:
- shard-iclb: [FAIL][112] ([i915#2428]) -> [FAIL][113] ([i915#307])
[112]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10011/shard-iclb3/igt@gem_mmap_gtt@cpuset-big-copy-odd.html
[113]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19993/shard-iclb1/igt@gem_mmap_gtt@cpuset-big-copy-odd.html
* igt@i915_pm_rc6_residency@rc6-idle:
- shard-iclb: [WARN][114] ([i915#2684]) -> [WARN][115] ([i915#2681] / [i915#2684])
[114]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10011/shard-iclb2/igt@i915_pm_rc6_residency@rc6-idle.html
[115]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19993/shard-iclb8/igt@i915_pm_rc6_residency@rc6-idle.html
* igt@kms_dp_dsc@basic-dsc-enable-edp:
- shard-iclb: [DMESG-WARN][116] ([i915#1226]) -> [SKIP][117] ([fdo#109349])
[116]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10011/shard-iclb2/igt@kms_dp_dsc@basic-dsc-enable-edp.html
[117]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19993/shard-iclb8/igt@kms_dp_dsc@basic-dsc-enable-edp.html
* igt@kms_psr2_sf@cursor-plane-update-sf:
- shard-iclb: [SKIP][118] ([i915#2920]) -> [SKIP][119] ([i915#658]) +2 similar issues
[118]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10011/shard-iclb2/igt@kms_psr2_sf@cursor-plane-update-sf.html
[119]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19993/shard-iclb4/igt@kms_psr2_sf@cursor-plane-update-sf.html
* igt@kms_psr2_sf@primary-plane-update-sf-dmg-area-1:
- shard-iclb: [SKIP][120] ([i915#658]) -> [SKIP][121] ([i915#2920]) +3 similar issues
[120]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10011/shard-iclb6/igt@kms_psr2_sf@primary-plane-update-sf-dmg-area-1.html
[121]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19993/shard-iclb2/igt@kms_psr2_sf@primary-plane-update-sf-dmg-area-1.html
* igt@runner@aborted:
- shard-kbl: ([FAIL][122], [FAIL][123], [FAIL][124], [FAIL][125], [FAIL][126], [FAIL][127], [FAIL][128], [FAIL][129], [FAIL][130], [FAIL][131]) ([i915#1436] / [i915#180] / [i915#1814] / [i915#2292] / [i915#3002] / [i915#602]) -> ([FAIL][132], [FAIL][133], [FAIL][134], [FAIL][135], [FAIL][136], [FAIL][137], [FAIL][138], [FAIL][139], [FAIL][140], [FAIL][141], [FAIL][142]) ([i915#1436] / [i915#180] / [i915#1814] / [i915#2505] / [i915#3002] / [i915#602])
[122]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10011/shard-kbl7/igt@runner@aborted.html
[123]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10011/shard-kbl3/igt@runner@aborted.html
[124]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10011/shard-kbl3/igt@runner@aborted.html
[125]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10011/shard-kbl3/igt@runner@aborted.html
[126]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10011/shard-kbl7/igt@runner@aborted.html
[127]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10011/shard-kbl4/igt@runner@aborted.html
[128]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10011/shard-kbl3/igt@runner@aborted.html
[129]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10011/shard-kbl7/igt@runner@aborted.html
[130]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10011/shard-kbl1/igt@runner@aborted.html
[131]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10011/shard-kbl7/igt@runner@aborted.html
[132]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19993/shard-kbl3/igt@runner@aborted.html
[133]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19993/shard-kbl7/igt@runner@aborted.html
[134]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19993/shard-kbl7/igt@runner@aborted.html
[135]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19993/shard-kbl4/igt@runner@aborted.html
[136]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19993/shard-kbl3/igt@runner@aborted.html
[137]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19993/shard-kbl4/igt@runner@aborted.html
[138]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19993/shard-kbl3/igt@runner@aborted.html
[139]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19993/shard-kbl4/igt@runner@aborted.html
[140]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19993/shard-kbl3/igt@runner@aborted.html
[141]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19993/shard-kbl3/igt@runner@aborted.html
[142]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19993/shard-kbl6/igt@runner@aborted.html
- shard-apl: ([FAIL][143], [FAIL][144], [FAIL][145]) ([i915#1814] / [i915#3002]) -> ([FAIL][146], [FAIL][147], [FAIL][148]) ([i915#180] / [i915#3002])
[143]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10011/shard-apl6/igt@runner@aborted.html
[144]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10011/shard-apl2/igt@runner@aborted.html
[145]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10011/shard-apl8/igt@runner@aborted.html
[146]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19993/shard-apl1/igt@runner@aborted.html
[147]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19993/shard-apl2/igt@runner@aborted.html
[148]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19993/shard-apl6/igt@runner@aborted.html
- shard-skl: ([FAIL][149], [FAIL][150], [FAIL][151], [FAIL][152], [FAIL][153], [FAIL][154]) ([i915#1436] / [i915#1814] / [i915#2029] / [i915#2722] / [i915#3002]) -> ([FAIL][155], [FAIL][156], [FAIL][157]) ([i915#1814] / [i915#2029] / [i915#3002])
[149]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10011/shard-skl2/igt@runner@aborted.html
[150]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10011/shard-skl2/igt@runner@aborted.html
[151]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10011/shard-skl6/igt@runner@aborted.html
[152]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10011/shard-skl2/igt@runner@aborted.html
[153]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10011/shard-skl9/igt@runner@aborted.html
[154]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10011/shard-skl2/igt@runner@aborted.html
[155]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19993/shard-skl6/igt@runner@aborted.html
[156]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19993/shard-skl2/igt@runner@aborted.html
[157]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19993/shard-skl10/igt@runner@aborted.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[IGT#2]: https://gitlab.freedesktop.org/drm/igt-gpu-tools/issues/2
[fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109349]: https://bugs.freedesktop.org/show_bug.cgi?id=109349
[fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[i915#1099]: https://gitlab.freedesktop.org/drm/intel/issues/1099
[i915#118
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19993/index.html
[-- Attachment #1.2: Type: text/html, Size: 35090 bytes --]
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915/gt: Disable HiZ Raw Stall Optimization on broken gen7
2021-04-26 16:05 ` Ville Syrjälä
@ 2021-04-27 8:33 ` Simon Rettberg
0 siblings, 0 replies; 11+ messages in thread
From: Simon Rettberg @ 2021-04-27 8:33 UTC (permalink / raw)
To: Ville Syrjälä; +Cc: intel-gfx, development
Am Mon, 26 Apr 2021 19:05:40 +0300
schrieb Ville Syrjälä <ville.syrjala@linux.intel.com>:
> On Mon, Apr 26, 2021 at 04:11:24PM +0200, Simon Rettberg wrote:
> > When resetting CACHE_MODE registers, don't enable HiZ Raw Stall
> > Optimization on Ivybridge GT1 and Baytrail, as it causes severe
> > glitches when rendering any kind of 3D accelerated content.
> > This optimization is disabled on these platforms by default
> > according to official documentation from 01.org.
> >
> > Fixes: ef99a60ffd9b ("drm/i915/gt: Clear CACHE_MODE prior to
> > clearing residuals") Fixes: 520d05a77b28 ("drm/i915/gt: Clear
> > CACHE_MODE prior to clearing residuals") BugLink:
> > https://gitlab.freedesktop.org/drm/intel/-/issues/3081 BugLink:
> > https://gitlab.freedesktop.org/drm/intel/-/issues/3404 BugLink:
> > https://gitlab.freedesktop.org/drm/intel/-/issues/3071 Reviewed-By:
> > Manuel Bentele <development@manuel-bentele.de> Signed-off-by: Simon
> > Rettberg <simon.rettberg@rz.uni-freiburg.de> ---
> > drivers/gpu/drm/i915/gt/gen7_renderclear.c | 5 ++++-
> > 1 file changed, 4 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/i915/gt/gen7_renderclear.c
> > b/drivers/gpu/drm/i915/gt/gen7_renderclear.c index
> > de575fdb0..21f08e538 100644 ---
> > a/drivers/gpu/drm/i915/gt/gen7_renderclear.c +++
> > b/drivers/gpu/drm/i915/gt/gen7_renderclear.c @@ -397,7 +397,10 @@
> > static void emit_batch(struct i915_vma * const vma,
> > gen7_emit_pipeline_invalidate(&cmds); batch_add(&cmds,
> > MI_LOAD_REGISTER_IMM(2)); batch_add(&cmds,
> > i915_mmio_reg_offset(CACHE_MODE_0_GEN7));
> > - batch_add(&cmds, 0xffff0000);
> > + batch_add(&cmds, 0xffff0000 |
> > + ((IS_IVB_GT1(i915) || IS_VALLEYVIEW(i915))
> > ?
> > + HIZ_RAW_STALL_OPT_DISABLE :
> > + 0));
> > batch_add(&cmds, i915_mmio_reg_offset(CACHE_MODE_1));
> > batch_add(&cmds, 0xffff0000 |
> > PIXEL_SUBSPAN_COLLECT_OPT_DISABLE);
> > gen7_emit_pipeline_invalidate(&cmds);
>
> CACHE_MODE* should be context saved. So there seems to be some kind
> of more fundemental bug in this code if it manages to clobber
> application contexts. Looking at the code it at least tries to
> switch to the kernel context before emitting the w/a batch.
We got a hunch about this while poking at the code, but lack expertise
and knowledge about i915 or drm in general.
The idea was that according to our understanding, this whole code
exists because some state is not properly cleared/restored when
switching between vGPUs. So on a normal desktop system this code gets
called only once, at boot-up. Assuming there isn't an actual bug in the
code somewhere else, could there be a similar issue when switching
between kernel and application context? The fact that there's already
another optimization explicitly disabled for CACHE_MODE_1 in this very
code fragment seems to support this theory.
Anyways, even though this only affects hardware that's close to a
decade old, this is a rather serious issue as it breaks anything 3D
accelerated; this bug has made it into the mainline kernel with 5.10.13,
and as distros will start to pick up newer kernels I can see a lot of
reports pouring in. Ubuntu 21.04 with Kernel 5.11 was just released and
suffers from this issue as well.
So a stop-gap solution like this patch, or just fully reverting the
commit in question might be reasonable if the underlying issue cannot
be found.
Simon
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915/gt: Disable HiZ Raw Stall Optimization on broken gen7
2021-04-26 14:11 [Intel-gfx] [PATCH] drm/i915/gt: Disable HiZ Raw Stall Optimization on broken gen7 Simon Rettberg
` (3 preceding siblings ...)
2021-04-27 3:10 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
@ 2021-05-13 0:18 ` Dave Airlie
2021-05-13 11:30 ` Rodrigo Vivi
2021-05-13 12:31 ` [Intel-gfx] ✗ Fi.CI.BUILD: failure for drm/i915/gt: Disable HiZ Raw Stall Optimization on broken gen7 (rev2) Patchwork
5 siblings, 1 reply; 11+ messages in thread
From: Dave Airlie @ 2021-05-13 0:18 UTC (permalink / raw)
To: Simon Rettberg, Jani Nikula, Jason Ekstrand
Cc: Intel Graphics Development, development
Reviewed-by: Dave Airlie <airlied@redhat.com>
Can we get this fix in, having a regression spanning 3 kernels isn't a
good look, we can work out why it matters later in life if anyone
cares.
Dave.
On Tue, 27 Apr 2021 at 00:31, Simon Rettberg
<simon.rettberg@rz.uni-freiburg.de> wrote:
>
> When resetting CACHE_MODE registers, don't enable HiZ Raw Stall
> Optimization on Ivybridge GT1 and Baytrail, as it causes severe glitches
> when rendering any kind of 3D accelerated content.
> This optimization is disabled on these platforms by default according to
> official documentation from 01.org.
>
> Fixes: ef99a60ffd9b ("drm/i915/gt: Clear CACHE_MODE prior to clearing residuals")
> Fixes: 520d05a77b28 ("drm/i915/gt: Clear CACHE_MODE prior to clearing residuals")
> BugLink: https://gitlab.freedesktop.org/drm/intel/-/issues/3081
> BugLink: https://gitlab.freedesktop.org/drm/intel/-/issues/3404
> BugLink: https://gitlab.freedesktop.org/drm/intel/-/issues/3071
> Reviewed-By: Manuel Bentele <development@manuel-bentele.de>
> Signed-off-by: Simon Rettberg <simon.rettberg@rz.uni-freiburg.de>
> ---
> drivers/gpu/drm/i915/gt/gen7_renderclear.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/gt/gen7_renderclear.c b/drivers/gpu/drm/i915/gt/gen7_renderclear.c
> index de575fdb0..21f08e538 100644
> --- a/drivers/gpu/drm/i915/gt/gen7_renderclear.c
> +++ b/drivers/gpu/drm/i915/gt/gen7_renderclear.c
> @@ -397,7 +397,10 @@ static void emit_batch(struct i915_vma * const vma,
> gen7_emit_pipeline_invalidate(&cmds);
> batch_add(&cmds, MI_LOAD_REGISTER_IMM(2));
> batch_add(&cmds, i915_mmio_reg_offset(CACHE_MODE_0_GEN7));
> - batch_add(&cmds, 0xffff0000);
> + batch_add(&cmds, 0xffff0000 |
> + ((IS_IVB_GT1(i915) || IS_VALLEYVIEW(i915)) ?
> + HIZ_RAW_STALL_OPT_DISABLE :
> + 0));
> batch_add(&cmds, i915_mmio_reg_offset(CACHE_MODE_1));
> batch_add(&cmds, 0xffff0000 | PIXEL_SUBSPAN_COLLECT_OPT_DISABLE);
> gen7_emit_pipeline_invalidate(&cmds);
> --
> 2.25.1
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915/gt: Disable HiZ Raw Stall Optimization on broken gen7
2021-05-13 0:18 ` [Intel-gfx] [PATCH] " Dave Airlie
@ 2021-05-13 11:30 ` Rodrigo Vivi
2021-05-18 8:30 ` Simon Rettberg
0 siblings, 1 reply; 11+ messages in thread
From: Rodrigo Vivi @ 2021-05-13 11:30 UTC (permalink / raw)
To: Dave Airlie; +Cc: development, Intel Graphics Development
On Thu, May 13, 2021 at 10:18:49AM +1000, Dave Airlie wrote:
> Reviewed-by: Dave Airlie <airlied@redhat.com>
>
> Can we get this fix in, having a regression spanning 3 kernels isn't a
> good look, we can work out why it matters later in life if anyone
> cares.
Agreed and pushed do drm-intel-next.
This triggered me to do an archeology work here and I found a possible
alternative for ILK:
+#define HIZ_UNIT_CLOCK_GATE_DISABLE REG_BIT(5)
#define FDI_PLL_FREQ_CTL _MMIO(0x46030)
#define FDI_PLL_FREQ_CHANGE_REQUEST (1 << 24)
diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c
index 06d5b7cc8b62..6316b70978f7 100644
--- a/drivers/gpu/drm/i915/intel_pm.c
+++ b/drivers/gpu/drm/i915/intel_pm.c
@@ -6892,8 +6892,11 @@ static void ilk_init_clock_gating(struct drm_i915_private *dev_priv)
intel_uncore_write(&dev_priv->uncore, PCH_3DCGDIS0,
MARIUNIT_CLOCK_GATE_DISABLE |
SVSMUNIT_CLOCK_GATE_DISABLE);
+
+ /* WaDisableHizUnitClockGating:ilk */
intel_uncore_write(&dev_priv->uncore, PCH_3DCGDIS1,
- VFMUNIT_CLOCK_GATE_DISABLE);
+ VFMUNIT_CLOCK_GATE_DISABLE |
+ HIZ_UNIT_CLOCK_GATE_DISABLE);
however I couldn't find anything for Baytrail, so let's move with this
one for now.
>
> Dave.
>
> On Tue, 27 Apr 2021 at 00:31, Simon Rettberg
> <simon.rettberg@rz.uni-freiburg.de> wrote:
> >
> > When resetting CACHE_MODE registers, don't enable HiZ Raw Stall
> > Optimization on Ivybridge GT1 and Baytrail, as it causes severe glitches
> > when rendering any kind of 3D accelerated content.
> > This optimization is disabled on these platforms by default according to
> > official documentation from 01.org.
> >
> > Fixes: ef99a60ffd9b ("drm/i915/gt: Clear CACHE_MODE prior to clearing residuals")
> > Fixes: 520d05a77b28 ("drm/i915/gt: Clear CACHE_MODE prior to clearing residuals")
> > BugLink: https://gitlab.freedesktop.org/drm/intel/-/issues/3081
> > BugLink: https://gitlab.freedesktop.org/drm/intel/-/issues/3404
> > BugLink: https://gitlab.freedesktop.org/drm/intel/-/issues/3071
> > Reviewed-By: Manuel Bentele <development@manuel-bentele.de>
> > Signed-off-by: Simon Rettberg <simon.rettberg@rz.uni-freiburg.de>
> > ---
> > drivers/gpu/drm/i915/gt/gen7_renderclear.c | 5 ++++-
> > 1 file changed, 4 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/i915/gt/gen7_renderclear.c b/drivers/gpu/drm/i915/gt/gen7_renderclear.c
> > index de575fdb0..21f08e538 100644
> > --- a/drivers/gpu/drm/i915/gt/gen7_renderclear.c
> > +++ b/drivers/gpu/drm/i915/gt/gen7_renderclear.c
> > @@ -397,7 +397,10 @@ static void emit_batch(struct i915_vma * const vma,
> > gen7_emit_pipeline_invalidate(&cmds);
> > batch_add(&cmds, MI_LOAD_REGISTER_IMM(2));
> > batch_add(&cmds, i915_mmio_reg_offset(CACHE_MODE_0_GEN7));
> > - batch_add(&cmds, 0xffff0000);
> > + batch_add(&cmds, 0xffff0000 |
> > + ((IS_IVB_GT1(i915) || IS_VALLEYVIEW(i915)) ?
> > + HIZ_RAW_STALL_OPT_DISABLE :
> > + 0));
> > batch_add(&cmds, i915_mmio_reg_offset(CACHE_MODE_1));
> > batch_add(&cmds, 0xffff0000 | PIXEL_SUBSPAN_COLLECT_OPT_DISABLE);
> > gen7_emit_pipeline_invalidate(&cmds);
> > --
> > 2.25.1
> >
> > _______________________________________________
> > Intel-gfx mailing list
> > Intel-gfx@lists.freedesktop.org
> > https://lists.freedesktop.org/mailman/listinfo/intel-gfx
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 11+ messages in thread
* [Intel-gfx] ✗ Fi.CI.BUILD: failure for drm/i915/gt: Disable HiZ Raw Stall Optimization on broken gen7 (rev2)
2021-04-26 14:11 [Intel-gfx] [PATCH] drm/i915/gt: Disable HiZ Raw Stall Optimization on broken gen7 Simon Rettberg
` (4 preceding siblings ...)
2021-05-13 0:18 ` [Intel-gfx] [PATCH] " Dave Airlie
@ 2021-05-13 12:31 ` Patchwork
5 siblings, 0 replies; 11+ messages in thread
From: Patchwork @ 2021-05-13 12:31 UTC (permalink / raw)
To: Rodrigo Vivi; +Cc: intel-gfx
== Series Details ==
Series: drm/i915/gt: Disable HiZ Raw Stall Optimization on broken gen7 (rev2)
URL : https://patchwork.freedesktop.org/series/89502/
State : failure
== Summary ==
Applying: drm/i915/gt: Disable HiZ Raw Stall Optimization on broken gen7
error: corrupt patch at line 16
error: could not build fake ancestor
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 drm/i915/gt: Disable HiZ Raw Stall Optimization on broken gen7
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915/gt: Disable HiZ Raw Stall Optimization on broken gen7
2021-05-13 11:30 ` Rodrigo Vivi
@ 2021-05-18 8:30 ` Simon Rettberg
2021-05-18 12:59 ` Rodrigo Vivi
0 siblings, 1 reply; 11+ messages in thread
From: Simon Rettberg @ 2021-05-18 8:30 UTC (permalink / raw)
To: Rodrigo Vivi; +Cc: Intel Graphics Development, development
Am Thu, 13 May 2021 07:30:17 -0400
schrieb Rodrigo Vivi <rodrigo.vivi@intel.com>:
> On Thu, May 13, 2021 at 10:18:49AM +1000, Dave Airlie wrote:
> > Reviewed-by: Dave Airlie <airlied@redhat.com>
> >
> > Can we get this fix in, having a regression spanning 3 kernels
> > isn't a good look, we can work out why it matters later in life if
> > anyone cares.
>
> Agreed and pushed do drm-intel-next.
What's the status here? I can't seem to find the fix in drm-intel-next.
- Simon
>
> This triggered me to do an archeology work here and I found a possible
> alternative for ILK:
>
> +#define HIZ_UNIT_CLOCK_GATE_DISABLE REG_BIT(5)
>
> #define FDI_PLL_FREQ_CTL _MMIO(0x46030)
> #define FDI_PLL_FREQ_CHANGE_REQUEST (1 << 24)
> diff --git a/drivers/gpu/drm/i915/intel_pm.c
> b/drivers/gpu/drm/i915/intel_pm.c index 06d5b7cc8b62..6316b70978f7
> 100644 --- a/drivers/gpu/drm/i915/intel_pm.c
> +++ b/drivers/gpu/drm/i915/intel_pm.c
> @@ -6892,8 +6892,11 @@ static void ilk_init_clock_gating(struct
> drm_i915_private *dev_priv) intel_uncore_write(&dev_priv->uncore,
> PCH_3DCGDIS0, MARIUNIT_CLOCK_GATE_DISABLE |
> SVSMUNIT_CLOCK_GATE_DISABLE);
> +
> + /* WaDisableHizUnitClockGating:ilk */
> intel_uncore_write(&dev_priv->uncore, PCH_3DCGDIS1,
> - VFMUNIT_CLOCK_GATE_DISABLE);
> + VFMUNIT_CLOCK_GATE_DISABLE |
> + HIZ_UNIT_CLOCK_GATE_DISABLE);
>
> however I couldn't find anything for Baytrail, so let's move with this
> one for now.
>
> >
> > Dave.
> >
> > On Tue, 27 Apr 2021 at 00:31, Simon Rettberg
> > <simon.rettberg@rz.uni-freiburg.de> wrote:
> > >
> > > When resetting CACHE_MODE registers, don't enable HiZ Raw Stall
> > > Optimization on Ivybridge GT1 and Baytrail, as it causes severe
> > > glitches when rendering any kind of 3D accelerated content.
> > > This optimization is disabled on these platforms by default
> > > according to official documentation from 01.org.
> > >
> > > Fixes: ef99a60ffd9b ("drm/i915/gt: Clear CACHE_MODE prior to
> > > clearing residuals") Fixes: 520d05a77b28 ("drm/i915/gt: Clear
> > > CACHE_MODE prior to clearing residuals") BugLink:
> > > https://gitlab.freedesktop.org/drm/intel/-/issues/3081 BugLink:
> > > https://gitlab.freedesktop.org/drm/intel/-/issues/3404 BugLink:
> > > https://gitlab.freedesktop.org/drm/intel/-/issues/3071
> > > Reviewed-By: Manuel Bentele <development@manuel-bentele.de>
> > > Signed-off-by: Simon Rettberg <simon.rettberg@rz.uni-freiburg.de>
> > > --- drivers/gpu/drm/i915/gt/gen7_renderclear.c | 5 ++++-
> > > 1 file changed, 4 insertions(+), 1 deletion(-)
> > >
> > > diff --git a/drivers/gpu/drm/i915/gt/gen7_renderclear.c
> > > b/drivers/gpu/drm/i915/gt/gen7_renderclear.c index
> > > de575fdb0..21f08e538 100644 ---
> > > a/drivers/gpu/drm/i915/gt/gen7_renderclear.c +++
> > > b/drivers/gpu/drm/i915/gt/gen7_renderclear.c @@ -397,7 +397,10 @@
> > > static void emit_batch(struct i915_vma * const vma,
> > > gen7_emit_pipeline_invalidate(&cmds); batch_add(&cmds,
> > > MI_LOAD_REGISTER_IMM(2)); batch_add(&cmds,
> > > i915_mmio_reg_offset(CACHE_MODE_0_GEN7));
> > > - batch_add(&cmds, 0xffff0000);
> > > + batch_add(&cmds, 0xffff0000 |
> > > + ((IS_IVB_GT1(i915) ||
> > > IS_VALLEYVIEW(i915)) ?
> > > + HIZ_RAW_STALL_OPT_DISABLE :
> > > + 0));
> > > batch_add(&cmds, i915_mmio_reg_offset(CACHE_MODE_1));
> > > batch_add(&cmds, 0xffff0000 |
> > > PIXEL_SUBSPAN_COLLECT_OPT_DISABLE);
> > > gen7_emit_pipeline_invalidate(&cmds); --
> > > 2.25.1
> > >
> > > _______________________________________________
> > > Intel-gfx mailing list
> > > Intel-gfx@lists.freedesktop.org
> > > https://lists.freedesktop.org/mailman/listinfo/intel-gfx
> > _______________________________________________
> > Intel-gfx mailing list
> > Intel-gfx@lists.freedesktop.org
> > https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915/gt: Disable HiZ Raw Stall Optimization on broken gen7
2021-05-18 8:30 ` Simon Rettberg
@ 2021-05-18 12:59 ` Rodrigo Vivi
0 siblings, 0 replies; 11+ messages in thread
From: Rodrigo Vivi @ 2021-05-18 12:59 UTC (permalink / raw)
To: Simon Rettberg; +Cc: Intel Graphics Development, development
On Tue, May 18, 2021 at 10:30:25AM +0200, Simon Rettberg wrote:
> Am Thu, 13 May 2021 07:30:17 -0400
> schrieb Rodrigo Vivi <rodrigo.vivi@intel.com>:
>
> > On Thu, May 13, 2021 at 10:18:49AM +1000, Dave Airlie wrote:
> > > Reviewed-by: Dave Airlie <airlied@redhat.com>
> > >
> > > Can we get this fix in, having a regression spanning 3 kernels
> > > isn't a good look, we can work out why it matters later in life if
> > > anyone cares.
> >
> > Agreed and pushed do drm-intel-next.
>
> What's the status here? I can't seem to find the fix in drm-intel-next.
ouch! face-palm for myself.
I hit the push and never looked back:
$ dim push-queued
dim: 153dfcd6b299 ("drm/i915/gt: Disable HiZ Raw Stall Optimization on broken gen7"): SHA1 in fixes line not found:
dim: 520d05a77b28 ("drm/i915/gt: Clear CACHE_MODE prior to clearing residuals")
dim: ERROR: issues in commits detected, aborting
now I removed the invalid fixes line and pushed...
Thank you so much for noticing this.
Sorry,
Rodrigo.
>
> - Simon
>
> >
> > This triggered me to do an archeology work here and I found a possible
> > alternative for ILK:
> >
> > +#define HIZ_UNIT_CLOCK_GATE_DISABLE REG_BIT(5)
> >
> > #define FDI_PLL_FREQ_CTL _MMIO(0x46030)
> > #define FDI_PLL_FREQ_CHANGE_REQUEST (1 << 24)
> > diff --git a/drivers/gpu/drm/i915/intel_pm.c
> > b/drivers/gpu/drm/i915/intel_pm.c index 06d5b7cc8b62..6316b70978f7
> > 100644 --- a/drivers/gpu/drm/i915/intel_pm.c
> > +++ b/drivers/gpu/drm/i915/intel_pm.c
> > @@ -6892,8 +6892,11 @@ static void ilk_init_clock_gating(struct
> > drm_i915_private *dev_priv) intel_uncore_write(&dev_priv->uncore,
> > PCH_3DCGDIS0, MARIUNIT_CLOCK_GATE_DISABLE |
> > SVSMUNIT_CLOCK_GATE_DISABLE);
> > +
> > + /* WaDisableHizUnitClockGating:ilk */
> > intel_uncore_write(&dev_priv->uncore, PCH_3DCGDIS1,
> > - VFMUNIT_CLOCK_GATE_DISABLE);
> > + VFMUNIT_CLOCK_GATE_DISABLE |
> > + HIZ_UNIT_CLOCK_GATE_DISABLE);
> >
> > however I couldn't find anything for Baytrail, so let's move with this
> > one for now.
> >
> > >
> > > Dave.
> > >
> > > On Tue, 27 Apr 2021 at 00:31, Simon Rettberg
> > > <simon.rettberg@rz.uni-freiburg.de> wrote:
> > > >
> > > > When resetting CACHE_MODE registers, don't enable HiZ Raw Stall
> > > > Optimization on Ivybridge GT1 and Baytrail, as it causes severe
> > > > glitches when rendering any kind of 3D accelerated content.
> > > > This optimization is disabled on these platforms by default
> > > > according to official documentation from 01.org.
> > > >
> > > > Fixes: ef99a60ffd9b ("drm/i915/gt: Clear CACHE_MODE prior to
> > > > clearing residuals") Fixes: 520d05a77b28 ("drm/i915/gt: Clear
> > > > CACHE_MODE prior to clearing residuals") BugLink:
> > > > https://gitlab.freedesktop.org/drm/intel/-/issues/3081 BugLink:
> > > > https://gitlab.freedesktop.org/drm/intel/-/issues/3404 BugLink:
> > > > https://gitlab.freedesktop.org/drm/intel/-/issues/3071
> > > > Reviewed-By: Manuel Bentele <development@manuel-bentele.de>
> > > > Signed-off-by: Simon Rettberg <simon.rettberg@rz.uni-freiburg.de>
> > > > --- drivers/gpu/drm/i915/gt/gen7_renderclear.c | 5 ++++-
> > > > 1 file changed, 4 insertions(+), 1 deletion(-)
> > > >
> > > > diff --git a/drivers/gpu/drm/i915/gt/gen7_renderclear.c
> > > > b/drivers/gpu/drm/i915/gt/gen7_renderclear.c index
> > > > de575fdb0..21f08e538 100644 ---
> > > > a/drivers/gpu/drm/i915/gt/gen7_renderclear.c +++
> > > > b/drivers/gpu/drm/i915/gt/gen7_renderclear.c @@ -397,7 +397,10 @@
> > > > static void emit_batch(struct i915_vma * const vma,
> > > > gen7_emit_pipeline_invalidate(&cmds); batch_add(&cmds,
> > > > MI_LOAD_REGISTER_IMM(2)); batch_add(&cmds,
> > > > i915_mmio_reg_offset(CACHE_MODE_0_GEN7));
> > > > - batch_add(&cmds, 0xffff0000);
> > > > + batch_add(&cmds, 0xffff0000 |
> > > > + ((IS_IVB_GT1(i915) ||
> > > > IS_VALLEYVIEW(i915)) ?
> > > > + HIZ_RAW_STALL_OPT_DISABLE :
> > > > + 0));
> > > > batch_add(&cmds, i915_mmio_reg_offset(CACHE_MODE_1));
> > > > batch_add(&cmds, 0xffff0000 |
> > > > PIXEL_SUBSPAN_COLLECT_OPT_DISABLE);
> > > > gen7_emit_pipeline_invalidate(&cmds); --
> > > > 2.25.1
> > > >
> > > > _______________________________________________
> > > > Intel-gfx mailing list
> > > > Intel-gfx@lists.freedesktop.org
> > > > https://lists.freedesktop.org/mailman/listinfo/intel-gfx
> > > _______________________________________________
> > > Intel-gfx mailing list
> > > Intel-gfx@lists.freedesktop.org
> > > https://lists.freedesktop.org/mailman/listinfo/intel-gfx
>
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 11+ messages in thread
end of thread, other threads:[~2021-05-18 12:59 UTC | newest]
Thread overview: 11+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-26 14:11 [Intel-gfx] [PATCH] drm/i915/gt: Disable HiZ Raw Stall Optimization on broken gen7 Simon Rettberg
2021-04-26 16:05 ` Ville Syrjälä
2021-04-27 8:33 ` Simon Rettberg
2021-04-26 18:48 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for " Patchwork
2021-04-26 19:18 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2021-04-27 3:10 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
2021-05-13 0:18 ` [Intel-gfx] [PATCH] " Dave Airlie
2021-05-13 11:30 ` Rodrigo Vivi
2021-05-18 8:30 ` Simon Rettberg
2021-05-18 12:59 ` Rodrigo Vivi
2021-05-13 12:31 ` [Intel-gfx] ✗ Fi.CI.BUILD: failure for drm/i915/gt: Disable HiZ Raw Stall Optimization on broken gen7 (rev2) Patchwork
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.