From: Tian Tao <tiantao6@hisilicon.com>
To: <clm@fb.com>, <josef@toxicpanda.com>, <dsterba@suse.com>
Cc: <linux-btrfs@vger.kernel.org>, Tian Tao <tiantao6@hisilicon.com>
Subject: [PATCH] btrfs: delete unneeded assignments in btrfs_defrag_file
Date: Tue, 27 Apr 2021 09:50:21 +0800 [thread overview]
Message-ID: <1619488221-29490-1-git-send-email-tiantao6@hisilicon.com> (raw)
ret is assigned -EAGAIN at line 1455 and then reassigned defrag_count
at line 1547 after exiting the while loop, but the btrfs_defrag_file
function returns a negative number indicating that the execution failed
because it does not make sense to reassign defrag_count to ret, so
delete it.
Signed-off-by: Tian Tao <tiantao6@hisilicon.com>
---
fs/btrfs/ioctl.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/fs/btrfs/ioctl.c b/fs/btrfs/ioctl.c
index ee1dbab..2b3b228 100644
--- a/fs/btrfs/ioctl.c
+++ b/fs/btrfs/ioctl.c
@@ -1544,8 +1544,6 @@ int btrfs_defrag_file(struct inode *inode, struct file *file,
btrfs_set_fs_incompat(fs_info, COMPRESS_ZSTD);
}
- ret = defrag_count;
-
out_ra:
if (do_compress) {
btrfs_inode_lock(inode, 0);
--
2.7.4
next reply other threads:[~2021-04-27 1:50 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-27 1:50 Tian Tao [this message]
2021-04-28 18:02 ` [PATCH] btrfs: delete unneeded assignments in btrfs_defrag_file David Sterba
2021-04-29 1:16 ` tiantao (H)
2021-04-29 13:22 ` David Sterba
2021-04-30 1:27 ` tiantao (H)
2021-05-03 14:25 ` David Sterba
2021-04-27 8:03 kernel test robot
2021-04-29 13:15 ` Dan Carpenter
2021-04-29 13:15 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1619488221-29490-1-git-send-email-tiantao6@hisilicon.com \
--to=tiantao6@hisilicon.com \
--cc=clm@fb.com \
--cc=dsterba@suse.com \
--cc=josef@toxicpanda.com \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.