From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DC198C433ED for ; Tue, 27 Apr 2021 21:10:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id AA6396105A for ; Tue, 27 Apr 2021 21:10:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239327AbhD0VLE (ORCPT ); Tue, 27 Apr 2021 17:11:04 -0400 Received: from mail.kernel.org ([198.145.29.99]:38836 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239047AbhD0VKx (ORCPT ); Tue, 27 Apr 2021 17:10:53 -0400 Received: by mail.kernel.org (Postfix) with ESMTPS id 0BD5561401; Tue, 27 Apr 2021 21:10:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1619557810; bh=d82NCV/TH6w3zyVp8P1oiizsMEP4o+OYdZ9mR7Wfo5I=; h=Subject:From:Date:References:In-Reply-To:To:Cc:From; b=mCbeWSwBNUsnYosJdQ2ylI1FWCJsDPpTG8g8xkt/HbfRF8hNTgM5RplLsPpaHYrAd 8/qFHBkF1UYvU88j3KMnGWUN0MtV5jHkvAQpOrRa0XB5ddO8CmQ+rn8zNOgid1cSEG ikCVoWqFC/zCE21K4FbsvLnKjKPLgyXIDIZeAJi9QongI+YXNzVW3V58KWpPEYyu/W oSU2G3nsK3uRJvr/qdQBBWcTj+u94JhMVmaxFgOiXRSbeH1D2GYwdUsccRovPEEcL4 11+ohBu/6yvBNVOFMOQaiq/48VTCmUJrBCleiPInAKn7WjHzDS+Gai8bKjyRs0LEbn Tl7tYTHhqRuPw== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: Re: [PATCH net] net: bridge: mcast: fix broken length + header check for MRDv6 Adv. From: patchwork-bot+netdevbpf@kernel.org Message-Id: <161955781000.15707.777989471738202707.git-patchwork-notify@kernel.org> Date: Tue, 27 Apr 2021 21:10:10 +0000 References: <20210425152736.8421-1-linus.luessing@c0d3.blue> In-Reply-To: <20210425152736.8421-1-linus.luessing@c0d3.blue> To: =?utf-8?q?Linus_L=C3=BCssing_=3Clinus=2Eluessing=40c0d3=2Eblue=3E?=@ci.codeaurora.org Cc: netdev@vger.kernel.org, roopa@nvidia.com, nikolay@nvidia.com, kuba@kernel.org, davem@davemloft.net, bridge@lists.linux-foundation.org, linux-kernel@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello: This patch was applied to netdev/net-next.git (refs/heads/master): On Sun, 25 Apr 2021 17:27:35 +0200 you wrote: > The IPv6 Multicast Router Advertisements parsing has the following two > issues: > > For one thing, ICMPv6 MRD Advertisements are smaller than ICMPv6 MLD > messages (ICMPv6 MRD Adv.: 8 bytes vs. ICMPv6 MLDv1/2: >= 24 bytes, > assuming MLDv2 Reports with at least one multicast address entry). > When ipv6_mc_check_mld_msg() tries to parse an Multicast Router > Advertisement its MLD length check will fail - and it will wrongly > return -EINVAL, even if we have a valid MRD Advertisement. With the > returned -EINVAL the bridge code will assume a broken packet and will > wrongly discard it, potentially leading to multicast packet loss towards > multicast routers. > > [...] Here is the summary with links: - [net] net: bridge: mcast: fix broken length + header check for MRDv6 Adv. https://git.kernel.org/netdev/net-next/c/99014088156c You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1619557810; bh=d82NCV/TH6w3zyVp8P1oiizsMEP4o+OYdZ9mR7Wfo5I=; h=Subject:From:Date:References:In-Reply-To:To:Cc:From; b=mCbeWSwBNUsnYosJdQ2ylI1FWCJsDPpTG8g8xkt/HbfRF8hNTgM5RplLsPpaHYrAd 8/qFHBkF1UYvU88j3KMnGWUN0MtV5jHkvAQpOrRa0XB5ddO8CmQ+rn8zNOgid1cSEG ikCVoWqFC/zCE21K4FbsvLnKjKPLgyXIDIZeAJi9QongI+YXNzVW3V58KWpPEYyu/W oSU2G3nsK3uRJvr/qdQBBWcTj+u94JhMVmaxFgOiXRSbeH1D2GYwdUsccRovPEEcL4 11+ohBu/6yvBNVOFMOQaiq/48VTCmUJrBCleiPInAKn7WjHzDS+Gai8bKjyRs0LEbn Tl7tYTHhqRuPw== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: patchwork-bot+netdevbpf@kernel.org Message-Id: <161955781000.15707.777989471738202707.git-patchwork-notify@kernel.org> Date: Tue, 27 Apr 2021 21:10:10 +0000 References: <20210425152736.8421-1-linus.luessing@c0d3.blue> In-Reply-To: <20210425152736.8421-1-linus.luessing@c0d3.blue> Subject: Re: [Bridge] [PATCH net] net: bridge: mcast: fix broken length + header check for MRDv6 Adv. List-Id: Linux Ethernet Bridging List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?utf-8?q?Linus_L=C3=BCssing_=3Clinus=2Eluessing=40c0d3=2Eblue=3E?=@ci.codeaurora.org Cc: netdev@vger.kernel.org, bridge@lists.linux-foundation.org, linux-kernel@vger.kernel.org, nikolay@nvidia.com, roopa@nvidia.com, kuba@kernel.org, davem@davemloft.net Hello: This patch was applied to netdev/net-next.git (refs/heads/master): On Sun, 25 Apr 2021 17:27:35 +0200 you wrote: > The IPv6 Multicast Router Advertisements parsing has the following two > issues: > > For one thing, ICMPv6 MRD Advertisements are smaller than ICMPv6 MLD > messages (ICMPv6 MRD Adv.: 8 bytes vs. ICMPv6 MLDv1/2: >= 24 bytes, > assuming MLDv2 Reports with at least one multicast address entry). > When ipv6_mc_check_mld_msg() tries to parse an Multicast Router > Advertisement its MLD length check will fail - and it will wrongly > return -EINVAL, even if we have a valid MRD Advertisement. With the > returned -EINVAL the bridge code will assume a broken packet and will > wrongly discard it, potentially leading to multicast packet loss towards > multicast routers. > > [...] Here is the summary with links: - [net] net: bridge: mcast: fix broken length + header check for MRDv6 Adv. https://git.kernel.org/netdev/net-next/c/99014088156c You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html