From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.4 required=3.0 tests=BAYES_00,DATE_IN_PAST_06_12, DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 55690C433ED for ; Wed, 28 Apr 2021 05:35:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id F256061418 for ; Wed, 28 Apr 2021 05:35:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229717AbhD1FgZ (ORCPT ); Wed, 28 Apr 2021 01:36:25 -0400 Received: from relay.smtp-ext.broadcom.com ([192.19.11.229]:58674 "EHLO relay.smtp-ext.broadcom.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235766AbhD1FgX (ORCPT ); Wed, 28 Apr 2021 01:36:23 -0400 Received: from localhost.localdomain (unknown [10.157.2.20]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by relay.smtp-ext.broadcom.com (Postfix) with ESMTPS id EDB33E9277; Tue, 27 Apr 2021 22:27:08 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 relay.smtp-ext.broadcom.com EDB33E9277 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=broadcom.com; s=dkimrelay; t=1619587631; bh=0d3lEW+cPvrHyMfGa1TXdzyCoM5KR8c3lo+uDbUr32g=; h=From:To:Cc:Subject:Date:From; b=MbSLzCdGrzEq3sqFl5XNqI+UCAAPT9TtYHodW27FlWsqn5Mg8USewGD75tH1PHjPG B3mkGXnTQ5ZJEhr5YvQor1j4YpupM1MRQdtk2TT1kvqA0qS+JiEcxWe7aPdX0QIivV b/lBGjf7yjNo8hLD44XQ6YcDzeIISnyJgIq24t90= From: Muneendra To: linux-block@vger.kernel.org, linux-scsi@vger.kernel.org, tj@kernel.org, linux-nvme@lists.infradead.org, hare@suse.de Cc: jsmart2021@gmail.com, emilne@redhat.com, mkumar@redhat.com, Muneendra Subject: [PATCH v10 00/13] blkcg:Support to track FC storage blk io traffic Date: Wed, 28 Apr 2021 04:04:44 +0530 Message-Id: <1619562897-14062-1-git-send-email-muneendra.kumar@broadcom.com> X-Mailer: git-send-email 1.8.3.1 Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org This Patch added a unique application identifier i.e app_id knob to blkcg which allows identification of traffic sources at an individual cgroup based Applications (ex:virtual machine (VM))level in both host and fabric infrastructure. Added a new sysfs attribute appid_store to set the application identfier in the blkcg associted with cgroup id under /sys/class/fc/fc_udev_device/* With this new interface the user can set the application identfier in the blkcg associted with cgroup id. This capability can be utilized by multiple block transport infrastructure like fc,iscsi,roce. Existing FC fabric will use this feature and the description of the use case is below. Various virtualization technologies used in Fibre Channel SAN deployments have created the opportunity to identify and associate traffic with specific virtualized applications. The concepts behind the T11 Application Services standard is to provide the general mechanisms needed to identify virtualized services. It enables the Fabric and the storage targets to identify, monitor, and handle FC traffic based on vm tags by inserting application specific identification into the FC frame. The patches were cut against 5.13/scsi-queue tree v10: Fixed the spelling mistakes and function name corrections Removed the redundant code v9: Addressed the issues reported by kernel test robot Replaced lpfc_get_vmid_from_hashtable with the generic kernel based hashtable (include/linux/hashtable.h) and made the changes in the code accordingly. Addressed the locking issue and also merged few patches v8: Modified the structure member,log messages and function declarations Added proper error codes and return values v7: Modified the Kconfig comments v6: Addressed the issues reported by kernel test robot Modified the Kconfig files as per standard v5: Renamed the function cgroup_get_from_kernfs_id to cgroup_get_from_id. Moved the input validation at the beginning of the function in Renamed the arguments appropriatley. Changed Return code to non-numeric/SymbolChanged Return code to non-numeric/Symbol Modified the comments. v4: Addressed the error reported by kernel test robot v3: removed RFC. Renamed the functions and app_id to more specific Addressed the reference leaks in blkcg_set_app_identifier Added a new config BLK_CGROUP_FC_APPID and made changes to select the same under SCSI_FC_ATTRS V2: renamed app_identifier to app_id. removed the sysfs interface blkio.app_identifie under /sys/fs/cgroup/blkio Ported the patch on top of 5.10/scsi-queue. Removed redundant code due to changes since last submit. Added a fix for issuing QFPA command. Gaurav Srivastava (10): lpfc: vmid: Add the datastructure for supporting VMID in lpfc lpfc: vmid: VMID params initialization lpfc: vmid: Add support for vmid in mailbox command, does vmid resource allocation and vmid cleanup lpfc: vmid: Implements ELS commands for appid patch lpfc: vmid: Functions to manage vmids lpfc: vmid: Implements CT commands for appid. lpfc: vmid: Appends the vmid in the wqe before sending lpfc: vmid: Timeout implementation for vmid lpfc: vmid: Adding qfpa and vmid timeout check in worker thread lpfc: vmid: Introducing vmid in io path. Muneendra (3): cgroup: Added cgroup_get_from_id blkcg: Added a app identifier support for blkcg nvme: Added a newsysfs attribute appid_store block/Kconfig | 9 + drivers/nvme/host/fc.c | 73 +++++- drivers/scsi/Kconfig | 13 ++ drivers/scsi/lpfc/lpfc.h | 122 +++++++++++ drivers/scsi/lpfc/lpfc_attr.c | 48 ++++ drivers/scsi/lpfc/lpfc_crtn.h | 11 + drivers/scsi/lpfc/lpfc_ct.c | 255 +++++++++++++++++++++ drivers/scsi/lpfc/lpfc_disc.h | 1 + drivers/scsi/lpfc/lpfc_els.c | 366 ++++++++++++++++++++++++++++++- drivers/scsi/lpfc/lpfc_hbadisc.c | 148 +++++++++++++ drivers/scsi/lpfc/lpfc_hw.h | 124 ++++++++++- drivers/scsi/lpfc/lpfc_hw4.h | 12 + drivers/scsi/lpfc/lpfc_init.c | 104 +++++++++ drivers/scsi/lpfc/lpfc_mbox.c | 6 + drivers/scsi/lpfc/lpfc_scsi.c | 321 +++++++++++++++++++++++++++ drivers/scsi/lpfc/lpfc_sli.c | 23 ++ drivers/scsi/lpfc/lpfc_sli.h | 8 + include/linux/blk-cgroup.h | 56 +++++ include/linux/cgroup.h | 6 + kernel/cgroup/cgroup.c | 26 +++ 20 files changed, 1723 insertions(+), 9 deletions(-) -- 2.26.2 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.4 required=3.0 tests=BAYES_00,DATE_IN_PAST_06_12, DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A9297C433B4 for ; Wed, 28 Apr 2021 05:38:52 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 16A6F6141E for ; Wed, 28 Apr 2021 05:38:52 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 16A6F6141E Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=broadcom.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:MIME-Version:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Message-Id:Date:Subject:Cc:To:From:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Owner; bh=hCItbc+BwbGIJM4IYeKzoUmGcAAUiFlCRC1BYuY7deI=; b=la92rAPpTaaymsy/xcHQbxcxFy +AdPmBywUdQmLHT91oMNWI4hwsIInkKmEFc/NVKeohengMBPrwl2lD4zjaZ6LRWgEdbbDkYdVFiuO TiC0HseuPMZxVayLJ1FPVGpZemqBlCUvhFZ6cQF9Ny7cEyH49fRe20fuuA4NoIKwQxqIbt3u2+W2x lj2EIM9qjPkR0/WkcgVCGdWd/wahNOL6dVh7/FqskCQ6PC6BJUZwZzHdT/7IHCXGYtzJ+t0VOvFju gfWY6P0PCD8F3m69xbx7jEDa2Wj2CZfbSIicm4ofMKlzEN/L8nDdWN2xDSGZICe0C1jVZIZnVTEpu kZlnNqtg==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lbcuI-002q0c-2a; Wed, 28 Apr 2021 05:38:42 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lbcrN-002pcR-Gf for linux-nvme@desiato.infradead.org; Wed, 28 Apr 2021 05:35:42 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Message-Id:Date:Subject:Cc:To:From: Sender:Reply-To:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:In-Reply-To:References; bh=jdQm9FjfbeoBpv7WNOa/OirMK9Bxk9CY8ZVBCXxNYfY=; b=J0k1yTYL4mx0acSGPA9UpvKJvR Ix9Uze8Jol0N1mPPN3q/yOeAPDz14N/kwo595f2D9nzwHoxvrD/YInrh8mWAVr/i8UCNud1ngXpr6 PbK+6qQRbEZhMhiCGxNyTGSeL+I1eeGKymAgyPLDWAAQK3inAU0PE28gorHrzgfNADk1OYiUwEiME ea/VHR+ZIH8mfo76G9mpg5d9vGvyAGyHop8bRVZsGMjRW7QGidbzFkqbins9NpeLOi80HiwhZyXZx B+cYIDuiK9bVhyxHL+G/H4GebCj1FPV1xCqQZ6lQttw43KD4639YI4xPAX2NlpGV70dkSLJNlC7eb WnivRhXw==; Received: from relay.smtp-ext.broadcom.com ([192.19.11.229]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lbcrJ-00HBhx-W5 for linux-nvme@lists.infradead.org; Wed, 28 Apr 2021 05:35:40 +0000 Received: from localhost.localdomain (unknown [10.157.2.20]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by relay.smtp-ext.broadcom.com (Postfix) with ESMTPS id EDB33E9277; Tue, 27 Apr 2021 22:27:08 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 relay.smtp-ext.broadcom.com EDB33E9277 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=broadcom.com; s=dkimrelay; t=1619587631; bh=0d3lEW+cPvrHyMfGa1TXdzyCoM5KR8c3lo+uDbUr32g=; h=From:To:Cc:Subject:Date:From; b=MbSLzCdGrzEq3sqFl5XNqI+UCAAPT9TtYHodW27FlWsqn5Mg8USewGD75tH1PHjPG B3mkGXnTQ5ZJEhr5YvQor1j4YpupM1MRQdtk2TT1kvqA0qS+JiEcxWe7aPdX0QIivV b/lBGjf7yjNo8hLD44XQ6YcDzeIISnyJgIq24t90= From: Muneendra To: linux-block@vger.kernel.org, linux-scsi@vger.kernel.org, tj@kernel.org, linux-nvme@lists.infradead.org, hare@suse.de Cc: jsmart2021@gmail.com, emilne@redhat.com, mkumar@redhat.com, Muneendra Subject: [PATCH v10 00/13] blkcg:Support to track FC storage blk io traffic Date: Wed, 28 Apr 2021 04:04:44 +0530 Message-Id: <1619562897-14062-1-git-send-email-muneendra.kumar@broadcom.com> X-Mailer: git-send-email 1.8.3.1 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210427_223538_665253_0C7306BD X-CRM114-Status: GOOD ( 17.14 ) X-BeenThere: linux-nvme@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-nvme" Errors-To: linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org This Patch added a unique application identifier i.e app_id knob to blkcg which allows identification of traffic sources at an individual cgroup based Applications (ex:virtual machine (VM))level in both host and fabric infrastructure. Added a new sysfs attribute appid_store to set the application identfier in the blkcg associted with cgroup id under /sys/class/fc/fc_udev_device/* With this new interface the user can set the application identfier in the blkcg associted with cgroup id. This capability can be utilized by multiple block transport infrastructure like fc,iscsi,roce. Existing FC fabric will use this feature and the description of the use case is below. Various virtualization technologies used in Fibre Channel SAN deployments have created the opportunity to identify and associate traffic with specific virtualized applications. The concepts behind the T11 Application Services standard is to provide the general mechanisms needed to identify virtualized services. It enables the Fabric and the storage targets to identify, monitor, and handle FC traffic based on vm tags by inserting application specific identification into the FC frame. The patches were cut against 5.13/scsi-queue tree v10: Fixed the spelling mistakes and function name corrections Removed the redundant code v9: Addressed the issues reported by kernel test robot Replaced lpfc_get_vmid_from_hashtable with the generic kernel based hashtable (include/linux/hashtable.h) and made the changes in the code accordingly. Addressed the locking issue and also merged few patches v8: Modified the structure member,log messages and function declarations Added proper error codes and return values v7: Modified the Kconfig comments v6: Addressed the issues reported by kernel test robot Modified the Kconfig files as per standard v5: Renamed the function cgroup_get_from_kernfs_id to cgroup_get_from_id. Moved the input validation at the beginning of the function in Renamed the arguments appropriatley. Changed Return code to non-numeric/SymbolChanged Return code to non-numeric/Symbol Modified the comments. v4: Addressed the error reported by kernel test robot v3: removed RFC. Renamed the functions and app_id to more specific Addressed the reference leaks in blkcg_set_app_identifier Added a new config BLK_CGROUP_FC_APPID and made changes to select the same under SCSI_FC_ATTRS V2: renamed app_identifier to app_id. removed the sysfs interface blkio.app_identifie under /sys/fs/cgroup/blkio Ported the patch on top of 5.10/scsi-queue. Removed redundant code due to changes since last submit. Added a fix for issuing QFPA command. Gaurav Srivastava (10): lpfc: vmid: Add the datastructure for supporting VMID in lpfc lpfc: vmid: VMID params initialization lpfc: vmid: Add support for vmid in mailbox command, does vmid resource allocation and vmid cleanup lpfc: vmid: Implements ELS commands for appid patch lpfc: vmid: Functions to manage vmids lpfc: vmid: Implements CT commands for appid. lpfc: vmid: Appends the vmid in the wqe before sending lpfc: vmid: Timeout implementation for vmid lpfc: vmid: Adding qfpa and vmid timeout check in worker thread lpfc: vmid: Introducing vmid in io path. Muneendra (3): cgroup: Added cgroup_get_from_id blkcg: Added a app identifier support for blkcg nvme: Added a newsysfs attribute appid_store block/Kconfig | 9 + drivers/nvme/host/fc.c | 73 +++++- drivers/scsi/Kconfig | 13 ++ drivers/scsi/lpfc/lpfc.h | 122 +++++++++++ drivers/scsi/lpfc/lpfc_attr.c | 48 ++++ drivers/scsi/lpfc/lpfc_crtn.h | 11 + drivers/scsi/lpfc/lpfc_ct.c | 255 +++++++++++++++++++++ drivers/scsi/lpfc/lpfc_disc.h | 1 + drivers/scsi/lpfc/lpfc_els.c | 366 ++++++++++++++++++++++++++++++- drivers/scsi/lpfc/lpfc_hbadisc.c | 148 +++++++++++++ drivers/scsi/lpfc/lpfc_hw.h | 124 ++++++++++- drivers/scsi/lpfc/lpfc_hw4.h | 12 + drivers/scsi/lpfc/lpfc_init.c | 104 +++++++++ drivers/scsi/lpfc/lpfc_mbox.c | 6 + drivers/scsi/lpfc/lpfc_scsi.c | 321 +++++++++++++++++++++++++++ drivers/scsi/lpfc/lpfc_sli.c | 23 ++ drivers/scsi/lpfc/lpfc_sli.h | 8 + include/linux/blk-cgroup.h | 56 +++++ include/linux/cgroup.h | 6 + kernel/cgroup/cgroup.c | 26 +++ 20 files changed, 1723 insertions(+), 9 deletions(-) -- 2.26.2 _______________________________________________ Linux-nvme mailing list Linux-nvme@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-nvme