All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mark Brown <broonie@kernel.org>
To: Saravana Kannan <saravanak@google.com>
Cc: Mark Brown <broonie@kernel.org>,
	kernel-team@android.com, linux-kernel@vger.kernel.org,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Andy Shevchenko <andy.shevchenko@gmail.com>,
	linux-spi@vger.kernel.org,
	"Rafael J. Wysocki" <rafael@kernel.org>,
	Guenter Roeck <linux@roeck-us.net>,
	Marek Szyprowski <m.szyprowski@samsung.com>
Subject: Re: [PATCH] spi: Fix spi device unregister flow
Date: Wed, 28 Apr 2021 17:53:41 +0100	[thread overview]
Message-ID: <161962869503.49700.1086509645637096934.b4-ty@kernel.org> (raw)
In-Reply-To: <20210426235638.1285530-1-saravanak@google.com>

On Mon, 26 Apr 2021 16:56:38 -0700, Saravana Kannan wrote:
> When an SPI device is unregistered, the spi->controller->cleanup() is
> called in the device's release callback. That's wrong for a couple of
> reasons:
> 
> 1. spi_dev_put() can be called before spi_add_device() is called. And
>    it's spi_add_device() that calls spi_setup(). This will cause clean()
>    to get called without the spi device ever being setup.
> 
> [...]

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-next

Thanks!

[1/1] spi: Fix spi device unregister flow
      commit: c7299fea67696db5bd09d924d1f1080d894f92ef

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark

  parent reply	other threads:[~2021-04-28 16:54 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-26 23:56 [PATCH] spi: Fix spi device unregister flow Saravana Kannan
2021-04-27  6:52 ` Andy Shevchenko
2021-04-27 10:48   ` Mark Brown
2021-04-27 11:42     ` Andy Shevchenko
2021-04-27 11:49       ` Greg Kroah-Hartman
2021-04-27 15:02         ` Saravana Kannan
2021-04-28 16:53 ` Mark Brown [this message]
2021-05-03 10:07 ` Lukas Wunner
2021-05-03 10:16   ` Andy Shevchenko
2021-05-03 17:21   ` Saravana Kannan
2021-05-03 17:56     ` Lukas Wunner
2021-05-03 18:15       ` Saravana Kannan
2021-05-04  9:17         ` Lukas Wunner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=161962869503.49700.1086509645637096934.b4-ty@kernel.org \
    --to=broonie@kernel.org \
    --cc=andy.shevchenko@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=kernel-team@android.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-spi@vger.kernel.org \
    --cc=linux@roeck-us.net \
    --cc=m.szyprowski@samsung.com \
    --cc=rafael@kernel.org \
    --cc=saravanak@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.