All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH net-next 1/1] net/sched: act_ct: Remove redundant ct get and check
@ 2021-04-28  6:05 Roi Dayan
  2021-04-28 21:10 ` patchwork-bot+netdevbpf
  0 siblings, 1 reply; 2+ messages in thread
From: Roi Dayan @ 2021-04-28  6:05 UTC (permalink / raw)
  To: netdev; +Cc: Paul Blakey, Roi Dayan

The assignment is not being used and redundant.
The check for null is redundant as nf_conntrack_put() also
checks this.

Signed-off-by: Roi Dayan <roid@nvidia.com>
Reviewed-by: Paul Blakey <paulb@nvidia.com>
---
 net/sched/act_ct.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/net/sched/act_ct.c b/net/sched/act_ct.c
index 16e888a9601d..65e9ffe6cf7d 100644
--- a/net/sched/act_ct.c
+++ b/net/sched/act_ct.c
@@ -990,9 +990,7 @@ static int tcf_ct_act(struct sk_buff *skb, const struct tc_action *a,
 
 		/* Associate skb with specified zone. */
 		if (tmpl) {
-			ct = nf_ct_get(skb, &ctinfo);
-			if (skb_nfct(skb))
-				nf_conntrack_put(skb_nfct(skb));
+			nf_conntrack_put(skb_nfct(skb));
 			nf_conntrack_get(&tmpl->ct_general);
 			nf_ct_set(skb, tmpl, IP_CT_NEW);
 		}
-- 
2.26.2


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH net-next 1/1] net/sched: act_ct: Remove redundant ct get and check
  2021-04-28  6:05 [PATCH net-next 1/1] net/sched: act_ct: Remove redundant ct get and check Roi Dayan
@ 2021-04-28 21:10 ` patchwork-bot+netdevbpf
  0 siblings, 0 replies; 2+ messages in thread
From: patchwork-bot+netdevbpf @ 2021-04-28 21:10 UTC (permalink / raw)
  To: Roi Dayan; +Cc: netdev, paulb

Hello:

This patch was applied to netdev/net-next.git (refs/heads/master):

On Wed, 28 Apr 2021 09:05:32 +0300 you wrote:
> The assignment is not being used and redundant.
> The check for null is redundant as nf_conntrack_put() also
> checks this.
> 
> Signed-off-by: Roi Dayan <roid@nvidia.com>
> Reviewed-by: Paul Blakey <paulb@nvidia.com>
> 
> [...]

Here is the summary with links:
  - [net-next,1/1] net/sched: act_ct: Remove redundant ct get and check
    https://git.kernel.org/netdev/net-next/c/9be02dd38581

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html



^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-04-28 21:10 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-28  6:05 [PATCH net-next 1/1] net/sched: act_ct: Remove redundant ct get and check Roi Dayan
2021-04-28 21:10 ` patchwork-bot+netdevbpf

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.