From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 31528C43460 for ; Fri, 30 Apr 2021 02:17:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0DE6C613EE for ; Fri, 30 Apr 2021 02:17:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229853AbhD3CSG (ORCPT ); Thu, 29 Apr 2021 22:18:06 -0400 Received: from mail.kernel.org ([198.145.29.99]:43228 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229577AbhD3CSD (ORCPT ); Thu, 29 Apr 2021 22:18:03 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 9F239613EE; Fri, 30 Apr 2021 02:17:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1619749035; bh=Hv1C2LyXJqO2i3JKRnZtQbt4ua6L32rnPt3ObKyL2NI=; h=In-Reply-To:References:Subject:From:Cc:To:Date:From; b=M6wiVI4fIVtHzldUu5wZztmxWCZp/lKGbCnzCkiorRaFxMy9wHWvnfcvh94LQBi5H nZI/789x4cNgbLqMo8Yp8QxSnE8+h/fZ6Gm2cM0pZ81pShzZ0H26VPHJGENYglAjdA exSaEp/8+m8mgKr+kla8Qd9+Ha6TylTvNXhbiAElKBso+qbND2N0hL/bH2VyIUL41m ZF1qzzkM8QQaJbPNICeTiB1wQ2ezV/XCHgsXOUQOccmAnxhhNppNiqHUYxjFPtv+MZ Tkyit8DYSzQc+/TcCA7SVUcUMLTSaqrOox5m3rFyw/xBemDFGnLB2gxnnr6XVcqAoF ZIRxFXwmjZL4w== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable In-Reply-To: <87v98dqzfe.fsf@kokedama.swc.toshiba.co.jp> References: <20210421134844.3297838-1-arnd@kernel.org> <871rb2swd9.fsf@kokedama.swc.toshiba.co.jp> <01e78b64-8ad1-dfc8-9fc0-6afff4841492@xilinx.com> <87v98dqzfe.fsf@kokedama.swc.toshiba.co.jp> Subject: Re: [PATCH] clk: zynqmp: fix compile testing without ZYNQMP_FIRMWARE From: Stephen Boyd Cc: Arnd Bergmann , Michael Turquette , Arnd Bergmann , Rajan Vaja , Greg Kroah-Hartman , Jolly Shah , Quanyang Wang , linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org To: Michal Simek , Punit Agrawal Date: Thu, 29 Apr 2021 19:17:14 -0700 Message-ID: <161974903429.177949.6659170601321970979@swboyd.mtv.corp.google.com> User-Agent: alot/0.9.1 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Quoting Punit Agrawal (2021-04-22 23:37:25) > Michal Simek writes: > > > > > >>> =20 > >>> rate =3D parent_rate * fbdiv; > >>> if (zynqmp_pll_get_mode(hw) =3D=3D PLL_MODE_FRAC) { > >>=20 > >> The changes make sense in that the functions error out sensibly when t= he > >> zynqmp firmware driver is not enabled. > >>=20 > >> Acked-by: Punit Agrawal > > > > I think code should be checked that these error values are handled how > > they should be handled. >=20 > I only looked at it from the point of view of getting rid of the > warnings - based on the commit log, Arnd's patch is only taking care of > the compiler warnings when the driver is built with > CONFIG_COMPILE_TEST=3Dy and likely CONFIG_ZYNQMP_FIRMWARE=3Dn. The subject line basically says this. >=20 > In practice, the code should not be hit at runtime due to the dependency > on the firmware driver. Even then, a better fix would indeed be taking > the returned values at call sites into account. Still needs to be fixed. If a better patch is sent I would apply it, but if that isn't going to happen I'll apply this one. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B1E41C433ED for ; Fri, 30 Apr 2021 02:18:54 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6BFC561418 for ; Fri, 30 Apr 2021 02:18:54 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6BFC561418 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Message-ID:Date:To:Cc:From:Subject:References: In-Reply-To:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=LJ7zzW53dQS2I9vb3qme7X0ex7w3lcuPh9gjl1nlv9s=; b=do5wvwzwUv0DkazDToT6ptMXD a8Z//gvi+M0Ypoy6pH9X2VVTCvrZ7kte5iGjRX41AMj0SqFmNQxzrAEQW3qOkhjCj0MNo2Juur0QL OkDWsCjiIkNHo08SFCn9nH5c2yt1Ef+8DZqRKLbmwWiiJIKUC/6d9ev/8rRhRYmG60wivvRBWBQEA 3jYEVJ4vwBbh69q4vj59eI+yl92I0/GKANvBDqJoIu6JacibBxMvyUff4imNYu34dAnvQCsD5rs3B R6DLjqNG1X4j8FgNthNGTrkUoiri0CPOf3S/TXgFHmIHPs7c+SsiyZ7lJejWQLhKhI3btrp7lfVMQ QqUh+2ZgQ==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lcIiY-006zqO-Dl; Fri, 30 Apr 2021 02:17:23 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lcIiU-006zqG-Nf for linux-arm-kernel@desiato.infradead.org; Fri, 30 Apr 2021 02:17:18 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Message-ID:Date:To:Cc:From:Subject: References:In-Reply-To:Content-Transfer-Encoding:MIME-Version:Content-Type: Sender:Reply-To:Content-ID:Content-Description; bh=+d5lR0/LDOANawLS/0uHaP4TzokI3aXGddB4bZHH0kA=; b=LTr/XcQnGaf7dN4+Jigb3bmaeu TbfwAYdmzghmbFHpuvuAOmt2JtYfxjfQWL9+xkCuQnpNFa7BVouO+qIzw7Wlt3l6yMPZOynUIokCt NqlKBtt6Qt3xAn0aaxjIMjpv1UkYMZXO3X1HyFtSdVMIa/nqoh3cgcRZoB15JcKo01+U+FYOIl+ZX dmAxdlmwQSlPA1DTPJkz8zMstVXdEAunisNVrlbo3uPQE1L3kzfigGheFMTnW3lle1kXZImF3sMSM XIehNVF6ZvphUz/i9r14P9aNXPaKboY9taYeQP2Wrr+iMi86G0f+j8u7pXnZtGnzWTxbK4xm53sBv CLul1NyQ==; Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lcIiS-0014Ux-Aw for linux-arm-kernel@lists.infradead.org; Fri, 30 Apr 2021 02:17:17 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id 9F239613EE; Fri, 30 Apr 2021 02:17:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1619749035; bh=Hv1C2LyXJqO2i3JKRnZtQbt4ua6L32rnPt3ObKyL2NI=; h=In-Reply-To:References:Subject:From:Cc:To:Date:From; b=M6wiVI4fIVtHzldUu5wZztmxWCZp/lKGbCnzCkiorRaFxMy9wHWvnfcvh94LQBi5H nZI/789x4cNgbLqMo8Yp8QxSnE8+h/fZ6Gm2cM0pZ81pShzZ0H26VPHJGENYglAjdA exSaEp/8+m8mgKr+kla8Qd9+Ha6TylTvNXhbiAElKBso+qbND2N0hL/bH2VyIUL41m ZF1qzzkM8QQaJbPNICeTiB1wQ2ezV/XCHgsXOUQOccmAnxhhNppNiqHUYxjFPtv+MZ Tkyit8DYSzQc+/TcCA7SVUcUMLTSaqrOox5m3rFyw/xBemDFGnLB2gxnnr6XVcqAoF ZIRxFXwmjZL4w== MIME-Version: 1.0 In-Reply-To: <87v98dqzfe.fsf@kokedama.swc.toshiba.co.jp> References: <20210421134844.3297838-1-arnd@kernel.org> <871rb2swd9.fsf@kokedama.swc.toshiba.co.jp> <01e78b64-8ad1-dfc8-9fc0-6afff4841492@xilinx.com> <87v98dqzfe.fsf@kokedama.swc.toshiba.co.jp> Subject: Re: [PATCH] clk: zynqmp: fix compile testing without ZYNQMP_FIRMWARE From: Stephen Boyd Cc: Arnd Bergmann , Michael Turquette , Arnd Bergmann , Rajan Vaja , Greg Kroah-Hartman , Jolly Shah , Quanyang Wang , linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org To: Michal Simek , Punit Agrawal Date: Thu, 29 Apr 2021 19:17:14 -0700 Message-ID: <161974903429.177949.6659170601321970979@swboyd.mtv.corp.google.com> User-Agent: alot/0.9.1 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210429_191716_413682_555F70D6 X-CRM114-Status: GOOD ( 18.03 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Quoting Punit Agrawal (2021-04-22 23:37:25) > Michal Simek writes: > > > > > >>> > >>> rate = parent_rate * fbdiv; > >>> if (zynqmp_pll_get_mode(hw) == PLL_MODE_FRAC) { > >> > >> The changes make sense in that the functions error out sensibly when the > >> zynqmp firmware driver is not enabled. > >> > >> Acked-by: Punit Agrawal > > > > I think code should be checked that these error values are handled how > > they should be handled. > > I only looked at it from the point of view of getting rid of the > warnings - based on the commit log, Arnd's patch is only taking care of > the compiler warnings when the driver is built with > CONFIG_COMPILE_TEST=y and likely CONFIG_ZYNQMP_FIRMWARE=n. The subject line basically says this. > > In practice, the code should not be hit at runtime due to the dependency > on the firmware driver. Even then, a better fix would indeed be taking > the returned values at call sites into account. Still needs to be fixed. If a better patch is sent I would apply it, but if that isn't going to happen I'll apply this one. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel