Re: [RFC PATCH v2 0/2] hw/ppc: code motion to compile without TCG

[no-reply@patchew.org]

Patchew URL: https://patchew.org/QEMU/20210430184047.81653-1-lucas.araujo@eldorado.org.br/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: 20210430184047.81653-1-lucas.araujo@eldorado.org.br
Subject: [RFC PATCH v2 0/2] hw/ppc: code motion to compile without TCG 

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 * [new tag]         patchew/20210430184047.81653-1-lucas.araujo@eldorado.org.br -> patchew/20210430184047.81653-1-lucas.araujo@eldorado.org.br
Switched to a new branch 'test'
1cd2718 hw/ppc: Moved TCG code to spapr_hcall_tcg
99b0292 target/ppc: Moved functions out of mmu-hash64

=== OUTPUT BEGIN ===
1/2 Checking commit 99b02924c4ea (target/ppc: Moved functions out of mmu-hash64)
Use of uninitialized value $acpi_testexpected in string eq at ./scripts/checkpatch.pl line 1529.
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#245: 
new file mode 100644

total: 0 errors, 1 warnings, 214 lines checked

Patch 1/2 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
2/2 Checking commit 1cd27189f2ae (hw/ppc: Moved TCG code to spapr_hcall_tcg)
Use of uninitialized value $acpi_testexpected in string eq at ./scripts/checkpatch.pl line 1529.
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#378: 
new file mode 100644

WARNING: Block comments use a leading /* on a separate line
#462: FILE: hw/ppc/spapr_hcall_tcg.c:80:
+        /* FIXME: What WIMG combinations could be sensible for IO?

WARNING: Block comments use a trailing */ on a separate line
#463: FILE: hw/ppc/spapr_hcall_tcg.c:81:
+         * For now we allow WIMG=010x, but are there others? */

ERROR: spaces required around that '*' (ctx:VxV)
#601: FILE: hw/ppc/spapr_hcall_tcg.c:219:
+        target_ulong *tsh = &args[i*2];
                                    ^

ERROR: spaces required around that '*' (ctx:VxV)
#602: FILE: hw/ppc/spapr_hcall_tcg.c:220:
+        target_ulong tsl = args[i*2 + 1];
                                  ^

total: 2 errors, 3 warnings, 673 lines checked

Patch 2/2 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/20210430184047.81653-1-lucas.araujo@eldorado.org.br/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com