All of lore.kernel.org
 help / color / mirror / Atom feed
From: Hans de Goede <hdegoede@redhat.com>
To: Werner Sembach <wse@tuxedocomputers.com>,
	dmitry.torokhov@gmail.com, tiwai@suse.de, mpdesouza@suse.com,
	arnd@arndb.de, samuel@cavoj.net, linux-input@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 1/4] input/i8042: Move __initconst to fix code styling warning
Date: Mon, 28 Mar 2022 14:02:32 +0200	[thread overview]
Message-ID: <161e7a97-d259-0bd7-431f-6b9f69e7cc37@redhat.com> (raw)
In-Reply-To: <20220322162125.59838-2-wse@tuxedocomputers.com>

Hi,

On 3/22/22 17:21, Werner Sembach wrote:
> Move __intconst from before i8042_dmi_laptop_table[] to after it for
> consistent code styling.
> 
> Signed-off-by: Werner Sembach <wse@tuxedocomputers.com>
> Cc: stable@vger.kernel.org

Thanks, patch looks good to me:

Reviewed-by: Hans de Goede <hdegoede@redhat.com>

Regards,

Hans


> ---
>  drivers/input/serio/i8042-x86ia64io.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/input/serio/i8042-x86ia64io.h b/drivers/input/serio/i8042-x86ia64io.h
> index 148a7c5fd0e2..91c6f24b4837 100644
> --- a/drivers/input/serio/i8042-x86ia64io.h
> +++ b/drivers/input/serio/i8042-x86ia64io.h
> @@ -791,7 +791,7 @@ static const struct dmi_system_id __initconst i8042_dmi_nopnp_table[] = {
>  	{ }
>  };
>  
> -static const struct dmi_system_id __initconst i8042_dmi_laptop_table[] = {
> +static const struct dmi_system_id i8042_dmi_laptop_table[] __initconst = {
>  	{
>  		.matches = {
>  			DMI_MATCH(DMI_CHASSIS_TYPE, "8"), /* Portable */


  reply	other threads:[~2022-03-28 12:02 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-22 16:21 [PATCH v4] input/i8042: Rework quirk tables Werner Sembach
2022-03-22 16:21 ` [PATCH v4 1/4] input/i8042: Move __initconst to fix code styling warning Werner Sembach
2022-03-28 12:02   ` Hans de Goede [this message]
2022-03-22 16:21 ` [PATCH v4 2/4] input/i8042: Merge quirk tables Werner Sembach
2022-03-28 12:02   ` Hans de Goede
2022-03-28 15:57     ` Werner Sembach
2022-03-22 16:21 ` [PATCH v4 3/4] input/i8042: Add debug output for quirks Werner Sembach
2022-03-22 20:50   ` kernel test robot
2022-03-28 12:08     ` Hans de Goede
2022-03-28 12:08       ` Hans de Goede
2022-03-28 16:28       ` Werner Sembach
2022-03-28 16:28         ` Werner Sembach
2022-03-28 16:30         ` Hans de Goede
2022-03-28 16:30           ` Hans de Goede
2022-03-22 23:32   ` kernel test robot
2022-03-22 16:21 ` [PATCH v4 4/4] input/i8042: Add TUXEDO devices to i8042 quirk tables Werner Sembach
2022-03-28 12:10   ` Hans de Goede

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=161e7a97-d259-0bd7-431f-6b9f69e7cc37@redhat.com \
    --to=hdegoede@redhat.com \
    --cc=arnd@arndb.de \
    --cc=dmitry.torokhov@gmail.com \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mpdesouza@suse.com \
    --cc=samuel@cavoj.net \
    --cc=tiwai@suse.de \
    --cc=wse@tuxedocomputers.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.