All of lore.kernel.org
 help / color / mirror / Atom feed
From: chenxiang <chenxiang66@hisilicon.com>
To: <robert.moore@intel.com>, <erik.kaneda@intel.com>,
	<rafael.j.wysocki@intel.com>, <hoan@os.amperecomputing.com>,
	<fancer.lancer@gmail.com>
Cc: <linux-acpi@vger.kernel.org>, <linux-gpio@vger.kernel.org>,
	<linuxarm@huawei.com>, Xiang Chen <chenxiang66@hisilicon.com>
Subject: [PATCH] ACPICA: fix a memleak issue related to ACPI/GPIO
Date: Wed, 12 May 2021 11:30:07 +0800	[thread overview]
Message-ID: <1620790207-128605-1-git-send-email-chenxiang66@hisilicon.com> (raw)

From: Xiang Chen <chenxiang66@hisilicon.com>

There is a memleak reported as follows:

unreferenced object 0xffff00208ff85a00 (size 128):
  comm "swapper/0", pid 1, jiffies 4294892588 (age 887.572s)
  hex dump (first 32 bytes):
    00 00 00 00 02 00 00 00 08 5a f8 8f 20 00 ff ff  .........Z.. ...
    08 5a f8 8f 20 00 ff ff 00 00 00 00 00 00 00 00  .Z.. ...........
backtrace:
    [<00000000bc25bad8>] slab_post_alloc_hook+0x80/0x2e0
    [<000000008d547074>] kmem_cache_alloc+0x194/0x2c0
    [<00000000b08da9ad>] acpi_os_create_semaphore+0x3c/0x78
    [<0000000024816c0a>] acpi_ev_install_space_handler+0x214/0x274
    [<00000000d93a5ac2>] acpi_install_address_space_handler+0x64/0xb0
    [<0000000098c37a45>] acpi_gpiochip_add+0x130/0x348
    [<00000000c1cf4b42>] gpiochip_add_data_with_key+0x79c/0xdd0
    [<000000005ce539e9>] devm_gpiochip_add_data_with_key+0x30/0x90
    [<00000000a3038b8d>] dwapb_gpio_probe+0x3e4/0x7e8
    [<0000000047a03eba>] platform_probe+0x68/0xe0
    [<00000000dc15c501>] really_probe+0x17c/0x4a0
    [<00000000aa1f123d>] driver_probe_device+0x68/0xd0
    [<00000000d97646e0>] device_driver_attach+0x74/0x80
    [<0000000073d5b3e5>] __driver_attach+0x8c/0xe0
    [<00000000ff60d118>] bus_for_each_dev+0x7c/0xd8
    [<00000000b018393d>] driver_attach+0x24/0x30

It requires to delete the handler object in function 
acpi_remove_address_space_handler() but it just up the sem with function
acpi_os_release_mutex(), so use acpi_os_delete_mutex() instead of 
acpi_os_release_mutex() in function acpi_remove_address_space_handler().

Signed-off-by: Xiang Chen <chenxiang66@hisilicon.com>
---
 drivers/acpi/acpica/evxfregn.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/acpi/acpica/evxfregn.c b/drivers/acpi/acpica/evxfregn.c
index b1ff0a8..4db0bec 100644
--- a/drivers/acpi/acpica/evxfregn.c
+++ b/drivers/acpi/acpica/evxfregn.c
@@ -201,7 +201,7 @@ acpi_remove_address_space_handler(acpi_handle device,
 
 			/* Now we can delete the handler object */
 
-			acpi_os_release_mutex(handler_obj->address_space.
+			acpi_os_delete_mutex(handler_obj->address_space.
 					      context_mutex);
 			acpi_ut_remove_reference(handler_obj);
 			goto unlock_and_exit;
-- 
2.8.1


             reply	other threads:[~2021-05-12  3:34 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-12  3:30 chenxiang [this message]
2021-05-17 18:54 ` [PATCH] ACPICA: fix a memleak issue related to ACPI/GPIO Kaneda, Erik
2021-05-18  2:02   ` chenxiang (M)
2021-05-18 21:35     ` Kaneda, Erik
2021-05-19 10:51       ` chenxiang (M)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1620790207-128605-1-git-send-email-chenxiang66@hisilicon.com \
    --to=chenxiang66@hisilicon.com \
    --cc=erik.kaneda@intel.com \
    --cc=fancer.lancer@gmail.com \
    --cc=hoan@os.amperecomputing.com \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linuxarm@huawei.com \
    --cc=rafael.j.wysocki@intel.com \
    --cc=robert.moore@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.