From: Patchwork <patchwork@emeril.freedesktop.org>
To: "Jani Nikula" <jani.nikula@intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: split out new intel_backlight.[ch]
Date: Wed, 12 May 2021 13:58:25 -0000 [thread overview]
Message-ID: <162082790560.28506.8447185153939330199@emeril.freedesktop.org> (raw)
In-Reply-To: <cover.1620825897.git.jani.nikula@intel.com>
== Series Details ==
Series: drm/i915: split out new intel_backlight.[ch]
URL : https://patchwork.freedesktop.org/series/90078/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip
5c56f5e2aca2 drm/i915/backlight: extract backlight code to a separate file
-:57: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating?
#57:
new file mode 100644
-:262: WARNING:LINE_SPACING: Missing a blank line after declarations
#262: FILE: drivers/gpu/drm/i915/display/intel_backlight.c:201:
+ u32 val = intel_de_read(dev_priv, BLC_PWM_PCH_CTL2) & ~BACKLIGHT_DUTY_CYCLE_MASK;
+ intel_de_write(dev_priv, BLC_PWM_PCH_CTL2, val | level);
-:1822: WARNING:BRACES: braces {} are not necessary for any arm of this statement
#1822: FILE: drivers/gpu/drm/i915/display/intel_backlight.c:1761:
+ if (connector->base.connector_type == DRM_MODE_CONNECTOR_DSI) {
[...]
+ } else {
[...]
-:1891: CHECK:LINE_SPACING: Please use a blank line after function/struct/union/enum declarations
#1891: FILE: drivers/gpu/drm/i915/display/intel_backlight.h:46:
+}
+static inline void intel_backlight_device_unregister(struct intel_connector *connector)
total: 0 errors, 3 warnings, 1 checks, 3769 lines checked
019319571e81 drm/i915/backlight: mass rename functions to have intel_backlight_ prefix
-:557: WARNING:LONG_LINE: line length of 104 exceeds 100 columns
#557: FILE: drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c:239:
+ panel->backlight.pwm_funcs->disable(conn_state, intel_backlight_invert_pwm_level(connector, 0));
total: 0 errors, 1 warnings, 0 checks, 568 lines checked
edb31254e71a drm/i915/panel: mass rename functions to have intel_panel_ prefix
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2021-05-12 13:58 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-12 13:30 [Intel-gfx] [PATCH 0/3] drm/i915: split out new intel_backlight.[ch] Jani Nikula
2021-05-12 13:30 ` [Intel-gfx] [PATCH 1/3] drm/i915/backlight: extract backlight code to a separate file Jani Nikula
2021-05-12 13:30 ` [Intel-gfx] [PATCH 2/3] drm/i915/backlight: mass rename functions to have intel_backlight_ prefix Jani Nikula
2021-05-12 13:30 ` [Intel-gfx] [PATCH 3/3] drm/i915/panel: mass rename functions to have intel_panel_ prefix Jani Nikula
2021-05-14 17:20 ` Ville Syrjälä
2021-05-12 13:58 ` Patchwork [this message]
2021-05-12 14:29 ` [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: split out new intel_backlight.[ch] Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=162082790560.28506.8447185153939330199@emeril.freedesktop.org \
--to=patchwork@emeril.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jani.nikula@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.